rfc_facil 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 90d241e12a7657fe09501ed8d060af1f0b563c4e
-  data.tar.gz: 84a309812ff7c1e5161446d88882a6dae3dbdf6b
+  metadata.gz: 2e4beff53f9889d87b462d70ef89626a465c47fd
+  data.tar.gz: 2c3a42b7c21b0799d0d88581917476c86a054cc9
 SHA512:
-  metadata.gz: 793b87293071c2ae0870bf405bc531119f891eaad72816061c03c32d841fb2355230d86efb979169cac04593987b707199d02d58c5ec339e7649b0da67f8c664
-  data.tar.gz: 580a7adbfb39eaf743274a3827d547e8ea5ca30e15b21558cb3b6c67097ac2b6b28b6171258faf5802e53a544667751f2a5b1288f6859f66ddf918fabc5626c3
+  metadata.gz: ef619a13b09e212df01f75df492fc5d616de7c546d647fc7fbc01f752a1f656baa624c6e304f94c904e22c74f7b1a2bc7c4769d6b21901fd6865716cb010bc91
+  data.tar.gz: 21b4428b04a98f0f5acf266a8984ea0201f85e62b53ed4f80e43601b3b9167efda69b7ab3be5f95cfbbcdc66416ef9da5eb2c34fddc4c04dc500d8304bc46f07

data/README.md

@@ -1,8 +1,10 @@
 # Rfc Fácil
-![](logo.png)
+![](https://github.com/acrogenesis/rfc_facil/raw/master/logo.png)
 
 Libreria para calcular el Registro Federal de Contribuyentes en México (RFC) en Ruby.
 
+[![Build Status](https://travis-ci.org/acrogenesis/rfc_facil.svg?branch=master)](https://travis-ci.org/acrogenesis/rfc_facil)
+
 ## Uso
 
 ```ruby
@@ -20,5 +22,5 @@ Esta librería se basa en documentación oficial obtenida por medio del IFAI (In
 ### Agradecimiento
 El código es una version en Ruby de [rfc-facil](https://github.com/josketres/rfc-facil) hecha en Java por [josketres](https://github.com/josketres)
 
-## Contributing
+## Colabora
 Errores y pull requests son bienvenidos en Github: https://github.com/acrogenesis/rfc_facil.

data/lib/rfc_facil/homoclave_calculator.rb

@@ -35,7 +35,6 @@ class HomoclaveCalculator
 
   def sum_pairs_of_digits
     @pairs_of_digits_sum = 0
-    # @mapped_full_name[0..-2].each_char do |c, i|
     (0..@mapped_full_name.length - 2).each do |i|
       num1 = @mapped_full_name[i..i + 1].to_i
       num2 = @mapped_full_name[i + 1..i + 1].to_i

data/lib/rfc_facil/rfc.rb

@@ -13,7 +13,7 @@ class Rfc
     @person = Person.new(@name, @first_last_name, @second_last_name, @day, @month, @year)
     @ten_digits_code = TenDigitsCodeCalculator.new(@person).calculate
     @homoclave = HomoclaveCalculator.new(@person).calculate
-    @verification_digit = VerificationDigitCalculator.new(@ten_digits_code << @homoclave).calculate
+    @verification_digit = VerificationDigitCalculator.new("#{@ten_digits_code}#{@homoclave}").calculate
   end
 
   def to_s

data/lib/rfc_facil/version.rb

@@ -1,3 +1,3 @@
 module RfcFacil
-  VERSION = '0.1.0'
+  VERSION = '0.1.1'
 end

data/rfc_facil.gemspec

@@ -10,7 +10,7 @@ Gem::Specification.new do |spec|
   spec.email         = ['adrian.rangel@gmail.com']
 
   spec.summary       = 'Libreria para calcular el Registro Federal de Contribuyentes en México (RFC).'
-  spec.homepage      = 'https://github.com/acrogenesis/rfc_facil'
+  spec.homepage      = 'https://acrogenesis.com/rfc_facil/'
 
   spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   spec.bindir        = 'exe'

data/tests/rfc_facil/test_homoclave_calculator.rb

@@ -1,57 +1,57 @@
 class TestHomoclaveCalculator < Minitest::Test
   def test_calculate_homoclave_for_simple_test_case
-    assert_equal(homoclave('Juan', 'Perez', 'Garcia'), 'LN')
+    assert_equal('LN', homoclave('Juan', 'Perez', 'Garcia'))
   end
 
   def test_calculate_same_homoclave_for_names_with_and_without_accents
-    assert_equal(homoclave('Juan', 'Perez', 'Garcia'),
-                 homoclave('Juan', 'Pérez', 'García'))
+    assert_equal(homoclave('Juan', 'Pérez', 'García'),
+                 homoclave('Juan', 'Perez', 'Garcia'))
   end
 
   def test_calculate_homoclave_for_person_with_more_than_one_name
-    assert_equal(homoclave('Jose Antonio', 'Del real', 'Anzures'), 'N9')
+    assert_equal('N9', homoclave('Jose Antonio', 'Del real', 'Anzures'))
   end
 
   def test_calculate_homoclave_for_name_with_n_with_tilde
-    assert_equal(homoclave('Juan', 'Muñoz', 'Ortega'), 'T6')
+    assert_equal('T6', homoclave('Juan', 'Muñoz', 'Ortega'))
   end
 
   def test_calculate_homoclave_for_name_with_multiple_n_with_tilde
-    assert_equal(homoclave('Juan', 'Muñoz', 'Muñoz'), 'RZ')
+    assert_equal('RZ', homoclave('Juan', 'Muñoz', 'Muñoz'))
   end
 
   def test_calculate_different_homoclave_for_name_with_n_with_tilde_and_without
-    refute_equal(homoclave('Juan', 'Muñoz', 'Ortega'),
-                 homoclave('Juan', 'Munoz', 'Ortega'))
+    refute_equal(homoclave('Juan', 'Munoz', 'Ortega'),
+                 homoclave('Juan', 'Muñoz', 'Ortega'))
   end
 
   def test_calculate_homoclave_for_name_with_u_with_umlaut
-    assert_equal(homoclave('Jesus', 'Argüelles', 'Ortega'), 'JF')
+    assert_equal('JF', homoclave('Jesus', 'Argüelles', 'Ortega'))
   end
 
   def test_calculate_same_homoclave_for_name_with_u_with_umlaut_and_without
-    assert_equal(homoclave('Jesus', 'Argüelles', 'Ortega'),
-                 homoclave('Jesus', 'Arguelles', 'Ortega'))
+    assert_equal(homoclave('Jesus', 'Arguelles', 'Ortega'),
+                 homoclave('Jesus', 'Argüelles', 'Ortega'))
   end
 
   def test_calculate_homoclave_for_name_with_ampersand
-    assert_equal(homoclave('Juan', 'Perez&Gomez', 'Garcia'), '2R')
+    assert_equal('2R', homoclave('Juan', 'Perez&Gomez', 'Garcia'))
   end
 
   def test_calculate_same_homoclave_for_name_with_and_without_special_characters
-    assert_equal(homoclave('Juan', 'Mc.Gregor', "O'Connor-Juarez"),
-                 homoclave('Juan', 'McGregor', 'OConnorJuarez'))
+    assert_equal(homoclave('Juan', 'McGregor', 'OConnorJuarez'),
+                 homoclave('Juan', 'Mc.Gregor', "O'Connor-Juarez"))
   end
 
   def test_calculate_different_homoclave_for_names_with_and_without_ampersand
-    refute_equal(homoclave('Juan', 'Perez&Gomez', 'Garcia'),
-                 homoclave('Juan', 'PerezGomez', 'Garcia'))
+    refute_equal(homoclave('Juan', 'PerezGomez', 'Garcia'),
+                 homoclave('Juan', 'Perez&Gomez', 'Garcia'))
   end
 
   def test_calculate_same_homoclave_for_different_birthdays
     assert_equal(
-      HomoclaveCalculator.new(Person.new('Juan', 'Perez', 'Garcia', 1, 1, 1901)).calculate,
-      HomoclaveCalculator.new(Person.new('Juan', 'Perez', 'Garcia', 5, 8, 1987)).calculate
+      HomoclaveCalculator.new(Person.new('Juan', 'Perez', 'Garcia', 5, 8, 1987)).calculate,
+      HomoclaveCalculator.new(Person.new('Juan', 'Perez', 'Garcia', 1, 1, 1901)).calculate
     )
   end
 

data/tests/rfc_facil/test_rfc.rb

@@ -1,11 +1,11 @@
 class TestRfc < Minitest::Test
-  def should_build_rfc
-    Rfc.new(name: 'Adrian Marcelo', first_last_name: 'Rangel',
-            second_last_name: 'Araujo', day: 27, month: 11, year: 1992)
+  def test_rfc
+    rfc = Rfc.new(name: 'Adrian Marcelo', first_last_name: 'Rangel',
+                  second_last_name: 'Araujo', day: 27, month: 11, year: 1992)
 
-    assert_equal(rfc.ten_digits_code, 'RAAA921127')
-    assert_equal(rfc.homoclave, 'RI')
-    assert_equal(rfc.verification_digit, '6')
-    assert_equal(rfc.to_s, 'RAAA921127RI6')
+    assert_equal('RAAA921127', rfc.ten_digits_code)
+    assert_equal('RI', rfc.homoclave)
+    assert_equal('6', rfc.verification_digit)
+    assert_equal('RAAA921127RI6', rfc.to_s)
   end
 end

data/tests/rfc_facil/test_ten_digits_code_calculator.rb

@@ -1,72 +1,72 @@
 class TestTenDigitsCodeCalculator < Minitest::Test
   def test_calculate_ten_digits_code_for_simple_test_case
-    assert_equal(ten_digits_code('Juan', 'Barrios', 'Fernandez', 13, 12, 1970), 'BAFJ701213')
+    assert_equal('BAFJ701213', ten_digits_code('Juan', 'Barrios', 'Fernandez', 13, 12, 1970))
   end
 
   def test_calculate_ten_digits_code_for_date_after_year_2000
-    assert_equal(ten_digits_code('Juan', 'Barrios', 'Fernandez', 1, 12, 2001), 'BAFJ011201')
+    assert_equal('BAFJ011201', ten_digits_code('Juan', 'Barrios', 'Fernandez', 1, 12, 2001))
   end
 
   def test_exclude_special_particles_in_both_last_names
     # DE, LA, LAS, MC, VON, DEL, LOS, Y, MAC, VAN, MI
-    assert_equal(ten_digits_code('Eric', 'Mc Gregor', 'Von Juarez', 13, 12, 1970), 'GEJE701213')
+    assert_equal('GEJE701213', ten_digits_code('Eric', 'Mc Gregor', 'Von Juarez', 13, 12, 1970))
   end
 
   def test_exclude_special_particles_in_the_first_last_name
-    assert_equal(ten_digits_code('Josue', 'Zarzosa', 'de la Torre', 13, 12, 1970), 'ZATJ701213')
+    assert_equal('ZATJ701213', ten_digits_code('Josue', 'Zarzosa', 'de la Torre', 13, 12, 1970))
   end
 
   def test_exclude_special_particles_in_the_second_last_name
-    assert_equal(ten_digits_code('Josue', 'de la Torre', 'Zarzosa', 13, 12, 1970), 'TOZJ701213')
+    assert_equal('TOZJ701213', ten_digits_code('Josue', 'de la Torre', 'Zarzosa', 13, 12, 1970))
   end
 
   def test_use_first_word_of_compound_second_last_name
-    assert_equal(ten_digits_code('Antonio', 'Jiménez', 'Ponce de León', 13, 12, 1970), 'JIPA701213')
+    assert_equal('JIPA701213', ten_digits_code('Antonio', 'Jiménez', 'Ponce de León', 13, 12, 1970))
   end
 
   def test_use_first_word_of_compound_first_last_name
-    assert_equal(ten_digits_code('Antonio', 'Ponce de León', 'Juarez', 13, 12, 1970), 'POJA701213')
+    assert_equal('POJA701213', ten_digits_code('Antonio', 'Ponce de León', 'Juarez', 13, 12, 1970))
   end
 
   def test_use_use_first_two_letters_of_first_name_if_first_last_name_has_just_one_letter
-    assert_equal(ten_digits_code('Alvaro', 'de la O', 'Lozano', 13, 12, 1970), 'OLAL701213')
+    assert_equal('OLAL701213', ten_digits_code('Alvaro', 'de la O', 'Lozano', 13, 12, 1970))
   end
 
   def test_use_use_first_two_letters_of_first_name_if_first_last_name_has_just_two_letters
-    assert_equal(ten_digits_code('Ernesto', 'Ek', 'Rivera', 13, 12, 1970), 'ERER701213')
+    assert_equal('ERER701213', ten_digits_code('Ernesto', 'Ek', 'Rivera', 13, 12, 1970))
   end
 
   def test_use_first_name_if_person_has_multiple_names
-    assert_equal(ten_digits_code('Luz María', 'Fernández', 'Juárez', 13, 12, 1970), 'FEJL701213')
+    assert_equal('FEJL701213', ten_digits_code('Luz María', 'Fernández', 'Juárez', 13, 12, 1970))
   end
 
   def test_use_second_name_if_person_has_multiple_names_and_first_name_is_jose
-    assert_equal(ten_digits_code('José Antonio', 'Camargo', 'Hernández', 13, 12, 1970), 'CAHA701213')
+    assert_equal('CAHA701213', ten_digits_code('José Antonio', 'Camargo', 'Hernández', 13, 12, 1970))
   end
 
   def test_use_second_name_if_person_has_multiple_names_and_first_name_is_maria
-    assert_equal(ten_digits_code('María Luisa', 'Ramírez', 'Sánchez', 13, 12, 1970), 'RASL701213')
+    assert_equal('RASL701213', ten_digits_code('María Luisa', 'Ramírez', 'Sánchez', 13, 12, 1970))
   end
 
   def test_use_first_two_letters_of_second_last_name_if_empty_first_last_name_is_provided
-    assert_equal(ten_digits_code('Juan', '', 'Martínez', 13, 12, 1970), 'MAJU701213')
+    assert_equal('MAJU701213', ten_digits_code('Juan', '', 'Martínez', 13, 12, 1970))
   end
 
   def test_use_first_two_letters_of_second_last_name_if_nil_first_last_name_is_provided
-    assert_equal(ten_digits_code('Juan', nil, 'Martínez', 13, 12, 1970), 'MAJU701213')
+    assert_equal('MAJU701213', ten_digits_code('Juan', nil, 'Martínez', 13, 12, 1970))
   end
 
   def test_use_first_two_letters_of_first_last_name_if_empty_second_last_name_is_provided
-    assert_equal(ten_digits_code('Gerarda', 'Zafra', '', 13, 12, 1970), 'ZAGE701213')
+    assert_equal('ZAGE701213', ten_digits_code('Gerarda', 'Zafra', '', 13, 12, 1970))
   end
 
   def test_use_first_two_letters_of_first_last_name_if_nil_second_last_name_is_provided
-    assert_equal(ten_digits_code('Gerarda', 'Zafra', nil, 13, 12, 1970), 'ZAGE701213')
+    assert_equal('ZAGE701213', ten_digits_code('Gerarda', 'Zafra', nil, 13, 12, 1970))
   end
 
   def test_replace_last_letter_with_x_if_code_makes_forbidden_word
     # BUEI -> BUEX
-    assert_equal(ten_digits_code('Ingrid', 'Bueno', 'Ezquerra', 13, 12, 1970), 'BUEX701213')
+    assert_equal('BUEX701213', ten_digits_code('Ingrid', 'Bueno', 'Ezquerra', 13, 12, 1970))
   end
 
   private

data/tests/rfc_facil/test_verification_digit_calculator.rb

@@ -1,6 +1,6 @@
 class VerificationDigitCalculatorTest < Minitest::Test
   def test_calculate_verification_digit
-    assert_equal(verification_digit('GODE561231GR'), '8')
+    assert_equal('8', verification_digit('GODE561231GR'))
   end
 
   def verification_digit(rfc12Digit)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rfc_facil
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Adrian Rangel
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2015-10-11 00:00:00.000000000 Z
+date: 2015-10-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n
@@ -108,7 +108,7 @@ files:
 - tests/rfc_facil/test_ten_digits_code_calculator.rb
 - tests/rfc_facil/test_verification_digit_calculator.rb
 - tests/tests_helper.rb
-homepage: https://github.com/acrogenesis/rfc_facil
+homepage: https://acrogenesis.com/rfc_facil/
 licenses: []
 metadata: {}
 post_install_message: