rf-stylez 1.0.0 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d03b1eaf0d1d4470b65a658c809ad325c16b2884e93f0c4e6b18f9914a3a76fb
-  data.tar.gz: cd8eaf1aa26c2359f2cb42a6894b11245a2a94099845811361957eae3a3ea5a6
+  metadata.gz: 6eab02f25e22ed5d7365687d436c5f7c6b7e8e036b9d41203b482cb945e573e9
+  data.tar.gz: b0a3163d0569cb82d9024902f2669b78be9bc6f0a8c6541e632212925e05a9ab
 SHA512:
-  metadata.gz: 539a02d714f5bad8c553586bd494f8b41fd55d49d472f196a178b124abdd4a7b7e5b1d1003ade7892c0c61176a80f5ed5ce3ed8562292ac9c8aed970a6e472f7
-  data.tar.gz: fd74a452a0183221a50ca4aabe4fa01c34c0a98156b3fc7595592182415dc26e1b41ec1db03e5166a0cf11c201c9359d2632a1e064968e955ebf7d4c3325d8be
+  metadata.gz: 7f8d14ce2b39e35025cb459371df3369e20e0a5120e29323dcd78acc51829a4fcfc1e4efabdb4ecb31d392235c96e23df40f7ef6314a0dd5beaa56b874c2aa8e
+  data.tar.gz: 012adcb6bdc628f820958909f86042a3a8d4e3863baee8afe070c29dfea9f550a1c2d23c90346a5660963fae813837cf5fbc38978361e88031b06a16f06069c3

data/.circleci/config.yml

@@ -3,7 +3,7 @@ version: 2.1
 jobs:
   test:
     docker:
-      - image: cimg/ruby:3.2.0
+      - image: cimg/ruby:3.2.2
         auth:
           username: $DOCKERHUB_USERNAME
           password: $DOCKERHUB_TOKEN
@@ -32,7 +32,7 @@ jobs:
 
   push_to_rubygems:
     docker:
-      - image: cimg/ruby:3.2.0
+      - image: cimg/ruby:3.2.2
         auth:
           username: $DOCKERHUB_USERNAME
           password: $DOCKERHUB_TOKEN
@@ -52,6 +52,21 @@ jobs:
             gem build rf-stylez
             gem push rf-stylez-*.gem
 
+  update_jira:
+    docker:
+      - image: alpine:3.8
+        auth:
+          username: $DOCKERHUB_USERNAME
+          password: $DOCKERHUB_TOKEN
+    steps:
+      - run:
+          name: Install dependencies
+          command: apk add --no-cache bash curl git openssh
+      - checkout
+      - run:
+          name: Update JIRA
+          command: .circleci/update-jira.sh
+
 workflows:
   version: 2
   gem_release:
@@ -70,3 +85,13 @@ workflows:
           context:
             - DockerHub
             - RubyGems
+      - update_jira:
+          requires:
+            - push_to_rubygems
+          filters:
+            branches:
+              only:
+                - master
+          context:
+            - DockerHub
+            - update-jira-webhook

data/.circleci/update-jira.sh

@@ -0,0 +1,10 @@
+#!/usr/bin/env bash
+
+set -euo pipefail
+
+# Use JIRA automation webhooks to move issues to SHIPPED:
+# https://support.atlassian.com/jira-software-cloud/docs/automation-triggers/#Automationtriggers-Incomingwebhook
+
+git log --max-count=50 --pretty=format:'%s' | grep -Eo '^\w+-[0-9]+' | sort -u | while read i; do
+  curl -X POST "$UPDATE_JIRA_WEBHOOK_URL?issue=$i"
+done

data/.github/workflows/pronto.yml

@@ -9,7 +9,9 @@ permissions:
 
 jobs:
   pronto:
+
     runs-on: ubuntu-latest
+
     env:
       # `MAKE="make --jobs $(nproc)"` is from
       # https://build.betterup.com/one-weird-trick-that-will-speed-up-your-bundle-install/
@@ -20,18 +22,20 @@ jobs:
 
     steps:
       - name: Checkout code
-        uses: actions/checkout@v2
-      # Set the depth to 100 and hope this won't fail for branches with a lot of little commits
-      - run: |
-          git fetch --no-tags --prune --depth=100 origin +refs/heads/*:refs/remotes/origin/*
+        uses: actions/checkout@v3
+        with:
+          fetch-depth: 100
+      - run: git fetch --no-tags --prune --depth=100 origin "+refs/heads/$GITHUB_BASE_REF:refs/remotes/origin/$GITHUB_BASE_REF"
+
       - name: Setup Ruby
         uses: ruby/setup-ruby@v1
         with:
-          ruby-version:  "3.2.0"
-          # Run `bundle install` with cache when `true`
+          ruby-version:  "3.2.2"
           bundler-cache: true
+
       - name: Setup pronto
         run: gem install pronto pronto-rubocop
+
       - name: Run Pronto
         run: bundle exec pronto run -f github_status github_pr -c origin/${{ github.base_ref }}
         env:

data/README.md

@@ -9,7 +9,6 @@ This is a place for style configurations for [Rainforest QA](https://www.rainfor
 - pull latest master
 - run `rake release:source_control_push`
 - CI/CD will take care of releasing rf-stylez to rubygems
-- Update circlemator `bundle update rf-stylez`
 
 ## Adding `rf-stylez` to a new project
 

data/lib/rf/stylez/update_check.rb

@@ -1,32 +1,33 @@
 # frozen_string_literal: true
 
-require 'json'
-require 'net/http'
-require 'logger'
+require "json"
+require "net/http"
+require "logger"
 
 module Rf
   module Stylez
+    # Check for updates to rf-stylez
     module UpdateCheck
-      RUBYGEMS_URL = URI('https://rubygems.org/api/v1/gems/rf-stylez.json').freeze
+      RUBYGEMS_URL = URI("https://rubygems.org/api/v1/gems/rf-stylez.json").freeze
 
       def self.check
         logger = Logger.new(STDOUT)
         current_version = Gem::Version.new(VERSION)
 
         remote_version = Gem::Version.new(
-          JSON.parse(Net::HTTP.get(RUBYGEMS_URL))['version']
+          JSON.parse(Net::HTTP.get(RUBYGEMS_URL))["version"] # rubocop:disable Lint/NoJSON
         )
         if current_version >= remote_version
-          logger.info('You are running latest rf-stylez ')
-          logger.info('(•_•) ( •_•)>⌐■-■ (⌐■_■)')
+          logger.info("You are running latest rf-stylez ")
+          logger.info("(•_•) ( •_•)>⌐■-■ (⌐■_■)")
         else
-          logger.warn('RF Stylez is out of date!')
+          logger.warn("RF Stylez is out of date!")
           logger.warn("Newest version is: #{remote_version}")
           logger.warn("You are running: #{current_version}")
-          logger.warn('Please update: `gem update rf-stylez`')
+          logger.warn("Please update: `gem update rf-stylez`")
         end
       rescue SocketError
-        logger.info('Offline, cannot check for rf-stylez updates')
+        logger.info("Offline, cannot check for rf-stylez updates")
       end
     end
   end

data/lib/rf/stylez/version.rb

@@ -2,6 +2,6 @@
 
 module Rf
   module Stylez
-    VERSION = "1.0.0"
+    VERSION = "1.0.2"
   end
 end

data/lib/rf/stylez.rb

@@ -1,17 +1,18 @@
 # frozen_string_literal: true
 
-require 'rf/stylez/version'
-require 'rf/stylez/update_check'
-require 'rubocop'
-require 'rubocop/cop/lint/no_json'
-require 'rubocop/cop/lint/no_http_party'
-require 'rubocop/cop/lint/obscure'
-require 'rubocop/cop/lint/no_grape_api'
-require 'rubocop/cop/lint/use_positive_int32_validator'
-require 'rubocop/cop/lint/no_untyped_raise'
-require 'rubocop/cop/lint/no_vcr_recording'
+require "rf/stylez/version"
+require "rf/stylez/update_check"
+require "rubocop"
+require "rubocop/cop/lint/no_json"
+require "rubocop/cop/lint/no_http_party"
+require "rubocop/cop/lint/obscure"
+require "rubocop/cop/lint/no_grape_api"
+require "rubocop/cop/lint/use_positive_int32_validator"
+require "rubocop/cop/lint/no_untyped_raise"
+require "rubocop/cop/lint/no_vcr_recording"
 
 module Rf
+  # Stylez
   module Stylez
     def self.reek_config_path
       File.expand_path("../../ruby/.reek.yml", __dir__)

data/lib/rubocop/cop/lint/no_bang_state_machine_events.rb

@@ -18,10 +18,10 @@ module RuboCop
       #     end
       #   end
       class NoBangStateMachineEvents < Cop
-        MSG = 'Event names ending with a `!` define `!`-ended methods that do not raise'
+        MSG = "Event names ending with a `!` define `!`-ended methods that do not raise"
 
-        def_node_matcher :is_state_machine_event?, '(send nil? :event (sym $_))'
-        def_node_matcher :is_state_machine?, '(block (send nil? :state_machine ...) ...)'
+        def_node_matcher :is_state_machine_event?, "(send nil? :event (sym $_))"
+        def_node_matcher :is_state_machine?, "(block (send nil? :state_machine ...) ...)"
 
         def on_send(node)
           return unless (event_name = is_state_machine_event?(node))

data/lib/rubocop/cop/lint/no_grape_api.rb

@@ -13,9 +13,9 @@ module RuboCop
       #   # good
       #   class Foo < Api::Base
       class NoGrapeAPI < Cop
-        MSG = 'Prefer inheriting `Api::AuthBase` or `Api::Base` instead of `Grape::API`.'.freeze
+        MSG = "Prefer inheriting `Api::AuthBase` or `Api::Base` instead of `Grape::API`."
 
-        def_node_matcher :inherits_Grape_API?, '(class (const ...) (const (const nil? :Grape) :API) ...)'
+        def_node_matcher :inherits_Grape_API?, "(class (const ...) (const (const nil? :Grape) :API) ...)"
 
         def on_class(node)
           return unless inherits_Grape_API?(node)

data/lib/rubocop/cop/lint/no_http_party.rb

@@ -10,9 +10,9 @@ module RuboCop
       #   # good
       #   TimedRequest.get(...)
       class NoHTTParty < Cop
-        MSG = 'Prefer `TimedRequest` instead of raw `HTTParty` calls.'.freeze
+        MSG = "Prefer `TimedRequest` instead of raw `HTTParty` calls."
 
-        def_node_matcher :is_HTTParty?, '(send (const nil? :HTTParty) ...)'
+        def_node_matcher :is_HTTParty?, "(send (const nil? :HTTParty) ...)"
 
         def on_send(node)
           return unless is_HTTParty?(node)

data/lib/rubocop/cop/lint/no_json.rb

@@ -11,9 +11,9 @@ module RuboCop
       #   MultiJson.load(...)
       #
       class NoJSON < Cop
-        MSG = 'Use `MultiJson` instead of `JSON`.'.freeze
+        MSG = "Use `MultiJson` instead of `JSON`."
 
-        def_node_matcher :is_JSON?, '(const nil? :JSON)'
+        def_node_matcher :is_JSON?, "(const nil? :JSON)"
 
         def on_const(node)
           return unless is_JSON?(node)

data/lib/rubocop/cop/lint/no_untyped_raise.rb

@@ -11,9 +11,9 @@ module RuboCop
       #   raise ArgumentError, 'foo'
       #
       class NoUntypedRaise < Cop
-        MSG = 'Do not raise untyped exceptions, specify the error type so it can be rescued specifically.'
+        MSG = "Do not raise untyped exceptions, specify the error type so it can be rescued specifically."
 
-        def_node_matcher :is_untyped_raise?, '(send nil? {:raise :fail} (str ...) ...)'
+        def_node_matcher :is_untyped_raise?, "(send nil? {:raise :fail} (str ...) ...)"
 
         def on_send(node)
           return unless is_untyped_raise?(node)

data/lib/rubocop/cop/lint/no_vcr_recording.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
-require 'unparser'
+
+require "unparser"
 
 module RuboCop
   module Cop
@@ -15,7 +16,7 @@ module RuboCop
       class NoVCRRecording < RuboCop::Cop::Base
         extend AutoCorrector
 
-        MSG = 'Do not set :record option in VCR'.freeze
+        MSG = "Do not set :record option in VCR"
 
         def_node_search :is_only_setting_record_option?, <<~PATTERN
           (pair
@@ -48,7 +49,7 @@ module RuboCop
 
           add_offense(node) do |corrector|
             if is_only_setting_record_option?(node)
-              corrector.replace(node, 'vcr: true')
+              corrector.replace(node, "vcr: true")
             elsif is_setting_record_option?(node)
               corrector.replace(node, remove_record_option(node))
             end

data/lib/rubocop/cop/lint/obscure.rb

@@ -20,7 +20,7 @@ module RuboCop
       #
       # https://ruby-doc.org/core-2.4.0/String.html#method-i-25
       class Obscure < Cop
-        MSG = 'Do not use the flipflop operator'.freeze
+        MSG = "Do not use the flipflop operator"
 
         def_node_matcher :is_stringformat?, <<-PATTERN
           (send {str dstr} $:% ...)
@@ -36,7 +36,7 @@ module RuboCop
 
         def on_send(node)
           return unless is_stringformat?(node)
-          add_offense(node, message: 'Do not use String#%')
+          add_offense(node, message: "Do not use String#%")
         end
       end
     end

data/lib/rubocop/cop/lint/use_positive_int32_validator.rb

@@ -14,7 +14,7 @@ module RuboCop
       #     requires :id, type: Integer, positive_int32: true
       #   end
       class UsePositiveInt32Validator < Cop
-        MSG = 'If this Integer maps to a postgres Integer column, validate with `positive_int32: true`'
+        MSG = "If this Integer maps to a postgres Integer column, validate with `positive_int32: true`"
 
         # check if the param is `requires` / `optional`
         def_node_search :find_params_hashes, <<~PATTERN
@@ -23,9 +23,9 @@ module RuboCop
           $(hash ...) ...)
         PATTERN
         # check if hash contains `type: Integer`
-        def_node_search :is_type_integer?, '(pair (sym :type) (const nil? :Integer))'
+        def_node_search :is_type_integer?, "(pair (sym :type) (const nil? :Integer))"
         # check if the hash contains the `positive_int32` validator
-        def_node_search :validates_integer?, '(pair (sym :positive_int32) {{true false} (int _)})'
+        def_node_search :validates_integer?, "(pair (sym :positive_int32) {{true false} (int _)})"
 
         def on_block(node)
           return unless (hash = find_params_hashes(node))

data/rf-stylez.gemspec

@@ -21,16 +21,16 @@ Gem::Specification.new do |spec|
   spec.executables   = ["rf-stylez"]
   spec.require_paths = ["lib"]
 
-  spec.add_runtime_dependency "rubocop", "1.41.1"
-  spec.add_runtime_dependency "rubocop-rails", "2.17.4"
-  spec.add_runtime_dependency "rubocop-rspec", "2.16.0"
+  spec.add_runtime_dependency "rubocop", "1.54.1"
+  spec.add_runtime_dependency "rubocop-rails", "2.20.2"
+  spec.add_runtime_dependency "rubocop-rspec", "2.22.0"
   spec.add_runtime_dependency "reek", "~> 6.1"
   spec.add_runtime_dependency "get_env", "~> 0.2.0"
   spec.add_runtime_dependency "unparser", "~> 0.6"
   spec.add_runtime_dependency "pronto", "~> 0.11.1"
-  spec.add_runtime_dependency "pronto-rubocop", "~> 0.11.4"
+  spec.add_runtime_dependency "pronto-rubocop", "~> 0.11.5"
 
-  spec.add_development_dependency "bundler", "~> 2.1"
+  spec.add_development_dependency "bundler", "~> 2.4"
   spec.add_development_dependency "rake", "~> 13.0"
   spec.add_development_dependency "rspec", ">= 3.4"
   spec.add_development_dependency "byebug"

data/ruby/rubocop.yml

@@ -1,5 +1,5 @@
 AllCops:
-  TargetRubyVersion: 2.7
+  TargetRubyVersion: 3.2
   DisabledByDefault: true
   Include:
     - '**/*.rb'
@@ -180,6 +180,8 @@ Style/Documentation:
   Enabled: true
 Style/DocumentationMethod:
   Enabled: false
+Style/OpenStructUse:
+  Enabled: true
 
 Layout/LineLength:
   Enabled: true

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rf-stylez
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.2
 platform: ruby
 authors:
 - Emanuel Evans
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-01-09 00:00:00.000000000 Z
+date: 2023-07-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,42 +16,42 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.41.1
+        version: 1.54.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.41.1
+        version: 1.54.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.17.4
+        version: 2.20.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.17.4
+        version: 2.20.2
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.16.0
+        version: 2.22.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.16.0
+        version: 2.22.0
 - !ruby/object:Gem::Dependency
   name: reek
   requirement: !ruby/object:Gem::Requirement
@@ -114,28 +114,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.11.4
+        version: 0.11.5
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.11.4
+        version: 0.11.5
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.1'
+        version: '2.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.1'
+        version: '2.4'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -201,6 +201,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".circleci/config.yml"
+- ".circleci/update-jira.sh"
 - ".github/dependabot.yml"
 - ".github/workflows/pronto.yml"
 - ".gitignore"
@@ -247,7 +248,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.1
+rubygems_version: 3.4.10
 signing_key: 
 specification_version: 4
 summary: Styles for Rainforest code