rf-stylez 0.14.0 → 0.16.0

Sign up to get free protection for your applications and to get access to all the features.
Files changed (13) hide show
  1. checksums.yaml +4 -4
  2. data/.circleci/config.yml +2 -16
  3. data/.github/workflows/pronto.yml +40 -0
  4. data/.gitignore +1 -0
  5. data/Gemfile +3 -4
  6. data/bin/rf-stylez +7 -4
  7. data/lib/rf/stylez/update_check.rb +2 -4
  8. data/lib/rf/stylez/version.rb +1 -1
  9. data/lib/rf/stylez.rb +3 -0
  10. data/rf-stylez.gemspec +26 -22
  11. data/ruby/.reek.yml +65 -0
  12. metadata +45 -16
  13. data/.travis.yml +0 -6
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: 61997bdfb767ee58340845830dd03f1a71f9432318818ddca2c511f70d570dbb
4
- data.tar.gz: 96b7a3c0213e4980736a2a32f45827776b9eb376399f2ca2a32fcff468da1f28
3
+ metadata.gz: c5698db46106cea7f1f43340ccce5c27bd69270d451908684fac3cbd6faf92f8
4
+ data.tar.gz: d98bb236422f73775a6308379725281e19f9b08fa1deace9fa8e07561994f993
5
5
  SHA512:
6
- metadata.gz: f9f9830783fc1680ff00cbcc316f324e330815d59f603c2c539830f76df2fd12b887d44a3f53c22d560450533860bb5209fdb79c00b827e5c0ec3f6c1a0623c8
7
- data.tar.gz: 042cff1fe645245641e7cdd34250f343b9853c53939de469106794fb4021aefc83f2572b495efc01630b6ca2b8a9aa82b89b521c968c1b6b46edcf7a6e781dbc
6
+ metadata.gz: 9c755c9e685f4c1587f2a20b01082480a2af46e142e48f724b686e8f66a4cd63a883aba46955e53062722d4cced9ead949912fb88f002d248669e8b8c13ac4f0
7
+ data.tar.gz: 705e934a2927652a9fbcac383b59d87445127104402aec8bd7dec80410e3617796409700ac0ca7d7eaf94fda35beddde29c97ca94e99768c539fa68928335592
data/.circleci/config.yml CHANGED
@@ -1,18 +1,9 @@
1
1
  version: 2.1
2
2
 
3
3
  jobs:
4
- style_check:
5
- docker:
6
- - image: gcr.io/rf-public-images/circlemator:latest
7
- steps:
8
- - checkout
9
- - run:
10
- name: Style check
11
- command: circlemator style-check --base-branch=master
12
-
13
4
  test:
14
5
  docker:
15
- - image: circleci/ruby:2.7.1
6
+ - image: cimg/ruby:3.2.0
16
7
  auth:
17
8
  username: $DOCKERHUB_USERNAME
18
9
  password: $DOCKERHUB_TOKEN
@@ -47,7 +38,7 @@ jobs:
47
38
 
48
39
  push_to_rubygems:
49
40
  docker:
50
- - image: circleci/ruby:2.7.1
41
+ - image: cimg/ruby:3.2.0
51
42
  auth:
52
43
  username: $DOCKERHUB_USERNAME
53
44
  password: $DOCKERHUB_TOKEN
@@ -74,11 +65,6 @@ workflows:
74
65
  - test:
75
66
  context:
76
67
  - DockerHub
77
- - style_check:
78
- filters:
79
- branches:
80
- ignore:
81
- - master
82
68
  - push_to_rubygems:
83
69
  filters:
84
70
  branches:
data/.github/workflows/pronto.yml ADDED
@@ -0,0 +1,40 @@
1
+ name: Pronto
2
+ on: [pull_request]
3
+
4
+ permissions:
5
+ checks: write
6
+ contents: read
7
+ pull-requests: write
8
+ statuses: write
9
+
10
+ jobs:
11
+ pronto:
12
+ runs-on: ubuntu-latest
13
+ env:
14
+ # `MAKE="make --jobs $(nproc)"` is from
15
+ # https://build.betterup.com/one-weird-trick-that-will-speed-up-your-bundle-install/
16
+ # Only works for MRI
17
+ #
18
+ # Using 4 since https://github.com/ruby/setup-ruby use 4
19
+ MAKE: "make --jobs 4"
20
+
21
+ steps:
22
+ - name: Checkout code
23
+ uses: actions/checkout@v2
24
+ # Set the depth to 100 and hope this won't fail for branches with a lot of little commits
25
+ - run: |
26
+ git fetch --no-tags --prune --depth=100 origin +refs/heads/*:refs/remotes/origin/*
27
+ - name: Setup Ruby
28
+ uses: ruby/setup-ruby@v1
29
+ with:
30
+ ruby-version: "3.2.0"
31
+ # Run `bundle install` with cache when `true`
32
+ bundler-cache: true
33
+ - name: Setup pronto
34
+ run: gem install pronto pronto-rubocop
35
+ - name: Run Pronto
36
+ run: bundle exec pronto run -f github_status github_pr -c origin/${{ github.base_ref }}
37
+ env:
38
+ PRONTO_PULL_REQUEST_ID: ${{ github.event.pull_request.number }}
39
+ PRONTO_GITHUB_ACCESS_TOKEN: "${{ github.token }}"
40
+ BUNDLE_PATH: "vendor/bundle"
data/.gitignore CHANGED
@@ -8,3 +8,4 @@
8
8
  /spec/reports/
9
9
  /tmp/
10
10
  .byebug_history
11
+ .tool-versions
data/Gemfile CHANGED
@@ -1,6 +1,5 @@
1
1
  # frozen_string_literal: true
2
2
 
3
- source 'https://rubygems.org' do
4
- # Specify your gem's dependencies in rf-stylez.gemspec
5
- gemspec
6
- end
3
+ source "https://rubygems.org"
4
+
5
+ gemspec
data/bin/rf-stylez CHANGED
@@ -4,9 +4,12 @@ require "bundler/setup"
4
4
  require "rf/stylez"
5
5
 
6
6
  command = ARGV.first
7
- unless command == 'check-latest'
8
- STDERR.puts('Usage: rf-stylez check-latest')
9
- return
7
+ case command
8
+ when 'check-latest'
9
+ Rf::Stylez::UpdateCheck.check
10
+ when 'reek-config-path'
11
+ puts(Rf::Stylez.reek_config_path)
12
+ else
13
+ STDERR.puts('Usage: rf-stylez [check-latest][reek-config-path]')
10
14
  end
11
15
 
12
- Rf::Stylez::UpdateCheck.check
data/lib/rf/stylez/update_check.rb CHANGED
@@ -4,8 +4,6 @@ require 'json'
4
4
  require 'net/http'
5
5
  require 'logger'
6
6
 
7
- require 'semantic_versioning'
8
-
9
7
  module Rf
10
8
  module Stylez
11
9
  module UpdateCheck
@@ -13,9 +11,9 @@ module Rf
13
11
 
14
12
  def self.check
15
13
  logger = Logger.new(STDOUT)
16
- current_version = SemanticVersioning::Version.new(VERSION)
14
+ current_version = Gem::Version.new(VERSION)
17
15
 
18
- remote_version = SemanticVersioning::Version.new(
16
+ remote_version = Gem::Version.new(
19
17
  JSON.parse(Net::HTTP.get(RUBYGEMS_URL))['version']
20
18
  )
21
19
  if current_version >= remote_version
data/lib/rf/stylez/version.rb CHANGED
@@ -2,6 +2,6 @@
2
2
 
3
3
  module Rf
4
4
  module Stylez
5
- VERSION = '0.14.0'
5
+ VERSION = "0.16.0"
6
6
  end
7
7
  end
data/lib/rf/stylez.rb CHANGED
@@ -13,5 +13,8 @@ require 'rubocop/cop/lint/no_vcr_recording'
13
13
 
14
14
  module Rf
15
15
  module Stylez
16
+ def self.reek_config_path
17
+ File.expand_path("../../ruby/.reek.yml", __dir__)
18
+ end
16
19
  end
17
20
  end
data/rf-stylez.gemspec CHANGED
@@ -1,34 +1,38 @@
1
1
  # coding: utf-8
2
- lib = File.expand_path('../lib', __FILE__)
2
+ # frozen_string_literal: true
3
+
4
+ lib = File.expand_path("../lib", __FILE__)
3
5
  $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
4
- require 'rf/stylez/version'
6
+ require "rf/stylez/version"
5
7
 
6
8
  Gem::Specification.new do |spec|
7
- spec.name = 'rf-stylez'
9
+ spec.name = "rf-stylez"
8
10
  spec.version = Rf::Stylez::VERSION
9
- spec.authors = ['Emanuel Evans']
10
- spec.email = ['emanuel@rainforestqa.com']
11
- spec.license = 'MIT'
11
+ spec.authors = ["Emanuel Evans"]
12
+ spec.email = ["emanuel@rainforestqa.com"]
13
+ spec.license = "MIT"
12
14
 
13
15
  spec.summary = %q{Styles for Rainforest code}
14
- spec.description = 'Configurations for Rubocop and other style enforcers/linters'
15
- spec.homepage = 'https://github.com/rainforestapp/rf-stylez'
16
+ spec.description = "Configurations for Rubocop and other style enforcers/linters"
17
+ spec.homepage = "https://github.com/rainforestapp/rf-stylez"
16
18
 
17
19
  spec.files = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
18
- spec.bindir = 'bin'
19
- spec.executables = ['rf-stylez']
20
- spec.require_paths = ['lib']
20
+ spec.bindir = "bin"
21
+ spec.executables = ["rf-stylez"]
22
+ spec.require_paths = ["lib"]
21
23
 
22
- spec.add_runtime_dependency 'rubocop', '1.15.0'
23
- spec.add_runtime_dependency 'rubocop-rails', '2.10.1'
24
- spec.add_runtime_dependency 'rubocop-rspec', '2.3.0'
25
- spec.add_runtime_dependency 'get_env', '~> 0.2.0'
26
- spec.add_runtime_dependency 'semantic_versioning', '~> 0.2'
27
- spec.add_runtime_dependency 'unparser', '~> 0.6'
24
+ spec.add_runtime_dependency "rubocop", "1.41.1"
25
+ spec.add_runtime_dependency "rubocop-rails", "2.17.4"
26
+ spec.add_runtime_dependency "rubocop-rspec", "2.16.0"
27
+ spec.add_runtime_dependency "reek", "~> 6.1"
28
+ spec.add_runtime_dependency "get_env", "~> 0.2.0"
29
+ spec.add_runtime_dependency "unparser", "~> 0.6"
30
+ spec.add_runtime_dependency "pronto", "~> 0.11.1"
31
+ spec.add_runtime_dependency "pronto-rubocop", "~> 0.11.4"
28
32
 
29
- spec.add_development_dependency 'bundler', '~> 2.1'
30
- spec.add_development_dependency 'rake', '~> 13.0'
31
- spec.add_development_dependency 'rspec', '>= 3.4'
32
- spec.add_development_dependency 'byebug'
33
- spec.add_development_dependency 'rspec_junit_formatter'
33
+ spec.add_development_dependency "bundler", "~> 2.1"
34
+ spec.add_development_dependency "rake", "~> 13.0"
35
+ spec.add_development_dependency "rspec", ">= 3.4"
36
+ spec.add_development_dependency "byebug"
37
+ spec.add_development_dependency "rspec_junit_formatter"
34
38
  end
data/ruby/.reek.yml ADDED
@@ -0,0 +1,65 @@
1
+ ---
2
+ ### Generic smell configuration
3
+
4
+ # You can check all defaults at https://github.com/troessner/reek/blob/master/docs/defaults.reek.yml
5
+ detectors:
6
+ # IrresponsibleModule duplicates rubocop top-level comment rule
7
+ IrresponsibleModule:
8
+ enabled: false
9
+
10
+ NestedIterators:
11
+ max_allowed_nesting: 1
12
+
13
+ UtilityFunction:
14
+ public_methods_only: true
15
+
16
+ TooManyStatements:
17
+ max_statements: 10
18
+
19
+ TooManyMethods:
20
+ max_methods: 20
21
+
22
+ TooManyInstanceVariables:
23
+ max_instance_variables: 8
24
+
25
+ ### Directory specific configuration
26
+
27
+ # You can configure smells on a per-directory base.
28
+ # E.g. the classic Rails case: controllers smell of NestedIterators (see /docs/Nested-Iterators.md) and
29
+ # helpers smell of UtilityFunction (see docs/Utility-Function.md)
30
+ #
31
+ # Note that we only allow configuration on a directory level, not a file level,
32
+ # so all paths have to point to directories.
33
+ # A Dir.glob pattern can be used.
34
+ directories:
35
+ "app/controllers":
36
+ NestedIterators:
37
+ max_allowed_nesting: 2
38
+ UnusedPrivateMethod:
39
+ enabled: false
40
+ InstanceVariableAssumption:
41
+ enabled: false
42
+ "app/helpers":
43
+ UtilityFunction:
44
+ enabled: false
45
+ "app/mailers":
46
+ InstanceVariableAssumption:
47
+ enabled: false
48
+ "app/models":
49
+ InstanceVariableAssumption:
50
+ enabled: false
51
+ "app/rack/api":
52
+ MissingSafeMethod:
53
+ exclude:
54
+ - validate_param!
55
+ InstanceVariableAssumption:
56
+ enabled: false
57
+ "spec/mailers/previews":
58
+ UtilityFunction:
59
+ enabled: false
60
+
61
+ exclude_paths:
62
+ - db/
63
+ - script/
64
+ - bin/
65
+ - app/jobs/data_correction/
metadata CHANGED
@@ -1,14 +1,14 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: rf-stylez
3
3
  version: !ruby/object:Gem::Version
4
- version: 0.14.0
4
+ version: 0.16.0
5
5
  platform: ruby
6
6
  authors:
7
7
  - Emanuel Evans
8
8
  autorequire:
9
9
  bindir: bin
10
10
  cert_chain: []
11
- date: 2022-02-08 00:00:00.000000000 Z
11
+ date: 2023-01-02 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: rubocop
@@ -16,70 +16,70 @@ dependencies:
16
16
  requirements:
17
17
  - - '='
18
18
  - !ruby/object:Gem::Version
19
- version: 1.15.0
19
+ version: 1.41.1
20
20
  type: :runtime
21
21
  prerelease: false
22
22
  version_requirements: !ruby/object:Gem::Requirement
23
23
  requirements:
24
24
  - - '='
25
25
  - !ruby/object:Gem::Version
26
- version: 1.15.0
26
+ version: 1.41.1
27
27
  - !ruby/object:Gem::Dependency
28
28
  name: rubocop-rails
29
29
  requirement: !ruby/object:Gem::Requirement
30
30
  requirements:
31
31
  - - '='
32
32
  - !ruby/object:Gem::Version
33
- version: 2.10.1
33
+ version: 2.17.4
34
34
  type: :runtime
35
35
  prerelease: false
36
36
  version_requirements: !ruby/object:Gem::Requirement
37
37
  requirements:
38
38
  - - '='
39
39
  - !ruby/object:Gem::Version
40
- version: 2.10.1
40
+ version: 2.17.4
41
41
  - !ruby/object:Gem::Dependency
42
42
  name: rubocop-rspec
43
43
  requirement: !ruby/object:Gem::Requirement
44
44
  requirements:
45
45
  - - '='
46
46
  - !ruby/object:Gem::Version
47
- version: 2.3.0
47
+ version: 2.16.0
48
48
  type: :runtime
49
49
  prerelease: false
50
50
  version_requirements: !ruby/object:Gem::Requirement
51
51
  requirements:
52
52
  - - '='
53
53
  - !ruby/object:Gem::Version
54
- version: 2.3.0
54
+ version: 2.16.0
55
55
  - !ruby/object:Gem::Dependency
56
- name: get_env
56
+ name: reek
57
57
  requirement: !ruby/object:Gem::Requirement
58
58
  requirements:
59
59
  - - "~>"
60
60
  - !ruby/object:Gem::Version
61
- version: 0.2.0
61
+ version: '6.1'
62
62
  type: :runtime
63
63
  prerelease: false
64
64
  version_requirements: !ruby/object:Gem::Requirement
65
65
  requirements:
66
66
  - - "~>"
67
67
  - !ruby/object:Gem::Version
68
- version: 0.2.0
68
+ version: '6.1'
69
69
  - !ruby/object:Gem::Dependency
70
- name: semantic_versioning
70
+ name: get_env
71
71
  requirement: !ruby/object:Gem::Requirement
72
72
  requirements:
73
73
  - - "~>"
74
74
  - !ruby/object:Gem::Version
75
- version: '0.2'
75
+ version: 0.2.0
76
76
  type: :runtime
77
77
  prerelease: false
78
78
  version_requirements: !ruby/object:Gem::Requirement
79
79
  requirements:
80
80
  - - "~>"
81
81
  - !ruby/object:Gem::Version
82
- version: '0.2'
82
+ version: 0.2.0
83
83
  - !ruby/object:Gem::Dependency
84
84
  name: unparser
85
85
  requirement: !ruby/object:Gem::Requirement
@@ -94,6 +94,34 @@ dependencies:
94
94
  - - "~>"
95
95
  - !ruby/object:Gem::Version
96
96
  version: '0.6'
97
+ - !ruby/object:Gem::Dependency
98
+ name: pronto
99
+ requirement: !ruby/object:Gem::Requirement
100
+ requirements:
101
+ - - "~>"
102
+ - !ruby/object:Gem::Version
103
+ version: 0.11.1
104
+ type: :runtime
105
+ prerelease: false
106
+ version_requirements: !ruby/object:Gem::Requirement
107
+ requirements:
108
+ - - "~>"
109
+ - !ruby/object:Gem::Version
110
+ version: 0.11.1
111
+ - !ruby/object:Gem::Dependency
112
+ name: pronto-rubocop
113
+ requirement: !ruby/object:Gem::Requirement
114
+ requirements:
115
+ - - "~>"
116
+ - !ruby/object:Gem::Version
117
+ version: 0.11.4
118
+ type: :runtime
119
+ prerelease: false
120
+ version_requirements: !ruby/object:Gem::Requirement
121
+ requirements:
122
+ - - "~>"
123
+ - !ruby/object:Gem::Version
124
+ version: 0.11.4
97
125
  - !ruby/object:Gem::Dependency
98
126
  name: bundler
99
127
  requirement: !ruby/object:Gem::Requirement
@@ -174,10 +202,10 @@ extra_rdoc_files: []
174
202
  files:
175
203
  - ".circleci/config.yml"
176
204
  - ".github/dependabot.yml"
205
+ - ".github/workflows/pronto.yml"
177
206
  - ".gitignore"
178
207
  - ".rspec"
179
208
  - ".rubocop.yml"
180
- - ".travis.yml"
181
209
  - Gemfile
182
210
  - LICENSE
183
211
  - README.md
@@ -197,6 +225,7 @@ files:
197
225
  - lib/rubocop/cop/lint/use_positive_int32_validator.rb
198
226
  - rails/rubocop.yml
199
227
  - rf-stylez.gemspec
228
+ - ruby/.reek.yml
200
229
  - ruby/rubocop.yml
201
230
  - ruby/rubocop_lint.yml
202
231
  homepage: https://github.com/rainforestapp/rf-stylez
@@ -218,7 +247,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
218
247
  - !ruby/object:Gem::Version
219
248
  version: '0'
220
249
  requirements: []
221
- rubygems_version: 3.1.2
250
+ rubygems_version: 3.4.1
222
251
  signing_key:
223
252
  specification_version: 4
224
253
  summary: Styles for Rainforest code
data/.travis.yml DELETED
@@ -1,6 +0,0 @@
1
- language: ruby
2
- rvm:
3
- - 2.6.3
4
- - 2.5.1
5
- - 2.4.4
6
- before_install: gem install bundler -v 1.10.6