rf-stylez 0.11.1 → 0.12.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 73102c0596ce3354435f37083348b38db9d7def32d14e8d6c14ecc5c7869a9fe
-  data.tar.gz: 8f272dd380d4bde12f56fbc15e3edd68d7fce16504d4920629fe415b0e326508
+  metadata.gz: 379e37d37df24166deb38eef0b97d0373a6734aeb738b8bfb80637bf118bc012
+  data.tar.gz: b6b1d14e28ae49b27e9e25f766d729b8bddea43b5227010b129690bbb58e19db
 SHA512:
-  metadata.gz: 7cbb8cf428fe5d4f743dc571a947826114885369f614af81edd6ea3de3f6f36a498653db5bad394974731eb2d97693a09e5feb59d9ffd2e717405ed78d8f65e0
-  data.tar.gz: 077d3802422b789e01fc1101e011499ec0bdce6f651af4e31c0ecef7427b2c7c7f1354036a00dca45ac21a000eb018f92a087276acfee4beb1af5d85e68849f4
+  metadata.gz: 6cba253d02a644530d184380ba14d9bc716190866c8e891f547bd791d08d016b8ecbe82ff6bf366a89af79fac879c71b6d58643b8eb4fe1968c793c6bc29bd93
+  data.tar.gz: 2dbb03b8a502241e7ff0494414753281bf5a5d8352c9e781a3803fcecefdb3a3addf94e399939f0946681cfa904a41f6fca1c104920a827304ba171cfa82801c

data/lib/rf/stylez/version.rb

@@ -2,6 +2,6 @@
 
 module Rf
   module Stylez
-    VERSION = '0.11.1'
+    VERSION = '0.12.0'
   end
 end

data/lib/rf/stylez.rb

@@ -9,6 +9,7 @@ require 'rubocop/cop/lint/obscure'
 require 'rubocop/cop/lint/no_grape_api'
 require 'rubocop/cop/lint/use_positive_int32_validator'
 require 'rubocop/cop/lint/no_untyped_raise'
+require 'rubocop/cop/lint/no_vcr_recording'
 
 module Rf
   module Stylez

data/lib/rubocop/cop/lint/no_vcr_recording.rb

@@ -0,0 +1,74 @@
+# frozen_string_literal: true
+require 'unparser'
+
+module RuboCop
+  module Cop
+    module Lint
+      # @example
+      #   # bad
+      #   vcr: { record_mode: :once, tag: :foo }
+      #   vcr: { record_mode: :none }
+      #
+      #   # good
+      #   vcr: { tag: :foo }
+      #   vcr: true
+      class NoVCRRecording < RuboCop::Cop::Base
+        extend AutoCorrector
+
+        MSG = 'Do not set :record option in VCR'.freeze
+
+        def_node_search :is_only_setting_record_option?, <<~PATTERN
+          (pair
+            (sym :vcr)
+            (hash
+              (pair
+                (sym :record)
+                ...
+              )
+            )
+          )
+        PATTERN
+        def_node_search :is_setting_record_option?, <<~PATTERN
+          (pair
+            (sym :vcr)
+            (hash
+              <
+                (pair
+                  (sym :record)
+                  ...
+                )
+                ...
+              >
+            )
+          )
+        PATTERN
+
+        def on_pair(node)
+          return unless is_only_setting_record_option?(node) || is_setting_record_option?(node)
+
+          add_offense(node) do |corrector|
+            if is_only_setting_record_option?(node)
+              corrector.replace(node, 'vcr: true')
+            elsif is_setting_record_option?(node)
+              corrector.replace(node, remove_record_option(node))
+            end
+          end
+        end
+
+        private
+
+        def remove_record_option(top_pair_node)
+          extend AST::Sexp
+
+          _vcr_key, hash = top_pair_node.children
+          other_options = hash.children.reject do |pair|
+            key, _value = pair.children
+            key == s(:sym, :record)
+          end
+
+          Unparser.unparse(s(:pair, s(:sym, :vcr), s(:hash, *other_options)))
+        end
+      end
+    end
+  end
+end

data/rf-stylez.gemspec

@@ -19,11 +19,12 @@ Gem::Specification.new do |spec|
   spec.executables   = ['rf-stylez']
   spec.require_paths = ['lib']
 
-  spec.add_runtime_dependency 'rubocop', '1.12'
-  spec.add_runtime_dependency 'rubocop-rails', '2.9.1'
+  spec.add_runtime_dependency 'rubocop', '1.15.0'
+  spec.add_runtime_dependency 'rubocop-rails', '2.10.1'
   spec.add_runtime_dependency 'rubocop-rspec', '2.3.0'
   spec.add_runtime_dependency 'get_env', '~> 0.2.0'
   spec.add_runtime_dependency 'semantic_versioning', '~> 0.2'
+  spec.add_runtime_dependency 'unparser', '~> 0.6'
 
   spec.add_development_dependency 'bundler', '~> 2.1'
   spec.add_development_dependency 'rake', '~> 13.0'

data/ruby/rubocop.yml

@@ -34,6 +34,10 @@ Lint/UsePositiveInt32Validator:
   Enabled: true
 Lint/NoJSON:
   Enabled: true
+Lint/NoVCRRecording:
+  Enabled: true
+  Include:
+    - spec/**/*
 
 # Good style cops
 Layout/BlockAlignment:

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rf-stylez
 version: !ruby/object:Gem::Version
-  version: 0.11.1
+  version: 0.12.0
 platform: ruby
 authors:
 - Emanuel Evans
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-05-14 00:00:00.000000000 Z
+date: 2021-08-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,28 +16,28 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: '1.12'
+        version: 1.15.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: '1.12'
+        version: 1.15.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.9.1
+        version: 2.10.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.9.1
+        version: 2.10.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
@@ -80,6 +80,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.2'
+- !ruby/object:Gem::Dependency
+  name: unparser
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.6'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.6'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -178,6 +192,7 @@ files:
 - lib/rubocop/cop/lint/no_http_party.rb
 - lib/rubocop/cop/lint/no_json.rb
 - lib/rubocop/cop/lint/no_untyped_raise.rb
+- lib/rubocop/cop/lint/no_vcr_recording.rb
 - lib/rubocop/cop/lint/obscure.rb
 - lib/rubocop/cop/lint/use_positive_int32_validator.rb
 - rails/rubocop.yml