rf-stylez 0.11.0 → 0.14.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7ccc61a83003b3de44d1bfc278492c425bd472dc04ffcfc5b3553b79b0fdaf30
-  data.tar.gz: 3c04bc697ecec80f69431996caab873691e86a028490c84727cbab7cec7922c0
+  metadata.gz: 61997bdfb767ee58340845830dd03f1a71f9432318818ddca2c511f70d570dbb
+  data.tar.gz: 96b7a3c0213e4980736a2a32f45827776b9eb376399f2ca2a32fcff468da1f28
 SHA512:
-  metadata.gz: c5986cd858419d5f000158dc8ca19d0d7c407259bfcd6b7e7fbf7abeb17166f2debedca2983ec1a8af75fbb522892f923401c233acc5b2626565300c1f7cc997
-  data.tar.gz: 89ea291297ee107387ea9cbb2bd8a29864c180e0dbf2d53608c337c7c3914eef6bcb9a8da7567a0a04cf4b75ca8ab18564a3a6efd72c7c1374a2a73603e64fa6
+  metadata.gz: f9f9830783fc1680ff00cbcc316f324e330815d59f603c2c539830f76df2fd12b887d44a3f53c22d560450533860bb5209fdb79c00b827e5c0ec3f6c1a0623c8
+  data.tar.gz: 042cff1fe645245641e7cdd34250f343b9853c53939de469106794fb4021aefc83f2572b495efc01630b6ca2b8a9aa82b89b521c968c1b6b46edcf7a6e781dbc

data/lib/rf/stylez/version.rb

@@ -2,6 +2,6 @@
 
 module Rf
   module Stylez
-    VERSION = '0.11.0'
+    VERSION = '0.14.0'
   end
 end

data/lib/rf/stylez.rb

@@ -9,6 +9,7 @@ require 'rubocop/cop/lint/obscure'
 require 'rubocop/cop/lint/no_grape_api'
 require 'rubocop/cop/lint/use_positive_int32_validator'
 require 'rubocop/cop/lint/no_untyped_raise'
+require 'rubocop/cop/lint/no_vcr_recording'
 
 module Rf
   module Stylez

data/lib/rubocop/cop/lint/no_vcr_recording.rb

@@ -0,0 +1,74 @@
+# frozen_string_literal: true
+require 'unparser'
+
+module RuboCop
+  module Cop
+    module Lint
+      # @example
+      #   # bad
+      #   vcr: { record_mode: :once, tag: :foo }
+      #   vcr: { record_mode: :none }
+      #
+      #   # good
+      #   vcr: { tag: :foo }
+      #   vcr: true
+      class NoVCRRecording < RuboCop::Cop::Base
+        extend AutoCorrector
+
+        MSG = 'Do not set :record option in VCR'.freeze
+
+        def_node_search :is_only_setting_record_option?, <<~PATTERN
+          (pair
+            (sym :vcr)
+            (hash
+              (pair
+                (sym :record)
+                ...
+              )
+            )
+          )
+        PATTERN
+        def_node_search :is_setting_record_option?, <<~PATTERN
+          (pair
+            (sym :vcr)
+            (hash
+              <
+                (pair
+                  (sym :record)
+                  ...
+                )
+                ...
+              >
+            )
+          )
+        PATTERN
+
+        def on_pair(node)
+          return unless is_only_setting_record_option?(node) || is_setting_record_option?(node)
+
+          add_offense(node) do |corrector|
+            if is_only_setting_record_option?(node)
+              corrector.replace(node, 'vcr: true')
+            elsif is_setting_record_option?(node)
+              corrector.replace(node, remove_record_option(node))
+            end
+          end
+        end
+
+        private
+
+        def remove_record_option(top_pair_node)
+          extend AST::Sexp
+
+          _vcr_key, hash = top_pair_node.children
+          other_options = hash.children.reject do |pair|
+            key, _value = pair.children
+            key == s(:sym, :record)
+          end
+
+          Unparser.unparse(s(:pair, s(:sym, :vcr), s(:hash, *other_options)))
+        end
+      end
+    end
+  end
+end

data/rf-stylez.gemspec

@@ -19,11 +19,12 @@ Gem::Specification.new do |spec|
   spec.executables   = ['rf-stylez']
   spec.require_paths = ['lib']
 
-  spec.add_runtime_dependency 'rubocop', '1.12'
-  spec.add_runtime_dependency 'rubocop-rails', '2.9.1'
+  spec.add_runtime_dependency 'rubocop', '1.15.0'
+  spec.add_runtime_dependency 'rubocop-rails', '2.10.1'
   spec.add_runtime_dependency 'rubocop-rspec', '2.3.0'
   spec.add_runtime_dependency 'get_env', '~> 0.2.0'
   spec.add_runtime_dependency 'semantic_versioning', '~> 0.2'
+  spec.add_runtime_dependency 'unparser', '~> 0.6'
 
   spec.add_development_dependency 'bundler', '~> 2.1'
   spec.add_development_dependency 'rake', '~> 13.0'

data/ruby/rubocop.yml

@@ -34,6 +34,10 @@ Lint/UsePositiveInt32Validator:
   Enabled: true
 Lint/NoJSON:
   Enabled: true
+Lint/NoVCRRecording:
+  Enabled: true
+  Include:
+    - spec/**/*
 
 # Good style cops
 Layout/BlockAlignment:
@@ -50,6 +54,7 @@ Layout/TrailingWhitespace:
   Enabled: true
 Layout/EmptyLineBetweenDefs:
   Enabled: true
+  EmptyLineBetweenClassDefs: false
 Layout/IndentationWidth:
   Enabled: true
 Layout/AccessModifierIndentation:
@@ -130,7 +135,18 @@ Style/MethodCallWithoutArgsParentheses:
 Style/InfiniteLoop:
   Enabled: true
 Style/StringLiterals:
-  Enabled: true
+  Description: 'Checks if uses of quotes match the configured preference.'
+  StyleGuide: '#consistent-string-literals'
+  Enabled: true
+  VersionAdded: '0.9'
+  VersionChanged: '0.36'
+  EnforcedStyle: double_quotes
+  SupportedStyles:
+    - single_quotes
+    - double_quotes
+  # If `true`, strings which span multiple lines using `\` for continuation must
+  # use the same type of quotes on each line.
+  ConsistentQuotesInMultiline: true
 Style/AndOr:
   Enabled: true
 Style/Not:
@@ -160,12 +176,18 @@ Style/SymbolProc:
   Enabled: true
 Style/RegexpLiteral:
   Enabled: true
+Style/Documentation:
+  Enabled: true
+Style/DocumentationMethod:
+  Enabled: false
 
 Layout/LineLength:
   Enabled: true
   Max: 120
   AllowHeredoc: true
   AllowURI: true
+Layout/EmptyLineAfterMagicComment:
+  Enabled: true
 
 # Dumb lint cops
 Lint/AmbiguousOperator:

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rf-stylez
 version: !ruby/object:Gem::Version
-  version: 0.11.0
+  version: 0.14.0
 platform: ruby
 authors:
 - Emanuel Evans
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-05-14 00:00:00.000000000 Z
+date: 2022-02-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,28 +16,28 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: '1.12'
+        version: 1.15.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: '1.12'
+        version: 1.15.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.9.1
+        version: 2.10.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.9.1
+        version: 2.10.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
@@ -80,6 +80,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.2'
+- !ruby/object:Gem::Dependency
+  name: unparser
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.6'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.6'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -178,6 +192,7 @@ files:
 - lib/rubocop/cop/lint/no_http_party.rb
 - lib/rubocop/cop/lint/no_json.rb
 - lib/rubocop/cop/lint/no_untyped_raise.rb
+- lib/rubocop/cop/lint/no_vcr_recording.rb
 - lib/rubocop/cop/lint/obscure.rb
 - lib/rubocop/cop/lint/use_positive_int32_validator.rb
 - rails/rubocop.yml