revs-utils 1.0.13 → 1.0.14

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    NjU2NmIwNThmMTdhOTYzNjE1YjMzZGYzNDVmOTkxMGViMTEzZmVkZA==
+    NWQyNzQ0ZDdhYmMzZmY3OTRiOGQ4MDAwYjJmODhmOTlkNDYwOGI0Zg==
   data.tar.gz: !binary |-
-    NDNjZWEwMzJmYmMyMWE2ZmJjMjM4ZDk2NmFmNzJhNDVmNGNiNTBlOA==
+    ZDNjMjY4NjExMzBlODMzZDc5MzgzOWE4YWRlNzBmODhiMWRlZmQ1Yw==
 SHA512:
   metadata.gz: !binary |-
-    ZmMxNDcwYjJmNDY1NzBiYzExYjMxZGVkOGMzNjA5YTVhNzg2ZWRhNGZhODBk
-    NmMzMGNlOTFlZDRjODNmZjFkNTlhZGQ4OWVlNTg0ZjQ2NTdhNzJkMDVlNjU1
-    Y2VmYzYyNDQzN2VlNGE0N2FmNGU2ZGQ2MWI0ODVkMDI5NjgyNjk=
+    NDRhYjMwYjFlYWMzNWZjMGZkYzBjMzg5ZWU2NmY3NjI3YzNmNDI2ZjhlNTdl
+    MTE5MmEzYzVlZTliMzQ1NTA2MDU4MTkyNTAyZjU5NmNmNTZmZDkwZjk5MTYx
+    NWRkYTRmYmZiNmQyZTZkZDU1Y2UwMjczMDBiNDYxOTc2MjMxYzY=
   data.tar.gz: !binary |-
-    ZmIwZWQxZDBlNTM0ZjIzYmQ4YTliZWQyZTc2NmY3OGY4ZDAzZjM5MjRlZGJk
-    OTE4MzFhZTNiN2YyYzYyNDlmNjA2ODljYThiMzMwNDZiMGFhNTk1YzRiM2E2
-    YjcxN2YxYmI5ZTc0YTMwZjAxM2IzNmJjYThmZDZlOWQ0OGNhOGE=
+    NWFhYjRkNTYwZDI3Y2JjMDQ2YTVkMDI2NzEwZTFjYTM0ZTc3MTQzOGYxNWMw
+    ODZjZDIxNzU4ODFlYzBmOTkyZjIwNDA0Y2UwNzg0YThjMGEyNjc3MmMzZWVm
+    YjBiYmUzOWI4OTc5YmE5N2ZhMzAzMzAwMDc5YzhlNWM5Y2U4YWE=

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    revs-utils (1.0.12)
+    revs-utils (1.0.13)
       actionpack (~> 3)
       chronic
       countries (= 0.9.2)

data/lib/revs-utils.rb

@@ -240,6 +240,7 @@ module Revs
       # tell us if the string passed is in is a full date of the format M/D/YYYY or m-d-yyyy or m-d-yy or M/D/YY, and returns the date object if it is valid
       def get_full_date(date_string)
         begin
+          return false if date_string.scan(/(-|\/)/).count < 2 # we need at least two / or - characters to count as a full date
           date_obj=Chronic.parse(date_string).to_date
           date_obj=date_obj.prev_year(100) if date_obj > Date.today # if the parsing yields a date in the future, this is a problem, so adjust back a century (due to this issue: http://stackoverflow.com/questions/27058068/ruby-incorrectly-parses-2-digit-year)
           is_valid_year?(date_obj.year.to_s) ? date_obj : false

data/lib/revs-utils/version.rb

@@ -1,5 +1,5 @@
 module Revs
   module Utils
-    VERSION = "1.0.13"
+    VERSION = "1.0.14"
   end
 end

data/spec/revs-utils_spec.rb

@@ -76,17 +76,30 @@ describe "Revs-Utils" do
    end
       
    it "should indicate if a date is valid" do
+     
+     # formats that are ok
      @revs.get_full_date('5/1/1959').should == Date.strptime("5/1/1959", '%m/%d/%Y')
      @revs.get_full_date('5-1-1959').should == Date.strptime("5/1/1959", '%m/%d/%Y')
      @revs.get_full_date('5-1-2014').should == Date.strptime("5/1/2014", '%m/%d/%Y')
-     @revs.get_full_date('5-1-59').should == Date.strptime("5/1/1959", '%m/%d/%Y') # deal with two digit years ok too
-     @revs.get_full_date('1/1/71').should == Date.strptime("1/1/1971", '%m/%d/%Y') # deal with two digit years ok too
-     @revs.get_full_date('5-1-14').should == Date.strptime("5/1/2014", '%m/%d/%Y') # deal with two digit years ok too     
-     @revs.get_full_date('5-1-21').should == Date.strptime("5/1/1921", '%m/%d/%Y') # deal with two digit years ok too     
-     @revs.get_full_date('1966-02-27').should == Date.strptime("2/27/1966", '%m/%d/%Y') # deal with alternate formats
-     @revs.get_full_date('1966-2-5').should == Date.strptime("2/5/1966", '%m/%d/%Y') # deal with alternate formats
-     @revs.get_full_date('1966-14-11').should be_false
-     @revs.get_full_date('bogus').should be_false
+     @revs.get_full_date('5-1-59').should == Date.strptime("5/1/1959", '%m/%d/%Y') 
+     @revs.get_full_date('1/1/71').should == Date.strptime("1/1/1971", '%m/%d/%Y') 
+     @revs.get_full_date('5-1-14').should == Date.strptime("5/1/2014", '%m/%d/%Y')     
+     @revs.get_full_date('5-1-21').should == Date.strptime("5/1/1921", '%m/%d/%Y')     
+     @revs.get_full_date('1966-02-27').should == Date.strptime("2/27/1966", '%m/%d/%Y')  
+     @revs.get_full_date('1966-2-5').should == Date.strptime("2/5/1966", '%m/%d/%Y')  
+     
+     # bad full dates
+     @revs.get_full_date('1966-14-11').should be_false # bad month
+     @revs.get_full_date('1966\4\11').should be_false # slashes are the wrong way
+     @revs.get_full_date('bogus').should be_false # crap string
+     @revs.get_full_date('').should be_false # blank
+     @revs.get_full_date('1965').should be_false # only the year
+     @revs.get_full_date('1965-68').should be_false # range of years
+     @revs.get_full_date('1965,1968').should be_false # multiple years
+     @revs.get_full_date('1965|1968').should be_false # multiple years
+     @revs.get_full_date('1965-1968').should be_false # multiple years
+     @revs.get_full_date('1965-8').should be_false # multiple years
+
    end
 
    it "should indicate if we have a valid year" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: revs-utils
 version: !ruby/object:Gem::Version
-  version: 1.0.13
+  version: 1.0.14
 platform: ruby
 authors:
 - Peter Mangiafico