revocare 0.1.1 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8f929fa681bc6b0ada88fd4ff25836596e9994e1559b14bfc5c4f529a6beff99
-  data.tar.gz: ae32cfc85a2bdca4d5dd23eb21dbc4184cbdf2fe1e5c9ae459695c33cd3e99fb
+  metadata.gz: e43ceb2584f78094a31fb9289b40ccd9bbf8650ddb9905bb9cf37004ccc1c9fc
+  data.tar.gz: 6d65f5b9409553aa60dd0193a641252af0e2581463ce84cade6bbc697f9e59e6
 SHA512:
-  metadata.gz: 5678ed93ba7a0e5f691f0bf2d0cce4f7c68733a9d8ed13e569dce1b314ea70c5426da08fca50ddb3fc5d77e76d641e8ea8cdfe7cc2d07f350950c3f39e4cf72b
-  data.tar.gz: bc95dbf169d33c8de843ab0585a58630694cf2fa1d796041cd44c895dbe506e3cb76d6b1a1db4530122c6474dccf938e81ce2fce51ff871478e27b42fa1f2dda
+  metadata.gz: 25281b5ad2fed87409376d50df06f9d1c79bca374ca25fac74610dcecfeebab29287fd83e08034033cacd94922cd62c99bc1deb32f85da7b81133da03f356718
+  data.tar.gz: e2e30482a99d39910ea928c4f47b1af946048424bccead1fc5a4856b7a376828325561ba9489f9f056ddd028e43a97805ca3e714d4bd9078422654842f7d854b

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 # `revocare`
 
+## [0.2.1] (Unreleased)
+- Properly handle custom validators
+- Show validator class name instead of underscore-d name
+
+## [0.2.0]
+- Create a directory to hold all files. Also, create a file for each model rather than a single file for all models. This vastly improves readability.
+
 ## [0.1.1]
 - Make each callback name and chain node unique as to not share nodes between models
 - Properly order callback methods in which they will be executed

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    revocare (0.1.1)
+    revocare (0.2.1)
       activerecord (>= 5.2, < 7.1)
       activesupport (>= 5.2, < 7.1)
       ruby-graphviz (~> 1.2)

data/lib/revocare/callback_data.rb

@@ -65,9 +65,14 @@ module Revocare
 
     def extract_methods(callback_filter)
       if callback_filter.is_a?(ActiveModel::Validator)
-        name = callback_filter.class.name.demodulize.underscore
-        callback_filter.attributes.map do |attr|
-          [name, attr].join(":")
+        name = callback_filter.class.name.demodulize
+
+        if callback_filter.respond_to?(:attributes)
+          callback_filter.attributes.map do |attribute|
+            [name, attribute].join(":")
+          end
+        else
+          [name]
         end
       else
         [callback_filter.to_s]

data/lib/revocare/cli.rb

@@ -30,7 +30,7 @@ module Revocare
     def call
       data = Revocare::CallbackData.to_a
       writer = Revocare::DataWriter.new(data: data)
-      writer.write_to_file
+      writer.write_to_directory
     end
   end
 end

data/lib/revocare/data_writer.rb

@@ -7,10 +7,11 @@ module Revocare
     SUPPORTED_FORMATS = [
       GRAPHVIZ_FORMAT,
     ].freeze
-    DEFAULT_FILENAME = "callbacks.pdf"
+    DEFAULT_DIRECTORY = "./callbacks"
+    DEFAULT_EXTENSION = "pdf"
 
     def initialize(data:, format: DEFAULT_FORMAT)
-      @graph = GraphViz.new(:G, type: :digraph)
+      @graphs = []
       @data = data
       @format = format
       validate_format!
@@ -28,31 +29,37 @@ module Revocare
       @format
     end
 
-    def write_to_file(filename: DEFAULT_FILENAME)
-      extension = File.extname(filename).tr(".", "").to_sym
+    def write_to_directory(extension: DEFAULT_EXTENSION)
+      FileUtils.mkdir_p(DEFAULT_DIRECTORY)
 
       if format == GRAPHVIZ_FORMAT
         data.each_with_index do |model_data, index|
-          model_node = add_model_node(model_data[:model])
+          @current_graph = GraphViz.new(:G, type: :digraph)
+
+          model_name = model_data[:model]
+          model_node = add_model_node(model_name)
+
           model_data[:callbacks].each do |callback|
             name, chain = callback.values_at(:callback_name, :callback_chain)
             name_node = add_callback_node(name, index)
+
             method_nodes = chain.each_with_index.map do |method, order|
               add_callback_chain_node(method, index, order)
             end
 
-            graph.add_edge(model_node, name_node)
-            graph.add_edges(name_node, method_nodes)
+            current_graph.add_edge(model_node, name_node)
+            current_graph.add_edges(name_node, method_nodes)
           end
-        end
 
-        graph.output(extension => filename)
+          filename = "#{DEFAULT_DIRECTORY}/#{model_name.downcase}.#{extension}"
+          current_graph.output(extension => filename)
+        end
       end
     end
 
     private
 
-    attr_reader :data, :graph
+    attr_reader :data, :graphs, :current_graph
 
     def validate_format!
       if !SUPPORTED_FORMATS.include?(@format)
@@ -74,7 +81,7 @@ module Revocare
     end
 
     def add_node(name, index, shape, label = nil)
-      graph.add_node("#{name}#{index}", label: label || name, shape: shape)
+      current_graph.add_node("#{name}#{index}", label: label || name, shape: shape)
     end
   end
 end

data/lib/revocare/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Revocare
-  VERSION = "0.1.1"
+  VERSION = "0.2.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: revocare
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.1
 platform: ruby
 authors:
 - Tyler Ewing
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-01-21 00:00:00.000000000 Z
+date: 2023-01-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord