revisions 0.0.0 → 0.1.0

data/README.rdoc

@@ -47,8 +47,7 @@ pending_revisions:
 * returns true if there are revisions with a more recent updated_at than the model.
 
 save_revision:
-* If your model is a draft, it simply saves the model.
-* If your model is published, it saves a revision (does not modify the core model)
+* Saves a copy of your model (a revision) in the same table
 * OG model doesn't change, so all associations are intact
 * Behaves like standard ActiveRecord save (ie. returns true/false if it saves succesfully and creates an errors array if not)
 * can be called with bang (save_revision!) to throw an exception if it doesn't save.
@@ -80,15 +79,6 @@ apply_revision will affect the original response
 	response.apply_revision						# => true
 	response.title									# => 'monkey'
 
-
-
-==Final Suggestion
-
-Since revisions all live within the same table, you probably want to setup a default scope on your model so you don't access revisions directly.
-
-	default_scope :conditions => "status <> 'revision'"
-
-
 == LIMITATIONS
 
 There are a few things on the to-do list, among them:

data/VERSION

@@ -1 +1 @@
-0.0.0
+0.1.0

data/lib/revisions.rb

@@ -37,23 +37,19 @@ module Revisions
     end
 
     def save_revision
-      if self.published?
-        new_copy = self.clone
-        attributes_to_nil = {}
-        self.unrevised_attributes.each {|a| attributes_to_nil[a] = nil }
-        new_copy.attributes=attributes_to_nil
-        new_copy.created_at = new_copy.updated_at = Time.zone.now
-        new_copy.status = 'revision'
-        new_copy.revision_of = self.id
-        if new_copy.save
-          true
-        else
-          new_copy.errors.each {|attribute,message| self.errors.add(attribute,message)} 
-          false
-        end
+      new_copy = self.clone
+      attributes_to_nil = {}
+      self.unrevised_attributes.each {|a| attributes_to_nil[a] = nil }
+      new_copy.attributes=attributes_to_nil
+      new_copy.created_at = new_copy.updated_at = Time.zone.now
+      new_copy.status = 'revision'
+      new_copy.revision_of = self.id
+      if new_copy.save
+        true
       else
-        save
-      end     
+        new_copy.errors.each {|attribute,message| self.errors.add(attribute,message)} 
+        false
+      end   
     end
 
     def save_revision!

data/revisions.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{revisions}
-  s.version = "0.0.0"
+  s.version = "0.1.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Brian Hamman"]
-  s.date = %q{2010-04-29}
+  s.date = %q{2010-05-20}
   s.description = %q{Save and apply revisions to a model, while keeping track of old revisiions}
   s.email = %q{hamman@gmail.com}
   s.extra_rdoc_files = [

data/test/test_revisions.rb

@@ -26,11 +26,12 @@ class TestRevisions < Test::Unit::TestCase
         end
       end
       
-      should "just save to the same record when in draft mode" do
+      should "save a revision even in draft mode" do
         @response.revisions.delete_all
         @response.status = 'draft'
         assert @response.save_revision
-        assert_equal 0, @response.revisions.size
+        @response.reload
+        assert_equal 1, @response.revisions.size
       end
     
       should "save a revision that copies all fields" do

metadata

@@ -4,9 +4,9 @@ version: !ruby/object:Gem::Version
   prerelease: false
   segments: 
   - 0
+  - 1
   - 0
-  - 0
-  version: 0.0.0
+  version: 0.1.0
 platform: ruby
 authors: 
 - Brian Hamman
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-04-29 00:00:00 -04:00
+date: 2010-05-20 00:00:00 -04:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency