reviewlette 0.0.6 → 0.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 53593949368f61246646984e517e18c7e478497c
-  data.tar.gz: 2c1af0b6ac234d1a06ea28f1906323857a398073
+  metadata.gz: aa4d4a0eb15ee9feae3c0d1d10cea567af2f2ffe
+  data.tar.gz: 84e46cc35612094c580654a48c5cd03eec633bb0
 SHA512:
-  metadata.gz: 1e3e7d9571d7869b2f49e34a7d1be93269e8f8c6f300f00f02bb757e3036aeab4248dfddb8a9479735aac970ebbad56765b6defbfd4bcfc234ac3a94476bf60f
-  data.tar.gz: f4fbe33ad2be3922ae2e9de8d494209f2defbecb0cd19f49affed7d72b4c88cd7d2bbd3b7e942920644f33f2349f74ed83f1995884441f222c0fe3ff92d5f2dc
+  metadata.gz: 104f9629561f1e3f329eebc6823810dcc25174e24b412132e5f297538b51c7ce2ebc76378e1583964619fbd59f1ec8d661ed41711cabbb974209cfc3872d93d7
+  data.tar.gz: dd5b12654663ed8a7aca64d2998157365bb250f2f6582cbbe3c207a2f7d94546ae899fe1d3b44c0d8851d97d94e06c38f1a806a5178f4d6492128691edbace98

data/.gitignore

@@ -2,14 +2,8 @@
 *.db
 *.log
 *.html
-database
-*.yml~
 .idea
-/.idea
-.idea*
-/.idea/*
 *.rbc
-*.yml
 .bundle
 coverage
 .swp
@@ -25,3 +19,7 @@ tmp
 _yardoc
 rdoc/
 doc/
+config/github.yml
+config/trello.yml
+config/members.yml
+

data/Gemfile

@@ -2,7 +2,7 @@ source 'http://rubygems.org'
 
 gem 'json'
 gem 'haml'
-gem 'octokit', '~> 3.0'
+gem 'octokit', '~> 3.8.0'
 gem 'ruby-trello'
 gem 'rdoc'
 gem 'rspec'

data/Gemfile.lock

@@ -10,7 +10,7 @@ GEM
       minitest (~> 5.1)
       thread_safe (~> 0.1)
       tzinfo (~> 1.1)
-    addressable (2.3.6)
+    addressable (2.3.8)
     ap (0.1.1)
       httparty (>= 0.7.7)
     builder (3.2.2)
@@ -27,7 +27,7 @@ GEM
       safe_yaml (~> 1.0.0)
     diff-lcs (1.2.5)
     docile (1.1.3)
-    faraday (0.9.0)
+    faraday (0.9.1)
       multipart-post (>= 1.2, < 3)
     haml (4.0.5)
       tilt
@@ -42,8 +42,8 @@ GEM
     multi_xml (0.5.5)
     multipart-post (2.0.0)
     oauth (0.4.7)
-    octokit (3.1.0)
-      sawyer (~> 0.5.3)
+    octokit (3.8.0)
+      sawyer (~> 0.6.0, >= 0.5.3)
     prophet (1.5.5)
       octokit
       rspec
@@ -71,7 +71,7 @@ GEM
       oauth (~> 0.4.5)
       rest-client (~> 1.6.7)
     safe_yaml (1.0.3)
-    sawyer (0.5.4)
+    sawyer (0.6.0)
       addressable (~> 2.3.5)
       faraday (~> 0.8, < 0.10)
     sequel (4.13.0)
@@ -102,7 +102,7 @@ DEPENDENCIES
   coveralls
   haml
   json
-  octokit (~> 3.0)
+  octokit (~> 3.8.0)
   prophet
   rake
   rdoc

data/README.md

@@ -10,31 +10,18 @@ Tool to automatically assign a "Reviewer" to a GitHub Issue and to the attached
 What it does:
 
 - Finds unassigned issues on GitHub.
-- Assignes a member of your team.
+- Assigns a member of your team.
 - Locates the right Card on Trello.
 - Checks if the assignee is on vacation(using tel).
 - Adds the assigned member to the Card.
-- If the Issue/PullRequest is closed or merged move it in the right column.
-- Prints graphs using Morris.js to display statistics(autorefresh every 5 seconds).
-
-
-![alt tag](http://h.dropcanvas.com/72fj0/graph.jpg)
+- Move the card to 'In review'
 
 
 ## Installation
 
-```
-git clone git@github.com:jschmid1/reviewlette.git
-cd reviewlette
-bundle
-cd bin
-./reviewlette
-```
-
-or
-
 ```
 gem install reviewlette
+reviewlette
 ```
 
 
@@ -43,52 +30,13 @@ gem install reviewlette
 #### Name your pullrequest like so:
 #### Review_#23_name_of_review_42  <= trello card number
 
-Fill `config/.trello.yml` with your **consumerkey**, **consumersecret**, **oauthtoken** and **board_id**
-
-```yml
--comsumerkey: theconsumerkey11
--consumersecret: theconsumersecret11
--oauthtoken: theoauthtoken11
-```
-
-[Which can be generated here](https://trello.com/1/appKey/generate)
-
-Fill `config/.github.yml` with your **token** and **repo**
-
-```yml
--token: thetokenfromgithub
--repo: ['my/repo', 'my/otherrepo']
-```
-
-[Which can be generated here](https://github.com/settings/applications/new)
+Fill `config/.trello.yml` (instructions in the file)
+Fill `config/.github.yml` (instructions in the file
 
 
-Edit the `reviewlette.db` scaffold in the main directory to your needs.
-
-Structure:
-
-| primary_key   | first_name     | last_name     | Reviews_count  | created_at    | github_name   | trello_name   | vacation_status | tel_name      |
-|:-------------:|:-------------: |:-------------:|:-------------: |:-------------:|:-------------:|:-------------:|:-------------:  |:-------------:|
-| Integer(PK)   | Text           | Text          | Integer        | Text          |  Text         |Text           |          Numeric|           Text|
-| 1             | Joshua         | Schmid        | 30             | 2014-01-01    |  jschmid1     |jschmid1       |          false  |        jschmid|
-
-
-
-
-You can either use a GUI like [Sqlite database browser](http://sqlitebrowser.org/) or the sqlite commandline interface
-
-e.g.
-
-```ruby
-insert into reviewer values('John','Smith', '0', '', 'github_name', 'trello_name', 'false', 'tel_name');
-```
-
 ---
 
 [Using Octokit as a GitHub api wrapper](https://github.com/octokit/octokit.rb)
-
-[Using Sequel as Database Module](https://github.com/jeremyevans/sequel)
-
 [Using ruby-trello as a Trello api wrapper](https://github.com/jeremytregunna/ruby-trello)
 
 

data/Rakefile

@@ -2,4 +2,16 @@ require 'rspec/core/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+task :default => :spec
+
+desc 'Run console loaded with gem'
+task :console do
+  require 'irb'
+  require 'irb/completion'
+  require 'byebug'
+  require 'awesome_print'
+  $LOAD_PATH.unshift File.join(File.dirname(__FILE__), 'lib')
+  require 'reviewlette'
+  ARGV.clear
+  IRB.start
+end

data/bin/reviewlette

@@ -3,5 +3,6 @@
 $LOAD_PATH.unshift File.join(File.dirname(__FILE__), '..', 'lib')
 require 'reviewlette'
 
-Reviewlette.spin
+reviewlette = Reviewlette.new
+reviewlette.run
 

data/config/github_example.yml

@@ -0,0 +1,3 @@
+# generate the token here: https://github.com/settings/tokens/new
+token:
+repo: SUSE/connect

data/config/members_example.yml

@@ -0,0 +1,25 @@
+members:
+  - name: Tom
+    suse_username: tschmidt
+    trello_username: thomasschmidt
+    github_username: digitaltom
+  - name: Artem
+    suse_username: achernikov
+    trello_username: artemchernikov
+    github_username: kalabiyau
+  - name: Kirill
+    suse_username: kpimenov
+    trello_username: kirillpimenov
+    github_username: kirushik
+  - name: Vlad
+    suse_username: vlewin
+    trello_username: vlewin
+    github_username: vlewin
+  - name: Will
+    suse_username: wstephenson
+    trello_username: wstephenson
+    github_username: wstephenson
+  - name: Nadja
+    suse_username: nwalter
+    trello_username: nadjaw2
+    github_username: nadjaw

data/config/trello_example.yml

@@ -0,0 +1,9 @@
+# Get your trello keys here: https://trello.com/app-key
+consumerkey:
+
+# request the token here:
+# https://trello.com/1/authorize?key=<key from above>&name=reviewlette&expiration=never&response_type=token&scope=read,write
+oauthtoken:
+
+# The board_id can be read from the url of the board.
+board_id:

data/lib/reviewlette/github_connection.rb

@@ -1,45 +1,40 @@
 require 'yaml'
 require 'octokit'
 
-module Reviewlette
+GITHUB_CONFIG = YAML.load_file("#{File.dirname(__FILE__)}/../../config/github.yml")
 
-  class GithubConnection
+class GithubConnection
 
-    GITHUB_CONFIG = YAML.load_file("#{File.dirname(__FILE__)}/../../config/.github.yml")
+  attr_accessor :client, :repo
 
-    attr_accessor :client, :repo
-
-    def initialize
-      gh_connection
-    end
-
-    def gh_connection
-      @client = Octokit::Client.new(:access_token => GITHUB_CONFIG['token'])
-    end
-
-    def get_branch_name(pr_id, repo)
-      @client.pull_requests(repo)[pr_id].head.ref
-    end
-
-    def list_pulls(repo)
-      @client.pull_requests(repo)
-    end
-
-    def pull_merged?(repo, number)
-      client.pull_merged?(repo, number)
-    end
+  def initialize
+    @client = Octokit::Client.new(:access_token => GITHUB_CONFIG['token'])
+    @repo = GITHUB_CONFIG['repo']
+  end
 
-    def add_assignee(repo, number, title, body, name)
-      @client.update_issue(repo, number, title, body, :assignee => name)
-    end
+  def list_pulls
+    @client.pull_requests(@repo)
+  end
 
-    def comment_on_issue(repo, number, name, trello_card_url)
-      @client.add_comment(repo, number, "@#{name} is your reviewer :thumbsup: check #{trello_card_url}")
-    end
+  def add_assignee(number, assignee)
+    @client.update_issue(@repo, number, assignee: assignee)
+  end
 
-    def list_issues(repo)
-      @client.list_issues(repo)
-    end
+  def reviewer_comment(number, assignee, trello_card)
+    comment = "@#{assignee} is your reviewer :dancers: check #{trello_card.url} \n" \
+              "@#{assignee}: Please review this pull request using our guidelines: \n" \
+              "* test for acceptance criteria / functionality \n" \
+              "* check if the new code is covered with tests \n" \
+              "* check for unintended consequences \n" \
+              "* encourage usage of the boyscout rule \n" \
+              "* make sure the code is architected in the best way \n" \
+              "* check that no unnecessary technical debt got introduced \n" \
+              "* make sure that no unnecessary FIXMEs or TODOs got added \n"
+    @client.add_comment(@repo, number, comment)
+  end
 
+  def unassigned_pull_requests
+    list_pulls.select { |issue| !issue[:assignee] }
   end
-end
+
+end

data/lib/reviewlette/trello_connection.rb

@@ -1,79 +1,45 @@
 require 'yaml'
 require 'trello'
-require 'logger'
-require_relative 'database'
-require_relative 'exceptions'
 
-class Trello::Card
+TRELLO_CONFIG = YAML.load_file("#{File.dirname(__FILE__)}/../../config/trello.yml")
 
-  def assignees
-    @trello_connection = ::Reviewlette::TrelloConnection.new
-    member_ids.map{|id| @trello_connection.find_member_by_id(id)}
-  end
-end
-
-module Reviewlette
-
-  class TrelloConnection
-
-    attr_accessor :board
-
-    def initialize
-      setup_trello
-    end
-
-    def determine_reviewer(card)
-      raise AlreadyAssignedException, "Everyone on the team is assigned to the Card." if reviewer_exception_handler(card)
-      find_member_by_username(sample_reviewer(card))
-    end
-
-    def sample_reviewer(card)
-      (team - card.assignees.map(&:username)).sample
-    end
-
-    def reviewer_exception_handler(card)
-      (team - card.assignees.map(&:username)).count <= 0
-    end
-
-    def add_reviewer_to_card(reviewer, card)
-      card.add_member(reviewer) if reviewer
-    end
+class TrelloConnection
 
-    def comment_on_card(reviewer, card)
-      card.add_comment(reviewer) if reviewer
-    end
+  attr_accessor :board
 
-    def move_card_to_list(card, column)
-      card.move_to_list(column)
+  def initialize
+    Trello.configure do |config|
+      config.developer_public_key = TRELLO_CONFIG['consumerkey']
+      config.member_token = TRELLO_CONFIG['oauthtoken']
     end
+    @board = Trello::Board.find(TRELLO_CONFIG['board_id'])
+  end
 
-    def team
-      #where vacation is not false
-      @team ||= Reviewlette::Database.new.get_users_trello_entries
-    end
+  def add_reviewer_to_card(reviewer, card)
+    reviewer = find_member_by_username(reviewer)
+    card.add_member(reviewer)
+  end
 
-    def find_column(column_name)
-      @board.lists.find {|x| x.name == column_name}
-    end
+  def comment_on_card(comment, card)
+    card.add_comment(comment)
+  end
 
-    def find_member_by_username(username)
-      @board.members.find{|m| m.username == username}
-    end
+  def move_card_to_list(card, column_name)
+    column = find_column(column_name)
+    card.move_to_list(column)
+  end
 
-    def find_member_by_id(id)
-      @board.members.find{|m| m.id == id}
-    end
+  def find_column(column_name)
+    @board.lists.find { |x| x.name == column_name }
+  end
 
-    def find_card_by_id(id)
-      @board.cards.find{|c| c.short_id == id.to_i}
-    end
+  def find_member_by_username(username)
+    @board.members.find { |m| m.username == username }
+  end
 
-    def setup_trello
-      Trello.configure do |config|
-        config.developer_public_key = ::Reviewlette::TRELLO_CONFIG1['consumerkey']
-        config.member_token = ::Reviewlette::TRELLO_CONFIG1['oauthtoken']
-      end
-      @board = Trello::Board.find(::Reviewlette::TRELLO_CONFIG1['board_id'])
-    end
+  def find_card_by_id(id)
+    @board.cards.find { |c| c.short_id == id.to_i }
   end
+
 end
+

data/lib/reviewlette/vacations.rb

@@ -1,38 +1,30 @@
 require 'net/telnet'
-module Reviewlette
 
-  class Vacations
+class Vacations
 
-    def self.find_vacations(username)
-      vacations = []
-      tn = Net::Telnet.new('Host' => 'present.suse.de', 'Port' => 9874, 'Binmode' => false)
-      collect = false
-      tn.cmd(username) do |data|
-        data.split("\n").each do |l|
-          collect = true if l =~ /^Absence/
-          next unless collect
-          if l[0,1] == "-"
-            collect = false
-            next
-          end
-          dates = []
-          l.split(" ").each do |date|
-            unless date =~ /#{Time.now.year}/
-              next
-            end
-            dates.push(date)
-          end
-          case dates.size
-            when 1
-              vacations.push("#{dates[0]}")
-            when 2
-              vacations.push("#{dates[0]} - #{dates[1]}")
-            else
-          end
+  def self.find_vacations(username)
+    vacations = []
+    tn = Net::Telnet.new('Host' => 'present.suse.de', 'Port' => 9874, 'Binmode' => false)
+    tn.cmd("#{username}").split("\n").each do |line|
+      if line =~ /\S{3} #{Time.now.year}-\d\d-\d\d/
+        dates = []
+        line.split(" ").each do |date|
+          dates.push(date) if date =~ /#{Time.now.year}-\d\d-\d\d/
         end
+        dates[1] = dates[0] unless dates[1]
+        vacations.push(Date.parse(dates[0])..Date.parse(dates[1]))
       end
-      tn.close
-      vacations
     end
+    tn.close
+    vacations
   end
-end
+
+  def self.members_on_vacation
+    members_on_vacation = MEMBERS_CONFIG['members'].collect do |member|
+      username = member['suse_username']
+      username if (username && Vacations.find_vacations(username).any? { |v| v === Date.today })
+    end
+    members_on_vacation.compact
+  end
+
+end