reviewlette 0.0.6 → 0.0.7

data/spec/reviewlette_spec.rb

@@ -2,366 +2,70 @@ require 'spec_helper'
 
 describe Reviewlette do
 
-  # set instance variable from local variable
-  def instance_variable!(variable_name)
-    Reviewlette.instance_variable_set("@#{variable_name}", send(variable_name.to_sym))
-  end
-
-  let(:number) { 23 }
-  let(:title) { 'title' }
-  let(:body) { 'body' }
-  let(:githubname) { 'gitty' }
-  let(:trelloname) { 'jschmid' }
-  let(:github_stub) { github_stub }
-  let(:board) { stub_boards_call }
-  let(:repo) { 'repo/repo' }
-  let(:id) { 23 }
-  let(:card) { stub_card_call }
-  let(:logger) { double 'logger' }
-  let(:repos) { %w[repo/repo, repos/repos] }
-  let(:trello_connection) { double 'trello_connection' }
-  let(:reviewer) {double 'reviewer'}
-  let(:db) {Reviewlette::Database.new}
-  let(:github_connection) { double 'github_connection' }
-  let(:full_comment) { @full_comment = "@#{trelloname} will review https://github.com/#{repo}/issues/#{number.to_s}" }
-  let(:exp) { AlreadyAssignedException }
-
-  describe '.spin' do
-    before do
-      instance_variable! :github_connection
-      instance_variable! :repo
-      instance_variable! :trello_connection
-      instance_variable! :id
-      instance_variable! :repos
-      instance_variable! :title
-      instance_variable! :body
-      instance_variable! :number
-      instance_variable! :logger
-      instance_variable! :repos
-      issue = { number: 1, title: 'Title', body: 'Body' }
-      expect(Reviewlette).to receive(:setup)
-      expect(Reviewlette).to receive(:get_available_repos).and_return [repo]
-      expect(Reviewlette).to receive(:get_unassigned_github_issues).and_return [issue]
-      expect(Reviewlette).to receive(:find_card).and_return true
-      expect(Reviewlette).to receive(:update_vacations)
-    end
-
-    it 'spins until find_id' do
-      expect(Reviewlette).to receive(:find_id).and_return false
-      expect(Reviewlette).to_not receive(:set_reviewer)
-      expect(Reviewlette).to_not receive(:transform_name)
-      expect(Reviewlette).to_not receive(:add_reviewer_on_github)
-      expect(Reviewlette).to_not receive(:comment_on_github)
-      expect(Reviewlette).to_not receive(:add_to_trello_card)
-      expect(Reviewlette).to_not receive(:comment_on_trello)
-      expect(Reviewlette).to_not receive(:move_to_list)
-      expect(Reviewlette).to_not receive(:comment_on_error)
-      Reviewlette.spin
-    end
-
-    it 'spins until set_reviewer' do
-      expect(Reviewlette).to receive(:find_id).and_return true
-      expect(Reviewlette).to receive(:set_reviewer)
-      expect(Reviewlette).to_not receive(:transform_name)
-      expect(Reviewlette).to_not receive(:add_reviewer_on_github)
-      expect(Reviewlette).to_not receive(:comment_on_github)
-      expect(Reviewlette).to_not receive(:add_to_trello_card)
-      expect(Reviewlette).to_not receive(:comment_on_trello)
-      expect(Reviewlette).to_not receive(:move_to_list)
-      expect(Reviewlette).to receive(:comment_on_error)
-      Reviewlette.spin
-    end
-
-    it 'spins until set_reviewer' do
-      expect(Reviewlette).to receive(:find_id).and_return true
-      expect(Reviewlette).to receive(:set_reviewer).and_return true
-      expect(Reviewlette).to receive(:transform_name)
-      expect(Reviewlette).to receive(:add_reviewer_on_github)
-      expect(Reviewlette).to receive(:comment_on_github)
-      # expect(Reviewlette).to receive(:add_to_trello_card)
-      expect(Reviewlette).to receive(:comment_on_trello)
-      expect(Reviewlette).to receive(:move_to_list)
-      Reviewlette.instance_variable_set(:@reviewer, 'hi')
-      Reviewlette.instance_variable_set(:@db, db)
-      allow(@reviewer).to receive(:username)
-      expect(db).to receive(:add_pr_to_db).with('Title', @reviewer.username)
-      expect(Reviewlette.instance_variable_set(:@reviewer, nil))
-      expect(Reviewlette).to_not receive(:comment_on_error)
-      Reviewlette.spin
-    end
-  end
-
-  describe '.get_available_repos' do
-
-    it 'pulls in an array on avaialble repos' do
-
-      instance_variable! :repos
-      expect(Reviewlette.instance_variable_get(:@repos)).to be_kind_of Array #ok
-      Reviewlette.get_available_repos
-    end
-  end
-
-  describe '#find_card' do
-
-    it 'finds the card by Github title' do
-      line = 'Review_1337_name_of_pr_trello_shortid_454'
-      pulls = { number: 1 }
-      expect(Reviewlette).to receive(:match_pr_id_with_issue_id).and_return [pulls]
-      allow(Reviewlette.find_card(line)).to receive(:match_pr_id_with_issue_id).and_return Array
-    end
-
-  end
-
-  describe '.fetch_branch' do
-
-    it 'gets the branch_name from github' do
-      branch_name = 'review_github_branch_name_trello_23'
-      subject.instance_variable_set(:@pullreq_ids, {number: 1})
-      split_branch_name = branch_name.split('_')
-      instance_variable! :github_connection
-      expect(Reviewlette.instance_variable_get(:@pullreq_ids)).to receive_message_chain(:values, :index => 0).and_return number
-      expect(github_connection).to receive(:get_branch_name).and_return branch_name
-      expect(branch_name).to receive(:split).with('_').and_return split_branch_name
-      expect(split_branch_name).to receive_message_chain(:last, :to_i)
-      Reviewlette.fetch_branch
-    end
-  end
-
-  describe '.comment_on_error' do
-    it 'posts a comment with the arror message on trello' do
-      instance_variable! :trello_connection
-      expect(trello_connection).to receive(:comment_on_card).with("Skipped Issue 1 because everyone on the team is assigned to the card", nil)
-      Reviewlette.comment_on_error
-    end
-  end
-
-  describe '.get_unassigned_github_issues' do
-    it 'returns all unassigned issues' do
-      instance_variable! :github_connection
-      expect(github_connection).to receive_message_chain(:list_issues, :select)
-      Reviewlette.get_unassigned_github_issues
-    end
-  end
-
-  describe '.match_pr_id_with_issue_id' do
-
-    it 'matches issue id with pr id' do
-      instance_variable! :github_connection
-      instance_variable! :repo
-      pulls  = {number: 1}
-      allow(github_connection).to receive(:list_pulls).and_return [pulls]
-      allow(pulls).to receive(:number).and_return [1]
-      Reviewlette.match_pr_id_with_issue_id
-    end
-  end
-
-
-  describe '.transform_name' do
-    it 'transforms trelloname to github name' do
-      instance_variable! :trelloname
-      Reviewlette.transform_name
-      expect(Reviewlette.instance_variable_get("@githubname")).to be_a_kind_of String
-    end
-  end
+  subject { Reviewlette }
+  let( :reviewlette ) { subject.new }
 
-  describe '.find_id' do
-    before do
-      instance_variable! :id
-      instance_variable! :trello_connection
-    end
+  before {
+    allow(GithubConnection).to receive(:new).and_return GithubConnection
+    allow(TrelloConnection).to receive(:new).and_return TrelloConnection
+  }
 
-    it 'finds the id' do
-      expect(trello_connection).to receive(:find_card_by_id).with(id).and_return card
-      Reviewlette.find_id
-    end
 
-    it 'does not find the id' do
-      Reviewlette.instance_variable_set("@id", 0)
-      Reviewlette.instance_variable_set("@logger", logger)
-      expect(logger).to receive(:warn)
-      expect(Reviewlette.find_id).to be false
+  describe '.new' do
+    it 'sets github and trello connections' do
+       expect(GithubConnection).to receive (:new)
+       expect(TrelloConnection).to receive (:new)
+       subject.new
     end
   end
 
-  describe '.set_reviewer' do
+  describe '.run' do
 
-    before do
-      Reviewlette.instance_variable_set("@reviewer", nil)
-    end
+    it 'iterates over all open pull requests and extracts trello ids from name' do
+      expect(GithubConnection).to receive(:unassigned_pull_requests).and_return([{number: 11, title: 'test_issue_12'}])
+      expect(TrelloConnection).to receive(:find_card_by_id).with(12)
 
-    it 'sets the reviewer' do
-      reviewer = double('reviewer')
-      instance_variable! :trello_connection
-      instance_variable! :card
-      expect(trello_connection).to receive(:determine_reviewer).with(card).and_return reviewer
-      expect(reviewer).to receive(:username).and_return String
-      expect(reviewer).to receive(:username).and_return String
-      Reviewlette.set_reviewer
+      reviewlette.run
     end
 
-    it 'fails to set the reviewer because everyone on the team is assigned to the card' do
-      reviewer = double('reviewer')
-      instance_variable! :trello_connection
-      instance_variable! :card
-      Reviewlette.instance_variable_set("@logger", logger)
-      expect(trello_connection).to receive(:determine_reviewer).with(card).and_raise(Reviewlette::AlreadyAssignedException)
-      allow(card).to receive(:short_id).and_return 3
-      expect($stdout).to receive(:puts)
-      expect(logger).to receive(:warn)
-      expect(Reviewlette.set_reviewer).to eq false
-    end
-  end
+    it 'adds assignee and reviewer comment on github, adds comment on trello and moves card' do
+      card = Trello::Card.new
+      expect(GithubConnection).to receive(:unassigned_pull_requests).and_return([{number: 11, title: 'test_issue_12'}])
+      expect(TrelloConnection).to receive(:find_card_by_id).with(12).and_return(card)
+      expect(reviewlette).to receive(:select_reviewer).and_return({'suse_username' => 'test', 'github_username' => 'testgit'})
 
-  describe '.add_reviewer_on_github' do
-    it 'adds the reviewer on github as assignee' do
-      instance_variable! :github_connection
-      instance_variable! :title
-      instance_variable! :body
-      instance_variable! :number
-      instance_variable! :githubname
-      expect(github_connection).to receive(:add_assignee).with('repo/repo', 23, 'title', 'body', 'gitty').and_return true
-      Reviewlette.add_reviewer_on_github
-    end
-  end
+      expect(GithubConnection).to receive(:add_assignee).with(11, 'testgit')
+      expect(GithubConnection).to receive(:reviewer_comment).with(11, 'testgit', card)
+      expect(GithubConnection).to receive(:repo).and_return('SUSE/test')
 
-  describe '.comment_on_github' do
-    it 'comments on the issue' do
-      instance_variable! :card
-      instance_variable! :number
-      instance_variable! :githubname
-      instance_variable! :github_connection
-      expect(card).to receive(:url).and_return 'www.example.url'
-      expect(github_connection).to receive(:comment_on_issue).with('repo/repo', 23, 'gitty', 'www.example.url').and_return true
-      Reviewlette.comment_on_github
-    end
-  end
+      expect(TrelloConnection).to receive(:comment_on_card).with("@ will review https://github.com/SUSE/test/issues/11", card)
+      expect(TrelloConnection).to receive(:move_card_to_list).with(card, 'In review')
 
-  describe '.add_to_trello_card' do
-    it 'adds a reviewer to the right trello card' do
-      instance_variable! :trello_connection
-      instance_variable! :reviewer
-      instance_variable! :card
-      expect(trello_connection).to receive(:add_reviewer_to_card).with(reviewer, card).and_return true
-      Reviewlette.add_to_trello_card
+      reviewlette.run
     end
 
-    it 'rescues with: already assigned' do
-      instance_variable! :trello_connection
-      expect{Reviewlette.add_to_trello_card}.to raise_exception
-      # Reviewlette.add_to_trello_card
-    end
   end
 
-  describe '.comment_on_trello' do
-    before do
-      instance_variable! :repo
-      instance_variable! :trelloname
-      instance_variable! :number
-      instance_variable! :trello_connection
-      instance_variable! :full_comment
-      instance_variable! :card
-    end
-
-    it 'puts a comment on the trello card ' do
-      expect(full_comment).to eq '@jschmid will review https://github.com/repo/repo/issues/23'
-    end
+  describe '.select_reviewer' do
 
-    it 'actually posts' do
-      expect(trello_connection).to receive(:comment_on_card).with(full_comment, card).and_return true
-      Reviewlette.comment_on_trello
-    end
-  end
+    MEMBERS_CONFIG['members'] = [{'suse_username' => 'test1', 'trello_username' => 'trellotest1'},
+                                 {'suse_username' => 'test2', 'trello_username' => 'trellotest2'}]
 
-  describe '.move_to_list' do
-    before do
-      instance_variable! :github_connection
-      instance_variable! :trello_connection
-      instance_variable! :card
-      instance_variable! :repo
-      instance_variable! :id
+    it 'excludes members on vacation' do
+      card = Trello::Card.new
+      allow(card).to receive(:members).and_return([])
+      expect(Vacations).to receive(:members_on_vacation).and_return(MEMBERS_CONFIG['members'].first['suse_username'])
+      expect(reviewlette.select_reviewer(nil, card)).to eq(MEMBERS_CONFIG['members'].last)
     end
 
-    it 'moves the card to #Done list if the pull is merged' do
-      expect(trello_connection).to receive(:find_column).with('Done').and_return 'Done'
-      expect(trello_connection).to receive(:move_card_to_list).with(card,'Done').and_return Object
-      expect(github_connection).to receive(:pull_merged?).with(repo, id).and_return true
-      Reviewlette.move_to_list
+    it 'excludes the owner of the trello card' do
+      card = Trello::Card.new
+      allow(card).to receive_message_chain(:members, :map).and_return(['trellotest1'])
+      expect(Vacations).to receive(:members_on_vacation).and_return([])
+      expect(reviewlette.select_reviewer(nil, card)).to eq(MEMBERS_CONFIG['members'].last)
     end
 
-    it 'moves the card to #in-Review list if the pull is not merged' do
-      expect(trello_connection).to receive(:find_column).with('In review').and_return 'In review'
-      expect(trello_connection).to receive(:move_card_to_list).with(card,'In review').and_return Object
-      expect(github_connection).to receive(:pull_merged?).with(repo, id).and_return false
-      Reviewlette.move_to_list
-    end
   end
 
-  describe '.setup' do
-    before do
-      instance_variable! :github_connection
-      instance_variable! :trello_connection
-      instance_variable! :board
-      instance_variable! :repo
-    end
-
-    it 'sets up repo variable' do
-      Reviewlette.setup
-      expect(Reviewlette.instance_variable_get('@repo')).to be_kind_of String #ok
-    end
-    it 'sets up the github_connection' do
-      Reviewlette.setup
-      expect(github_connection).to be_kind_of Object #how to call this kind of structure
-    end
 
-    it 'sets up the trello_connection' do
-      Reviewlette.setup
-      expect(Reviewlette.instance_variable_get('@trello_connection')).to be_kind_of Object #same
-    end
-
-    it 'sets up the board' do
-      Reviewlette.setup
-      expect(Reviewlette.instance_variable_get('@board')).to be_kind_of Object #same
-    end
-  end
-
-  describe '.update_vacations' do
-
-    it 'updates vacationsstatus based on tel vacation output' do
-      vacations = ['2015-01-07', '2015-01-25']
-      instance_variable_set(:@vacations, vacations)
-      instance_variable_set(:@db, db)
-      expect(Reviewlette::Vacations).to receive(:find_vacations).at_least(:once)
-      expect(Reviewlette).to receive(:evaluate_vacations).at_least(:once)
-      Reviewlette.update_vacations
-    end
-  end
-
-  describe '.evaluate_vacations' do
-
-    it 'checks if vacation state is true' do
-      today = Date.today
-      allow(subject).to receive(:parse_vacations).and_return [[today]]
-      subject.evaluate_vacations('jschmid')
-    end
-
-    it 'checks if vacation state is false' do
-      allow(subject).to receive(:parse_vacations).and_return [1,2]
-      subject.evaluate_vacations('jschmid')
-    end
-  end
-
-
-  describe '.parse_vacations' do
-
-    it 'parses Date in proper format' do
-      # vacations = ["2014-08-23 - 2014-09-14", "2014-10-03 - 2014-10-05", "2014-12-24 - 2014-12-28"]
-      # split = [["2014-08-23", "2014-09-14"], ["2014-10-03", "2014-10-05"], ["2014-12-24", "2014-12-28"]]
-      # ret = [['Sat, 23 Aug 2014', 'Sun, 14 Sep 2014'], ['Fri, 03 Oct 2014', 'Sun, 05 Oct 2014'], ['Wed, 24 Dec 2014', 'Sun, 28 Dec 2014']]
-      # instance_variable_set(:@vacations, vacations)
-      # instance_variable_set(:@split, split)
-      # expect(instance_variable_get(:@vacations)).to receive(:map).and_return split
-      # expect(instance_variable_get(:@split)).to receive(:map).and_return ret
-      # subject.parse_vacations
-    end
-  end
 end

data/spec/spec_helper.rb

@@ -7,17 +7,10 @@ require 'simplecov'
 SimpleCov.minimum_coverage 80
 SimpleCov.formatter = SimpleCov::Formatter::HTMLFormatter
 SimpleCov.start do
-  add_filter '/spec/'
-  #add_filter 'vendor'
+  add_filter '/spec'
 end
 
 
 require 'webmock/rspec'
 require 'rspec'
-require_relative '../lib/reviewlette/exceptions'
-require_relative '../lib/reviewlette/vacations'
-require_relative '../lib/reviewlette/database'
 require 'reviewlette'
-require 'support/request_stubbing'
-
-

data/spec/trello_connection_spec.rb

@@ -1,202 +1,67 @@
 require 'spec_helper'
 
-describe Reviewlette::TrelloConnection do
+describe TrelloConnection do
 
-  subject { Reviewlette::TrelloConnection }
+  TRELLO_CONFIG = { :consumerkey => '4a6', :consumersecret => '899', :oauthtoken => 'a8e', :board_id => 'T5S' }
+  subject { TrelloConnection }
+  let (:trello) { subject.new }
+  let (:card) { Trello::Card.new }
 
-  describe '.new' do
-
-    it 'populates board variable with instance of Trello::Board' do
-      stub_boards_call
-      expect(subject.new.board).to be_kind_of Trello::Board
-    end
-
-    it 'sets up trello' do
-      allow(Trello::Board).to receive(:find).and_return nil
-      config = Reviewlette::TRELLO_CONFIG1
-      expect_any_instance_of(Trello::Configuration).to receive(:developer_public_key=).with(config['consumerkey']).and_call_original
-      subject.new
-    end
+  before {
+    allow(Trello::Board).to receive(:find).and_return(Trello::Board.new)
+  }
 
+  describe '.new' do
     it 'sets up trello' do
-      allow(Trello::Board).to receive(:find).and_return nil
-      config = Reviewlette::TRELLO_CONFIG1
-      expect_any_instance_of(Trello::Configuration).to receive(:member_token=).with(config['oauthtoken']).and_call_original
+      expect_any_instance_of(Trello::Configuration).to receive(:developer_public_key=).with(TRELLO_CONFIG['consumerkey'])
+      expect_any_instance_of(Trello::Configuration).to receive(:member_token=).with(TRELLO_CONFIG['oauthtoken'])
       subject.new
     end
-
-  end
-
-
-  describe '#find_member_by_id(id)' do
-    let( :trello_connection ) { subject.new }
-
-    before do
-      allow_any_instance_of(subject).to receive(:setup_trello).and_return true
-      allow(subject).to receive(:find_card_by_id).and_return :id
-    end
-
-    it "finds the right card based on the trello id" do
-      board = double('board')
-      trello_connection.board = board
-      expect(board).to receive_message_chain(:cards, :find)
-      trello_connection.send(:find_card_by_id, 42)
-      #privates with send
-    end
-  end
-
-  describe '#find_member_by_username' do
-    let( :trello_connection ) { subject.new }
-
-    before do
-      allow_any_instance_of(subject).to receive(:setup_trello).and_return true
-      allow(subject).to receive(:find_member_by_username).and_return :username
-    end
-
-    it "finds a member based on a username and returns a trello member object" do
-      board = double('board')
-      trello_connection.board = board
-      expect(board).to receive_message_chain(:members, :find)
-      trello_connection.send(:find_member_by_username, 'art')
-    end
-  end
-
-  describe '#find_member_by_id' do
-    let( :trello_connection ) { subject.new }
-
-    before do
-      allow_any_instance_of(subject).to receive(:setup_trello).and_return true
-      allow(subject).to receive(:find_member_by_id).and_return :id
-    end
-
-    it "finds the right member based on the trello id and returns a trello member object" do
-      board = double('board')
-      trello_connection.board = board
-      expect(board).to receive_message_chain(:members, :find)
-      trello_connection.send(:find_member_by_id, 42)
-    end
   end
 
   describe '#add_reviewer_to_card' do
-    let ( :trello_connection ) { subject.new }
-
-    before do
-      allow_any_instance_of(subject).to receive(:setup_trello).and_return true
-    end
-
     it "adds the valid member to the trello card and comments it" do
-      card = double('card')
-      allow(card).to receive(:add_member).and_return true
-      expect(trello_connection.add_reviewer_to_card('asd', card)).to eq true
+      expect(trello).to receive(:find_member_by_username).with('testuser1').and_return 'testuser1'
+      expect_any_instance_of(Trello::Card).to receive(:add_member).with('testuser1')
+      trello.add_reviewer_to_card('testuser1', card)
     end
   end
 
   describe '#comment_on_card' do
-    let ( :trello_connection ) { subject.new }
-
-    before do
-      allow_any_instance_of(subject).to receive(:setup_trello).and_return true
-    end
-
     it "comments on the assigned trello card " do
-      card = double('card')
-      allow(card).to receive(:add_comment).with('username').and_return true
-      expect(trello_connection.comment_on_card('username', card)).to eq true
-    end
-  end
-
-  describe '#team' do
-    let ( :trello_connection ) { subject.new }
-
-    before do
-      allow_any_instance_of(subject).to receive(:setup_trello).and_return true
-    end
-
-    it "builds the team member list" do
-      expect(trello_connection.team).to be_a_kind_of Array
+      allow(card).to receive(:add_comment).with('comment').and_return true
+      expect(trello.comment_on_card('comment', card)).to eq true
     end
   end
 
   describe '#move_card_to_list' do
-    let( :trello_connection ) { subject.new }
-
-    before do
-      allow_any_instance_of(subject).to receive(:setup_trello).and_return true
-    end
-
     it 'move cards to its certain column' do
-      card = double('card')
-      allow(card).to receive(:move_to_list).with('Done').and_return true
-      expect(trello_connection.move_card_to_list(card, 'Done')).to be true
-    end
-
-    it 'fails to  move cards to its certain column' do
-      card = double('card')
-      allow(card).to receive(:move_to_list).with('Done').and_return false
-      expect(trello_connection.move_card_to_list(card, 'Done')).to be false
+      expect(trello).to receive(:find_column).with('Done').and_return 'column'
+      expect(card).to receive(:move_to_list).with('column').and_return true
+      expect(trello.move_card_to_list(card, 'Done')).to be true
     end
   end
 
   describe '#find_column' do
-    let( :trello_connection ) { subject.new }
-
-    before do
-      allow_any_instance_of(subject).to receive(:setup_trello).and_return true
-    end
-
     it 'detects columns' do
-      board = double('board')
-      trello_connection.board = board
-      expect(board).to receive_message_chain(:lists, :find)
-      trello_connection.send(:find_column, 'Done')
+      expect_any_instance_of(Trello::Board).to receive_message_chain(:lists, :find)
+      trello.find_column('Done')
     end
   end
 
-  describe '#sample_reviewer' do
-    let ( :trello_connection ) { subject.new }
-
-    before do
-      allow_any_instance_of(subject).to receive(:setup_trello).and_return true
-    end
-    it 'randomly selects a teammember' do
-      card = double('card')
-      expect(card).to receive_message_chain(:assignees, :map).and_return ['funny','names']
-      trello_connection.sample_reviewer(card)
+  describe '#find_member_by_username' do
+    it "finds a member based on a username and returns a trello member object" do
+      expect_any_instance_of(Trello::Board).to receive_message_chain(:members, :find)
+      trello.find_member_by_username('testuser')
     end
   end
 
-  describe '#reviewer_exception_handler' do
-    let ( :trello_connection ) { subject.new }
-
-    before do
-      allow_any_instance_of(subject).to receive(:setup_trello).and_return true
-    end
-    it 'checks sum of for card assignees' do
-      card = double('card')
-      expect(card).to receive_message_chain(:assignees, :map).and_return [1,2,3]
-      trello_connection.reviewer_exception_handler(card)
+  describe '#find_card_by_id(id)' do
+    it "finds the right card based on the trello id" do
+      expect_any_instance_of(Trello::Board).to receive_message_chain(:cards, :find)
+      trello.find_card_by_id(123)
     end
   end
 
-  describe '#determine_reviewer' do
-    let ( :trello_connection ) { subject.new }
-
-    before do
-      allow_any_instance_of(subject).to receive(:setup_trello).and_return true
-    end
-
-    it 'fails to holds an array of the available reveiewers' do
-      card = double('card')
-      expect(trello_connection).to receive(:reviewer_exception_handler).with(card).and_return true
-      expect{trello_connection.determine_reviewer(card)}.to raise_error(Exception, 'Everyone on the team is assigned to the Card.')
-    end
 
-    it 'holds an array of the available reveiewers' do
-      card = double('card')
-      expect(trello_connection).to receive(:reviewer_exception_handler).with(card).and_return false
-      expect(trello_connection).to receive(:sample_reviewer).and_return true
-      expect(trello_connection).to receive(:find_member_by_username).and_return 'name'
-      expect(trello_connection.determine_reviewer(card)).to eq 'name'
-    end
-  end
 end