reviewlette 0.0.9 → 1.0.0

data/spec/trello_connection_spec.rb

@@ -1,70 +1,71 @@
 require 'spec_helper'
 
-describe TrelloConnection do
-  subject { TrelloConnection }
-
-  let(:trello)        { subject.new }
+describe Reviewlette::TrelloConnection do
+  subject { described_class.new }
   let(:card)          { Trello::Card.new }
   let(:trello_config) { { 'consumerkey' => consumerkey, 'oauthtoken' => oauthtoken } }
   let(:consumerkey)   { '4a6' }
   let(:oauthtoken)    { 'a8e' }
 
-
   before do
     allow(Trello::Board).to receive(:find).and_return(Trello::Board.new)
     allow(YAML).to receive(:load_file).and_return(trello_config)
   end
 
-
   describe '.new' do
     it 'sets up trello' do
       expect_any_instance_of(Trello::Configuration).to receive(:developer_public_key=).with(consumerkey)
       expect_any_instance_of(Trello::Configuration).to receive(:member_token=).with(oauthtoken)
-      subject.new
+      described_class.new
     end
   end
 
   describe '#add_reviewer_to_card' do
     it 'adds the valid member to the trello card and comments it' do
-      expect(trello).to receive(:find_member_by_username).with('testuser1').and_return 'testuser1'
+      expect(subject).to receive(:find_member_by_username).with('testuser1').and_return 'testuser1'
       expect_any_instance_of(Trello::Card).to receive(:add_member).with('testuser1')
-      trello.add_reviewer_to_card('testuser1', card)
+      subject.add_reviewer_to_card('testuser1', card)
     end
   end
 
-  describe '#comment_on_card' do
+  describe '#comment_reviewers' do
     it 'comments on the assigned trello card ' do
-      allow(card).to receive(:add_comment).with('comment').and_return true
-      expect(trello.comment_on_card('comment', card)).to eq true
+      repo_name = 'testrepo'
+      issue_id  = 1
+      reviewers = [double(trello_handle: 'test1'), double(trello_handle: 'test2')]
+      comment   = "@test1 and @test2 will review https://github.com/#{repo_name}/issues/#{issue_id}"
+
+      allow(card).to receive(:add_comment).with(comment).and_return true
+      expect(subject.comment_reviewers(card, repo_name, issue_id, reviewers)).to eq true
     end
   end
 
   describe '#move_card_to_list' do
     it 'move cards to its certain column' do
-      expect(trello).to receive(:find_column).with('Done').and_return 'column'
+      expect(subject).to receive(:find_column).with('Done').and_return 'column'
       expect(card).to receive(:move_to_list).with('column').and_return true
-      expect(trello.move_card_to_list(card, 'Done')).to be true
+      expect(subject.move_card_to_list(card, 'Done')).to be true
     end
   end
 
   describe '#find_column' do
     it 'detects columns' do
       expect_any_instance_of(Trello::Board).to receive_message_chain(:lists, :find)
-      trello.find_column('Done')
+      subject.find_column('Done')
     end
   end
 
   describe '#find_member_by_username' do
     it 'finds a member based on a username and returns a trello member object' do
       expect_any_instance_of(Trello::Board).to receive_message_chain(:members, :find)
-      trello.find_member_by_username('testuser')
+      subject.find_member_by_username('testuser')
     end
   end
 
   describe '#find_card_by_id(id)' do
     it 'finds the right card based on the trello id' do
       expect_any_instance_of(Trello::Board).to receive_message_chain(:cards, :find)
-      trello.find_card_by_id(123)
+      subject.find_card_by_id(123)
     end
   end
 end

metadata

@@ -1,79 +1,51 @@
 --- !ruby/object:Gem::Specification
 name: reviewlette
 version: !ruby/object:Gem::Version
-  version: 0.0.9
+  version: 1.0.0
 platform: ruby
 authors:
 - jschmid1
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-21 00:00:00.000000000 Z
+date: 2016-12-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ruby-trello
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.1.1
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.1.1
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: octokit
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.8.0
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.8.0
-- !ruby/object:Gem::Dependency
-  name: sequel
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 4.13.0
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 4.13.0
-- !ruby/object:Gem::Dependency
-  name: sqlite3
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 1.3.9
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 1.3.9
+        version: '0'
 description: Easy, fair and trackable labor division in your team.
 email:
 - jschmid@suse.de
-executables:
-- reviewlette
+executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".dockerignore"
 - ".gitignore"
 - ".rspec"
 - ".travis.yml"
@@ -83,20 +55,17 @@ files:
 - LICENSE
 - README.md
 - Rakefile
-- bin/reviewlette
 - config/github_example.yml
-- config/members_example.yml
 - config/trello_example.yml
 - lib/reviewlette.rb
 - lib/reviewlette/github_connection.rb
 - lib/reviewlette/trello_connection.rb
-- lib/reviewlette/vacations.rb
+- lib/reviewlette/version.rb
 - reviewlette.gemspec
 - spec/github_connection_spec.rb
 - spec/reviewlette_spec.rb
 - spec/spec_helper.rb
 - spec/trello_connection_spec.rb
-- spec/vacation_spec.rb
 homepage: http://rubygems.org/gems/reviewlette
 licenses:
 - MIT
@@ -117,7 +86,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Randomly assignes a reviewer to your Pullrequest and corresponding Trello
@@ -127,5 +96,3 @@ test_files:
 - spec/reviewlette_spec.rb
 - spec/spec_helper.rb
 - spec/trello_connection_spec.rb
-- spec/vacation_spec.rb
-has_rdoc: 

data/bin/reviewlette

@@ -1,8 +0,0 @@
-#!/usr/bin/ruby
-
-$LOAD_PATH.unshift File.join(File.dirname(__FILE__), '..', 'lib')
-require 'reviewlette'
-
-reviewlette = Reviewlette.new
-reviewlette.run
-

data/config/members_example.yml

@@ -1,25 +0,0 @@
-members:
-  - name: Tom
-    suse_username: tschmidt
-    trello_username: thomasschmidt
-    github_username: digitaltom
-  - name: Artem
-    suse_username: achernikov
-    trello_username: artemchernikov
-    github_username: kalabiyau
-  - name: Kirill
-    suse_username: kpimenov
-    trello_username: kirillpimenov
-    github_username: kirushik
-  - name: Vlad
-    suse_username: vlewin
-    trello_username: vlewin
-    github_username: vlewin
-  - name: Will
-    suse_username: wstephenson
-    trello_username: wstephenson
-    github_username: wstephenson
-  - name: Nadja
-    suse_username: nwalter
-    trello_username: nadjaw2
-    github_username: nadjaw

data/lib/reviewlette/vacations.rb

@@ -1,30 +0,0 @@
-require 'net/telnet'
-
-class Vacations
-
-  def self.find_vacations(username)
-    vacations = []
-    tn = Net::Telnet.new('Host' => 'present.suse.de', 'Port' => 9874, 'Binmode' => false)
-    tn.cmd("#{username}").split("\n").each do |line|
-      if line =~ /\S{3} #{Time.now.year}-\d\d-\d\d/
-        dates = []
-        line.split(" ").each do |date|
-          dates.push(date) if date =~ /#{Time.now.year}-\d\d-\d\d/
-        end
-        dates[1] = dates[0] unless dates[1]
-        vacations.push(Date.parse(dates[0])..Date.parse(dates[1]))
-      end
-    end
-    tn.close
-    vacations
-  end
-
-  def self.members_on_vacation(members)
-    members_on_vacation = members.collect do |member|
-      username = member['suse_username']
-      username if (username && Vacations.find_vacations(username).any? { |v| v === Date.today })
-    end
-    members_on_vacation.compact
-  end
-
-end

data/spec/vacation_spec.rb

@@ -1,36 +0,0 @@
-require 'spec_helper'
-
-describe Vacations do
-  subject { Vacations }
-
-  let(:members_config) { { members: [member1, member2, member3] } }
-  let(:member1) { { 'suse_username' => 'testuser1' } }
-  let(:member2) { { 'suse_username' => 'testuser2' } }
-  let(:member3) { { 'suse_username' => 'testuser3' } }
-  let(:timestamp) { 'Absence    : Thu 2015-04-02 - Tue 2015-04-07' }
-
-  describe '.find_vacations' do
-    it 'parses the vacations dates out of tel' do
-      stub_telnet = double
-      expect(stub_telnet).to receive(:cmd).with('testuser1').and_return(timestamp)
-      expect(stub_telnet).to receive(:close).and_return(true)
-
-      expect(Net::Telnet).to receive(:new).and_return(stub_telnet)
-      vacations = subject.find_vacations('testuser1')
-
-      expect(vacations).to be_kind_of(Array)
-      expect(vacations).to eq([Date.parse('2015-04-02')..Date.parse('2015-04-07')])
-    end
-  end
-
-  describe '.members_on_vacation' do
-    it 'finds members on vacation' do
-      allow(subject).to receive(:find_vacations).with('testuser1').and_return [(Date.today - 1)..(Date.today + 2)]
-      allow(subject).to receive(:find_vacations).with('testuser2').and_return [(Date.today - 1)..(Date.today - 1)]
-      allow(subject).to receive(:find_vacations).with('testuser3').and_return []
-
-      expect(subject.members_on_vacation(members_config[:members])).to be_kind_of(Array)
-      expect(subject.members_on_vacation(members_config[:members])).to eq(['testuser1'])
-    end
-  end
-end