reviewed_braai 0.1.6 → 0.2.0

data/lib/reviewed_braai/errors.rb

@@ -1,37 +1,47 @@
 module ReviewedBraai
+
+  module Notifications
+    def self.notify error
+      if error.opts[:airbrake] && defined?(Airbrake)
+        Airbrake.notify(error, error.opts)
+      end
+    end
+
+    def self.log error_message
+      Rails.logger.warn(error_message) if defined?(Rails) && defined?(Rails.logger)
+    end
+  end
+
   class TagRenderError < StandardError
 
-    attr_accessor :key
+    attr_accessor :key, :opts
 
     def initialize(opts={})
-      error = {
-        error_class: "ReviewedBraai::TagRenderError",
+      @opts = {
+        error_class: self.class.to_s,
         error_message: "Tag Render Error",
         key: "Key not supplied",
         airbrake: true
       }.merge!(opts)
 
-      @key = error[:key]
+      @key = @opts[:key]
 
-      if error[:airbrake] && defined?(Airbrake)
-        Airbrake.notify(error)
-      elsif defined?(Rails) && defined?(Rails.logger)
-        Rails.logger.warn(error.to_s)
-      end
+      Notifications.notify(self) || Notifications.log(@opts.to_s)
 
-      super(error[:error_message])
+      super(@opts[:error_message])
     end
 
-    class TemplateNotFound < TagRenderError
+    class MatchNotFound < TagRenderError
       def initialize(error={})
-        error = { error_message: "Template not Found" }.merge!(error)
+        error = { error_message: "Braai Match Not Found", airbrake: false }.merge!(error)
         super(error)
       end
     end
 
-    class MatchNotFound < TagRenderError
+
+    class TemplateNotFound < TagRenderError
       def initialize(error={})
-        error = { error_message: "Braai Tag Match Not Found" }.merge!(error)
+        error = { error_message: "Template not Found" }.merge!(error)
         super(error)
       end
     end

data/lib/reviewed_braai/handlers/default.rb

@@ -2,11 +2,7 @@ module ReviewedBraai
   module Handlers
     class Default < ::Braai::Handlers::Default
       def perform
-        if value = super
-          value
-        else
-          raise ::ReviewedBraai::TagRenderError::MatchNotFound.new(key: key)
-        end
+        super || raise(::ReviewedBraai::TagRenderError::MatchNotFound.new(key: key))
       end
     end
 

data/lib/reviewed_braai/matchers/default.rb

@@ -6,10 +6,13 @@ module ReviewedBraai
       Braai::Template.map(Braai::Matchers::DefaultMatcher, ReviewedBraai::Handlers::Default)
       Braai::Template.map(Braai::Matchers::RegionMatcher, ReviewedBraai::Handlers::DefaultRegion)
 
-      Braai::Handlers.rescue_from ReviewedBraai::TagRenderError, ->(handler) do
+      Braai::Handlers.rescue_from ReviewedBraai::TagRenderError, ->(handler, e) do
         # puts %{handler: #{handler.inspect}}
-        "<!-- #{handler.key} -->"
+        "<!-- #{e.class.to_s}: #{handler.key} -->"
       end
+
+      # fallback match for any {{ word stuff="123" }} that isn't already commented out.
+      Braai::Template.add_fallback(/(?!<!-- [\w: ]*)({{\s*(\w+)\s(.*?)\s*}}(?!\s*-->))/, ReviewedBraai::Handlers::Default)
     end
   end
 end

data/lib/reviewed_braai/version.rb

@@ -1,3 +1,3 @@
 module ReviewedBraai
-  VERSION = "0.1.6"
+  VERSION = "0.2.0"
 end

metadata

@@ -1,32 +1,36 @@
 --- !ruby/object:Gem::Specification
 name: reviewed_braai
 version: !ruby/object:Gem::Version
-  version: 0.1.6
+  version: 0.2.0
+  prerelease: 
 platform: ruby
 authors:
 - Kevin Incorvia
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-03-07 00:00:00.000000000 Z
+date: 2013-03-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: braai
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: 1.5.0
+        version: 1.6.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: 1.5.0
+        version: 1.6.0
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -34,6 +38,7 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -70,25 +75,26 @@ files:
 - README.rdoc
 homepage: http://www.reviewed.com
 licenses: []
-metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.0
+rubygems_version: 1.8.25
 signing_key: 
-specification_version: 4
+specification_version: 3
 summary: Braai matchers for Reviewed.com
 test_files: []

checksums.yaml

@@ -1,15 +0,0 @@
----
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    MWFiMGUyYzYwMTNlMjE0MmMxM2U3ZWRjNmFmY2ZjZTI2ZGVlNjEwMg==
-  data.tar.gz: !binary |-
-    ZTMxNGFkY2RkYjQ5MzE5YTE5YmJiN2I1Yzg2YjNiN2JjNjM1NmVjZA==
-!binary "U0hBNTEy":
-  metadata.gz: !binary |-
-    Y2I2ZTBmYmI2MWJiODhkZGJhNmI0MzlhMDMyZThjYzIxOTI3MGQ2YjhiNGJk
-    NjFlYWY0MGE1NTlhY2I4MzA0NDgyY2ZhNjE2NThjNTY5MDYzYTRlNzkxNDZm
-    OWZjZTg4MjU3N2U3MmI1OWE5NDMyNGI0NWJjM2I2NzU4NDBhMGU=
-  data.tar.gz: !binary |-
-    NDY5NDhmZjFhYzg5YzFiODU3NzljNGZmZWI5N2U2YmU4MGU3MjcxZGVhMGM4
-    YWZiNzgyMzM3OGM2ZmNjMDY3NmVlNGZlMjQ3NGFjNGNhMmFlNmNkNmM0NDFj
-    OWFmNmJmZjMzMmQxM2NlYWZkYWM3ZmVhYmJjNmFiMGEzZjYyZjQ=