reviewed 0.7.1 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b1762a7ff061a439b273236b71942175c54e1128
-  data.tar.gz: 55efb7f2e40abb882057e7ab60db6c33acf8693d
+  metadata.gz: bf38625358e68de2ee624c7c170301c74ddfb97c
+  data.tar.gz: ecca4a7cf4c99639b520b5f6a9a582a77c87dce9
 SHA512:
-  metadata.gz: 0e225a57655c95cd7d261c0ed266d7fee28bc5c473f5163fa73d998ab663b538faa8b8eec4688f7f14ba4276b6fca9fd9a1eacf62d2fd29d339a8beb4d849c5a
-  data.tar.gz: ebc9ed2155e2d18c08f365ae66710e0e04eaf8db7ee3f73cf789e2396d1247ee0b473b444746ea1536d925b993f2cebea72562c0185157e68c91e322db083a61
+  metadata.gz: 8092e4c14f8251322010b90da07ee2042f0d00560f298862682dc82073b0a60d35691ae6514c39b616bf92742222faecf4305d79f465dab0f699ee037877e9fa
+  data.tar.gz: e334ce6c786bd38fbe55104a56e28911d4ce4fdcedca011606b86f9d6cc801d63f0f172c8daedbf7d5c67d1933864b5fd0c24640fd3aab58a499e20aa810204f

data/lib/reviewed/attachable.rb

@@ -21,7 +21,7 @@ module Reviewed
     end
 
     def fetch_attachments opts={}
-      req = Request.new :resource => Attachment, :scope => self
+      req = client.attachments(scope: self)
       req.where opts
     end
   end

data/lib/reviewed/base.rb

@@ -7,10 +7,11 @@ module Reviewed
 
     extend ::ActiveModel::Naming
 
-    attr_accessor :attributes
+    attr_accessor :attributes, :client
 
-    def initialize(data)
-      self.attributes = objectify(data)
+    def initialize(data, client = Reviewed::Client.new)
+      @attributes = objectify(data)
+      @client = client
     end
 
     def created_at

data/lib/reviewed/client.rb

@@ -53,8 +53,13 @@ module Reviewed
       klass_string.constantize rescue name
     end
 
+    # args are options passed to request object, for example in:
+    # client.attachments(scope: 'article')
+    # args = [{scope: 'article'}]
     def method_missing(method, *args, &block)
-      Reviewed::Request.new(resource: resource(method), client: self)
+      opts = { client: self, resource: resource(method) }
+      opts = opts.merge!(args[0]) if args[0]
+      Reviewed::Request.new(opts)
     end
 
     def connection

data/lib/reviewed/collection.rb

@@ -19,7 +19,7 @@ module Reviewed
       @page_attributes = body.pagination || {}
 
       data.each do |obj|
-        self.items << klass.new(obj)
+        self.items << klass.new(obj, client)
       end
     end
 

data/lib/reviewed/request.rb

@@ -34,11 +34,6 @@ module Reviewed
       where({})
     end
 
-    def object_from_response(method, url, params={})
-      response = client.send(method, url, params.merge(cache_control_params))
-      resource.new(response.body)
-    end
-
     def cached?
       !uncached?
     end
@@ -57,6 +52,11 @@ module Reviewed
       self
     end
 
+    def object_from_response(method, url, params={})
+      response = client.send(method, url, params.merge(cache_control_params))
+      resource.new(response.body, client)
+    end
+
     def collection_from_response(method, url, params={})
       response = client.send(method, url, params.merge(cache_control_params))
       Reviewed::Collection.new(client, resource, response, params)

data/lib/reviewed/version.rb

@@ -1,4 +1,4 @@
 module Reviewed
-  VERSION = "0.7.1"
+  VERSION = "0.8.0"
   API_VERSION = 'v1'
 end

data/spec/attachable_spec.rb

@@ -19,4 +19,8 @@ describe Reviewed::Article, vcr: true do
     @article.should_receive(:fetch_attachments).with({tags: 'foobar'})
     @article.attachments('foobar').should eql([])
   end
+
+  it 'uses the client to fetch scoped attachments' do
+    @article.attachments.count.should eql(1)
+  end
 end

data/spec/base_spec.rb

@@ -24,6 +24,16 @@ describe Reviewed::Base do
       obj = Example.new( { foo: 'bar' } )
       obj.instance_variable_get(:@attributes).should eql( { foo: 'bar' } )
     end
+
+    it 'should have a default client if one is not passed' do
+      obj = Example.new( { foo: 'bar' })
+      obj.client.should be_an_instance_of(Reviewed::Client)
+    end
+
+    it 'should have a client if passed in' do
+      obj = Example.new( { foo: 'bar' }, "client" )
+      obj.client.should eql('client')
+    end
   end
 
   describe 'to_path' do

data/spec/client_spec.rb

@@ -58,17 +58,20 @@ describe Reviewed::Client do
 
   describe '#method_missing' do
 
-    before(:each) do
-      @request = client.articles
-    end
-
     it 'returns a Reviewed::Request instance' do
-      @request.should be_an_instance_of(Reviewed::Request)
+      request = client.articles
+      request.should be_an_instance_of(Reviewed::Request)
     end
 
     it 'sets the correct instance variables' do
-      @request.resource.should eql(Reviewed::Article)
-      @request.client.should eql(client)
+      request = client.articles
+      request.resource.should eql(Reviewed::Article)
+      request.client.should eql(client)
+    end
+
+    it 'passes arguments to the request' do
+      request = client.articles(scope: "faux_scope")
+      request.instance_variable_get(:@scope).should eql('faux_scope')
     end
   end
 

data/spec/collection_spec.rb

@@ -25,6 +25,12 @@ describe Reviewed::Collection, vcr: true do
       end
     end
 
+    it 'passes the client to each object' do
+      @collection.each do |product|
+        product.client.should eql(client)
+      end
+    end
+
     it 'fetches the first page by default' do
       @collection.current_page.should == 1
     end