reviewed 0.6.4 → 0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3cd30ef279c05f3f026964de3ac26daa0acdcada
-  data.tar.gz: bb53799075c3ab77d965b01bdfbd9d6c01153cc8
+  metadata.gz: 0c792795b7c06ab995be841258051f4a3d69c028
+  data.tar.gz: 5e48c94469b90851737451bcb09055588c85fe7c
 SHA512:
-  metadata.gz: f21d93faaa5d6b4215d05b4f58638ea123866c8e6ec2d910a57fd11561404bde791d8f39857276ca489009bf013af56d578e701e21b47f9dc878d686ed966838
-  data.tar.gz: 1042ec623a5d69487eed6ff7094c56d74938d6394f74d43f831d3894c47c96c10282feeadd9efc0e4c7bc8567801106c446e7a0634034afab5ca5f3da0b66ea0
+  metadata.gz: 4e8d6bc0c79d1f678b1d8fddc46209562de5b3e4f95d99cc508231db3edbaee9795c39e4f2ba29418c255b719cd10896d68c57130155073fb7a0f3fe01bc4652
+  data.tar.gz: dad66fac14ece996338023c83369e14e25b3545118151b49a5d4ed4de5943f9c0c87b4f0d2b7466276be577a12d6fe6de35a1af5713545497f822a234ff19415

data/lib/faraday/cache.rb

@@ -18,7 +18,7 @@ module Faraday
 
       if serve_from_cache? && store.exist?(cache_key)
         begin
-          Hashie::Mash.new(Marshal.load( store.read(cache_key) ))
+          Hashie::Mash.new(MultiJson.load( store.read(cache_key) ))
         rescue => e
           raise e.message + ": #{cache_key}"
         end
@@ -26,7 +26,7 @@ module Faraday
         @app.call(env).on_complete do |response|
           if store_response?(response)
             store.delete(cache_key)
-            store.write(cache_key, Marshal.dump(response), write_options)
+            store.write(cache_key, MultiJson.dump(response), write_options)
           end
         end
       end

data/lib/reviewed/version.rb

@@ -1,4 +1,4 @@
 module Reviewed
-  VERSION = "0.6.4"
+  VERSION = "0.7"
   API_VERSION = 'v1'
 end

data/lib/reviewed.rb

@@ -1,5 +1,6 @@
 $LOAD_PATH.unshift(File.expand_path(File.dirname(__FILE__)))
 
+require 'multi_json'
 require 'faraday'
 require 'faraday_middleware'
 require 'faraday/api_key'

data/reviewed.gemspec

@@ -22,6 +22,7 @@ Gem::Specification.new do |gem|
   gem.add_dependency 'hashie', '~> 1.2'
   gem.add_dependency 'rack'
   gem.add_dependency 'redis-activesupport'
+  gem.add_dependency 'multi_json'
 
   gem.add_development_dependency 'rake'
   gem.add_development_dependency 'rspec', '>= 2.10'

data/spec/faraday/cache_spec.rb

@@ -17,15 +17,15 @@ describe Faraday::Cache do
     conn.headers = { "X-Reviewed-Website" => 'f0000123' }
 
     it "caches anything that doesn't have skip-cache or reset-cache" do
-      mock_cache_val = mock
-      Marshal.stub(:dump).with(hash_including(:body => 'I like turtles')).and_return(mock_cache_val)
+      mock_cache_val = double
+      MultiJson.stub(:dump).with(hash_including(:body => 'I like turtles')).and_return(mock_cache_val)
       Reviewed::Cache.store.should_receive(:write).with("f0000123:/articles", mock_cache_val, anything)
       conn.get('/articles')
     end
 
     it "can cache more than one thing" do
-      mock_cache_val = mock
-      Marshal.stub(:dump => mock_cache_val)
+      mock_cache_val = double
+      MultiJson.stub(:dump => mock_cache_val)
       Reviewed::Cache.store.should_receive(:write).with("f0000123:/articles", mock_cache_val, anything)
       Reviewed::Cache.store.should_receive(:write).with("f0000123:/products", mock_cache_val, anything)
 
@@ -34,7 +34,7 @@ describe Faraday::Cache do
     end
 
     it "serves responses from the cache when fresh and does not call the app" do
-      marshalled_response = Marshal.dump(body: 'old musty response')
+      marshalled_response = MultiJson.dump(body: 'old musty response')
       Reviewed::Cache.store.stub(:exist? => true)
       Reviewed::Cache.store.should_receive(:read).with("f0000123:/articles").and_return(marshalled_response)
       resp = conn.get '/articles'
@@ -54,6 +54,8 @@ describe Faraday::Cache do
       end
 
       it "replaces cached content with app response when reset-cache is a query param" do
+        mock_cache_val = double
+        MultiJson.stub(:dump).and_return(mock_cache_val)
         Reviewed::Cache.store.should_not_receive(:read)
         Reviewed::Cache.store.should_receive(:write)
         conn.get '/articles', {:"reset-cache" => true}

data/spec/faraday/errors_spec.rb

@@ -37,7 +37,7 @@ describe Faraday::Errors do
 
       it 'raises an ApiError error' do
         client = Reviewed::Client.new
-        client.stub!(:connection).and_return(test2)
+        client.stub(:connection).and_return(test2)
         expect {
           client.send(:perform, :get, '/products/123')
         }.to raise_error(Reviewed::ApiError)
@@ -45,7 +45,7 @@ describe Faraday::Errors do
 
       it 'passes other Reviewed errors through' do
         client = Reviewed::Client.new
-        client.stub!(:connection).and_raise(Reviewed::ConfigurationError.new)
+        client.stub(:connection).and_raise(Reviewed::ConfigurationError.new)
         expect {
             client.send(:perform, :get, '/products/123')
           }.to raise_error(Reviewed::ConfigurationError)

data/spec/request_spec.rb

@@ -32,7 +32,7 @@ describe Reviewed::Request do
       end
 
       it 'with resource as an object, calls :to_path on it' do
-        article_class = mock
+        article_class = double
         article_class.should_receive(:to_path).and_return('article')
         request = Reviewed::Request.new(resource: article_class)
         request.path.should eql('article')
@@ -41,8 +41,8 @@ describe Reviewed::Request do
 
     context 'scoped resource' do
       it 'calls to path with the given scope param' do
-        article_class = mock
-        scope = mock
+        article_class = double
+        scope = double
         article_class.should_receive(:to_path).with(scope)
         request = Reviewed::Request.new(resource: article_class, scope: scope)
         request.path

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: reviewed
 version: !ruby/object:Gem::Version
-  version: 0.6.4
+  version: '0.7'
 platform: ruby
 authors:
 - Nick Plante
@@ -109,6 +109,20 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: multi_json
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement