reviewed 0.6.2 → 0.6.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 571f18f181a7c3d85e77d20ee542088bcb4368bf
-  data.tar.gz: 019fc1a4e87ba8d0d39ccec6386faaf33f89b0b0
+  metadata.gz: fa11a3952897f5b9ce559f830e1bfecc7e36f50d
+  data.tar.gz: 3eb8766f1d332ea87cf3d51432e1e990a96f0d39
 SHA512:
-  metadata.gz: 3f4c6b6b515a849e3b33abc084d1ea9bf1aaef6c93f570b72eba38e677ced21ce67f25ff9d0817991d43984b3c1d8d620245149241a73a61a65725895996535e
-  data.tar.gz: 068bea025cada9fcee782507522105b5e36352d9915989517448e217e4d8d6ce6d8fe7648bf42192de8e22c35b887e5546c5c5dc66d6e3d56e68c869e5defd2c
+  metadata.gz: fa76c100e1ff5f150e03cc8a966828e7f5c13a3b675fed43aa2c71d65ef27d9baaea162c743c93b6a8186e02d889f23f7f838e193f643ecacd83bacdf9cc015b
+  data.tar.gz: 73ebf5077ebc656a42df42aaea07206473ce9560662514edd99dfcac291374c7e1aa9e96aa907fe7fca3b3f923b8fc0ac369a59f1368884c1f3780ab441ade9e

data/lib/faraday/cache.rb

@@ -16,11 +16,11 @@ module Faraday
 
       @website_id = env[:request_headers]['x-reviewed-website']
 
-      if serve_from_cache && store.exist?(cache_key)
+      if serve_from_cache? && store.exist?(cache_key)
         Hashie::Mash.new(Marshal.load( store.read(cache_key) ))
       else
         @app.call(env).on_complete do |response|
-          if store_response
+          if store_response?(response)
             store.delete(cache_key)
             store.write(cache_key, Marshal.dump(response), write_options)
           end
@@ -30,11 +30,12 @@ module Faraday
 
     private
 
-    def serve_from_cache
+    def serve_from_cache?
       @url.query.blank? || !@url.query.match(/\b(skip|reset)-cache\b/)
     end
 
-    def store_response
+    def store_response?(resp)
+      return false if resp[:status] != 200
       @url.query.blank? || !@url.query.match(/\bskip-cache\b/)
     end
 

data/lib/reviewed/version.rb

@@ -1,4 +1,4 @@
 module Reviewed
-  VERSION = "0.6.2"
+  VERSION = "0.6.3"
   API_VERSION = 'v1'
 end

data/spec/faraday/cache_spec.rb

@@ -10,6 +10,7 @@ describe Faraday::Cache do
       builder.adapter :test, Faraday::Adapter::Test::Stubs.new do |stub|
         stub.get('/articles') { [200, {}, 'I like turtles'] }
         stub.get('/products') { [200, {}, 'Weee products'] }
+        stub.get('/kaboom') { [500, {}, 'Kaboom'] }
       end
     end
 
@@ -40,6 +41,11 @@ describe Faraday::Cache do
       resp[:body].should eq("old musty response")
     end
 
+    it "does not store response when result is 500" do
+      Reviewed::Cache.store.should_not_receive(:write)
+      conn.get('/kaboom')
+    end
+
     describe "cache busting and skipping" do
       it "does not cache responses with skip-cache as a query param" do
         Reviewed::Cache.store.should_not_receive(:read)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: reviewed
 version: !ruby/object:Gem::Version
-  version: 0.6.2
+  version: 0.6.3
 platform: ruby
 authors:
 - Nick Plante
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-01 00:00:00.000000000 Z
+date: 2013-08-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -312,7 +312,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.0.6
 signing_key: 
 specification_version: 4
 summary: A Ruby Gem for Accessing the Reviewed.com API