reviewed 0.1.4 → 0.1.21

data/spec/product_spec.rb

@@ -8,7 +8,8 @@ describe Reviewed::Product do
 
   describe 'associations' do
 
-    describe 'attachments', vcr: true do
+    describe 'attachments' do
+      use_vcr_cassette 'product/attachments'
 
       before(:each) do
         @product = client.products.find('minden-master-ii')
@@ -43,7 +44,8 @@ describe Reviewed::Product do
     end
   end
 
-  describe 'manufacturer_specs', vcr: true do
+  describe 'manufacturer_specs' do
+    use_vcr_cassette 'product/manufacturer_specs'
 
     before(:each) do
       @product = client.products.find('minden-master-ii')

data/spec/request_spec.rb

@@ -37,20 +37,48 @@ describe Reviewed::Request do
     end
   end
 
+  describe '#get' do
+
+    it 'delegates to perform' do
+      request.should_receive(:perform).with(:get, "path", kind_of(Hash))
+      request.get("path", {})
+    end
+  end
+
+  describe '#put' do
+
+    it 'delegates to request' do
+      request.should_receive(:perform).with(:put, "path", kind_of(Hash))
+      request.put("path", {})
+    end
+  end
+
+  describe '#post' do
+
+    it 'delegates to request' do
+      request.should_receive(:perform).with(:post, "path", kind_of(Hash))
+      request.post("path", {})
+    end
+  end
+
+  describe '#delete' do
+
+    it 'delegates to request' do
+      request.should_receive(:perform).with(:delete, "path", kind_of(Hash))
+      request.delete("path", {})
+    end
+  end
+
   describe '#find' do
 
     it 'delegates to object_from_response' do
       request.should_receive(:object_from_response).with(:get, "articles/123", {})
       request.find(123)
     end
-
-    it 'cgi escapes id params' do
-      request.should_receive(:object_from_response).with(:get, "articles/Smith+%26+Wesson+v%2Fs+Colt%3A+Which+Makes+you+Manlier%3F", {})
-      request.find('Smith & Wesson v/s Colt: Which Makes you Manlier?')
-    end
   end
 
-  describe '#where', vcr: true do
+  describe '#where' do
+    use_vcr_cassette 'request/where/collection'
 
     it 'delegates to object_from_response' do
       request.should_receive(:collection_from_response).with(:get, "articles", {})
@@ -90,9 +118,10 @@ describe Reviewed::Request do
     end
   end
 
-  describe 'object_from_response', vcr: true do
+  describe 'object_from_response' do
+    use_vcr_cassette "request/object"
 
-    let(:article_id) { 'big-green-egg-medium-charcoal-grill-review' }
+    let(:article_id) { '509d166d60de7db97c05ce71' }
 
     it 'returns an object of the correct class' do
       response = request.object_from_response(:get, "articles/#{article_id}")
@@ -100,7 +129,8 @@ describe Reviewed::Request do
     end
   end
 
-  describe 'collection_from_response', vcr: true do
+  describe 'collection_from_response' do
+    use_vcr_cassette "request/collection"
 
     it 'returns a collection object' do
       collection = request.collection_from_response(:get, "articles")
@@ -114,4 +144,29 @@ describe Reviewed::Request do
       end
     end
   end
+
+  describe '#perform' do
+
+    describe 'request_params' do
+
+      context 'set' do
+        use_vcr_cassette 'request/perform/params'
+
+        it 'merges quest params' do
+          request.client.request_params = { per_page: 1 }
+          collection = request.collection_from_response(:get, "articles")
+          collection.count.should eql(1)
+        end
+      end
+
+      context 'not set' do
+        use_vcr_cassette 'request/perform/no_params'
+
+        it 'has nil query params' do
+          collection = request.collection_from_response(:get, "articles")
+          collection.count.should eql(20)
+        end
+      end
+    end
+  end
 end

data/spec/reviewed_spec.rb

@@ -1,13 +1,4 @@
 require 'spec_helper.rb'
 
 describe Reviewed do
-
-  describe 'errors' do
-
-    it 'should respond to url' do
-      error = Reviewed::ResourceNotFound.new(url: 'url', msg: "msg")
-      error.url.should eql('url')
-      error.message.should eql('msg')
-    end
-  end
 end

data/spec/spec_helper.rb

@@ -1,8 +1,8 @@
 $LOAD_PATH.unshift(File.dirname(__FILE__))
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
 
-require 'vcr'
 require 'reviewed'
+require 'vcr'
 
 Dir['spec/support/*'].each { |f| require f }
 
@@ -11,16 +11,15 @@ RSpec.configure do |config|
   config.alias_example_to :fit, :focused => true
   config.alias_example_to :pit, :pending => true
   config.run_all_when_everything_filtered = true
+
+  config.extend VCR::RSpec::Macros
 end
 
 VCR.configure do |config|
   config.default_cassette_options = { record: :new_episodes }
   config.cassette_library_dir = 'spec/fixtures/vcr'
   config.hook_into :webmock
-  config.configure_rspec_metadata!
 end
 
-
-TEST_URL = 'https://the-guide-staging.herokuapp.com/api/v1'
-TEST_KEY = ENV['REVIEWED_API_KEY']
-
+TEST_URL = 'https://localhost:3000/api/v1'
+TEST_KEY = '1234567890'

data/spec/website_spec.rb

@@ -2,7 +2,8 @@ require 'spec_helper'
 
 describe Reviewed::Website do
 
-  describe 'all', vcr: true do
+  describe 'all' do
+    use_vcr_cassette 'website/where_collection'
 
     it 'calls "where" with correct arguements' do
       Reviewed::Website.should_receive(:where).with({per_page: 'all'})

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: reviewed
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.21
   prerelease: 
 platform: ruby
 authors:
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-03-22 00:00:00.000000000 Z
+date: 2012-12-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -108,22 +108,6 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -219,12 +203,10 @@ files:
 - README.md
 - Rakefile
 - lib/faraday/api_key.rb
-- lib/faraday/errors.rb
 - lib/reviewed.rb
 - lib/reviewed/article.rb
 - lib/reviewed/attachment.rb
 - lib/reviewed/author.rb
-- lib/reviewed/award.rb
 - lib/reviewed/base.rb
 - lib/reviewed/brand.rb
 - lib/reviewed/client.rb
@@ -239,54 +221,23 @@ files:
 - reviewed.gemspec
 - spec/article_spec.rb
 - spec/author_spec.rb
-- spec/award_spec.rb
 - spec/base_spec.rb
 - spec/brand_spec.rb
 - spec/client_spec.rb
 - spec/collection_spec.rb
 - spec/embeddable_spec.rb
 - spec/faraday/api_key_spec.rb
-- spec/faraday/errors_spec.rb
-- spec/fixtures/vcr/Reviewed_Article/associations/attachments/does_not_have_any_matching_attachments.yml
-- spec/fixtures/vcr/Reviewed_Article/associations/attachments/finds_attachments_by_tag.yml
-- spec/fixtures/vcr/Reviewed_Article/associations/attachments/has_many_attachments.yml
-- spec/fixtures/vcr/Reviewed_Article/associations/attachments/returns_all_attachments.yml
-- spec/fixtures/vcr/Reviewed_Article/associations/attachments/returns_attachments_of_the_correct_class.yml
-- spec/fixtures/vcr/Reviewed_Article/associations/pages/has_many_pages.yml
-- spec/fixtures/vcr/Reviewed_Article/associations/products/has_many_products.yml
-- spec/fixtures/vcr/Reviewed_Article/associations/products/returns_products_of_the_correct_class.yml
-- spec/fixtures/vcr/Reviewed_Article/find_page/finds_a_page_with_a_matching_slug.yml
-- spec/fixtures/vcr/Reviewed_Article/primary_product/returns_a_product_of_the_correct_class.yml
-- spec/fixtures/vcr/Reviewed_Article/primary_product/returns_nil_if_does_not_respond_to_products.yml
-- spec/fixtures/vcr/Reviewed_Article/primary_product/returns_the_primary_product.yml
-- spec/fixtures/vcr/Reviewed_Client/_perform/request_params/not_set/has_nil_query_params.yml
-- spec/fixtures/vcr/Reviewed_Client/_perform/request_params/set/merges_quest_params.yml
-- spec/fixtures/vcr/Reviewed_Collection/collection_data/fetches_the_first_page_by_default.yml
-- spec/fixtures/vcr/Reviewed_Collection/collection_data/is_enumerable.yml
-- spec/fixtures/vcr/Reviewed_Collection/next_page/fetches_the_next_page_of_results.yml
-- spec/fixtures/vcr/Reviewed_Collection/page_attributes_pagination_/indicates_if_the_page_number_is_out_of_bounds.yml
-- spec/fixtures/vcr/Reviewed_Collection/page_attributes_pagination_/indicates_whether_this_is_the_first_or_last_page.yml
-- spec/fixtures/vcr/Reviewed_Collection/page_attributes_pagination_/returns_the_limit_value_max_per_page_.yml
-- spec/fixtures/vcr/Reviewed_Collection/page_attributes_pagination_/returns_the_number_of_entries_on_the_current_page.yml
-- spec/fixtures/vcr/Reviewed_Collection/page_attributes_pagination_/returns_the_offset.yml
-- spec/fixtures/vcr/Reviewed_Collection/page_attributes_pagination_/returns_the_total_item_count.yml
-- spec/fixtures/vcr/Reviewed_Collection/page_attributes_pagination_/returns_the_total_number_of_pages.yml
-- spec/fixtures/vcr/Reviewed_Collection/previous_page/fetches_the_previous_page_of_results.yml
-- spec/fixtures/vcr/Reviewed_Collection/previous_page/returns_nil_if_there_is_no_previous_page.yml
-- spec/fixtures/vcr/Reviewed_Product/associations/attachments/does_not_have_any_matching_attachments.yml
-- spec/fixtures/vcr/Reviewed_Product/associations/attachments/finds_attachments_by_tag.yml
-- spec/fixtures/vcr/Reviewed_Product/associations/attachments/has_many_attachments.yml
-- spec/fixtures/vcr/Reviewed_Product/associations/attachments/returns_all_attachments.yml
-- spec/fixtures/vcr/Reviewed_Product/associations/attachments/returns_attachments_of_the_correct_class.yml
-- spec/fixtures/vcr/Reviewed_Product/manufacturer_specs/has_many_manufacturer_specs.yml
-- spec/fixtures/vcr/Reviewed_Product/manufacturer_specs/returns_attachments_of_the_correct_class.yml
-- spec/fixtures/vcr/Reviewed_Request/_where/filters_collections_using_other_supported_options.yml
-- spec/fixtures/vcr/Reviewed_Request/_where/returns_a_collection.yml
-- spec/fixtures/vcr/Reviewed_Request/_where/returns_an_empty_set_if_no_matching_data_was_found.yml
-- spec/fixtures/vcr/Reviewed_Request/_where/returns_the_appropriate_page_of_results.yml
-- spec/fixtures/vcr/Reviewed_Request/collection_from_response/returns_a_collection_object.yml
-- spec/fixtures/vcr/Reviewed_Request/collection_from_response/returns_objects_of_the_correct_class.yml
-- spec/fixtures/vcr/Reviewed_Request/object_from_response/returns_an_object_of_the_correct_class.yml
+- spec/fixtures/vcr/article/find_page.yml
+- spec/fixtures/vcr/article/grill.yml
+- spec/fixtures/vcr/article/products.yml
+- spec/fixtures/vcr/collection/products.yml
+- spec/fixtures/vcr/product/attachments.yml
+- spec/fixtures/vcr/product/manufacturer_specs.yml
+- spec/fixtures/vcr/request/collection.yml
+- spec/fixtures/vcr/request/object.yml
+- spec/fixtures/vcr/request/perform/no_params.yml
+- spec/fixtures/vcr/request/perform/params.yml
+- spec/fixtures/vcr/request/where/collection.yml
 - spec/product_spec.rb
 - spec/request_spec.rb
 - spec/reviewed_spec.rb
@@ -313,61 +264,30 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.25
+rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
 summary: A Ruby Gem for Accessing the Reviewed.com API
 test_files:
 - spec/article_spec.rb
 - spec/author_spec.rb
-- spec/award_spec.rb
 - spec/base_spec.rb
 - spec/brand_spec.rb
 - spec/client_spec.rb
 - spec/collection_spec.rb
 - spec/embeddable_spec.rb
 - spec/faraday/api_key_spec.rb
-- spec/faraday/errors_spec.rb
-- spec/fixtures/vcr/Reviewed_Article/associations/attachments/does_not_have_any_matching_attachments.yml
-- spec/fixtures/vcr/Reviewed_Article/associations/attachments/finds_attachments_by_tag.yml
-- spec/fixtures/vcr/Reviewed_Article/associations/attachments/has_many_attachments.yml
-- spec/fixtures/vcr/Reviewed_Article/associations/attachments/returns_all_attachments.yml
-- spec/fixtures/vcr/Reviewed_Article/associations/attachments/returns_attachments_of_the_correct_class.yml
-- spec/fixtures/vcr/Reviewed_Article/associations/pages/has_many_pages.yml
-- spec/fixtures/vcr/Reviewed_Article/associations/products/has_many_products.yml
-- spec/fixtures/vcr/Reviewed_Article/associations/products/returns_products_of_the_correct_class.yml
-- spec/fixtures/vcr/Reviewed_Article/find_page/finds_a_page_with_a_matching_slug.yml
-- spec/fixtures/vcr/Reviewed_Article/primary_product/returns_a_product_of_the_correct_class.yml
-- spec/fixtures/vcr/Reviewed_Article/primary_product/returns_nil_if_does_not_respond_to_products.yml
-- spec/fixtures/vcr/Reviewed_Article/primary_product/returns_the_primary_product.yml
-- spec/fixtures/vcr/Reviewed_Client/_perform/request_params/not_set/has_nil_query_params.yml
-- spec/fixtures/vcr/Reviewed_Client/_perform/request_params/set/merges_quest_params.yml
-- spec/fixtures/vcr/Reviewed_Collection/collection_data/fetches_the_first_page_by_default.yml
-- spec/fixtures/vcr/Reviewed_Collection/collection_data/is_enumerable.yml
-- spec/fixtures/vcr/Reviewed_Collection/next_page/fetches_the_next_page_of_results.yml
-- spec/fixtures/vcr/Reviewed_Collection/page_attributes_pagination_/indicates_if_the_page_number_is_out_of_bounds.yml
-- spec/fixtures/vcr/Reviewed_Collection/page_attributes_pagination_/indicates_whether_this_is_the_first_or_last_page.yml
-- spec/fixtures/vcr/Reviewed_Collection/page_attributes_pagination_/returns_the_limit_value_max_per_page_.yml
-- spec/fixtures/vcr/Reviewed_Collection/page_attributes_pagination_/returns_the_number_of_entries_on_the_current_page.yml
-- spec/fixtures/vcr/Reviewed_Collection/page_attributes_pagination_/returns_the_offset.yml
-- spec/fixtures/vcr/Reviewed_Collection/page_attributes_pagination_/returns_the_total_item_count.yml
-- spec/fixtures/vcr/Reviewed_Collection/page_attributes_pagination_/returns_the_total_number_of_pages.yml
-- spec/fixtures/vcr/Reviewed_Collection/previous_page/fetches_the_previous_page_of_results.yml
-- spec/fixtures/vcr/Reviewed_Collection/previous_page/returns_nil_if_there_is_no_previous_page.yml
-- spec/fixtures/vcr/Reviewed_Product/associations/attachments/does_not_have_any_matching_attachments.yml
-- spec/fixtures/vcr/Reviewed_Product/associations/attachments/finds_attachments_by_tag.yml
-- spec/fixtures/vcr/Reviewed_Product/associations/attachments/has_many_attachments.yml
-- spec/fixtures/vcr/Reviewed_Product/associations/attachments/returns_all_attachments.yml
-- spec/fixtures/vcr/Reviewed_Product/associations/attachments/returns_attachments_of_the_correct_class.yml
-- spec/fixtures/vcr/Reviewed_Product/manufacturer_specs/has_many_manufacturer_specs.yml
-- spec/fixtures/vcr/Reviewed_Product/manufacturer_specs/returns_attachments_of_the_correct_class.yml
-- spec/fixtures/vcr/Reviewed_Request/_where/filters_collections_using_other_supported_options.yml
-- spec/fixtures/vcr/Reviewed_Request/_where/returns_a_collection.yml
-- spec/fixtures/vcr/Reviewed_Request/_where/returns_an_empty_set_if_no_matching_data_was_found.yml
-- spec/fixtures/vcr/Reviewed_Request/_where/returns_the_appropriate_page_of_results.yml
-- spec/fixtures/vcr/Reviewed_Request/collection_from_response/returns_a_collection_object.yml
-- spec/fixtures/vcr/Reviewed_Request/collection_from_response/returns_objects_of_the_correct_class.yml
-- spec/fixtures/vcr/Reviewed_Request/object_from_response/returns_an_object_of_the_correct_class.yml
+- spec/fixtures/vcr/article/find_page.yml
+- spec/fixtures/vcr/article/grill.yml
+- spec/fixtures/vcr/article/products.yml
+- spec/fixtures/vcr/collection/products.yml
+- spec/fixtures/vcr/product/attachments.yml
+- spec/fixtures/vcr/product/manufacturer_specs.yml
+- spec/fixtures/vcr/request/collection.yml
+- spec/fixtures/vcr/request/object.yml
+- spec/fixtures/vcr/request/perform/no_params.yml
+- spec/fixtures/vcr/request/perform/params.yml
+- spec/fixtures/vcr/request/where/collection.yml
 - spec/product_spec.rb
 - spec/request_spec.rb
 - spec/reviewed_spec.rb

data/lib/faraday/errors.rb

@@ -1,14 +0,0 @@
-module Faraday
-  class Errors < Faraday::Middleware
-
-    def call(env)
-      @app.call(env).on_complete do
-        if env[:response].status == 404
-          raise Reviewed::ResourceNotFound.new(msg: 'Not Found', url: env[:url])
-        end
-      end
-    end
-  end
-end
-
-Faraday.register_middleware :response, errors: Faraday::Errors

data/lib/reviewed/award.rb

@@ -1,4 +0,0 @@
-module Reviewed
-  class Award < Base
-  end
-end

data/spec/award_spec.rb

@@ -1,4 +0,0 @@
-require 'spec_helper'
-
-describe Reviewed::Award do
-end

data/spec/faraday/errors_spec.rb

@@ -1,73 +0,0 @@
-require 'spec_helper.rb'
-
-describe Faraday::Errors do
-
-  describe 'error' do
-    stubs = Faraday::Adapter::Test::Stubs.new do |stub|
-      stub.get('/products/123') {[ 404, {}, { message: 'Record Not Found' } ]}
-    end
-
-    stubs2 = Faraday::Adapter::Test::Stubs.new do |stub|
-      stub.get('/products/123') {[ 500, {}, '<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> <html> <head> <meta http-equiv="content-type" content="text/html; charset=ISO-8859-1"> <style type="text/css"> html, body, iframe { margin: 0; padding: 0; height: 100%; } iframe { display: block; width: 100%; border: none; } </style> <title>Application Error</title></head> </head> <body> <iframe src="//s3.amazonaws.com/heroku_pages/error.html"> <p>Application Error</p> </iframe> </body> </html>' ]}
-    end
-
-    test = Faraday.new do |builder|
-      builder.response :errors
-      builder.response :json
-      builder.adapter :test, stubs
-    end
-
-    test2 = Faraday.new do |builder|
-      builder.response :errors
-      builder.response :json
-      builder.adapter :test, stubs2
-    end
-
-    it 'should raise a ResourceNotFound error' do
-      expect {
-        test.get('/products/123')
-      }.to raise_error(Reviewed::ResourceNotFound) { |e|
-        e.url.should be_an_instance_of(URI::HTTP)
-        e.url.to_s.should eql('http:/products/123')
-        e.message.should eql('Not Found')
-      }
-    end
-
-    context 'faraday catch-all' do
-
-      it 'raises an ApiError error' do
-        client = Reviewed::Client.new
-        client.stub!(:connection).and_return(test2)
-        expect {
-          client.send(:perform, :get, '/products/123')
-        }.to raise_error(Reviewed::ApiError)
-      end
-
-      it 'passes other Reviewed errors through' do
-        client = Reviewed::Client.new
-        client.stub!(:connection).and_raise(Reviewed::ConfigurationError.new)
-        expect {
-            client.send(:perform, :get, '/products/123')
-          }.to raise_error(Reviewed::ConfigurationError)
-      end
-    end
-  end
-
-  describe 'no error' do
-    stubs = Faraday::Adapter::Test::Stubs.new do |stub|
-      stub.get('/products/123') {[ 200, {}, { message: 'Record Not Found' } ]}
-    end
-
-    test = Faraday.new do |builder|
-      builder.response :errors
-      builder.response :json
-      builder.adapter :test, stubs
-    end
-
-    it 'should not raise an error' do
-      expect {
-        test.get('/products/123')
-      }.to_not raise_error
-    end
-  end
-end