reviewed 0.1.2 → 0.1.4

data/spec/client_spec.rb

@@ -2,11 +2,13 @@ require 'spec_helper.rb'
 
 describe Reviewed::Client do
 
-  let(:client) { Reviewed::Client.new }
+  let(:client) do
+    Reviewed::Client.new(api_key: TEST_KEY, base_uri: TEST_URL)
+  end
 
-  describe 'variables' do
+  describe 'accessors' do
 
-    [:api_key, :base_uri, :api_version].each do |var|
+    [:api_key, :base_uri, :request_params].each do |var|
       describe "#{var}" do
 
         it 'exists' do
@@ -16,54 +18,86 @@ describe Reviewed::Client do
     end
   end
 
-  describe '#delete' do
+  describe '#configure' do
 
-    it 'delegates to request' do
-      client.should_receive(:request).with(:delete, "path", kind_of(Hash))
-      client.delete("path", {})
+    it 'returns self' do
+      client.configure{}.should be_an_instance_of(Reviewed::Client)
+    end
+
+    it 'yields self' do
+      client.configure do |config|
+        config.api_key = 'test_key'
+      end
+      client.api_key.should eql('test_key')
     end
   end
 
-  describe '#get' do
+  describe '#resource' do
 
-    it 'delegates to request' do
-      client.should_receive(:request).with(:get, "path", kind_of(Hash))
-      client.get("path", {})
+    context 'constant exists' do
+
+      it 'returns the appropriate constant' do
+        client.resource("articles").should eql(Reviewed::Article)
+      end
+    end
+
+    context 'constant does not exist' do
+
+      it 'returns the string' do
+        client.resource("foobar").should eql("foobar")
+      end
     end
   end
 
-  describe '#post' do
+  describe '#method_missing' do
 
-    it 'delegates to request' do
-      client.should_receive(:request).with(:post, "path", kind_of(Hash))
-      client.post("path", {})
+    before(:each) do
+      @request = client.articles
+    end
+
+    it 'returns a Reviewed::Request instance' do
+      @request.should be_an_instance_of(Reviewed::Request)
+    end
+
+    it 'sets the correct instance variables' do
+      @request.resource.should eql(Reviewed::Article)
+      @request.client.should eql(client)
+    end
+  end
+
+  describe '#get' do
+
+    it 'delegates to perform' do
+      client.should_receive(:perform).with(:get, "path", kind_of(Hash))
+      client.get("path", {})
     end
   end
 
   describe '#put' do
 
-    it 'delegates to request' do
-      client.should_receive(:request).with(:put, "path", kind_of(Hash))
+    it 'delegates to client' do
+      client.should_receive(:perform).with(:put, "path", kind_of(Hash))
       client.put("path", {})
     end
   end
 
-  describe '#url' do
+  describe '#post' do
 
-    it 'returns a url' do
-      client.url.should eql('http://localhost:3000/api/v1')
+    it 'delegates to client' do
+      client.should_receive(:perform).with(:post, "path", kind_of(Hash))
+      client.post("path", {})
     end
   end
 
-  describe '#request' do
+  describe '#delete' do
 
-    it 'verifies the key' do
-      client.stub_chain(:connection, :send).and_return(nil)
-      client.should_receive(:verify_key!)
-      client.send(:request, :get, 'test')
+    it 'delegates to request' do
+      client.should_receive(:perform).with(:delete, "path", kind_of(Hash))
+      client.delete("path", {})
     end
   end
 
+
   describe '#connnection' do
 
     let(:conn) { client.send(:connection) }
@@ -76,7 +110,7 @@ describe Reviewed::Client do
       conn.builder.handlers.should include(Faraday::Request::UrlEncoded)
     end
 
-    it 'uses a Json middleware' do
+    it 'uses a JSON middleware' do
       conn.builder.handlers.should include(FaradayMiddleware::ParseJson)
     end
 
@@ -89,7 +123,43 @@ describe Reviewed::Client do
     end
 
     it 'sets the url' do
-      conn.url_prefix.to_s.should eql('http://localhost:3000/api/v1')
+      conn.url_prefix.to_s.should match('https://')
+    end
+  end
+
+  describe '#perform' do
+
+    describe 'request_params', vcr: true do
+
+      context 'set' do
+
+        it 'merges quest params' do
+          client.request_params = { per_page: 1 }
+          collection = client.articles.where({})
+          collection.count.should eql(1)
+        end
+      end
+
+      context 'not set' do
+
+        it 'has nil query params' do
+          collection = client.articles.where({})
+          collection.count.should eql(20)
+        end
+      end
+
+
     end
   end
+
+  context 'with error' do
+
+    context 'bad response' do
+      it 'should raise a Reviewed::ApiError' do
+        client.connection.stub(:send).and_raise Faraday::Error::ClientError.new(true)
+        lambda { client.get('something that times out') }.should raise_error(Reviewed::ApiError)
+      end
+    end
+
+  end
 end

data/spec/collection_spec.rb

@@ -5,12 +5,14 @@ module Reviewed
   end
 end
 
-describe Reviewed::Collection do
-  use_vcr_cassette 'collection/products'
+describe Reviewed::Collection, vcr: true do
+
+  let(:client) do
+    Reviewed::Client.new(api_key: TEST_KEY, base_uri: TEST_URL)
+  end
 
   before(:each) do
-    Reviewed.api_key = TEST_KEY
-    @collection = Reviewed::Product.all # creates a collection
+    @collection = client.products.all # creates a collection
   end
 
   describe 'collection data' do

data/spec/faraday/api_key_spec.rb

@@ -0,0 +1,42 @@
+require 'spec_helper.rb'
+
+describe Faraday::ApiKey do
+
+  describe 'error' do
+
+    stubs = Faraday::Adapter::Test::Stubs.new do |stub|
+      stub.get('/products/123') {[ 200, {foo: 'hi'}, '']}
+    end
+
+    test = Faraday.new do |builder|
+      builder.request :api_key
+      builder.adapter :test, stubs
+    end
+
+    it 'should raise a configuration error' do
+      expect {
+        test.get('/products/123')
+      }.to raise_error(Reviewed::ConfigurationError)
+    end
+  end
+
+  describe 'no error' do
+
+    stubs = Faraday::Adapter::Test::Stubs.new do |stub|
+      stub.get('/products/123') {[ 200, {foo: 'hi'}, '']}
+    end
+
+    test = Faraday.new do |builder|
+      builder.request :api_key
+      builder.adapter :test, stubs
+    end
+
+    test.headers = { "X-Reviewed-Authorization" => '123' }
+
+    it 'should not raise an error' do
+      expect {
+        test.get('/products/123')
+      }.to_not raise_error
+    end
+  end
+end

data/spec/faraday/errors_spec.rb

@@ -0,0 +1,73 @@
+require 'spec_helper.rb'
+
+describe Faraday::Errors do
+
+  describe 'error' do
+    stubs = Faraday::Adapter::Test::Stubs.new do |stub|
+      stub.get('/products/123') {[ 404, {}, { message: 'Record Not Found' } ]}
+    end
+
+    stubs2 = Faraday::Adapter::Test::Stubs.new do |stub|
+      stub.get('/products/123') {[ 500, {}, '<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> <html> <head> <meta http-equiv="content-type" content="text/html; charset=ISO-8859-1"> <style type="text/css"> html, body, iframe { margin: 0; padding: 0; height: 100%; } iframe { display: block; width: 100%; border: none; } </style> <title>Application Error</title></head> </head> <body> <iframe src="//s3.amazonaws.com/heroku_pages/error.html"> <p>Application Error</p> </iframe> </body> </html>' ]}
+    end
+
+    test = Faraday.new do |builder|
+      builder.response :errors
+      builder.response :json
+      builder.adapter :test, stubs
+    end
+
+    test2 = Faraday.new do |builder|
+      builder.response :errors
+      builder.response :json
+      builder.adapter :test, stubs2
+    end
+
+    it 'should raise a ResourceNotFound error' do
+      expect {
+        test.get('/products/123')
+      }.to raise_error(Reviewed::ResourceNotFound) { |e|
+        e.url.should be_an_instance_of(URI::HTTP)
+        e.url.to_s.should eql('http:/products/123')
+        e.message.should eql('Not Found')
+      }
+    end
+
+    context 'faraday catch-all' do
+
+      it 'raises an ApiError error' do
+        client = Reviewed::Client.new
+        client.stub!(:connection).and_return(test2)
+        expect {
+          client.send(:perform, :get, '/products/123')
+        }.to raise_error(Reviewed::ApiError)
+      end
+
+      it 'passes other Reviewed errors through' do
+        client = Reviewed::Client.new
+        client.stub!(:connection).and_raise(Reviewed::ConfigurationError.new)
+        expect {
+            client.send(:perform, :get, '/products/123')
+          }.to raise_error(Reviewed::ConfigurationError)
+      end
+    end
+  end
+
+  describe 'no error' do
+    stubs = Faraday::Adapter::Test::Stubs.new do |stub|
+      stub.get('/products/123') {[ 200, {}, { message: 'Record Not Found' } ]}
+    end
+
+    test = Faraday.new do |builder|
+      builder.response :errors
+      builder.response :json
+      builder.adapter :test, stubs
+    end
+
+    it 'should not raise an error' do
+      expect {
+        test.get('/products/123')
+      }.to_not raise_error
+    end
+  end
+end