reviewed 0.0.6 → 0.0.7

data/spec/product_spec.rb

@@ -1,28 +1,42 @@
 require 'spec_helper'
 
 describe Reviewed::Product do
-  describe 'attachments' do
-    use_vcr_cassette 'product/attachments'
 
-    before(:each) do
-      @product = Reviewed::Product.find('minden-master-ii')
-    end
+  describe 'associations' do
 
-    it 'returns all attachments' do
-      @product.attachments.length.should == 1
-    end
+    describe 'attachments' do
+      use_vcr_cassette 'product/attachments'
 
-    it 'finds attachments by tag' do
-      attachments = @product.attachments('vanity')
-      attachments.length.should == 1
-      attachments.each do |attachment|
-        attachment.tags.join(',').should match(/vanity/i)
+      before(:each) do
+        @product = Reviewed::Product.find('minden-master-ii')
+      end
+
+      it 'has_many :attachments' do
+        Reviewed::Product._embedded_many.should include({"attachments"=>Reviewed::Attachment})
+      end
+
+      it 'returns attachments of the correct class' do
+        @product.attachments.each do |attachment|
+          attachment.should be_an_instance_of(Reviewed::Attachment)
+        end
+      end
+
+      it 'returns all attachments' do
+        @product.attachments.length.should == 1
       end
-    end
 
-    it 'does not have any matching attachments' do
-      attachments = @product.attachments('doesnotcompute')
-      attachments.length.should == 0
+      it 'finds attachments by tag' do
+        attachments = @product.attachments('vanity')
+        attachments.length.should == 1
+        attachments.each do |attachment|
+          attachment.tags.join(',').should match(/vanity/i)
+        end
+      end
+
+      it 'does not have any matching attachments' do
+        attachments = @product.attachments('doesnotcompute')
+        attachments.length.should == 0
+      end
     end
   end
 end

data/spec/reviewed_spec.rb

@@ -0,0 +1,19 @@
+require 'spec_helper.rb'
+
+describe Reviewed do
+
+  describe '.client' do
+
+    it 'returns a Reviewed::Client' do
+      Reviewed.client.should be_an_instance_of(Reviewed::Client)
+    end
+  end
+
+  describe '.method_missing' do
+
+    it 'delegates to the client' do
+      Reviewed::Client.any_instance.should_receive(:api_key)
+      Reviewed.api_key
+    end
+  end
+end

data/spec/utils_spec.rb

@@ -0,0 +1,40 @@
+require 'spec_helper.rb'
+
+describe Reviewed::Utils do
+
+  class MockUtils < Reviewed::Base; end
+
+  describe 'object_from_response' do
+    use_vcr_cassette "utils/object"
+
+    let(:article_id) { '509d166d60de7db97c05ce71' }
+
+    it 'returns an object of the correct class' do
+      response = MockUtils.object_from_response(:get, "articles/#{article_id}")
+      response.should be_an_instance_of(MockUtils)
+    end
+  end
+
+  describe 'collection_from_response' do
+    use_vcr_cassette "utils/collection"
+
+    it 'returns a collection object' do
+      collection = MockUtils.collection_from_response(:get, "articles")
+      collection.should be_an_instance_of(Reviewed::Collection)
+    end
+
+    it 'returns objects of the correct class' do
+      collection = MockUtils.collection_from_response(:get, "articles")
+      collection.items.each do |obj|
+        obj.should be_an_instance_of(MockUtils)
+      end
+    end
+  end
+
+  describe 'from_response' do
+
+    it 'returns a new object from a response' do
+      MockUtils.from_response({}).should be_an_instance_of(MockUtils) 
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: reviewed
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 0.0.7
   prerelease: 
 platform: ruby
 authors:
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-11-20 00:00:00.000000000 Z
+date: 2012-11-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -45,13 +45,13 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '3.0'
 - !ruby/object:Gem::Dependency
-  name: rest-client
+  name: faraday
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: 0.8.4
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -59,7 +59,23 @@ dependencies:
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: 0.8.4
+- !ruby/object:Gem::Dependency
+  name: faraday_middleware
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 0.9.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 0.9.0
 - !ruby/object:Gem::Dependency
   name: hashie
   requirement: !ruby/object:Gem::Requirement
@@ -172,14 +188,17 @@ files:
 - Rakefile
 - lib/reviewed.rb
 - lib/reviewed/article.rb
+- lib/reviewed/attachment.rb
 - lib/reviewed/author.rb
 - lib/reviewed/base.rb
 - lib/reviewed/brand.rb
+- lib/reviewed/client.rb
 - lib/reviewed/collection.rb
+- lib/reviewed/configurable.rb
+- lib/reviewed/embeddable.rb
+- lib/reviewed/page.rb
 - lib/reviewed/product.rb
-- lib/reviewed/request.rb
-- lib/reviewed/response.rb
-- lib/reviewed/util.rb
+- lib/reviewed/utils.rb
 - lib/reviewed/version.rb
 - lib/reviewed/website.rb
 - reviewed.gemspec
@@ -187,23 +206,25 @@ files:
 - spec/author_spec.rb
 - spec/base_spec.rb
 - spec/brand_spec.rb
+- spec/client_spec.rb
 - spec/collection_spec.rb
+- spec/configurable_spec.rb
+- spec/embeddable_spec.rb
 - spec/fixtures/vcr/article/attachments.yml
 - spec/fixtures/vcr/article/find_page.yml
 - spec/fixtures/vcr/article/products.yml
-- spec/fixtures/vcr/base/find_error_key.yml
-- spec/fixtures/vcr/base/find_ok.yml
+- spec/fixtures/vcr/base/article/find.yml
 - spec/fixtures/vcr/base/where_collection.yml
 - spec/fixtures/vcr/collection/products.yml
 - spec/fixtures/vcr/product/attachments.yml
-- spec/fixtures/vcr/request/authors.yml
-- spec/fixtures/vcr/response/authors.yml
+- spec/fixtures/vcr/utils.yml
+- spec/fixtures/vcr/utils/collection.yml
+- spec/fixtures/vcr/utils/object.yml
 - spec/product_spec.rb
-- spec/request_spec.rb
-- spec/response_spec.rb
+- spec/reviewed_spec.rb
 - spec/spec_helper.rb
 - spec/support/.gitkeep
-- spec/util_spec.rb
+- spec/utils_spec.rb
 - spec/website_spec.rb
 homepage: ''
 licenses: []
@@ -234,21 +255,23 @@ test_files:
 - spec/author_spec.rb
 - spec/base_spec.rb
 - spec/brand_spec.rb
+- spec/client_spec.rb
 - spec/collection_spec.rb
+- spec/configurable_spec.rb
+- spec/embeddable_spec.rb
 - spec/fixtures/vcr/article/attachments.yml
 - spec/fixtures/vcr/article/find_page.yml
 - spec/fixtures/vcr/article/products.yml
-- spec/fixtures/vcr/base/find_error_key.yml
-- spec/fixtures/vcr/base/find_ok.yml
+- spec/fixtures/vcr/base/article/find.yml
 - spec/fixtures/vcr/base/where_collection.yml
 - spec/fixtures/vcr/collection/products.yml
 - spec/fixtures/vcr/product/attachments.yml
-- spec/fixtures/vcr/request/authors.yml
-- spec/fixtures/vcr/response/authors.yml
+- spec/fixtures/vcr/utils.yml
+- spec/fixtures/vcr/utils/collection.yml
+- spec/fixtures/vcr/utils/object.yml
 - spec/product_spec.rb
-- spec/request_spec.rb
-- spec/response_spec.rb
+- spec/reviewed_spec.rb
 - spec/spec_helper.rb
 - spec/support/.gitkeep
-- spec/util_spec.rb
+- spec/utils_spec.rb
 - spec/website_spec.rb

data/lib/reviewed/request.rb

@@ -1,23 +0,0 @@
-module Reviewed
-  class Request
-
-    class << self
-
-      def get(url)
-        url = url =~ /http/ ? url : build_url(url)
-
-        begin
-          raw_response = RestClient.get(url, Util.build_request_headers)
-          Reviewed::Response.new(raw_response)
-        rescue RestClient::Exception => e
-          raise ResourceError.new(e.message)
-        end
-      end
-
-      def build_url(url)
-        url = [Reviewed.base_uri, API_VERSION, url].compact.join("/")
-      end
-    end
-  end
-end
-

data/lib/reviewed/response.rb

@@ -1,12 +0,0 @@
-module Reviewed
-  class Response
-
-    attr_accessor :raw
-    attr_accessor :json
-
-    def initialize(raw_response)
-      @raw = raw_response
-      @json = JSON.parse(raw_response)
-    end
-  end
-end

data/lib/reviewed/util.rb

@@ -1,16 +0,0 @@
-module Reviewed
-  class Util
-    def self.build_request_headers(headers={})
-      headers['X-Reviewed-Authorization'] ||= Reviewed.api_key
-      headers['accept'] ||= 'json'
-      headers.stringify_keys!
-    end
-
-    def self.build_query_string(hash={})
-      hash.keys.inject('') do |query_string, key|
-        query_string << '&' unless key == hash.keys.first
-        query_string << "#{URI.encode(key.to_s)}=#{URI.encode(hash[key].to_s)}"
-      end
-    end
-  end
-end

data/spec/fixtures/vcr/base/find_error_key.yml

@@ -1,172 +0,0 @@
----
-http_interactions:
-- request:
-    method: get
-    uri: https://the-guide-staging.herokuapp.com/api/v1/articles/50241b9c5da4ac8d38000001
-    body:
-      encoding: US-ASCII
-      string: ''
-    headers:
-      Accept:
-      - application/json
-      Accept-Encoding:
-      - gzip, deflate
-      X-Reviewed-Authorization:
-      - xxxxxxxxxxxxxxxx
-      User-Agent:
-      - Ruby
-  response:
-    status:
-      code: 401
-      message: !binary |-
-        VW5hdXRob3JpemVk
-    headers:
-      !binary "QWNjZXNzLUNvbnRyb2wtQWxsb3ctQ3JlZGVudGlhbHM=":
-      - !binary |-
-        dHJ1ZQ==
-      !binary "QWNjZXNzLUNvbnRyb2wtQWxsb3ctSGVhZGVycw==":
-      - !binary |-
-        eC1wYWdpbmF0aW9uLCB4LXJlcXVlc3RlZC13aXRoLCB4LXJlcXVlc3RlZC1i
-        eSwgeC1yZXZpZXdlZC1hdXRob3JpemF0aW9uLCBDb250ZW50LVR5cGU=
-      !binary "QWNjZXNzLUNvbnRyb2wtQWxsb3ctTWV0aG9kcw==":
-      - !binary |-
-        T1BUSU9OUywgR0VULCBQT1NULCBQVVQsIERFTEVURQ==
-      !binary "QWNjZXNzLUNvbnRyb2wtQWxsb3ctT3JpZ2lu":
-      - !binary |-
-        Kg==
-      !binary "QWNjZXNzLUNvbnRyb2wtTWF4LUFnZQ==":
-      - !binary |-
-        MTAwMA==
-      !binary "Q2FjaGUtQ29udHJvbA==":
-      - !binary |-
-        bm8tY2FjaGUsIG5vLXN0b3Jl
-      !binary "Q29udGVudC1FbmNvZGluZw==":
-      - !binary |-
-        Z3ppcA==
-      !binary "Q29udGVudC1UeXBl":
-      - !binary |-
-        YXBwbGljYXRpb24vanNvbjsgY2hhcnNldD11dGYtOA==
-      !binary "RGF0ZQ==":
-      - !binary |-
-        VHVlLCAwNiBOb3YgMjAxMiAyMTowMDowMSBHTVQ=
-      !binary "U2VydmVy":
-      - !binary |-
-        dGhpbiAxLjUuMCBjb2RlbmFtZSBLbmlmZQ==
-      !binary "U3RyaWN0LVRyYW5zcG9ydC1TZWN1cml0eQ==":
-      - !binary |-
-        bWF4LWFnZT0zMTUzNjAwMA==
-      !binary "VmFyeQ==":
-      - !binary |-
-        QWNjZXB0LUVuY29kaW5n
-      !binary "WC1SYWNrLUNhY2hl":
-      - !binary |-
-        bWlzcw==
-      !binary "WC1SZXF1ZXN0LUlk":
-      - !binary |-
-        MWFkYWUxMWU5MmRmZTA5OThmODYxYmU3OTYwMGUwNTQ=
-      !binary "WC1SdW50aW1l":
-      - !binary |-
-        MC4wMjM5NjM=
-      !binary "WC1VYS1Db21wYXRpYmxl":
-      - !binary |-
-        SUU9RWRnZSxjaHJvbWU9MQ==
-      !binary "VHJhbnNmZXItRW5jb2Rpbmc=":
-      - !binary |-
-        Y2h1bmtlZA==
-      !binary "Q29ubmVjdGlvbg==":
-      - !binary |-
-        a2VlcC1hbGl2ZQ==
-    body:
-      encoding: ASCII-8BIT
-      string: !binary |-
-        H4sIAFF6mVAAA6pWyk0tLk5MT1WyUnIsyFTwTq1UyMsvUUjLL81LUaoFAAAA
-        //8DABnVGWAfAAAA
-    http_version: 
-  recorded_at: Tue, 06 Nov 2012 20:59:58 GMT
-- request:
-    method: get
-    uri: https://the-guide-staging.herokuapp.com/api/v1/articles/notfound
-    body:
-      encoding: US-ASCII
-      string: ''
-    headers:
-      Accept:
-      - application/json
-      Accept-Encoding:
-      - gzip, deflate
-      X-Reviewed-Authorization:
-      - '1234567890'
-      User-Agent:
-      - Ruby
-  response:
-    status:
-      code: 404
-      message: !binary |-
-        Tm90IEZvdW5k
-    headers:
-      !binary "QWNjZXNzLUNvbnRyb2wtQWxsb3ctQ3JlZGVudGlhbHM=":
-      - !binary |-
-        dHJ1ZQ==
-      !binary "QWNjZXNzLUNvbnRyb2wtQWxsb3ctSGVhZGVycw==":
-      - !binary |-
-        eC1wYWdpbmF0aW9uLCB4LXJlcXVlc3RlZC13aXRoLCB4LXJlcXVlc3RlZC1i
-        eSwgeC1yZXZpZXdlZC1hdXRob3JpemF0aW9uLCBDb250ZW50LVR5cGU=
-      !binary "QWNjZXNzLUNvbnRyb2wtQWxsb3ctTWV0aG9kcw==":
-      - !binary |-
-        T1BUSU9OUywgR0VULCBQT1NULCBQVVQsIERFTEVURQ==
-      !binary "QWNjZXNzLUNvbnRyb2wtQWxsb3ctT3JpZ2lu":
-      - !binary |-
-        Kg==
-      !binary "QWNjZXNzLUNvbnRyb2wtTWF4LUFnZQ==":
-      - !binary |-
-        MTAwMA==
-      !binary "Q2FjaGUtQ29udHJvbA==":
-      - !binary |-
-        bm8tY2FjaGUsIG5vLXN0b3Jl
-      !binary "Q29udGVudC1FbmNvZGluZw==":
-      - !binary |-
-        Z3ppcA==
-      !binary "Q29udGVudC1UeXBl":
-      - !binary |-
-        YXBwbGljYXRpb24vanNvbjsgY2hhcnNldD11dGYtOA==
-      !binary "RGF0ZQ==":
-      - !binary |-
-        VHVlLCAwNiBOb3YgMjAxMiAyMTowMDowMiBHTVQ=
-      !binary "U2VydmVy":
-      - !binary |-
-        dGhpbiAxLjUuMCBjb2RlbmFtZSBLbmlmZQ==
-      !binary "U3RyaWN0LVRyYW5zcG9ydC1TZWN1cml0eQ==":
-      - !binary |-
-        bWF4LWFnZT0zMTUzNjAwMA==
-      !binary "VmFyeQ==":
-      - !binary |-
-        QWNjZXB0LUVuY29kaW5n
-      !binary "WC1SYWNrLUNhY2hl":
-      - !binary |-
-        bWlzcw==
-      !binary "WC1SYXRlLUxpbWl0":
-      - !binary |-
-        OTg5NjM=
-      !binary "WC1SZXF1ZXN0LUlk":
-      - !binary |-
-        NDVlNjlmMDQ1MzUwZDJjMjAxZjE3Y2I5YjZmMzNiYzk=
-      !binary "WC1SdW50aW1l":
-      - !binary |-
-        MC4yMjYzOTU=
-      !binary "WC1VYS1Db21wYXRpYmxl":
-      - !binary |-
-        SUU9RWRnZSxjaHJvbWU9MQ==
-      !binary "VHJhbnNmZXItRW5jb2Rpbmc=":
-      - !binary |-
-        Y2h1bmtlZA==
-      !binary "Q29ubmVjdGlvbg==":
-      - !binary |-
-        a2VlcC1hbGl2ZQ==
-    body:
-      encoding: ASCII-8BIT
-      string: !binary |-
-        H4sIAFJ6mVAAA6pWyk0tLk5MT1WyUgpKTc4vSlHwyy9RcMsvzUtRqgUAAAD/
-        /wMAZek3sh4AAAA=
-    http_version: 
-  recorded_at: Tue, 06 Nov 2012 20:59:58 GMT
-recorded_with: VCR 2.2.5