review 4.1.0 → 5.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 364df2692f5e92ca2eaf1b327861324d6d964b1534d468c951476eb5603f1275
-  data.tar.gz: 57b1f560b2a08559596f6eb55d3f5af942bb5712447470b506c1f2ac780287eb
+  metadata.gz: 413c947f61e128331f01df2d83a039d519145016ce5757d603be616867acf594
+  data.tar.gz: 3ba0c7cb9bb87e2b8668391d60865a9ff0d1b3f1481cffa0e1670cab540fd99e
 SHA512:
-  metadata.gz: 53298e1df89dc374b4809a8c4b7602885dc911df397fd1271a2504c030649e059a3f876c499a0d0c358c56d16e7dc3d50183b36b06dfff6e4f41d0853497f76d
-  data.tar.gz: 2ce2cd48f28475c89d5305c0097031d19cfdbe11d3b0d8e9f16213fe1ef1b977324fe5a1996706b69b7204789270535f5cfac0254b015a9a7a8d0efd496c5ffa
+  metadata.gz: 2131556e6cb7c916684b8fcdb6f1deea8a84b14dbbb5a2e62d4ad31caac832a2136d4afda25ee7c93670c56f24fd98f79090c90617e15db1cfb7ab331999b6b6
+  data.tar.gz: b929c23fa373de5780aeae97332103e19b444a57aa098ccf3f03c31716e7a46972d1213cc539d0785b76f94e2cdf5143521c3f9d446bbdb087030e357edacd7d

data/.github/workflows/ruby-tex.yml

@@ -0,0 +1,35 @@
+name: Test with TeXLive
+
+on:
+  push:
+    branches:
+    - master
+  pull_request:
+
+jobs:
+  build:
+
+    runs-on: ${{ matrix.os }}
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby: [2.5, 3.0]
+        os: [ubuntu-20.04]
+    steps:
+    - uses: actions/checkout@v2
+    - name: Install TeXLive 2020 in ubuntu
+      if: runner.os == 'Linux'
+      run: |
+        sudo apt-get update -y -qq && sudo apt-get install -y -qq texlive-lang-japanese texlive-fonts-recommended texlive-fonts-extra texlive-luatex texlive-extra-utils texlive-latex-extra dvipng poppler-utils
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby }}
+    - name: fix ImageMagick policy.xml on Linux
+      if: runner.os == 'Linux'
+      run: sudo sed -i 's/none/read|write/g' /etc/ImageMagick-6/policy.xml
+    - name: Build and test with Rake
+      run: |
+        gem install bundler --no-document
+        bundle install --retry 3
+        bundle exec rake

data/.github/workflows/ruby-win.yml

@@ -1,6 +1,10 @@
 name: TestWin
 
-on: [push]
+on:
+  push:
+    branches:
+    - master
+  pull_request:
 
 jobs:
   build:
@@ -9,12 +13,12 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ruby: [ '2.6.x', '2.5.x', '2.4.x' ]
+        ruby: [ '3.0', '2.6', '2.5', '2.4' ]
 
     steps:
-    - uses: actions/checkout@v1
+    - uses: actions/checkout@v2
     - name: Set up Ruby
-      uses: actions/setup-ruby@v1
+      uses: ruby/setup-ruby@v1
       with:
         ruby-version: ${{ matrix.ruby }}
     - name: Build and test with Rake
@@ -23,17 +27,23 @@ jobs:
         gem install bundler --no-document
         bundle install --retry 3
         bundle exec ruby test/run_test.rb --max-diff-target-string-size=10000 --verbose=v
-    - name: Test with epubcheck-ruby
+    - name: install Re:VIEW and epubcheck-ruby
       shell: bash
       run: |
         gem install -N epubcheck-ruby
-        ruby bin/review-init hello
+        rake install
+    - name: Test with epubcheck-ruby
+      shell: bash
+      run: |
+        review-init hello
         cd hello
-        ruby ../bin/review-epubmaker config.yml
+        ruby -e 'Dir.glob("*.re"){|path| File.write(path, File.read(path).gsub("=", "= foo")) }'
+        review-epubmaker config.yml
         epubcheck book.epub
         cd ..
-        ruby bin/review-init hello2 --epub-version 2
+        review-init hello2 --epub-version 2
         cd hello2
-        ruby ../bin/review-epubmaker config.yml
+        ruby -e 'Dir.glob("*.re"){|path| File.write(path, File.read(path).gsub("=", "= foo")) }'
+        review-epubmaker config.yml
         epubcheck book.epub
         cd ..

data/.github/workflows/ruby.yml

@@ -1,6 +1,10 @@
 name: Test
 
-on: [push]
+on:
+  push:
+    branches:
+    - master
+  pull_request:
 
 jobs:
   build:
@@ -9,12 +13,12 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ruby: [2.4, 2.5, 2.6, 2.7]
+        ruby: [2.4, 2.5, 2.6, 2.7, 3.0]
         os: [ubuntu-latest, macOS-latest]
     steps:
     - uses: actions/checkout@v2
     - name: Set up Ruby
-      uses: eregon/use-ruby-action@master
+      uses: ruby/setup-ruby@v1
       with:
         ruby-version: ${{ matrix.ruby }}
     - name: fix ImageMagick policy.xml on Linux

data/.rubocop.yml

@@ -1,14 +1,15 @@
 AllCops:
   Exclude:
-    - lib/lineinput.rb
     - lib/uuid.rb
     - test/syntax-book/*
+    - tmp/*
   DisplayCopNames: true
+  NewCops: enable
+  TargetRubyVersion: 2.5
 
 require:
   - rubocop-performance
-
-inherit_from: .rubocop_todo.yml
+  - rubocop-rake
 
 #### Lint
 
@@ -25,9 +26,6 @@ Lint/AssignmentInCondition:
 Lint/ParenthesesAsGroupedExpression:
   Enabled: true
 
-#Lint/RescueWithoutErrorClass:
-#  Enabled: false
-
 Lint/UnderscorePrefixedVariableName:
   Enabled: true
 
@@ -43,6 +41,22 @@ Lint/UselessAssignment:
 Lint/ErbNewArguments:
   Enabled: false
 
+Lint/DeprecatedOpenSSLConstant:
+  Enabled: true
+
+Lint/MixedRegexpCaptureTypes:
+  Enabled: true
+
+Lint/RaiseException:
+  Enabled: true
+
+Lint/StructNewOverride:
+  Enabled: true
+
+# make it enable when supporting only Ruby 3.0 and higher.
+Lint/RedundantDirGlobSort:
+  Enabled: false
+
 #### Performance
 
 Performance/RegexpMatch:
@@ -53,11 +67,44 @@ Performance/ReverseEach:
 
 # Use tr instead of gsub.
 Performance/StringReplacement:
-  Enabled: false
+  Enabled: true
 
 Performance/RangeInclude:
   Enabled: true
 
+Performance/DeletePrefix:
+  Enabled: false
+
+Performance/RedundantMerge:
+  Enabled: true
+
+Performance/AncestorsInclude:
+  Enabled: true
+
+Performance/BigDecimalWithNumericArgument:
+  Enabled: true
+
+Performance/RedundantSortBlock:
+  Enabled: true
+
+Performance/RedundantStringChars:
+  Enabled: true
+
+Performance/ReverseFirst:
+  Enabled: true
+
+Performance/SortReverse:
+  Enabled: true
+
+Performance/Squeeze:
+  Enabled: true
+
+Performance/StringInclude:
+  Enabled: false
+
+Performance/CollectionLiteralInLoop:
+  Enabled: false
+
 #### Style
 
 Style/AccessModifierDeclarations:
@@ -72,7 +119,7 @@ Style/Alias:
   Enabled: true
 
 Style/AndOr:
-  Enabled: false
+  Enabled: true
 
 Style/BarePercentLiterals:
   EnforcedStyle: percent_q
@@ -81,9 +128,6 @@ Style/BarePercentLiterals:
 Style/BlockDelimiters:
   Enabled: true
 
-Style/BracesAroundHashParameters:
-  Enabled: false
-
 Style/CaseEquality:
   Enabled: false
 
@@ -96,6 +140,9 @@ Style/ClassMethods:
 Style/CommentedKeyword:
   Enabled: false
 
+Style/DocumentDynamicEvalDefinition:
+  Enabled: false
+
 Style/FloatDivision:
   Enabled: false
 
@@ -120,7 +167,7 @@ Style/EmptyElse:
   Enabled: true
 
 Style/EvalWithLocation:
-  Enabled: false
+  Enabled: true
 
 Style/FormatString:
   EnforcedStyle: sprintf
@@ -133,7 +180,7 @@ Style/GuardClause:
   Enabled: false
 
 Style/IfInsideElse:
-  Enabled: false
+  Enabled: true
 
 Style/IfUnlessModifier:
   Enabled: false
@@ -141,13 +188,10 @@ Style/IfUnlessModifier:
 Style/MutableConstant:
   Enabled: false
 
-#Style/MultipleComparison:
-#  Enabled: true
-
-Style/RedundantInterpolation:
+Style/MultipleComparison:
   Enabled: true
 
-Performance/RedundantMerge:
+Style/RedundantInterpolation:
   Enabled: true
 
 Style/ZeroLengthPredicate:
@@ -211,11 +255,16 @@ Style/MethodCallWithArgsParentheses:
     - 'write'
     - 'warn'
     - 'error'
+    - 'error!'
+    - 'app_error'
     - 'raise'
     - 'yield'
     - 'source'
     - 'assert'
     - 'assert_equal'
+    - 'assert_raise'
+    - 'assert_raises'
+    - 'assert_nothing_raised'
     - 'sh'
     - 'mv'
     - 'rm_rf'
@@ -310,8 +359,50 @@ Style/RedundantPercentQ:
 Style/WhileUntilModifier:
   Enabled: false
 
-#Style/YodaCondition:
-#  Enabled: true
+Style/YodaCondition:
+  Enabled: true
+
+Style/ExponentialNotation:
+  Enabled: true
+
+Style/HashEachMethods:
+  Enabled: true
+
+Style/HashTransformKeys:
+  Enabled: true
+
+Style/HashTransformValues:
+  Enabled: true
+
+Style/RedundantFetchBlock:
+  Enabled: true
+
+Style/RedundantRegexpCharacterClass:
+  Enabled: true
+
+Style/RedundantRegexpEscape:
+  Enabled: true
+
+Style/SlicingWithRange:
+  Enabled: false
+
+Style/AccessorGrouping:
+  Enabled: false
+
+Style/CaseLikeIf:
+  Enabled: false
+
+Style/StringConcatenation:
+  Enabled: false
+
+Style/OptionalBooleanParameter:
+  Enabled: false
+
+Style/SoleNestedConditional:
+  Enabled: false
+
+Style/CombinableLoops:
+  Enabled: false
 
 ### Layout
 
@@ -339,7 +430,7 @@ Layout/EmptyLines:
   Enabled: true
 
 Layout/EmptyLineAfterGuardClause:
-  Enabled: false
+  Enabled: true
 
 Layout/EmptyLinesAroundAccessModifier:
   Enabled: true
@@ -354,7 +445,7 @@ Layout/EmptyLinesAroundModuleBody:
   Enabled: true
 
 Layout/EndOfLine:
-  Enabled: false
+  Enabled: true
 
 Layout/ExtraSpacing:
   Enabled: true
@@ -375,7 +466,7 @@ Layout/LeadingCommentSpace:
   Enabled: true
 
 Layout/MultilineOperationIndentation:
-  Enabled: false
+  Enabled: true
 
 Layout/SpaceAroundBlockParameters:
   EnforcedStyleInsidePipes: no_space
@@ -397,7 +488,7 @@ Layout/SpaceAroundOperators:
   Enabled: true
 
 Layout/SpaceBeforeBlockBraces:
-  Enabled: false
+  Enabled: true
 
 Layout/SpaceBeforeComma:
   Enabled: true
@@ -422,13 +513,24 @@ Layout/TrailingWhitespace:
   Enabled: true
   AllowInHeredoc: true
 
+Layout/EmptyLinesAroundAttributeAccessor:
+  Enabled: true
+
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: true
+
+Layout/LineLength:
+  Max: 256
+  Exclude:
+    - "test/**/*"
+
 #### Metrics
 
 Metrics/BlockNesting:
   Max: 4
 
 Metrics/ModuleLength:
-  Max: 200
+  Max: 300
 
 Metrics/ParameterLists:
   Max: 8
@@ -441,11 +543,6 @@ Metrics/ClassLength:
   Exclude:
     - 'test/*.rb'
 
-Metrics/LineLength:
-  Max: 256
-  Exclude:
-    - "test/**/*"
-
 ### should be < 50
 Metrics/MethodLength:
   Max: 100
@@ -456,7 +553,7 @@ Metrics/MethodLength:
 
 ### should be < 20
 Metrics/CyclomaticComplexity:
-  Max: 32
+  Max: 25
 
 ### should be < 60
 Metrics/AbcSize:
@@ -480,8 +577,8 @@ Naming/AccessorMethodName:
   Enabled: true
 
 # When defining the == operator, name its argument other.
-#Style/BinaryOperatorParameterName:
-#  Enabled: true
+Naming/BinaryOperatorParameterName:
+  Enabled: true
 
 Naming/FileName:
   Enabled: false
@@ -490,7 +587,7 @@ Naming/HeredocDelimiterNaming:
   Enabled: false
 
 Naming/MemoizedInstanceVariableName:
-  Enabled: false
+  Enabled: true
 
 Naming/MethodName:
   Enabled: true
@@ -505,8 +602,15 @@ Naming/VariableName:
 Naming/VariableNumber:
   EnforcedStyle: normalcase
   Enabled: true
+  Exclude:
+    - test/*
 
 #### Security
 
 Security/YAMLLoad:
   Enabled: true
+
+#### Gemspec
+
+Gemspec/RequiredRubyVersion:
+  Enabled: false