reverse_markdown 1.3.0 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8263de44d8eac3a94972aea1e17323f1c51a44055a2953a4fa4ba2202585aeee
-  data.tar.gz: 8f21ecda53dd5edfc9e5faaebf8105bb98033c43a1480dd4d56b885602933bc6
+  metadata.gz: 1945214c22af9c763471e6bf9375fe94f1618fd67af1de2a28a0c88cdc59c07a
+  data.tar.gz: 26352feda47de16934757ade063ec14d55a9a6c8364570a9b3b72c656deb803b
 SHA512:
-  metadata.gz: b05f33ea93fb3c751534166c1e8fe4baefd3dfa3d9546db1b8535a4e70ed9f25a92fafac167640ef10e6ed44a0cf5b0366dac9ce6d6a9d64ffe8d7642d8f3d1f
-  data.tar.gz: 0b37d09c0949a521c3ae7c09a27283165fbab621ab87377fb1b5f8b532d171abf6bb0d221dc810da3ffb2c34b2afe922463dadcf097a0810473781c0664f7978
+  metadata.gz: 959cc8dff7496eec2b8828f6f059ababa4d008fe6b5aebc05d442b6c746b4d863b1f860f29c5620738273ed808a21b9a19182283d2c177e8b86d0553e53f01ad
+  data.tar.gz: 2580ead64498f94190f4e20cb3a475e1e8e5dc7f3343fe8d7ea4fcb4a7d9a163628facdb0eb00ad2b335edc3b9758dc83389c7dfd611e1325586d9a75e4e9a33

data/CHANGELOG.md

@@ -1,6 +1,9 @@
 # Change Log
 All notable changes to this project will be documented in this file.
 
+## 1.4.0 – January 2020
+- BREAKING: jump links will no longer be ignored but treated as links, see #82
+
 ## 1.3.0 - September 2019
 - Add support for `s` HTML tag, thanks @fauno
 

data/Rakefile

@@ -10,5 +10,5 @@ task :default => :spec
 
 desc 'Open an irb session preloaded with this library'
 task :console do
-  sh 'irb -rubygems -I lib -r reverse_markdown.rb'
+  sh 'irb -I lib -r reverse_markdown.rb'
 end

data/lib/reverse_markdown.rb

@@ -1,4 +1,3 @@
-require 'digest'
 require 'nokogiri'
 require 'reverse_markdown/version'
 require 'reverse_markdown/errors'
@@ -33,15 +32,17 @@ require 'reverse_markdown/converters/tr'
 module ReverseMarkdown
 
   def self.convert(input, options = {})
-    root = case input
-      when String                  then Nokogiri::HTML(input).root
-      when Nokogiri::XML::Document then input.root
-      when Nokogiri::XML::Node     then input
-    end
+    config.with(options) do
+      input = cleaner.force_encoding(input.to_s)
 
-    root or return ''
+      root = case input
+        when String                  then Nokogiri::HTML(input).root
+        when Nokogiri::XML::Document then input.root
+        when Nokogiri::XML::Node     then input
+      end
+
+      root or return ''
 
-    config.with(options) do
       result = ReverseMarkdown::Converters.lookup(root.name).convert(root)
       cleaner.tidy(result)
     end

data/lib/reverse_markdown/cleaner.rb

@@ -59,6 +59,11 @@ module ReverseMarkdown
       string.gsub(/(\*\*|~~|__)\s([\.!\?'"])/, "\\1".strip + "\\2")
     end
 
+    def force_encoding(string)
+      ReverseMarkdown.config.force_encoding or return string
+      string.encode('UTF-8', 'binary', invalid: :replace, undef: :replace, replace: '')
+    end
+
     private
 
     def preserve_border_whitespaces(string, options = {}, &block)

data/lib/reverse_markdown/config.rb

@@ -1,10 +1,11 @@
 module ReverseMarkdown
   class Config
-    attr_accessor :unknown_tags, :github_flavored, :tag_border
+    attr_writer :unknown_tags, :github_flavored, :tag_border, :force_encoding
 
     def initialize
       @unknown_tags     = :pass_through
       @github_flavored  = false
+      @force_encoding   = false
       @em_delimiter     = '_'.freeze
       @strong_delimiter = '**'.freeze
       @inline_options   = {}
@@ -29,5 +30,9 @@ module ReverseMarkdown
     def tag_border
       @inline_options[:tag_border] || @tag_border
     end
+
+    def force_encoding
+      @inline_options[:force_encoding] || @force_encoding
+    end
   end
 end

data/lib/reverse_markdown/converters/a.rb

@@ -6,7 +6,7 @@ module ReverseMarkdown
         href  = node['href']
         title = extract_title(node)
 
-        if href.to_s.start_with?('#') || href.to_s.empty? || name.empty?
+        if href.to_s.empty? || name.empty?
           name
         else
           link = "[#{name}](#{href}#{title})"

data/lib/reverse_markdown/version.rb

@@ -1,3 +1,3 @@
 module ReverseMarkdown
-  VERSION = '1.3.0'
+  VERSION = '1.4.0'
 end

data/reverse_markdown.gemspec

@@ -11,7 +11,6 @@ Gem::Specification.new do |s|
   s.summary     = %q{Convert html code into markdown.}
   s.description = %q{Map simple html back into markdown, e.g. if you want to import existing html data in your application.}
   s.licenses    = ["WTFPL"]
-  s.rubyforge_project = "reverse_markdown"
 
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")

data/spec/components/anchors_spec.rb

@@ -20,7 +20,7 @@ describe ReverseMarkdown do
   context "links to ignore" do
     it { is_expected.to include ' ignore anchor tags with no link text ' }
     it { is_expected.to include ' not ignore [![An Image](image.png)](foo.html) anchor tags with images' }
-    it { is_expected.to include ' pass through the text of internal jumplinks without treating them as links ' }
+    it { is_expected.to include ' pass through the text of [internal jumplinks](#content) without treating them as links ' }
     it { is_expected.to include ' pass through the text of anchor tags with no href without treating them as links ' }
   end
 

data/spec/lib/reverse_markdown_spec.rb

@@ -33,5 +33,15 @@ describe ReverseMarkdown do
       end
       expect(ReverseMarkdown.config.github_flavored).to eq true
     end
+
+    describe 'force_encoding option', jruby: :exclude do
+      it 'raises invalid byte sequence in UTF-8 exception' do
+        expect { ReverseMarkdown.convert("hi \255") }.to raise_error(ArgumentError)
+      end
+
+      it 'handles invalid byte sequence if option is set' do
+        expect(ReverseMarkdown.convert("hi \255", force_encoding: true)).to eq "hi\n\n"
+      end
+    end
   end
 end

data/spec/spec_helper.rb

@@ -14,6 +14,14 @@ RSpec.configure do |config|
   config.after(:each) do
     ReverseMarkdown.instance_variable_set(:@config, nil)
   end
+
+  config.around(jruby: :exclude) do |example|
+    if RUBY_ENGINE == 'jruby'
+      example.metadata[:skip] = true
+    else
+      example.call
+    end
+  end
 end
 
 def node_for(html)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: reverse_markdown
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.4.0
 platform: ruby
 authors:
 - Johannes Opper
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-09-09 00:00:00.000000000 Z
+date: 2020-01-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri