rets 0.4.0 → 0.5.0

data/test/test_locking_http_client.rb

@@ -0,0 +1,29 @@
+require_relative "helper"
+
+class TestLockingHttpClient < MiniTest::Test
+  def setup
+    @fake_client = stub('fake_client')
+    @locker = stub('locker')
+    @locking_client = Rets::LockingHttpClient.new(@fake_client, @locker, 'lock_name')
+    @url = "fake rets url"
+    @params = {'fake_param' => 'fake_param_value'}
+  end
+
+  def test_locking_client_calls_the_real_client_if_lock_succeeds
+    @locker.stubs(:lock).with('lock_name', {}).yields(nil)
+    @fake_client.expects(:http_post).with(@url, @params, {})
+    @locking_client.http_post(@url, @params)
+  end
+
+  def test_locking_client_does_nothing_if_lock_fails_to_yield
+    @fake_client.expects(:http_post).never
+    @locker.stubs(:lock).with('lock_name', {})
+    @locking_client.http_post(@url, @params)
+  end
+
+  def test_locking_client_returns_result_from_client
+    @fake_client.stubs(:http_post).returns('result')
+    @locker.stubs(:lock).with('lock_name', {}).yields(nil)
+    assert_equal 'result', @locking_client.http_post(@url, @params)
+  end
+end

data/test/test_metadata.rb

@@ -1,8 +1,13 @@
-require "helper"
+require_relative "helper"
 
-class TestMetadata < Test::Unit::TestCase
+class TestMetadata < MiniTest::Test
   def setup
     @root = Rets::Metadata::Root.new
+    $VERBOSE = true
+  end
+
+  def teardown
+    $VERBOSE = false
   end
 
   def test_metadata_root_fetch_sources_returns_hash_of_metadata_types

data/test/test_parser_compact.rb

@@ -1,8 +1,8 @@
-require "helper"
+require_relative "helper"
 
-class TestParserCompact < Test::Unit::TestCase
+class TestParserCompact < MiniTest::Test
   def test_parse_document_raises_on_invalid_delimiter
-    assert_raise Rets::Parser::Compact::InvalidDelimiter do
+    assert_raises Rets::Parser::Compact::InvalidDelimiter do
       Rets::Parser::Compact.parse_document(INVALID_DELIMETER)
     end
   end
@@ -56,6 +56,16 @@ class TestParserCompact < Test::Unit::TestCase
     end
   end
 
+  def test_parse_empty_document
+    rows = Rets::Parser::Compact.parse_document(EMPTY_COMPACT)
+    assert_equal [], rows
+  end
+
+  def test_get_count
+    count = Rets::Parser::Compact.get_count(COUNT_ONLY)
+    assert_equal 1234, count
+  end
+
   def test_parse_example
     rows = Rets::Parser::Compact.parse_document(Nokogiri.parse(SAMPLE_COMPACT))
 

data/test/test_parser_multipart.rb

@@ -1,6 +1,6 @@
-require "helper"
+require_relative "helper"
 
-class TestParserMultipart < Test::Unit::TestCase
+class TestParserMultipart < MiniTest::Test
   def test_parse_returns_multiple_parts
     headers = {"content-type"=>"image/jpeg", "content-id"=>"90020062739", "content-length"=>"10"}
 
@@ -18,12 +18,12 @@ class TestParserMultipart < Test::Unit::TestCase
     assert_equal headers.merge("object-id" => "2"), part.headers
     assert_equal "yyyyyyyy", part.body.strip
   end
-  
+
   def test_parse_real_mls_data
     parts = Rets::Parser::Multipart.parse(MULTIPART_RESPONSE_URLS, "rets.object.content.boundary.1330546052739")
     assert_equal 5, parts.size
   end
-  
+
   def test_parse_values_with_colon_data
     parts = Rets::Parser::Multipart.parse(MULTIPART_RESPONSE_URLS, "rets.object.content.boundary.1330546052739")
     assert_equal 'http://foobarmls.com/RETS//MediaDisplay/98/hr2890998-1.jpg', parts[0].headers['location']
@@ -32,7 +32,7 @@ class TestParserMultipart < Test::Unit::TestCase
   def test_parse_with_error
     raw = "\r\n--89467f8e0c6b48158c8f1883910212ec\r\nContent-Type: text/xml\r\nContent-ID: foo\r\nObject-ID: *\r\n\r\n<RETS ReplyCode=\"20403\" ReplyText=\"No Object Found\" />\r\n\r\n--89467f8e0c6b48158c8f1883910212ec--\r\n"
     boundary = "89467f8e0c6b48158c8f1883910212ec"
-    assert_raise Rets::InvalidRequest do
+    assert_raises Rets::InvalidRequest do
       Rets::Parser::Multipart.parse(raw, boundary)
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rets
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,16 +9,16 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-08-29 00:00:00.000000000 Z
+date: 2013-09-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: net-http-persistent
+  name: httpclient
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: 2.3.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -26,7 +26,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: 2.3.0
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
@@ -50,7 +50,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '3.10'
+        version: '4.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -58,7 +58,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '3.10'
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: mocha
   requirement: !ruby/object:Gem::Requirement
@@ -114,7 +114,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '3.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -122,7 +122,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '3.6'
 description: ! '[![Build Status](https://secure.travis-ci.org/estately/rets.png?branch=master)](http://travis-ci.org/estately/rets)
 
   A pure-ruby library for fetching data from [RETS] servers.
@@ -135,7 +135,9 @@ executables:
 - rets
 extensions: []
 extra_rdoc_files:
+- CHANGELOG.md
 - Manifest.txt
+- README.md
 files:
 - CHANGELOG.md
 - Manifest.txt
@@ -143,7 +145,6 @@ files:
 - Rakefile
 - bin/rets
 - lib/rets.rb
-- lib/rets/authentication.rb
 - lib/rets/client.rb
 - lib/rets/metadata.rb
 - lib/rets/metadata/containers.rb
@@ -160,6 +161,7 @@ files:
 - test/test_metadata.rb
 - test/test_parser_compact.rb
 - test/test_parser_multipart.rb
+- test/test_locking_http_client.rb
 - .gemtest
 homepage: http://github.com/estately/rets
 licenses: []
@@ -175,6 +177,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: -2023944965655718483
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -183,13 +188,14 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: rets
-rubygems_version: 1.8.24
+rubygems_version: 1.8.23
 signing_key: 
 specification_version: 3
 summary: ! '[![Build Status](https://secure.travis-ci.org/estately/rets.png?branch=master)](http://travis-ci.org/estately/rets)
   A pure-ruby library for fetching data from [RETS] servers'
 test_files:
 - test/test_client.rb
+- test/test_locking_http_client.rb
 - test/test_metadata.rb
 - test/test_parser_compact.rb
 - test/test_parser_multipart.rb

data/lib/rets/authentication.rb

@@ -1,57 +0,0 @@
-module Rets
-  # Adapted from dbrain's Net::HTTP::DigestAuth gem, and RETS4R auth
-  # in order to support RETS' usage of digest authentication.
-  module Authentication
-    def build_auth(digest_authenticate, uri, nc = 0, method = "POST")
-      user     = CGI.unescape uri.user
-      password = CGI.unescape uri.password
-
-      digest_authenticate =~ /^(\w+) (.*)/
-
-      params = {}
-      $2.gsub(/(\w+)="(.*?)"/) { params[$1] = $2 }
-
-      cnonce = Digest::MD5.hexdigest "%x" % (Time.now.to_i + rand(65535))
-
-      digest = calculate_digest(
-        user, password, params['realm'], params['nonce'], method, uri.request_uri, params['qop'], cnonce, nc
-      )
-
-      header = [
-        %Q(Digest username="#{user}"),
-        %Q(realm="#{params['realm']}"),
-        %Q(qop="#{params['qop']}"),
-        %Q(uri="#{uri.request_uri}"),
-        %Q(nonce="#{params['nonce']}"),
-        %Q(nc=#{('%08x' % nc)}),
-        %Q(cnonce="#{cnonce}"),
-        %Q(response="#{digest}"),
-        %Q(opaque="#{params['opaque']}"),
-      ]
-
-      header.join(", ")
-    end
-
-    def calculate_digest(user, password, realm, nonce, method, uri, qop, cnonce, nc)
-      a1 = Digest::MD5.hexdigest "#{user}:#{realm}:#{password}"
-      a2 = Digest::MD5.hexdigest "#{method}:#{uri}"
-
-      if qop
-        Digest::MD5.hexdigest("#{a1}:#{nonce}:#{'%08x' % nc}:#{cnonce}:#{qop}:#{a2}")
-      else
-        Digest::MD5.hexdigest("#{a1}:#{nonce}:#{a2}")
-      end
-    end
-
-    def calculate_user_agent_digest(product, user_agent_password, rets_request_id, session_id, version)
-      a1 = Digest::MD5.hexdigest "#{product}:#{user_agent_password}"
-
-      Digest::MD5.hexdigest "#{a1}:#{rets_request_id}:#{session_id}:#{version}"
-    end
-
-    def build_user_agent_auth(*args)
-      %Q(Digest #{calculate_user_agent_digest(*args)})
-    end
-
-  end
-end