rets 0.1.7 → 0.2.0

data/CHANGELOG.md

@@ -1,4 +1,8 @@
-### 0.1.6 / 2012-04-05
+### 0.2.0 / 2012-04-20
+
+* feature: Ruby 1.9 compatibility!
+
+### 0.1.7 / 2012-04-05
 
 * feature: key_field lookup for resources
 

data/README.md

@@ -4,6 +4,7 @@
 
 ## DESCRIPTION:
 
+[![Build Status](https://secure.travis-ci.org/estately/rets.png?branch=master)](http://travis-ci.org/estately/rets)
 A pure-ruby library for fetching data from [RETS] servers.
 
 [RETS]: http://www.rets.org

data/Rakefile

@@ -2,15 +2,15 @@ require 'rubygems'
 require 'hoe'
 
 Hoe.plugin :git, :doofus
+Hoe.plugin :travis
 
 Hoe.spec 'rets' do
   developer 'Estately, Inc. Open Source', 'opensource@estately.com'
-  developer 'Ben Bleything',              'ben@bleything.net'
 
   extra_deps << [ "net-http-persistent", "~> 1.7" ]
-  extra_deps << [ "nokogiri",            "~> 1.4.4" ]
+  extra_deps << [ "nokogiri",            "~> 1.5.2" ]
 
-  extra_dev_deps << [ "mocha", "~> 0.9.12" ]
+  extra_dev_deps << [ "mocha", "~> 0.11.0" ]
 
   ### Use markdown for changelog and readme
   self.history_file = 'CHANGELOG.md'

data/lib/rets.rb

@@ -8,7 +8,7 @@ require 'net/http/persistent'
 require 'nokogiri'
 
 module Rets
-  VERSION = '0.1.7'
+  VERSION = '0.2.0'
 
   AuthorizationFailure = Class.new(ArgumentError)
   InvalidRequest       = Class.new(ArgumentError)

data/lib/rets/client.rb

@@ -160,7 +160,7 @@ module Rets
       content_type = response["content-type"]
 
       if content_type.include?("multipart")
-        boundary = content_type.scan(/boundary="?([^;"]*)?/).to_s
+        boundary = content_type.scan(/boundary="?([^;"]*)?/).join
 
         parts = Parser::Multipart.parse(response.body, boundary)
 
@@ -336,7 +336,7 @@ module Rets
     def cookies=(cookies)
       @cookies ||= {}
 
-      cookies.each do |cookie|
+      Array(cookies).each do |cookie|
         cookie.match(/(\S+)=([^;]+);?/)
 
         @cookies[$1] = $2
@@ -385,7 +385,7 @@ module Rets
 
       begin
         capability_uri = URI.parse(url)
-      rescue URI::InvalidURIError => e
+      rescue URI::InvalidURIError
         raise MalformedResponse, "Unable to parse capability URL: #{url.inspect}"
       end
 
@@ -395,15 +395,15 @@ module Rets
     def extract_capabilities(document)
       raw_key_values = document.xpath("/RETS/RETS-RESPONSE").text.strip
 
-      h = Hash.new{|h,k| h.key?(k.downcase) ? h[k.downcase] : nil }
+      hash = Hash.new{|h,k| h.key?(k.downcase) ? h[k.downcase] : nil }
 
       # ... :(
       # Feel free to make this better. It has a test.
       raw_key_values.split(/\n/).
         map  { |r| r.split(/=/, 2) }.
-        each { |k,v| h[k.strip.downcase] = v.strip }
+        each { |k,v| hash[k.strip.downcase] = v.strip }
 
-      h
+      hash
     end
 
 
@@ -503,7 +503,7 @@ module Rets
             end
           end
 
-        rescue Nokogiri::XML::SyntaxError => e
+        rescue Nokogiri::XML::SyntaxError
           #Not xml
         end
       end

data/lib/rets/metadata/root.rb

@@ -147,7 +147,11 @@ module Rets
         class_name = type.capitalize.gsub(/_(\w)/) { $1.upcase }
         container_name = "#{class_name}Container"
 
-        container_class = Containers.constants.include?(container_name) ? Containers.const_get(container_name) : Containers::Container
+        if ::RUBY_VERSION < '1.9'
+          container_class = Containers.const_defined?(container_name) ? Containers.const_get(container_name) : Containers::Container
+        else
+          container_class = Containers.const_defined?(container_name, true) ? Containers.const_get(container_name, true) : Containers::Container
+        end
         container_class.new(fragment)
       end
     end

data/lib/rets/metadata/table.rb

@@ -81,21 +81,21 @@ module Rets
 
         values = multi? ? value.split(","): [value]
 
-        values = values.map do |value|
+        values = values.map do |v|
 
           #Remove surrounding quotes
-          value  = value.scan(/^["']?(.*?)["']?$/).to_s
+          clean_value  = v.scan(/^["']?(.*?)["']?$/).join
 
-          lookup_type = lookup_type(value)
+          lookup_type = lookup_type(clean_value)
 
           resolved_value = lookup_type ? lookup_type.long_value : nil
 
-          warn("Discarding unmappable value of #{value.inspect}") if resolved_value.nil? && $VERBOSE
+          warn("Discarding unmappable value of #{clean_value.inspect}") if resolved_value.nil? && $VERBOSE
 
           resolved_value
         end
 
-        multi? ? values.map {|value| value.to_s.strip } : values.first.to_s.strip
+        multi? ? values.map {|v| v.to_s.strip } : values.first.to_s.strip
       end
     end
   end

data/test/test_metadata.rb

@@ -193,7 +193,7 @@ class TestMetadata < Test::Unit::TestCase
     Rets::Metadata::Resource.expects(:find_rets_classes).with(metadata, resource).returns([rets_class_fragment])
 
     classes = Rets::Metadata::Resource.build_classes(resource, metadata)
-    assert([rets_class], classes)
+    assert_equal([rets_class], classes)
   end
 
   def test_resource_build

metadata

@@ -1,22 +1,21 @@
 --- !ruby/object:Gem::Specification 
 name: rets
 version: !ruby/object:Gem::Version 
-  hash: 21
+  hash: 23
   prerelease: 
   segments: 
   - 0
-  - 1
-  - 7
-  version: 0.1.7
+  - 2
+  - 0
+  version: 0.2.0
 platform: ruby
 authors: 
 - Estately, Inc. Open Source
-- Ben Bleything
 autorequire: 
 bindir: bin
 cert_chain: []
 
-date: 2012-04-06 00:00:00 Z
+date: 2012-04-23 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: net-http-persistent
@@ -41,43 +40,43 @@ dependencies:
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        hash: 15
+        hash: 7
         segments: 
         - 1
-        - 4
-        - 4
-        version: 1.4.4
+        - 5
+        - 2
+        version: 1.5.2
   type: :runtime
   version_requirements: *id002
 - !ruby/object:Gem::Dependency 
-  name: mocha
+  name: rdoc
   prerelease: false
   requirement: &id003 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        hash: 35
+        hash: 19
         segments: 
-        - 0
-        - 9
-        - 12
-        version: 0.9.12
+        - 3
+        - 10
+        version: "3.10"
   type: :development
   version_requirements: *id003
 - !ruby/object:Gem::Dependency 
-  name: rdoc
+  name: mocha
   prerelease: false
   requirement: &id004 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        hash: 19
+        hash: 51
         segments: 
-        - 3
-        - 10
-        version: "3.10"
+        - 0
+        - 11
+        - 0
+        version: 0.11.0
   type: :development
   version_requirements: *id004
 - !ruby/object:Gem::Dependency 
@@ -88,20 +87,20 @@ dependencies:
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        hash: 25
+        hash: 7
         segments: 
-        - 2
-        - 13
-        version: "2.13"
+        - 3
+        - 0
+        version: "3.0"
   type: :development
   version_requirements: *id005
 description: |-
+  [![Build Status](https://secure.travis-ci.org/estately/rets.png?branch=master)](http://travis-ci.org/estately/rets)
   A pure-ruby library for fetching data from [RETS] servers.
   
   [RETS]: http://www.rets.org
 email: 
 - opensource@estately.com
-- ben@bleything.net
 executables: 
 - rets
 extensions: []
@@ -163,10 +162,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: rets
-rubygems_version: 1.8.15
+rubygems_version: 1.8.23
 signing_key: 
 specification_version: 3
-summary: A pure-ruby library for fetching data from [RETS] servers
+summary: "[![Build Status](https://secure.travis-ci.org/estately/rets.png?branch=master)](http://travis-ci.org/estately/rets) A pure-ruby library for fetching data from [RETS] servers"
 test_files: 
 - test/test_client.rb
 - test/test_metadata.rb