rets 0.1.0 → 0.1.1

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+### 0.1.1 / 2012-01-11
+
+* bugfix - prevent infinite loop in login
+
 # rets Changelog
 
 ### 0.1.0 / 2011-06-23

data/lib/rets.rb

@@ -8,7 +8,7 @@ require 'net/http/persistent'
 require 'nokogiri'
 
 module Rets
-  VERSION = '0.1.0'
+  VERSION = '0.1.1'
 
   AuthorizationFailure = Class.new(ArgumentError)
   InvalidRequest       = Class.new(ArgumentError)

data/lib/rets/client.rb

@@ -34,7 +34,8 @@ module Rets
     # RETS server provides, per http://retsdoc.onconfluence.com/display/rets172/4.10+Capability+URL+List.
     def login
       request(uri.path)
-      capabilities
+      raise UnknownResponse, "Cannot read rets server capabilities." unless @capabilities
+      @capabilities
     end
 
     # Finds records.
@@ -382,7 +383,7 @@ module Rets
       # Feel free to make this better. It has a test.
       raw_key_values.split(/\n/).
         map  { |r| r.split(/=/, 2) }.
-        each { |k,v| h[k.strip.downcase] = v }
+        each { |k,v| h[k.strip.downcase] = v.strip }
 
       h
     end

data/test/fixtures.rb

@@ -21,6 +21,14 @@ CAPABILITIES = <<-XML
 </RETS>
 XML
 
+CAPABILITIES_WITH_WHITESPACE = <<XML
+<RETS ReplyCode="0" ReplyText="Operation Successful">
+<RETS-RESPONSE>
+Action = /RETS/Action
+</RETS-RESPONSE>
+</RETS>
+XML
+
 # 44 is the ASCII code for comma; an invalid delimiter.
 INVALID_DELIMETER = <<-XML
 <?xml version="1.0"?>

data/test/test_client.rb

@@ -181,6 +181,13 @@ class TestClient < Test::Unit::TestCase
     )
   end
 
+  def test_extract_capabilities_with_whitespace
+    assert_equal(
+      {"action" => "/RETS/Action"},
+      @client.extract_capabilities(Nokogiri.parse(CAPABILITIES_WITH_WHITESPACE))
+    )
+  end
+
   def test_capability_url_returns_parsed_url
     @client.capabilities = { "foo" => "http://example.com" }
 
@@ -200,6 +207,12 @@ class TestClient < Test::Unit::TestCase
     @client.capabilities
   end
 
+  def test_login_fails_if_cannot_read_capabilities
+    @client.stubs(:request)
+    assert_raise Rets::UnknownResponse do
+      @client.login
+    end
+  end
 
   def test_cookies?
     assert @client.cookies?({"set-cookie" => "FavoriteFruit=Plum;"})

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: rets
 version: !ruby/object:Gem::Version 
-  hash: 27
+  hash: 25
   prerelease: 
   segments: 
   - 0
   - 1
-  - 0
-  version: 0.1.0
+  - 1
+  version: 0.1.1
 platform: ruby
 authors: 
 - Estately, Inc. Open Source
@@ -16,8 +16,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-06-23 00:00:00 -07:00
-default_executable: 
+date: 2012-01-11 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: net-http-persistent
@@ -67,21 +66,35 @@ dependencies:
   type: :development
   version_requirements: *id003
 - !ruby/object:Gem::Dependency 
-  name: hoe
+  name: rdoc
   prerelease: false
   requirement: &id004 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
-    - - ">="
+    - - ~>
       - !ruby/object:Gem::Version 
-        hash: 41
+        hash: 19
         segments: 
-        - 2
-        - 9
-        - 1
-        version: 2.9.1
+        - 3
+        - 10
+        version: "3.10"
   type: :development
   version_requirements: *id004
+- !ruby/object:Gem::Dependency 
+  name: hoe
+  prerelease: false
+  requirement: &id005 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ~>
+      - !ruby/object:Gem::Version 
+        hash: 27
+        segments: 
+        - 2
+        - 12
+        version: "2.12"
+  type: :development
+  version_requirements: *id005
 description: |-
   A pure-ruby library for fetching data from [RETS] servers.
   
@@ -120,7 +133,6 @@ files:
 - test/test_parser_compact.rb
 - test/test_parser_multipart.rb
 - .gemtest
-has_rdoc: true
 homepage: http://github.com/estately/rets
 licenses: []
 
@@ -151,7 +163,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: rets
-rubygems_version: 1.4.2
+rubygems_version: 1.8.10
 signing_key: 
 specification_version: 3
 summary: A pure-ruby library for fetching data from [RETS] servers