retentiongrid 0.1.1 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fbab0954075794e4599bf99ff930dc0d804f208e
-  data.tar.gz: 11d8fe0f7624dd1fe4562519000100fdfa13ce31
+  metadata.gz: 8d0fa613d3babf6c177b1aac2f3ee7cd0fe7a1af
+  data.tar.gz: 625ee2cab1d11aacd52ba112ee8a206e1ffef971
 SHA512:
-  metadata.gz: 7366ec154355f36d1da8178ebf01aadc62ade1fda549f368b4ed343a5cd09d6edfda2e113f70610df12929ccc4fce8bc64f9eb3f161e79bb5341cb9ff67716ef
-  data.tar.gz: 46820483122f5e7a84a9a75ddde2c9a31c4102033a047780a166cd8f03ca7bb34c21a2371568cf17ef8fb9426eceef423b3a2fbf57a19a57e3ddfe367bfdda73
+  metadata.gz: 5aba78ecd284681abec3f5389656d0c4616f9e9d81475dc7212fd1a03998aa309640a789d7bfb969e3fe2ea66f295e77737f434364bd824c7fb172fd451b9e9f
+  data.tar.gz: 27025e4f718fc732c5467b8aef7d64d9fa4b6a89864cd072ba05c6a7b9c5c49db93a82e24ab4431217e013aca56c4262534c4f3d7a959205dc2703d7ff51f539

data/lib/retentiongrid/api.rb

@@ -34,7 +34,8 @@ module Retentiongrid
       def get_with_response_check(*args)
         check_response_codes(get_without_response_check(*args))
       end
-      alias_method_chain :get, :response_check
+      alias_method :get_without_response_check, :get
+      alias_method :get, :get_with_response_check
 
       # Do a HTTP POST requests with the given arguments
       # and then check for the response code.
@@ -46,7 +47,8 @@ module Retentiongrid
       def post_with_response_check(*args)
         check_response_codes(post_without_response_check(*args))
       end
-      alias_method_chain :post, :response_check
+      alias_method :post_without_response_check, :post
+      alias_method :post, :post_with_response_check
 
       # Do a HTTP DELETE requests with the given arguments
       # and then check for the response code.
@@ -58,7 +60,8 @@ module Retentiongrid
       def delete_with_response_check(*args)
         check_response_codes(delete_without_response_check(*args))
       end
-      alias_method_chain :delete, :response_check
+      alias_method :delete_without_response_check, :delete
+      alias_method :delete, :delete_with_response_check
 
     end
 

data/lib/retentiongrid/customer.rb

@@ -9,9 +9,8 @@ module Retentiongrid
   #   customer = Retentiongrid::Customer.find('C123')
   #
   class Customer < Resource
-    include ActiveModel::Validations
 
-    BASE_PATH = '/customers'
+    BASE_PATH = '/customers'.freeze
 
     # The set of attributes defined by the API documentation
     ATTRIBUTES_NAMES = [ :customer_id, :full_name, :first_name, :email,
@@ -22,8 +21,6 @@ module Retentiongrid
       attr_accessor attrib
     end
 
-    validates :customer_id, :full_name, presence: true
-
     # API Stuff here
 
     # Find a customer with given id

data/lib/retentiongrid/order.rb

@@ -8,9 +8,8 @@ module Retentiongrid
   #   order = Retentiongrid::Order.find('A123')
   #
   class Order < Resource
-    include ActiveModel::Validations
 
-    BASE_PATH = '/orders'
+    BASE_PATH = '/orders'.freeze
 
     # The set of attributes defined by the API documentation
     ATTRIBUTES_NAMES = [  :order_id, :customer_id, :status, :total_price, :total_discounts,
@@ -23,8 +22,6 @@ module Retentiongrid
 
     attr_accessor :customer
 
-    validates :order_id, :customer_id, :currency, :total_price, :order_created_at, presence: true
-
     def initialize(attribs={})
       super
       @order_created_at = Time.parse(order_created_at) unless order_created_at.nil?

data/lib/retentiongrid/product.rb

@@ -1,7 +1,7 @@
 module Retentiongrid
   class Product < Resource
 
-    BASE_PATH = '/products'
+    BASE_PATH = '/products'.freeze
 
     # The set of attributes defined by the API documentation
     ATTRIBUTES_NAMES = [  :product_id, :available, :metadata,

data/lib/retentiongrid/resource.rb

@@ -4,7 +4,6 @@ module Retentiongrid
   # Base class for all API resources.
   #
   class Resource
-    include ActiveModel::Validations
 
     ATTRIBUTES_NAMES = []
 
@@ -12,10 +11,6 @@ module Retentiongrid
       attr_accessor attrib
     end
 
-    def self.base_path
-      '/'
-    end
-
     def initialize(attribs={})
       attribs.each do |attrib, value|
         self.send("#{attrib}=", value)

data/lib/retentiongrid/version.rb

@@ -1,3 +1,3 @@
 module Retentiongrid
-  VERSION = "0.1.1"
+  VERSION = "0.2.0"
 end

data/lib/retentiongrid.rb

@@ -1,4 +1,3 @@
-require 'active_model'
 require 'retentiongrid/version'
 require 'retentiongrid/resource'
 require 'retentiongrid/api'

data/retentiongrid.gemspec

@@ -20,15 +20,12 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_dependency 'httparty', '0.13.1'
-  spec.add_dependency 'activemodel', '>=3.2.0'
-
 
   spec.add_development_dependency 'bundler', '~> 1.6'
   spec.add_development_dependency 'rake'
   spec.add_development_dependency 'yard'
 
   spec.add_development_dependency 'rspec'
-  spec.add_development_dependency 'shoulda-matchers'
   spec.add_development_dependency 'webmock'
   spec.add_development_dependency 'factory_girl'
 

data/spec/integration/customer_spec.rb

@@ -49,10 +49,6 @@ RSpec.describe Customer do
 
   context '#delete' do
 
-    subject do
-      FactoryGirl.build(:customer)
-    end
-
     before :each do
       stub_request(:delete, "http://retentiongrid.apiary-mock.com/customers/#{subject.customer_id}").to_return(:status => 204, :body => '')
     end

data/spec/integration/product_spec.rb

@@ -83,14 +83,6 @@ RSpec.describe Product do
 
   context '#delete' do
 
-    let :product do
-      FactoryGirl.build(:product)
-    end
-
-    subject do
-      FactoryGirl.build(:product)
-    end
-
     before :each do
       stub_request(:delete, "http://retentiongrid.apiary-mock.com/products/#{subject.product_id}").to_return(:status => 204, :body => '')
     end

data/spec/models/customer_spec.rb

@@ -6,10 +6,8 @@ RSpec.describe Customer do
     FactoryGirl.build(:customer)
   end
 
-  context "validations" do
-    it { expect(subject).to validate_presence_of :customer_id }
-    it { expect(subject).to validate_presence_of :full_name }
-    it { expect(subject).to be_valid }
+  it "sets the base path correctly" do
+    expect(Customer::BASE_PATH).to eql '/customers'
   end
 
   it "makes sure the customer id is populated" do

data/spec/models/order_spec.rb

@@ -10,13 +10,8 @@ RSpec.describe Order do
     FactoryGirl.build(:order, customer: customer)
   end
 
-  context "validations" do
-    it { expect(subject).to validate_presence_of :order_id }
-    it { expect(subject).to validate_presence_of :customer_id }
-    it { expect(subject).to validate_presence_of :currency }
-    it { expect(subject).to validate_presence_of :total_price }
-    it { expect(subject).to validate_presence_of :order_created_at }
-    it { expect(subject).to be_valid }
+  it "sets the base path correctly" do
+    expect(Order::BASE_PATH).to eql '/orders'
   end
 
   it "makes sure the order id is populated" do

data/spec/models/product_spec.rb

@@ -6,6 +6,10 @@ RSpec.describe Product do
     FactoryGirl.build(:product)
   end
 
+  it "sets the base path correctly" do
+    expect(Product::BASE_PATH).to eql '/products'
+  end
+
   it "makes sure the product id is populated" do
     expect(subject.product_id).to_not eql nil
   end

data/spec/spec_helper.rb

@@ -1,7 +1,6 @@
 require 'webmock/rspec'
 require 'factory_girl'
 require 'retentiongrid'
-require 'shoulda/matchers'
 
 require 'rspec'
 require 'coveralls'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: retentiongrid
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
 platform: ruby
 authors:
 - Christoph Bünte
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-09 00:00:00.000000000 Z
+date: 2014-10-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -24,20 +24,6 @@ dependencies:
     - - '='
       - !ruby/object:Gem::Version
         version: 0.13.1
-- !ruby/object:Gem::Dependency
-  name: activemodel
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 3.2.0
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 3.2.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -94,20 +80,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: shoulda-matchers
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement