resync 0.4.4 → 0.4.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8e70fce0b524e1decc437cb83c31ef62d4f90402
-  data.tar.gz: 442ae82605b8ab0b3c808baf19a64c20ae086a43
+  metadata.gz: 01d85ad76444c1c9ca87238aa1686209a9825da5
+  data.tar.gz: 3466a4b39cdc6d936801618a914bf634ff309ec8
 SHA512:
-  metadata.gz: 98e4a481281ef924edc259449cdb5c407016fcad35b0912ac18e65c7fe95e767092dcab010a53d85656a09e95fd619702858ebac68d3b2f97ea610af42f76628
-  data.tar.gz: 450a3df07cceafbf62ae9551efefcb0c4ced58d864facb3c17a33728f541e1208b9ae06b5fc32f2a92b70df53920177866de60ae96aeb8ae607bc13332efef93
+  metadata.gz: 495c569a83abee87a05294d23fd6aa7b8ff063c7c049d52d72c7e0bb5206dd1f04c60fe8c8b5b2370f4bc61d9c5ca32cbd16cd0cb3c6fdc2e603d654f8f743a1
+  data.tar.gz: 19cd0c3f93813e2b3435a4f2eac4f21ec418c1c547d911fd7545b5798f27e0357607b2294d30389a30ea37d6db97ad9d93b9a8d70c32330d58710f5f2a994dbd

data/.gitignore

@@ -19,7 +19,7 @@ mkmf.log
 
 *.gem
 
-# IntellJ
+# IntelliJ
 
 *.iml
 *.ipr
@@ -27,10 +27,56 @@ mkmf.log
 .rakeTasks
 .idea
 
-# Emacs
+# Mac OS
+
+.DS_Store
 
+#### joe made this: http://goel.io/joe
+
+#####=== Emacs ===#####
+# -*- mode: gitignore; -*-
 *~
+\#*\#
+/.emacs.desktop
+/.emacs.desktop.lock
+*.elc
+auto-save-list
+tramp
+.\#*
 
-# Mac OS
+# Org-mode
+.org-id-locations
+*_archive
+
+# flymake-mode
+*_flymake.*
+
+# eshell files
+/eshell/history
+/eshell/lastdir
+
+# elpa packages
+/elpa/
+
+# reftex files
+*.rel
+
+# AUCTeX auto folder
+/auto/
+
+# cask packages
+.cask/
+dist/
+
+# Flycheck
+flycheck_*.el
+
+# server auth directory
+/server/
+
+# projectiles files
+.projectile
+
+# directory configuration
+.dir-locals.el
 
-.DS_Store

data/.rubocop.yml

@@ -21,3 +21,8 @@ Style/EmptyLinesAroundBlockBody:
 # Suppress complaints about post-2.0 syntax
 AllCops:
   TargetRubyVersion: 2.2
+
+# Make our own decisions about readability
+Style/TernaryParentheses:
+  Enabled: false
+

data/.ruby-version

@@ -1 +1 @@
-2.2.2
+2.2.5

data/CHANGES.md

@@ -1,3 +1,13 @@
+## 0.4.6 (next)
+
+## 0.4.5 (27 April 2017)
+
+- Update to Ruby 2.2.5
+- Update to XML::MappingExtensions 0.4.8
+- Update to MIME::Types 3.x
+- Update to RuboCop 0.47
+- Allow Rake versions > 10.x
+
 ## 0.4.4 (28 April 2016)
 
 - Update to XML::MappingExtensions 0.3.5

data/Rakefile

@@ -8,18 +8,18 @@ namespace :spec do
 
   desc 'Run all unit tests'
   RSpec::Core::RakeTask.new(:unit) do |task|
-    task.rspec_opts = %w(--color --format documentation --order default)
+    task.rspec_opts = %w[--color --format documentation --order default]
     task.pattern = 'unit/**/*_spec.rb'
   end
 
   desc 'Run all acceptance tests'
   RSpec::Core::RakeTask.new(:acceptance) do |task|
     ENV['COVERAGE'] = nil
-    task.rspec_opts = %w(--color --format documentation --order default)
+    task.rspec_opts = %w[--color --format documentation --order default]
     task.pattern = 'acceptance/**/*_spec.rb'
   end
 
-  task all: [:unit, :acceptance]
+  task all: %i[unit acceptance]
 end
 
 desc 'Run all tests'
@@ -45,7 +45,7 @@ RuboCop::RakeTask.new
 
 desc 'List TODOs (from spec/todo.rb)'
 RSpec::Core::RakeTask.new(:todo) do |task|
-  task.rspec_opts = %w(--color --format documentation --order default)
+  task.rspec_opts = %w[--color --format documentation --order default]
   task.pattern = 'todo.rb'
 end
 

data/lib/resync/capability_list.rb

@@ -69,8 +69,8 @@ module Resync
       capabilities = {}
       (resources || []).each do |resource|
         capability = resource.capability
-        fail ArgumentError, "No capability found for resource with URI #{resource.uri}" unless capability
-        fail ArgumentError, "Duplicate resource for capability #{capability}" if capabilities.key?(capability)
+        raise ArgumentError, "No capability found for resource with URI #{resource.uri}" unless capability
+        raise ArgumentError, "Duplicate resource for capability #{capability}" if capabilities.key?(capability)
         capabilities[capability] = resource
       end
       capabilities
@@ -79,7 +79,7 @@ module Resync
     def source_description_from(links)
       return nil unless links
       desc = links.map { |link| link.uri if link.rel == 'up' }.compact.first
-      fail ArgumentError, "No source descrption (<link rel='up'/>) provided" unless desc
+      raise ArgumentError, "No source descrption (<link rel='up'/>) provided" unless desc
       desc
     end
   end

data/lib/resync/link.rb

@@ -51,7 +51,7 @@ module Resync
     # @param path [String] For +ResourceDumpManifests+ and +ChangeDumpManifests+,
     #   the path to the referenced resource within the dump ZIP file.
     # @raise [URI::InvalidURIError] if +uri+ cannot be converted to a URI.
-    def initialize( # rubocop:disable Metrics/MethodLength, Metrics/ParameterLists
+    def initialize( # rubocop:disable Metrics/ParameterLists
         rel:,
         uri:,
 

data/lib/resync/metadata.rb

@@ -63,7 +63,7 @@ module Resync
     # @param capability [String] identifies the type of a ResourceSync document.
     # @param path [String] For +ResourceDumpManifests+ and +ChangeDumpManifests+,
     #   the path to the referenced resource within the dump ZIP file.
-    def initialize( # rubocop:disable Metrics/MethodLength, Metrics/ParameterLists
+    def initialize( # rubocop:disable Metrics/ParameterLists
         at_time: nil,
         from_time: nil,
         until_time: nil,

data/lib/resync/resource.rb

@@ -30,7 +30,7 @@ module Resync
     #   and 1.0 is the highest.
     # @param links [Array<Link>] related links (i.e. +<rs:ln>+).
     # @param metadata [Metadata] metadata about this resource.
-    def initialize( # rubocop:disable Metrics/MethodLength, Metrics/ParameterLists
+    def initialize( # rubocop:disable Metrics/ParameterLists
         uri:,
         modified_time: nil,
         changefreq: nil,

data/lib/resync/shared/base_change_index.rb

@@ -29,7 +29,7 @@ module Resync
     end
 
     def loosely(in_range, resource)
-      (resource.from_time || resource.until_time) ? strictly(in_range, resource) : true
+      resource.from_time || resource.until_time ? strictly(in_range, resource) : true
     end
   end
 end

data/lib/resync/shared/base_resource_list.rb

@@ -118,10 +118,10 @@ module Resync
     # @raise [ArgumentError] if the specified metadata does not have the correct +capability+ attribute for this list type.
     def metadata_with_correct_capability(metadata)
       capability = self.class::CAPABILITY
-      fail ArgumentError, "Missing constant #{self.class}::CAPABILITY" unless capability
+      raise ArgumentError, "Missing constant #{self.class}::CAPABILITY" unless capability
       return Metadata.new(capability: capability) unless metadata
-      fail ArgumentError, ":metadata argument <#{metadata}> does not appear to be metadata" unless metadata.respond_to?(:capability)
-      fail ArgumentError, "Wrong capability for #{self.class.name} metadata; expected '#{capability}', was '#{metadata.capability}'" unless metadata.capability == capability
+      raise ArgumentError, ":metadata argument <#{metadata}> does not appear to be metadata" unless metadata.respond_to?(:capability)
+      raise ArgumentError, "Wrong capability for #{self.class.name} metadata; expected '#{capability}', was '#{metadata.capability}'" unless metadata.capability == capability
       metadata
     end
 

data/lib/resync/shared/descriptor.rb

@@ -49,7 +49,7 @@ module Resync
     #   to hex-encoded digest values.
     # @param path [String] For +ResourceDumpManifests+ and +ChangeDumpManifests+,
     #   the path to the referenced resource within the dump ZIP file.
-    def initialize( # rubocop:disable Metrics/MethodLength, Metrics/ParameterLists
+    def initialize( # rubocop:disable Metrics/ParameterLists
         modified_time: nil,
         length: nil,
         mime_type: nil,
@@ -113,12 +113,12 @@ module Resync
     # Parameter validators
 
     def time_or_nil(time)
-      fail ArgumentError, "time #{time} is not a Time" if time && !time.is_a?(Time)
+      raise ArgumentError, "time #{time} is not a Time" if time && !time.is_a?(Time)
       time
     end
 
     def natural_number_or_nil(value)
-      fail ArgumentError, "value #{value} must be a non-negative integer" if value && (!value.is_a?(Integer) || value < 0)
+      raise ArgumentError, "value #{value} must be a non-negative integer" if value && (!value.is_a?(Integer) || value < 0)
       value
     end
 

data/lib/resync/shared/sorted_resource_list.rb

@@ -53,14 +53,11 @@ module Resync
     end
 
     def compare(left, right)
-      [:modified_time, :from_time, :at_time, :until_time, :completed_time].each do |time_reader|
+      %i[modified_time from_time at_time until_time completed_time].each do |time_reader|
         left_time = left.send(time_reader)
         right_time = right.send(time_reader)
-        if left_time && right_time
-          return left_time <=> right_time
-        elsif left_time || right_time
-          return left_time ? -1 : 1
-        end
+        return left_time <=> right_time if left_time && right_time
+        return left_time ? -1 : 1 if left_time || right_time
       end
       0
     end

data/lib/resync/types/change.rb

@@ -5,7 +5,7 @@ module Resync
     # The type of change indicated by a reference in a {ChangeList}, {ChangeDump}, etc.
     # Values: +CREATED+, +UPDATED+, +DELETED+
     class Change < TypesafeEnum::Base
-      [:CREATED, :UPDATED, :DELETED].each { |c| new c }
+      %i[CREATED UPDATED DELETED].each { |c| new c }
     end
   end
 end

data/lib/resync/types/change_frequency.rb

@@ -5,7 +5,7 @@ module Resync
     # The frequency of changes to a resource.
     # Values: +ALWAYS+, +HOURLY+, +DAILY+, +WEEKLY+, +MONTHLY+, +YEARLY+, +NEVER+
     class ChangeFrequency < TypesafeEnum::Base
-      [:ALWAYS, :HOURLY, :DAILY, :WEEKLY, :MONTHLY, :YEARLY, :NEVER].each { |cf| new cf }
+      %i[ALWAYS HOURLY DAILY WEEKLY MONTHLY YEARLY NEVER].each { |cf| new cf }
     end
   end
 end

data/lib/resync/version.rb

@@ -1,4 +1,4 @@
 module Resync
   # The version of this gem.
-  VERSION = '0.4.4'.freeze
+  VERSION = '0.4.5'.freeze
 end

data/lib/resync/xml.rb

@@ -37,7 +37,7 @@ module Resync
       when REXML::Element
         xml
       else
-        fail ArgumentError, "Unexpected argument type; expected XML document, String, or IO source, was #{xml.class}" unless can_parse(xml)
+        raise ArgumentError, "Unexpected argument type; expected XML document, String, or IO source, was #{xml.class}" unless can_parse(xml)
         REXML::Document.new(xml).root
       end
     end

data/lib/resync/xml_parser.rb

@@ -42,7 +42,7 @@ module Resync
     def self.find_root_type(types, root_element)
       capability = capability_for(root_element)
       root_type = types.find { |t| t::CAPABILITY == capability }
-      fail ArgumentError, "no mapped type for capability '#{capability}'" unless root_type
+      raise ArgumentError, "no mapped type for capability '#{capability}'" unless root_type
       root_type
     end
 
@@ -50,7 +50,7 @@ module Resync
 
     def self.capability_for(root_element)
       capability = capability_attribute_for(root_element).value
-      fail ArgumentError, "unable to identify capability of root element in #{root_element}" unless capability
+      raise ArgumentError, "unable to identify capability of root element in #{root_element}" unless capability
       capability
     end
 
@@ -58,7 +58,7 @@ module Resync
 
     def self.capability_attribute_for(root_element)
       capability_attr = REXML::XPath.first(root_element, CAPABILITY_ATTRIBUTE)
-      fail ArgumentError, "unable to identify capability of root element in #{root_element}" unless capability_attr
+      raise ArgumentError, "unable to identify capability of root element in #{root_element}" unless capability_attr
       capability_attr
     end