resubject 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9622a9c1f2e6e745fb007dfb4c5171feefaafcf1
-  data.tar.gz: 31a1819fdd559781b98612dfaf2f336a46d4bc31
+  metadata.gz: 5af4c75bfa632e18875bdb64492fa3a7454020d5
+  data.tar.gz: baa37ace997ee7b47ab2cdd1ebb6fcace4c049c5
 SHA512:
-  metadata.gz: 58bdd1ed48e037f0b4774baf8cbe264f4274c4ffbf00658a4adafba2857f1bfb86877d4435322afca3e4f3cb02c73ac3f2d52912a4848fab7a1b2f2a12fe8a65
-  data.tar.gz: caa9e377c606d3512ade4ec8fa23d3a3aad78ae534cc34dc073b97c77d06c71056c9c525cc6150472313409df300928012c33d57a682cf503864365720daace0
+  metadata.gz: 0ded2dd3031e370ed25f9d67c5b3512eba510d0bbcd3da2b77a277860d2d3556afc9cf8d68a0a66892ed392035572e2d0025e781e74ef538783c012e9787e7c5
+  data.tar.gz: 5f169109e23e0169dfbc514eccc5abe8dd545833271f693b3a2bf1bc86deb2b621e5fb2add954063e45629cae5f2adb3c76cf87d75c8a3a87fede2b9b9d11665

data/.rubocop.yml

@@ -0,0 +1,28 @@
+Metrics/AbcSize:
+  Max: 20
+
+Metrics/BlockLength:
+  Exclude:
+    - 'spec/**/*'
+    - 'test/**/*'
+
+Metrics/LineLength:
+  Max: 103
+
+Metrics/MethodLength:
+  Max: 15
+  Exclude:
+    - 'spec/**/*'
+    - 'test/**/*'
+
+Style/AsciiComments:
+  Enabled: false
+
+Style/Documentation:
+  Exclude:
+    - 'spec/**/*'
+    - 'test/**/*'
+    - 'lib/resubject/builder.rb'
+    - 'lib/resubject/naming.rb'
+    - 'lib/resubject/presenter.rb'
+    - 'lib/resubject/rails.rb'

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+# 0.2.2
+- rubocop style changes
+
 # 0.2.1
 - update yard and nokogiri due to security vulnerabilities (only on dev environment)
 

data/Gemfile

@@ -5,8 +5,9 @@ source 'https://rubygems.org'
 rails_version = ENV['rails']
 gem 'actionpack', "~> #{rails_version}"
 
-gem 'redcarpet'
-gem 'rake', '< 11.0'
 gem 'nokogiri', '~> 1.8'
+gem 'rake', '< 11.0'
+gem 'redcarpet'
+gem 'rubocop'
 # Specify your gem's dependencies in resubject.gemspec
 gemspec

data/README.md

@@ -11,7 +11,7 @@ Uber simple presenters using Ruby's SimpleDelegator.
 Add this line to your application's Gemfile:
 
 ```ruby
-gem 'resubject', '~> 0.2.1'
+gem 'resubject', '~> 0.2.2'
 ```
 
 And then execute:

data/Rakefile

@@ -3,11 +3,11 @@ require 'rspec/core/rake_task'
 require 'yard'
 
 desc 'Default: run specs.'
-task :default => :spec
+task default: :spec
 
 desc 'Run all specs'
 RSpec::Core::RakeTask.new(:spec)
 
 YARD::Rake::YardocTask.new do |t|
-  t.files   = ['lib/**/*.rb']
+  t.files = ['lib/**/*.rb']
 end

data/lib/resubject/builder.rb

@@ -69,7 +69,7 @@ module Resubject
       presenters = [Naming.presenter_for(object)] unless presenters.any?
 
       unless presenters.all? { |p| p.is_a?(Class) && p.ancestors.include?(Resubject::Presenter) }
-        raise InvalidPresenterArgument.new("Expected a presenter in #{presenters.inspect}")
+        raise InvalidPresenterArgument, "Expected a presenter in #{presenters.inspect}"
       end
 
       presenters.inject(object) do |presented, klass|

data/lib/resubject/extensions/template_methods.rb

@@ -47,7 +47,7 @@ module Resubject
       # @param [Symbol] attribute the name of the attribute to be generated
       # @see http://apidock.com/rails/ActionView/Helpers/DateHelper/time_ago_in_words
       def time_ago(attribute, include_seconds = false)
-        if Gem::Version.new(ActiveSupport::VERSION::STRING) < Gem::Version.new("4")
+        if Gem::Version.new(ActiveSupport::VERSION::STRING) < Gem::Version.new('4')
           define_method attribute do
             return if to_model.send(attribute).nil?
             template.time_ago_in_words to_model.send(attribute), include_seconds

data/lib/resubject/naming.rb

@@ -15,13 +15,13 @@ module Resubject
     # @return [Presenter] the related presenter class based on the object
     def self.presenter_for(presentable)
       klass = case presentable
-        when Symbol
-          presentable.to_s
-        when String
-          presentable
-        else
-          presentable.class.to_s
-        end
+              when Symbol
+                presentable.to_s
+              when String
+                presentable
+              else
+                presentable.class.to_s
+              end
 
       presenter = "#{klass.camelize}Presenter"
 

data/lib/resubject/presenter.rb

@@ -5,8 +5,8 @@ module Resubject
     extend Resubject::Extensions::TemplateMethods
 
     # the HTML helpers context
-    attr_reader  :context
-    alias_method :template, :context
+    attr_reader :context
+    alias template context
 
     # Create a new presenter
     #
@@ -23,7 +23,7 @@ module Resubject
       super(model)
     end
 
-    alias_method :to_model, :__getobj__
+    alias to_model __getobj__
 
     # Builds a collection of presenters given an array of objects
     #
@@ -84,24 +84,24 @@ module Resubject
       end
     end
 
-  private
+    private
 
     def translate(*args, &block)
       context.t(*args, &block)
     end
 
-    alias_method :t, :translate
+    alias t translate
 
     def localize(*args, &block)
       context.l(*args, &block)
     end
 
-    alias_method :l, :localize
+    alias l localize
 
     def helpers
       context
     end
 
-    alias_method :h, :helpers
+    alias h helpers
   end
 end

data/lib/resubject/rails.rb

@@ -8,6 +8,6 @@ module Resubject
       ::Rails.application.routes.url_helpers
     end
 
-    alias_method :r, :routes
+    alias r routes
   end
 end

data/lib/resubject/rails/engine.rb

@@ -1,6 +1,6 @@
 module Resubject
   class Engine < ::Rails::Engine #:nodoc:
-    initializer "resubject.helpers" do
+    initializer 'resubject.helpers' do
       ActiveSupport.on_load(:action_controller) do
         require 'resubject/rails/helpers'
         include Resubject::Helpers

data/lib/resubject/rails/helpers.rb

@@ -14,9 +14,7 @@ module Resubject
       presenters = Builder.present(objects, view_context, *presenters)
 
       presenters.tap do |p|
-        if block_given?
-          yield p
-        end
+        yield p if block_given?
       end
     end
   end

data/lib/resubject/rspec.rb

@@ -46,13 +46,13 @@ module Resubject
 end
 
 ::RSpec.configure do |c|
-  if ::RSpec::Core::Version::STRING.split(".").first.to_i >= 3
+  if ::RSpec::Core::Version::STRING.split('.').first.to_i >= 3
     c.include Resubject::Rspec,
-      type: :presenter,
-      file_path: %r(spec/presenters)
+              type: :presenter,
+              file_path: %r{spec/presenters}
   else
     c.include Resubject::Rspec,
-      type: :presenter,
-      example_group: { file_path: %r(spec/presenters) }
+              type: :presenter,
+              example_group: { file_path: %r{spec/presenters} }
   end
 end

data/lib/resubject/version.rb

@@ -1,3 +1,3 @@
 module Resubject
-  VERSION = "0.2.1"
+  VERSION = '0.2.2'.freeze
 end

data/resubject.gemspec

@@ -1,26 +1,26 @@
-# -*- encoding: utf-8 -*-
+
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'resubject/version'
 
 Gem::Specification.new do |gem|
-  gem.name          = "resubject"
+  gem.name          = 'resubject'
   gem.version       = Resubject::VERSION
-  gem.authors       = ["Felipe Elias Philipp", "Piotr Jakubowski"]
-  gem.email         = ["felipe@applicake.com", "piotr.jakubowski@applicake.com"]
-  gem.description   = %q{Uber simple presenters}
-  gem.summary       = %q{Uber simple presenters using Ruby's SimpleDelegator}
-  gem.homepage      = "https://github.com/felipeelias/resubject"
-  gem.license       = "MIT"
+  gem.authors       = ['Felipe Elias Philipp', 'Piotr Jakubowski']
+  gem.email         = ['felipe@applicake.com', 'piotr.jakubowski@applicake.com']
+  gem.description   = 'Uber simple presenters'
+  gem.summary       = "Uber simple presenters using Ruby's SimpleDelegator"
+  gem.homepage      = 'https://github.com/felipeelias/resubject'
+  gem.license       = 'MIT'
 
-  gem.files         = `git ls-files`.split($/)
-  gem.executables   = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
+  gem.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
+  gem.executables   = gem.files.grep(%r{^bin/}).map { |f| File.basename(f) }
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
-  gem.require_paths = ["lib"]
+  gem.require_paths = ['lib']
 
   gem.add_dependency 'activesupport', '>= 3.2'
 
-  gem.add_development_dependency "rake"
-  gem.add_development_dependency "rspec", "~> 2.12.0"
-  gem.add_development_dependency "yard", "~> 0.9"
+  gem.add_development_dependency 'rake'
+  gem.add_development_dependency 'rspec', '~> 2.12.0'
+  gem.add_development_dependency 'yard', '~> 0.9'
 end

data/spec/resubject/builder_spec.rb

@@ -28,12 +28,12 @@ describe Resubject::Builder do
     it 'presents the object with multiple classes' do
       OtherBoxPresenter.should_receive(:new).twice
       presenters = [OtherBoxPresenter, OtherBoxPresenter]
-      presented  = Resubject::Builder.present_one Box.new, template, *presenters
+      Resubject::Builder.present_one Box.new, template, *presenters
     end
 
     it 'raises an error if custom presenter is not a presenter' do
       expect do
-        Resubject::Builder.present_one Box.new, template, *[nil, Class.new]
+        Resubject::Builder.present_one Box.new, template, nil, Class.new
       end.to raise_error(Resubject::Builder::InvalidPresenterArgument)
     end
   end

data/spec/resubject/extensions/template_methods_spec.rb

@@ -20,14 +20,14 @@ describe Resubject::Presenter, 'template methods' do
   describe '.currency' do
     it 'returns currency format' do
       model.should_receive(:price).and_return(10.0)
-      expect(subject.price).to eq "$10.00"
+      expect(subject.price).to eq '$10.00'
     end
   end
 
   describe '.time_ago' do
     it 'returns time ago in words' do
       model.stub(:posted_at).and_return(Time.now - 60 * 60)
-      expect(subject.posted_at).to eq "about 1 hour"
+      expect(subject.posted_at).to eq 'about 1 hour'
     end
 
     it 'returns nothing if value is nil' do
@@ -39,14 +39,14 @@ describe Resubject::Presenter, 'template methods' do
   describe '.percentage' do
     it 'returns formatted percentage' do
       model.stub(:rating).and_return(95.123)
-      expect(subject.rating).to eq "95%"
+      expect(subject.rating).to eq '95%'
     end
   end
 
   describe '.date_format' do
     it 'returns formatted date' do
-      model.stub(:created_at).and_return(Time.at(1358082653).utc)
-      expect(subject.created_at).to eq "13 Jan 13:10"
+      model.stub(:created_at).and_return(Time.at(1_358_082_653).utc)
+      expect(subject.created_at).to eq '13 Jan 13:10'
     end
 
     it 'returns nothing if value is nil' do

data/spec/resubject/naming_spec.rb

@@ -28,7 +28,7 @@ describe Resubject::Naming do
     stub_const 'Namespaced', Class.new
     stub_const 'Namespaced::BoxPresenter', Class.new
 
-    presenter = Resubject::Naming.presenter_for "Namespaced::Box"
+    presenter = Resubject::Naming.presenter_for 'Namespaced::Box'
 
     expect(presenter).to eq Namespaced::BoxPresenter
   end

data/spec/resubject/presenter_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 describe Resubject::Presenter do
-  let(:object)   { mock :object }
+  let(:object) { mock :object }
 
   subject { Resubject::Presenter.new(object) }
 
@@ -49,19 +49,19 @@ describe Resubject::Presenter do
     end
 
     it 'generates a method preseting the attribute' do
-      box = stub :box, :item => Item.new
+      box = stub :box, item: Item.new
 
       expect(presenter.new(box).item).to be_a ItemPresenter
     end
 
     it 'does not attempt to find a class from nil' do
-      box = stub :box, :item => nil
+      box = stub :box, item: nil
 
       expect(presenter.new(box).item).to be_nil
     end
 
     it 'presents the attributes with custom presenter' do
-      box = stub :box, :other_item => stub
+      box = stub :box, other_item: stub
 
       expect(presenter.new(box).other_item).to be_a ItemPresenter
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: resubject
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - Felipe Elias Philipp
@@ -77,6 +77,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
 - ".travis.yml"
 - ".yardopts"
 - CHANGELOG.md