restpack_serializer 0.4.10 → 0.4.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2dfadef3b0cdb67cc4f5a4b659448218f230bcba
-  data.tar.gz: 5f83c011e2b01d6c539250e289661fde606d1d55
+  metadata.gz: 90d1438faf15f90e22381b152265374f8ad53543
+  data.tar.gz: 0fcbd12fbc3df348107fe579e5ea9e5103901529
 SHA512:
-  metadata.gz: b13cf34cf4f9e0a4cda766e356d6fc69e249eb9944de45f3ad5e489e9fda2f9506b377540f9a798782aa5cf230ecdaa5f966df884040b98b62afe5790689266d
-  data.tar.gz: 0d6c339987850df7d6a3e8dfe2a3e683eb2df3277878c0e98eaf613a0677f1da91eff1007bce939e9d8092d5ca976d9694143676209fd94f2406a682edc28492
+  metadata.gz: 0d4d76207155ad77ae9547c4f2439c9c6d5a7c8b9c5463aabf1d93e4d21d567c9e51169536a18f5619d407919b61c867bd754829e9095eea81dc2f67b166df04
+  data.tar.gz: 2900f4a1a0bbfe320d5daf0e5194a72d65f917a015b159253a8a5004007a52b1470fed900e9ba9abc9ea23bfce6b1ad69a934c5633b764893f35df6720ee75be

data/LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2013 Gavin Joyce
+Copyright (c) 2013-2014 Gavin Joyce
 Copyright (c) 2011-2012 José Valim & Yehuda Katz (https://github.com/rails-api/active_model_serializers/blob/master/MIT-LICENSE.txt)
 
 Permission is hereby granted, free of charge, to any person obtaining a copy of

data/README.md

@@ -9,7 +9,7 @@ restpack_serializer allows you to quickly provide a set of RESTful endpoints for
 
 ---
 
-* [An overview of RestPack](http://goo.gl/rGoIQ)
+* [An overview of RestPack](http://www.slideshare.net/gavinjoyce/taming-monolithic-monsters)
 * [JSON API](http://jsonapi.org/)
 
 ## Serialization
@@ -244,26 +244,28 @@ which yields:
             "type": "songs"
         }
     },
-    "artists": [
-        {
-            "id": "1",
-            "name": "Radiohead",
-            "website": "http://radiohead.com/",
-            "href": "/artists/1"
-        },
-        {
-            "id": "2",
-            "name": "Nick Cave & The Bad Seeds",
-            "website": "http://www.nickcave.com/",
-            "href": "/artists/2"
-        },
-        {
-            "id": "3",
-            "name": "John Frusciante",
-            "website": "http://johnfrusciante.com/",
-            "href": "/artists/3"
-        }
-    ]
+    "linked": {
+        "artists": [
+            {
+                "id": "1",
+                "name": "Radiohead",
+                "website": "http://radiohead.com/",
+                "href": "/artists/1"
+            },
+            {
+                "id": "2",
+                "name": "Nick Cave & The Bad Seeds",
+                "website": "http://www.nickcave.com/",
+                "href": "/artists/2"
+            },
+            {
+                "id": "3",
+                "name": "John Frusciante",
+                "website": "http://johnfrusciante.com/",
+                "href": "/artists/3"
+            }
+        ]
+    }
 }
 ```
 

data/lib/restpack_serializer/result.rb

@@ -11,23 +11,23 @@ module RestPack::Serializer
     def serialize
       result = {}
 
-      result[:meta] = @meta unless @meta.empty?
-      result[:links] = @links unless @links.empty?
-
       unless @resources.empty?
-        inject_to_many_links!
+        inject_has_many_links!
         result[@resources.keys.first] = @resources.values.first
 
         linked = @resources.except(@resources.keys.first)
         result[:linked] = linked unless linked.empty?
       end
 
+      result[:links] = @links unless @links.empty?
+      result[:meta] = @meta unless @meta.empty?
+
       result
     end
 
     private
 
-    def inject_to_many_links! #find and inject to_many links from related @resources
+    def inject_has_many_links!
       @resources.keys.each do |key|
         @resources[key].each do |item|
           if item[:links]
@@ -41,6 +41,7 @@ module RestPack::Serializer
                     linked_resource[:links] ||= {}
                     linked_resource[:links][key] ||= []
                     linked_resource[:links][key] << item[:id]
+                    linked_resource[:links][key].uniq!
                   end
                 end
               end

data/lib/restpack_serializer/version.rb

@@ -1,5 +1,5 @@
 module RestPack
   module Serializer
-    VERSION = '0.4.10'
+    VERSION = '0.4.11'
   end
 end

data/spec/result_spec.rb

@@ -36,15 +36,35 @@ describe RestPack::Serializer::Result do
         before do
           subject.resources[:albums] = [{ id: '1', name: 'AMOK'}]
           subject.resources[:songs] = [{ id: '91', name: 'Before Your Very Eyes...', links: { album: '1' }}]
+          subject.meta[:albums] = { count: 1 }
+          subject.meta[:songs] = { count: 1 }
           subject.links['albums.songs'] = { type: 'songs', href: '/api/v1/songs?album_id={albums.id}' }
           subject.links['songs.album'] = { type: 'albums', href: '/api/v1/albums/{songs.album}' }
         end
 
-        it 'returns correct jsonapi.org format, including injected to_many links' do
+        it 'returns correct jsonapi.org format, including injected has_many links' do
           result[:albums].should == [{ id: '1', name: 'AMOK', links: { songs: ['91'] } }]
           result[:links].should == subject.links
           result[:linked][:songs].should == subject.resources[:songs]
         end
+
+        it 'includes resources in correct order' do
+          result.keys[0].should == :albums
+          result.keys[1].should == :linked
+          result.keys[2].should == :links
+          result.keys[3].should == :meta
+        end
+
+        context 'with multiple calls to serialize' do
+          let(:result) do
+            subject.serialize
+            subject.serialize
+          end
+
+          it 'does not create duplicate has_many links' do
+            result[:albums].first[:links][:songs].count.should == 1
+          end
+        end
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: restpack_serializer
 version: !ruby/object:Gem::Version
-  version: 0.4.10
+  version: 0.4.11
 platform: ruby
 authors:
 - Gavin Joyce