restpack_account_service 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1bc43eb7e8751ef8c97bb4cd50943616524c1e64
-  data.tar.gz: 072c107cd0b80fd82a9332a5b72e91266f7fa86d
+  metadata.gz: 13434ac13f103eac8e0116648e6be345f052d383
+  data.tar.gz: 2f10acdedac8d08cd54d507f423c7e113b05edbe
 SHA512:
-  metadata.gz: ea2c3eeb8f36290e5a144255010e1ef218ba159f264db54e597dcd8fdb0de46f2b472f342678d5ffe84649ce80bddec0b1355d7e5b52ee9d4335f53923ec128a
-  data.tar.gz: 94a76cc6f9afdbcbb07961a2ce61f81562d86a639ca6fc944c3ae4dd6f751d89fdf49b7d5c5f1634050164e8e1c9cf7ccca2d83617bda1b3a521b9d036149b69
+  metadata.gz: 17e69aec099da18f9d332bc35ae32ff50f9bc3ed4715a63ed8a3c3a9c75c230ff72e7054be648e73a948f6e5bb71dd2fc7755e0095f74a68ad2fa5e8800be8be
+  data.tar.gz: bfdcd34bdcdc07ce1b132509e9df41587f9fef41242404bf193d48bea3e9f4d2b300353bbbf39fdd59c4ed44400ef662b13b79fe4b433ae253c3093d53dddae1

data/Rakefile

@@ -1,2 +1,2 @@
-require "restpack_gem"
+require 'restpack_gem'
 RestPack::Gem::Tasks.load_service_tasks

data/db/migrate/{20130919115210_create_accounts.rb → 20130919115211_create_accounts.rb}

@@ -1,6 +1,6 @@
 class CreateAccounts < ActiveRecord::Migration
   def change
-    create_table :restpack_accounts do |t|
+    create_table :restpack_account_accounts do |t|
       t.integer :created_by,      :null => false
       t.integer :application_id,  :null => false
       t.string  :name,            :null => false, :limit => 256

data/lib/restpack_account_service.rb

@@ -1,2 +1,2 @@
 require 'restpack_service'
-RestPack::Service::Loader.load 'account'
+RestPack::Service::Loader.load 'restpack_account_service', 'Accounts'

data/lib/restpack_account_service/commands/account/create.rb

@@ -1,22 +1,15 @@
-module RestPack::Account::Service::Commands
-  module Account
-    class Create < RestPack::Service::Command
-      required do
-        array :accounts do
-          hash do
-            required do
-              integer :application_id
-              integer :created_by
-              string :name
-            end
+module Commands::Accounts::Account
+  class Create < RestPack::Service::Commands::Create
+    required do
+      array :accounts do
+        hash do
+          required do
+            integer :application_id
+            integer :created_by
+            string :name
           end
         end
       end
-
-      def execute
-        accounts = Models::Account.create!(inputs[:accounts])
-        Serializers::Account.serialize(accounts)
-      end
     end
   end
 end

data/lib/restpack_account_service/commands/account/get.rb

@@ -1,20 +1,8 @@
-module RestPack::Account::Service::Commands
-  module Account
-    class Get < RestPack::Service::Command
-      required do
-        integer :id
-        integer :application_id
-      end
-
-      def execute
-        result = Serializers::Account.resource(inputs)
-
-        if result[:accounts].empty?
-          status :not_found
-        else
-          result
-        end
-      end
+module Commands::Accounts::Account
+  class Get < RestPack::Service::Commands::Get
+    required do
+      integer :id
+      integer :application_id
     end
   end
 end

data/lib/restpack_account_service/models/account.rb

@@ -1,6 +1,6 @@
-module RestPack::Account::Service::Models
+module Models::Accounts
   class Account < ActiveRecord::Base
-    self.table_name = :restpack_accounts
+    self.table_name = :restpack_account_accounts
 
     attr_accessible :application_id, :created_by, :name
     validates_presence_of :application_id, :created_by, :name

data/lib/restpack_account_service/serializers/account.rb

@@ -1,8 +1,8 @@
-module RestPack::Account::Service::Serializers
+module Serializers::Accounts
   class Account
     include RestPack::Serializer
 
-    self.model_class = Models::Account
+    self.model_class = Models::Accounts::Account
     self.key = :accounts
 
     attributes :id, :application_id, :created_by, :name, :href

data/lib/restpack_account_service/version.rb

@@ -1,7 +1,7 @@
 module RestPack
   module Account
     module Service
-      VERSION = "0.0.4"
+      VERSION = "0.0.5"
     end
   end
 end

data/spec/commands/account/create_spec.rb

@@ -1,32 +1,7 @@
-require_relative '../../spec_helper'
+require 'spec_helper'
 
-describe Commands::Account::Create do
-  #TODO: GJ: validate array
-  # is_required :created_by, :name
+describe Commands::Accounts::Account::Create do
+  it_acts_as_create_command(:accounts, :account)
 
-  context 'creating an account' do
-    let(:response) { subject.class.run(params) }
-
-    context 'with valid params' do
-      let(:account) { {
-        application_id: 111,
-        created_by: 234,
-        name: 'My New Group'
-      } }
-      let(:params) { {
-        accounts: [account]
-      } }
-
-      it 'returns the newly created account' do
-        response.success?.should == true
-
-        accounts = response.result[:accounts]
-        accounts.length.should == 1
-
-        accounts.first[:application_id].should == 111
-        accounts.first[:created_by].should == 234
-        accounts.first[:name].should == "My New Group"
-      end
-    end
-  end
+  pending 'validate command inputs'
 end

data/spec/commands/account/get_spec.rb

@@ -1,6 +1,6 @@
-require_relative '../../spec_helper'
+require 'spec_helper'
 
-describe Commands::Account::Get do
+describe Commands::Accounts::Account::Get do
   is_required :id, :application_id
 
   let(:response) { subject.class.run(params) }

data/spec/factories/account.rb

@@ -1,5 +1,5 @@
 FactoryGirl.define do
-  factory :account, :class => Models::Account do
+  factory :account, :class => Models::Accounts::Account do
     sequence(:application_id)
     sequence(:name) {|n| "Account ##{n}" }
     sequence(:created_by)

data/spec/factories/api_account.rb

@@ -0,0 +1,9 @@
+FactoryGirl.define do
+  factory :api_account, class: Hash do
+    sequence(:name) {|n| "Account ##{n}" }
+    sequence(:application_id)
+    sequence(:created_by)
+
+    initialize_with { attributes }
+  end
+end

data/spec/models/account_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Models::Account do
+describe Models::Accounts::Account do
   it { should validate_presence_of(:application_id) }
   it { should validate_presence_of(:created_by) }
   it { should validate_presence_of(:name) }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: restpack_account_service
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Gavin Joyce
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-21 00:00:00.000000000 Z
+date: 2013-11-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: restpack_service
@@ -136,7 +136,7 @@ files:
 - README.md
 - Rakefile
 - config/database.yml
-- db/migrate/20130919115210_create_accounts.rb
+- db/migrate/20130919115211_create_accounts.rb
 - lib/restpack_account_service.rb
 - lib/restpack_account_service/commands/account/create.rb
 - lib/restpack_account_service/commands/account/get.rb
@@ -150,6 +150,7 @@ files:
 - spec/commands/account/create_spec.rb
 - spec/commands/account/get_spec.rb
 - spec/factories/account.rb
+- spec/factories/api_account.rb
 - spec/models/account_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/RestPack
@@ -180,5 +181,6 @@ test_files:
 - spec/commands/account/create_spec.rb
 - spec/commands/account/get_spec.rb
 - spec/factories/account.rb
+- spec/factories/api_account.rb
 - spec/models/account_spec.rb
 - spec/spec_helper.rb