restify 1.9.0 → 1.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fabe3a3c7e412889e4fe339d9d422fc5c0c94147ca53c342888d7e5eb00608c2
-  data.tar.gz: 07b987075ca1987a95574298daf1d89c8cc398e7e95aaf48dde2fa2473d683cb
+  metadata.gz: f44b84123c73ffd08cc8668448b03470c06acaf0f693e844fface91ff44179b5
+  data.tar.gz: c194b2db48a18a7f234bba20ff4161f98277b1146e6b7bf2572c877c285c3794
 SHA512:
-  metadata.gz: 3b83864c86be0e6449d25224f748dcb506d47bbeba47f3587280399c54eb5059aec0a85a8dc85f6d142c262efeab4f01f53595d0840c318507fbfa119dacd3e6
-  data.tar.gz: a2d06c226182e654966690460768f8bdcb3c9bfbdd2de35da642ab2826e6eddbea871667564872a1635a0be157202c40a48cbf305befdca52cf29430482439e9
+  metadata.gz: 89de3a2282568b6cd4b58afdf04e2271abf283721a25535e5420a4b1e52e4ed6b3edf894180d6fd15ee010c7692f99942c047fe7baef81d5bd67ff13b756e189
+  data.tar.gz: e6b18bfd819aec933acdb9fbec820ea7e742918eebc795c77f5f7ba0b927ccae85b876b367df8325d90e2899aad77bcf30f691781419669fd7406a156e197f86

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## 1.10.0
+
+* Raise more specific error on a few status codes (#17)
+* Complete promises with an empty list (but a list) of dependencies (#18)
+
 ## 1.9.0
 
 * Do not raise error on 3XX responses but return responses

data/lib/restify/context.rb

@@ -62,7 +62,7 @@ module Restify
         if !response.errored?
           process response
         else
-          Context.raise_response_error(response)
+          raise ResponseError.from_code(response)
         end
       end
     end
@@ -101,18 +101,5 @@ module Restify
     def default_headers
       options.fetch(:headers, {})
     end
-
-    class << self
-      def raise_response_error(response)
-        case response.code
-          when 400...500
-            raise ClientError.new(response)
-          when 500...600
-            raise ServerError.new(response)
-          else
-            raise "Unknown response code: #{response.code}"
-        end
-      end
-    end
   end
 end

data/lib/restify/error.rb

@@ -20,6 +20,27 @@ module Restify
   class ResponseError < StandardError
     attr_reader :response
 
+    def self.from_code(response)
+      case response.code
+        when 400
+          BadRequest.new(response)
+        when 401
+          Unauthorized.new(response)
+        when 404
+          NotFound.new(response)
+        when 406
+          NotAcceptable.new(response)
+        when 422
+          UnprocessableEntity.new(response)
+        when 400...500
+          ClientError.new(response)
+        when 500...600
+          ServerError.new(response)
+        else
+          raise "Unknown response code: #{response.code}"
+      end
+    end
+
     def initialize(response)
       @response = response
       super "#{response.message} (#{response.code}) for `#{response.uri}':\n" \
@@ -65,4 +86,15 @@ module Restify
   # A {ServerError} will be raised when a response has a
   # 5XX status code.
   class ServerError < ResponseError; end
+
+  ###
+  # CONCRETE SUBCLASSES FOR TYPICAL STATUS CODES
+  #
+  # This makes it easy to rescue specific expected error types.
+
+  class BadRequest < ClientError; end
+  class Unauthorized < ClientError; end
+  class NotFound < ClientError; end
+  class NotAcceptable < ClientError; end
+  class UnprocessableEntity < ClientError; end
 end

data/lib/restify/promise.rb

@@ -7,6 +7,13 @@ module Restify
       @dependencies = dependencies.flatten
 
       super(&nil)
+
+      # When dependencies were passed in, but none are left after flattening,
+      # then we don't have to wait for explicit dependencies or resolution
+      # through a writer.
+      if !@task && @dependencies.empty? && dependencies.any?
+        complete true, [], nil
+      end
     end
 
     def wait(timeout = nil)

data/lib/restify/version.rb

@@ -3,7 +3,7 @@
 module Restify
   module VERSION
     MAJOR = 1
-    MINOR = 9
+    MINOR = 10
     PATCH = 0
     STAGE = nil
     STRING = [MAJOR, MINOR, PATCH, STAGE].reject(&:nil?).join('.').freeze

data/spec/restify/features/response_errors.rb

@@ -0,0 +1,79 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Restify do
+  let!(:request_stub) do
+    stub_request(:get, 'http://localhost/base')
+      .to_return do
+      <<-RESPONSE.gsub(/^ {8}/, '')
+        HTTP/1.1 #{http_status}
+        Content-Length: 333
+        Transfer-Encoding: chunked
+        Link: <http://localhost/other>; rel="neat"
+      RESPONSE
+    end
+  end
+
+  let(:http_status) { '200 OK' }
+
+  describe 'Error handling' do
+    subject(:request) { Restify.new('http://localhost/base').get.value! }
+
+    context 'for 400 status codes' do
+      let(:http_status) { '400 Bad Request' }
+
+      it 'throws a BadRequest exception' do
+        expect { request }.to raise_error Restify::BadRequest
+      end
+    end
+
+    context 'for 401 status codes' do
+      let(:http_status) { '401 Unauthorized' }
+
+      it 'throws an Unauthorized exception' do
+        expect { request }.to raise_error Restify::Unauthorized
+      end
+    end
+
+    context 'for 404 status codes' do
+      let(:http_status) { '404 Not Found' }
+
+      it 'throws a ClientError exception' do
+        expect { request }.to raise_error Restify::NotFoundError
+      end
+    end
+
+    context 'for 406 status codes' do
+      let(:http_status) { '406 Not Acceptable' }
+
+      it 'throws a NotAcceptable exception' do
+        expect { request }.to raise_error Restify::NotAcceptable
+      end
+    end
+
+    context 'for 422 status codes' do
+      let(:http_status) { '422 Unprocessable Entity' }
+
+      it 'throws a UnprocessableEntity exception' do
+        expect { request }.to raise_error Restify::UnprocessableEntity
+      end
+    end
+
+    context 'for any other 4xx status codes' do
+      let(:http_status) { '415 Unsupported Media Type' }
+
+      it 'throws a generic ClientError exception' do
+        expect { request }.to raise_error Restify::ClientError
+      end
+    end
+
+    context 'for any 5xx status codes' do
+      let(:http_status) { '500 Internal Server Error' }
+
+      it 'throws a generic ServerError exception' do
+        expect { request }.to raise_error Restify::ServerError
+      end
+    end
+  end
+end

data/spec/restify/promise_spec.rb

@@ -163,6 +163,13 @@ describe Restify::Promise do
         expect(subject).to eq 17
       end
     end
+
+    # Nobody does this explicitly, but it can happen when the array of
+    # dependencies is built dynamically.
+    context 'with an empty array of dependencies and without task' do
+      subject { described_class.new([]).value! }
+      it { is_expected.to eq [] }
+    end
   end
 
   describe '#wait' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: restify
 version: !ruby/object:Gem::Version
-  version: 1.9.0
+  version: 1.10.0
 platform: ruby
 authors:
 - Jan Graichen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-11-13 00:00:00.000000000 Z
+date: 2018-12-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -188,6 +188,7 @@ files:
 - spec/restify/context_spec.rb
 - spec/restify/features/head_requests_spec.rb
 - spec/restify/features/request_headers_spec.rb
+- spec/restify/features/response_errors.rb
 - spec/restify/global_spec.rb
 - spec/restify/link_spec.rb
 - spec/restify/processors/base_spec.rb
@@ -229,6 +230,7 @@ test_files:
 - spec/restify/context_spec.rb
 - spec/restify/features/head_requests_spec.rb
 - spec/restify/features/request_headers_spec.rb
+- spec/restify/features/response_errors.rb
 - spec/restify/global_spec.rb
 - spec/restify/link_spec.rb
 - spec/restify/processors/base_spec.rb