restify 1.13.0 → 1.14.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e2b5dacc128de6cbfed604453544f51eaeffd16b9b6cb83f5353ecca66d24a8d
-  data.tar.gz: 5c3eba335362aea288f851327fa96262e5b464b9a747b092955241bb362e9c0d
+  metadata.gz: a52b89b2f13d578bc3ee09444ed5a01e6e80597b13f8fed2a10135f482fde561
+  data.tar.gz: 6e98b2d97468fe186a8500e7b88e72e8e174ef13840a76fcf152d2a8dcc57b4d
 SHA512:
-  metadata.gz: 32569c3544a1ac6734b3c81c1e2b6a46ea7dba324c1f71f5e85bd1df93b8b73bb70114a7cec37dd8e38e561a821e674e8c437c78757d78df75e1e51b1a5a79f8
-  data.tar.gz: 6f03d156fcc20e0dfba3d7fda0a5c7851ff5d9342fbb9b50c4d90d1f43bf65e92f0ecabb714c4023ce4ca8cfb95b231abd7ea5d1e05339e839ea046b17f3d1fe
+  metadata.gz: 2c61229244ba3cfeb64d37f4328059e2f9c91f394dea86abe522cb2a4b2ce422ce107ca81a5cd5c55ec2d99b9c1409bd1f4fa6ca7ab13d86697e00dda02abb42
+  data.tar.gz: 1dc873a2867f9cb91e55419c7bf831486b3ad86ec28186b7a2d8bac14653518a496f1cd8369a432fa1c74600b0ad91cd25c3094ffd392a9982dac2128a224484

data/CHANGELOG.md

@@ -18,6 +18,12 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 ### Breaks
 
 
+## 1.14.0 - (2020-12-15)
+
+### New
+* Allow making requests with non-JSON bodies and custom content types (#42)
+
+
 ## 1.13.0 - (2020-06-12)
 ---
 

data/lib/restify/request.rb

@@ -34,18 +34,26 @@ module Restify
       @uri     = opts.fetch(:uri) { raise ArgumentError.new ':uri required.' }
       @data    = opts.fetch(:data, nil)
       @timeout = opts.fetch(:timeout, 300)
-      @headers = opts.fetch(:headers, {}).merge \
-        'Content-Type' => 'application/json'
+      @headers = opts.fetch(:headers, {})
+
+      @headers['Content-Type'] ||= 'application/json' if json?
     end
 
     def body
-      @body ||= begin
-        JSON.dump(data) unless data.nil?
-      end
+      @body ||= json? ? JSON.dump(@data) : @data
     end
 
     def to_s
       "#<#{self.class} #{method.upcase} #{uri}>"
     end
+
+    private
+
+    def json?
+      return false if @data.nil?
+      return false if @data.is_a? String
+
+      true
+    end
   end
 end

data/lib/restify/version.rb

@@ -3,7 +3,7 @@
 module Restify
   module VERSION
     MAJOR = 1
-    MINOR = 13
+    MINOR = 14
     PATCH = 0
     STAGE = nil
     STRING = [MAJOR, MINOR, PATCH, STAGE].reject(&:nil?).join('.').freeze

data/spec/restify/features/request_bodies_spec.rb

@@ -0,0 +1,86 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Restify do
+  let!(:request_stub) do
+    stub_request(:post, 'http://localhost/base')
+      .to_return do
+      <<-RESPONSE.gsub(/^ {8}/, '')
+        HTTP/1.1 200 OK
+        Content-Length: 333
+        Transfer-Encoding: chunked
+        Link: <http://localhost/other>; rel="neat"
+      RESPONSE
+    end
+  end
+
+  describe 'Request body' do
+    subject { Restify.new('http://localhost/base').post(body, {}, {headers: headers}).value! }
+    let(:headers) { {} }
+
+    context 'with JSON-like data structures' do
+      let(:body) { {a: 'b', c: 'd'} }
+
+      it 'is serialized as JSON' do
+        subject
+
+        expect(
+          request_stub.with(body: '{"a":"b","c":"d"}')
+        ).to have_been_requested
+      end
+
+      it 'gets a JSON media type for free' do
+        subject
+
+        expect(
+          request_stub.with(headers: {'Content-Type' => 'application/json'})
+        ).to have_been_requested
+      end
+
+      context 'with overridden media type' do
+        let(:headers) { {'Content-Type' => 'application/vnd.api+json'} }
+
+        it 'respects the override' do
+          subject
+
+          expect(
+            request_stub.with(headers: {'Content-Type' => 'application/vnd.api+json'})
+          ).to have_been_requested
+        end
+      end
+    end
+
+    context 'with strings' do
+      let(:body) { 'a=b&c=d' }
+
+      it 'is sent as provided' do
+        subject
+
+        expect(
+          request_stub.with(body: 'a=b&c=d')
+        ).to have_been_requested
+      end
+
+      it 'does not get a JSON media type' do
+        subject
+
+        expect(
+          request_stub.with {|req| req.headers['Content-Type'].nil? }
+        ).to have_been_requested
+      end
+
+      context 'with overridden media type' do
+        let(:headers) { {'Content-Type' => 'application/x-www-form-urlencoded'} }
+
+        it 'respects the override' do
+          subject
+
+          expect(
+            request_stub.with(headers: {'Content-Type' => 'application/x-www-form-urlencoded'})
+          ).to have_been_requested
+        end
+      end
+    end
+  end
+end

data/spec/restify/features/{response_errors.rb → response_errors_spec.rb}

@@ -40,7 +40,7 @@ describe Restify do
       let(:http_status) { '404 Not Found' }
 
       it 'throws a ClientError exception' do
-        expect { request }.to raise_error Restify::NotFoundError
+        expect { request }.to raise_error Restify::NotFound
       end
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: restify
 version: !ruby/object:Gem::Version
-  version: 1.13.0
+  version: 1.14.0
 platform: ruby
 authors:
 - Jan Graichen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-06-12 00:00:00.000000000 Z
+date: 2020-12-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -194,8 +194,9 @@ files:
 - spec/restify/context_spec.rb
 - spec/restify/error_spec.rb
 - spec/restify/features/head_requests_spec.rb
+- spec/restify/features/request_bodies_spec.rb
 - spec/restify/features/request_headers_spec.rb
-- spec/restify/features/response_errors.rb
+- spec/restify/features/response_errors_spec.rb
 - spec/restify/global_spec.rb
 - spec/restify/link_spec.rb
 - spec/restify/processors/base_spec.rb
@@ -227,7 +228,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.0.8
 signing_key: 
 specification_version: 4
 summary: An experimental hypermedia REST client.
@@ -236,8 +237,9 @@ test_files:
 - spec/restify/context_spec.rb
 - spec/restify/error_spec.rb
 - spec/restify/features/head_requests_spec.rb
+- spec/restify/features/request_bodies_spec.rb
 - spec/restify/features/request_headers_spec.rb
-- spec/restify/features/response_errors.rb
+- spec/restify/features/response_errors_spec.rb
 - spec/restify/global_spec.rb
 - spec/restify/link_spec.rb
 - spec/restify/processors/base_spec.rb