restful_resource 2.7.0 → 2.10.3

data/spec/restful_resource/rails_validations_spec.rb

@@ -7,7 +7,7 @@ RSpec.describe RestfulResource::RailsValidations do
     allow(Dealer).to receive(:http).and_return(@mock_http)
   end
 
-  context '#patch without errors' do
+  describe '#patch without errors' do
     before do
       data = { name: 'Barak' }
       expected_response = RestfulResource::Response.new(body: { name: 'Barak' }.to_json)
@@ -25,7 +25,7 @@ RSpec.describe RestfulResource::RailsValidations do
     end
   end
 
-  context '#patch with errors' do
+  describe '#patch with errors' do
     before do
       data = { name: 'Leonardo' }
       @error = 'Cannot use Ninja Turtles names'
@@ -72,13 +72,13 @@ RSpec.describe RestfulResource::RailsValidations do
     end
   end
 
-  context '#patch without errors' do
+  describe '#put without errors' do
     before do
       data = { name: 'Barak' }
       expected_response = RestfulResource::Response.new(body: { name: 'Barak' }.to_json)
-      expect_patch('http://api.carwow.co.uk/dealers/1', expected_response, data: data)
+      expect_put('http://api.carwow.co.uk/dealers/1', expected_response, data: data)
 
-      @object = Dealer.patch(1, data: data)
+      @object = Dealer.put(1, data: data)
     end
 
     it 'returns object' do
@@ -90,7 +90,7 @@ RSpec.describe RestfulResource::RailsValidations do
     end
   end
 
-  context '#put with errors' do
+  describe '#put with errors' do
     before do
       data = { name: 'Leonardo' }
       @error = 'Cannot use Ninja Turtles names'
@@ -137,7 +137,7 @@ RSpec.describe RestfulResource::RailsValidations do
     end
   end
 
-  context '#post without errors' do
+  describe '#post without errors' do
     before do
       data = { name: 'Barak' }
       expected_response = RestfulResource::Response.new(body: { name: 'Barak' }.to_json)
@@ -155,7 +155,7 @@ RSpec.describe RestfulResource::RailsValidations do
     end
   end
 
-  context '#post with errors' do
+  describe '#post with errors' do
     before do
       data = { name: 'Leonardo' }
       @error = 'Cannot use Ninja Turtles names'
@@ -192,7 +192,7 @@ RSpec.describe RestfulResource::RailsValidations do
     end
   end
 
-  context '#get without errors' do
+  describe '#get without errors' do
     before do
       expected_response = RestfulResource::Response.new(body: { name: 'Barak' }.to_json)
       expect_get('http://api.carwow.co.uk/dealers', expected_response)
@@ -209,7 +209,7 @@ RSpec.describe RestfulResource::RailsValidations do
     end
   end
 
-  context '#get with errors' do
+  describe '#get with errors' do
     before do
       @error = 'Missing parameter'
       expected_response = RestfulResource::Response.new(body: { errors: [@error] }.to_json)
@@ -239,4 +239,53 @@ RSpec.describe RestfulResource::RailsValidations do
       expect(@object.errors).to eq @error
     end
   end
+
+  describe '#delete' do
+    subject { Dealer.delete(123) }
+
+    context 'without errors' do
+      before do
+        expected_response = RestfulResource::Response.new(body: { name: 'Barak' }.to_json)
+        expect_delete('http://api.carwow.co.uk/dealers/123', expected_response)
+      end
+
+      it 'returns object' do
+        expect(subject.name).to eq 'Barak'
+      end
+
+      it 'returns valid object' do
+        expect(subject).to be_valid
+      end
+    end
+
+    context 'with errors' do
+      let(:errors) { { errors: ['Cannot use Ninja Turtles names'] } }
+
+      before do
+        expected_response = RestfulResource::Response.new(body: errors.to_json)
+        expect_delete_with_unprocessable_entity('http://api.carwow.co.uk/dealers/123', expected_response)
+      end
+
+      it 'has an error' do
+        expect(subject.errors.count).to eq 1
+      end
+
+      it 'has correct error' do
+        expect(subject.errors.first).to eq 'Cannot use Ninja Turtles names'
+      end
+
+      it 'returns not valid object' do
+        expect(subject).not_to be_valid
+      end
+
+      context 'when there is a single error' do
+        let(:errors) { 'Cannot use Ninja Turtles names' }
+
+        it 'handles errors returned as root object' do
+          expect(subject).not_to be_valid
+          expect(subject.errors).to eq errors
+        end
+      end
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -1,3 +1,4 @@
+require 'pry'
 require 'rspec'
 require 'rspec/its'
 require_relative '../lib/restful_resource'
@@ -65,3 +66,10 @@ def expect_post_with_unprocessable_entity(url, response, data: {})
   exception = RestfulResource::HttpClient::UnprocessableEntity.new(request, rest_client_response)
   expect(@mock_http).to receive(:post).with(url, data: data, headers: {}, open_timeout: nil, timeout: nil).and_raise(exception)
 end
+
+def expect_delete_with_unprocessable_entity(url, response)
+  request = RestfulResource::Request.new(:delete, url)
+  rest_client_response = OpenStruct.new(body: response.body, headers: response.headers, code: response.status)
+  exception = RestfulResource::HttpClient::UnprocessableEntity.new(request, rest_client_response)
+  expect(@mock_http).to receive(:delete).with(url, headers: {}, open_timeout: nil, timeout: nil).and_raise(exception)
+end

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: restful_resource
 version: !ruby/object:Gem::Version
-  version: 2.7.0
+  version: 2.10.3
 platform: ruby
 authors:
 - David Santoro
 - Federico Rebora
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-10-09 00:00:00.000000000 Z
+date: 2020-11-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -40,7 +40,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -54,7 +54,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -68,7 +68,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec_junit_formatter
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -96,47 +96,61 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: activesupport
+  name: rspec_junit_formatter
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-  type: :runtime
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '6.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '6.0'
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.15.0
+        version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.15.0
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: faraday-cdn-metrics
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.2'
 - !ruby/object:Gem::Dependency
   name: faraday-encoding
   requirement: !ruby/object:Gem::Requirement
@@ -155,30 +169,30 @@ dependencies:
   name: faraday-http-cache
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.2'
 - !ruby/object:Gem::Dependency
   name: faraday_middleware
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: link_header
   requirement: !ruby/object:Gem::Requirement
@@ -197,30 +211,30 @@ dependencies:
   name: rack
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.2'
 - !ruby/object:Gem::Dependency
   name: typhoeus
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.4'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.4'
 description: A simple activerecord inspired rest resource base class implemented using
   rest-client
 email:
@@ -274,7 +288,7 @@ homepage: http://www.github.com/carwow/restful_resource
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -289,8 +303,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.1.2
+signing_key:
 specification_version: 4
 summary: A simple activerecord inspired rest resource base class implemented using
   rest-client