restful_resource 2.16.0 → 2.18.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9f8db280a4d7afd8d96673bd146fc9ef8f07b65892c51510b96528cf14da3ef6
-  data.tar.gz: 90117d3293b54c29bd95e898e74c5bf4a36729aa3699febefe1611f7c0edd2b3
+  metadata.gz: 4f45c7bb4d3a312e9e03f80bb613672260ea6db0d7eb025cd5b8f8e347c242ff
+  data.tar.gz: 5afb32e079d5006ca35680ae356ca657d4e66bee19432a3a797a0a377dea0ac6
 SHA512:
-  metadata.gz: c75d4f211b12a0ba6a80911d86797317332343d36e293f4374612877c2e154ab963a45bc20a4916e8868c8c37b68c3d6d1716e97542ee7898c72622c539b648c
-  data.tar.gz: ced11a5b38856a0401f9380dcada04089ed5ac929f275a1bef34b13906944357c874ba7395e88a661cbcc791119920967c0c7736151c2c10dc1a328439e46545
+  metadata.gz: b3b92083d51ee14c66d5f8640b56119d734b277a1a0cde77f6b44f8f18dfaa90f71a66d53b696a3b8c53734d78952032a0da1d746055e84cf6ce82abe54195ff
+  data.tar.gz: fcf23240eca478b98a05df1fc26680c1028873da7b9588c96635fab52be1bb91811cf8ac30f94a5b60c7a445e0daf162b43764ceca9503f9a3c862c5e386b6b8

data/CHANGELOG.md

@@ -1,4 +1,15 @@
 # Changelog
+2.18
+---
+
+- Configure Faraday's default adapter as `net_http`
+- Fix `X-Client-Start` & `X-Client-Timeout` headers to be strings not integers
+
+2.17
+---
+
+- Re-add deprecation for :dig and :[] since they are still used by some clients
+
 2.16
 ---
 

data/lib/restful_resource/base.rb

@@ -2,6 +2,8 @@ module RestfulResource
   class Base < OpenObject
     extend RestfulResource::Associations
 
+    Deprecator = ActiveSupport::Deprecation.new('soon', 'restful_resource')
+
     def self.configure(base_url: nil,
       username: nil,
       password: nil,

data/lib/restful_resource/http_client.rb

@@ -1,6 +1,3 @@
-# Use the Faraday-Typhoeus adapter provided by Typhoeus, not Faraday
-require 'typhoeus/adapters/faraday'
-
 module RestfulResource
   class HttpClient
     class HttpError < StandardError
@@ -240,7 +237,7 @@ module RestfulResource
         b.response :encoding
         b.use :gzip
 
-        b.adapter :typhoeus
+        b.adapter Faraday.default_adapter
       end
     end
 
@@ -261,7 +258,7 @@ module RestfulResource
         req.url request.url
 
         req.headers = req.headers.merge(request.headers).merge(x_client_start: time_current_ms)
-        req.headers = req.headers.merge(x_client_timeout: req.options[:timeout]) if req.options[:timeout]
+        req.headers = req.headers.merge(x_client_timeout: req.options[:timeout]&.to_s) if req.options[:timeout]
       end
 
       Response.new(body: response.body, headers: response.headers, status: response.status)
@@ -295,7 +292,7 @@ module RestfulResource
     end
 
     def time_current_ms
-      (Time.current.to_f * 1_000.0).to_i
+      (Time.current.to_f * 1_000.0).to_i.to_s
     end
   end
 end

data/lib/restful_resource/railtie.rb

@@ -0,0 +1,7 @@
+module RestfulResource
+  class Railtie < Rails::Railtie
+    initializer 'restful_resource.deprecator' do |app|
+      app.deprecators[:restful_resource] = Base::Deprecator
+    end
+  end
+end

data/lib/restful_resource/strict_open_struct.rb

@@ -1,5 +1,5 @@
 module RestfulResource
   class StrictOpenStruct < ::OpenStruct
-    undef_method :dig, :[]
+    deprecate :dig, :[], deprecator: Base::Deprecator
   end
 end

data/lib/restful_resource/version.rb

@@ -1,3 +1,3 @@
 module RestfulResource
-  VERSION = '2.16.0'.freeze
+  VERSION = '2.18.0'.freeze
 end

data/lib/restful_resource.rb

@@ -24,3 +24,4 @@ require_relative 'restful_resource/redirections'
 require_relative 'restful_resource/instrumentation'
 require_relative 'restful_resource/base'
 require_relative 'restful_resource/strict_open_struct'
+require_relative 'restful_resource/railtie' if defined?(Rails::Railtie)

data/restful_resource.gemspec

@@ -34,5 +34,4 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'faraday_middleware', '~> 1.0'
   spec.add_dependency 'link_header'
   spec.add_dependency 'rack', '~> 2.2'
-  spec.add_dependency 'typhoeus', '~> 1.4'
 end

data/spec/restful_resource/http_client_configuration_spec.rb

@@ -18,8 +18,8 @@ describe RestfulResource::HttpClient do
     let(:middleware) { connection.builder.handlers }
 
     describe 'Builder configuration' do
-      it 'uses the typhoeus adapter' do
-        expect(connection.adapter).to eq Faraday::Adapter::Typhoeus
+      it 'uses the net http adapter' do
+        expect(connection.adapter).to eq Faraday::Adapter::NetHttp
       end
 
       it 'url_encodes requests' do

data/spec/restful_resource/http_client_spec.rb

@@ -221,7 +221,7 @@ RSpec.describe RestfulResource::HttpClient do
 
     context 'when explicit timeout set on connection' do
       let(:timeout) { 5 }
-      let(:required_headers) { { 'X-Client-Timeout' => 5 } }
+      let(:required_headers) { { 'X-Client-Timeout' => '5' } }
 
       it 'sets X-Client-Timeout correctly' do
         response = http_client.get('http://httpbin.org/get')
@@ -243,7 +243,7 @@ RSpec.describe RestfulResource::HttpClient do
 
     context 'when set on request' do
       let(:timeout) { nil }
-      let(:required_headers) { { 'X-Client-Timeout' => 1 } }
+      let(:required_headers) { { 'X-Client-Timeout' => '1' } }
 
       it 'sets X-Client-Timeout correctly' do
         response = http_client.get('http://httpbin.org/get', timeout: 1)
@@ -255,7 +255,7 @@ RSpec.describe RestfulResource::HttpClient do
 
   describe 'X-Client-Start' do
     let(:now) { Time.current }
-    let(:required_headers) { { 'X-Client-Start' => (now.to_f * 1000.0).to_i } }
+    let(:required_headers) { { 'X-Client-Start' => (now.to_f * 1000.0).to_i.to_s } }
     let(:http_client) { described_class.new(connection: connection) }
     let(:connection) do
       conn = faraday_connection do |stubs|

data/spec/restful_resource/strict_open_struct_spec.rb

@@ -4,14 +4,18 @@ RSpec.describe RestfulResource::StrictOpenStruct do
   let(:instance) { described_class.new(foo: 'bar') }
 
   describe '#dig' do
-    it 'is not defined' do
-      expect { instance.dig(:foo) }.to raise_error(NoMethodError)
+    it 'is deprecated' do
+      expect { instance.dig(:foo) }.to output(
+        /dig is deprecated and will be removed from restful_resource soon/
+      ).to_stderr
     end
   end
 
   describe '#[]' do
-    it 'is not defined' do
-      expect { instance[:foo] }.to raise_error(NoMethodError)
+    it 'is deprecated' do
+      expect { instance[:foo] }.to output(
+        /\[\] is deprecated and will be removed from restful_resource soon/
+      ).to_stderr
     end
   end
 end

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: restful_resource
 version: !ruby/object:Gem::Version
-  version: 2.16.0
+  version: 2.18.0
 platform: ruby
 authors:
 - David Santoro
 - Federico Rebora
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-03-05 00:00:00.000000000 Z
+date: 2024-03-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -227,20 +227,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.2'
-- !ruby/object:Gem::Dependency
-  name: typhoeus
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.4'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.4'
 description: A simple activerecord inspired rest resource base class implemented using
   rest-client
 email:
@@ -273,6 +259,7 @@ files:
 - lib/restful_resource/paginated_array.rb
 - lib/restful_resource/parameter_missing_error.rb
 - lib/restful_resource/rails_validations.rb
+- lib/restful_resource/railtie.rb
 - lib/restful_resource/redirections.rb
 - lib/restful_resource/request.rb
 - lib/restful_resource/resource_id_missing_error.rb
@@ -296,7 +283,7 @@ homepage: http://www.github.com/carwow/restful_resource
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -311,8 +298,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.19
-signing_key: 
+rubygems_version: 3.1.6
+signing_key:
 specification_version: 4
 summary: A simple activerecord inspired rest resource base class implemented using
   rest-client