restful_resource 2.16.0 → 2.17.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9f8db280a4d7afd8d96673bd146fc9ef8f07b65892c51510b96528cf14da3ef6
-  data.tar.gz: 90117d3293b54c29bd95e898e74c5bf4a36729aa3699febefe1611f7c0edd2b3
+  metadata.gz: 4f1e1688884fd8954caa9da4cef1a9d2c3a1e294ded09414ce82a3865cf40e30
+  data.tar.gz: cb8672227647b41612c0a6a9ba739dde8705fb353369347106b037cc4c2a45c2
 SHA512:
-  metadata.gz: c75d4f211b12a0ba6a80911d86797317332343d36e293f4374612877c2e154ab963a45bc20a4916e8868c8c37b68c3d6d1716e97542ee7898c72622c539b648c
-  data.tar.gz: ced11a5b38856a0401f9380dcada04089ed5ac929f275a1bef34b13906944357c874ba7395e88a661cbcc791119920967c0c7736151c2c10dc1a328439e46545
+  metadata.gz: 676a02c4acb372b64b6a82e628cef146a2043709cecb56a9819e37ce253d15af0f386db2a9d6e08a5c9b02d5e7e8895b61e88af7065f560c941ccad1400a8daa
+  data.tar.gz: e5ebf7348404ce117ac51963c23969754adbc144fbd97cc8ee4a967a80fe8c0a1a162ce55824800f5afd321167efe240fdb97226d05ded37fb74ba67209d6f4d

data/CHANGELOG.md

@@ -1,4 +1,9 @@
 # Changelog
+2.17
+---
+
+- Re-add deprecation for :dig and :[] since they are still used by some clients
+
 2.16
 ---
 

data/lib/restful_resource/base.rb

@@ -2,6 +2,8 @@ module RestfulResource
   class Base < OpenObject
     extend RestfulResource::Associations
 
+    Deprecator = ActiveSupport::Deprecation.new('soon', 'restful_resource')
+
     def self.configure(base_url: nil,
       username: nil,
       password: nil,

data/lib/restful_resource/railtie.rb

@@ -0,0 +1,7 @@
+module RestfulResource
+  class Railtie < Rails::Railtie
+    initializer 'restful_resource.deprecator' do |app|
+      app.deprecators[:restful_resource] = Base::Deprecator
+    end
+  end
+end

data/lib/restful_resource/strict_open_struct.rb

@@ -1,5 +1,5 @@
 module RestfulResource
   class StrictOpenStruct < ::OpenStruct
-    undef_method :dig, :[]
+    deprecate :dig, :[], deprecator: Base::Deprecator
   end
 end

data/lib/restful_resource/version.rb

@@ -1,3 +1,3 @@
 module RestfulResource
-  VERSION = '2.16.0'.freeze
+  VERSION = '2.17.0'.freeze
 end

data/lib/restful_resource.rb

@@ -24,3 +24,4 @@ require_relative 'restful_resource/redirections'
 require_relative 'restful_resource/instrumentation'
 require_relative 'restful_resource/base'
 require_relative 'restful_resource/strict_open_struct'
+require_relative 'restful_resource/railtie' if defined?(Rails::Railtie)

data/spec/restful_resource/strict_open_struct_spec.rb

@@ -4,14 +4,18 @@ RSpec.describe RestfulResource::StrictOpenStruct do
   let(:instance) { described_class.new(foo: 'bar') }
 
   describe '#dig' do
-    it 'is not defined' do
-      expect { instance.dig(:foo) }.to raise_error(NoMethodError)
+    it 'is deprecated' do
+      expect { instance.dig(:foo) }.to output(
+        /dig is deprecated and will be removed from restful_resource soon/
+      ).to_stderr
     end
   end
 
   describe '#[]' do
-    it 'is not defined' do
-      expect { instance[:foo] }.to raise_error(NoMethodError)
+    it 'is deprecated' do
+      expect { instance[:foo] }.to output(
+        /\[\] is deprecated and will be removed from restful_resource soon/
+      ).to_stderr
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: restful_resource
 version: !ruby/object:Gem::Version
-  version: 2.16.0
+  version: 2.17.0
 platform: ruby
 authors:
 - David Santoro
@@ -273,6 +273,7 @@ files:
 - lib/restful_resource/paginated_array.rb
 - lib/restful_resource/parameter_missing_error.rb
 - lib/restful_resource/rails_validations.rb
+- lib/restful_resource/railtie.rb
 - lib/restful_resource/redirections.rb
 - lib/restful_resource/request.rb
 - lib/restful_resource/resource_id_missing_error.rb