restful_client 0.1.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fdf61437db7d8ba44585cc4b91bcb2362227c068
-  data.tar.gz: 7d9fc6320b56785f07249b3146b15a04af2693b6
+  metadata.gz: ffdd1539730f64064b5e045bf4afcad0374ec2dc
+  data.tar.gz: 3110fcd87794defb963f4214b8164e706bf1cea5
 SHA512:
-  metadata.gz: 508b11c0cae03e2a895305162b92737e26e78e8e2f186d0a2b4edf454da5607eb624659022b606ec43eacec0685ea7a8f9e82de241cc3690470a85a766c3e7cb
-  data.tar.gz: c2f023f3df2c3bcedfe4916ddbb5c0597979e8cf310f0f763da9fde6470a31cd86b8c0b5fb9ccbae7b38fdabd5f74da4e26e5e049d107923c34e98711233d744
+  metadata.gz: 2b432086f2e3598fae207ca1a85e56a7c3a74f69194d00b10aa9ed495737c8072452e08d9f0e2c4ef97ff0b0899216400215e350832eb09461b4999013d4510e
+  data.tar.gz: 6aebfaf5672c02e41a1b66d7c884bd0c7c3a404a4b9a678d014ef0f0fef9ae194a46868f69c5a9d4cec2bd078c9eeeab99710dde7d04e49d5f61df336a3000e6

data/.hound.yml

@@ -0,0 +1,2 @@
+ruby:
+  config_file: .ruby-style.yml

data/.ruby-style.yml

@@ -0,0 +1,239 @@
+AllCops:
+  Exclude:
+    - "vendor/**/*"
+    - "db/schema.rb"
+  UseCache: false
+Style/CollectionMethods:
+  Description: Preferred collection methods.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#map-find-select-reduce-size
+  Enabled: true
+  PreferredMethods:
+    collect: map
+    collect!: map!
+    find: detect
+    find_all: select
+    reduce: inject
+Style/DotPosition:
+  Description: Checks the position of the dot in multi-line method calls.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#consistent-multi-line-chains
+  Enabled: true
+  EnforcedStyle: trailing
+  SupportedStyles:
+  - leading
+  - trailing
+Style/FileName:
+  Description: Use snake_case for source file names.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#snake-case-files
+  Enabled: false
+  Exclude: []
+Style/GuardClause:
+  Description: Check for conditionals that can be replaced with guard clauses
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-nested-conditionals
+  Enabled: false
+  MinBodyLength: 1
+Style/IfUnlessModifier:
+  Description: Favor modifier if/unless usage when you have a single-line body.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#if-as-a-modifier
+  Enabled: false
+  MaxLineLength: 80
+Style/OptionHash:
+  Description: Don't use option hashes when you can use keyword arguments.
+  Enabled: false
+Style/PercentLiteralDelimiters:
+  Description: Use `%`-literal delimiters consistently
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#percent-literal-braces
+  Enabled: false
+  PreferredDelimiters:
+    "%": "()"
+    "%i": "()"
+    "%q": "()"
+    "%Q": "()"
+    "%r": "{}"
+    "%s": "()"
+    "%w": "()"
+    "%W": "()"
+    "%x": "()"
+Style/PredicateName:
+  Description: Check the names of predicate methods.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#bool-methods-qmark
+  Enabled: true
+  NamePrefix:
+  - is_
+  - has_
+  - have_
+  NamePrefixBlacklist:
+  - is_
+  Exclude:
+  - spec/**/*
+Style/RaiseArgs:
+  Description: Checks the arguments passed to raise/fail.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#exception-class-messages
+  Enabled: false
+  EnforcedStyle: exploded
+  SupportedStyles:
+  - compact
+  - exploded
+Style/SignalException:
+  Description: Checks for proper usage of fail and raise.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#fail-method
+  Enabled: false
+  EnforcedStyle: semantic
+  SupportedStyles:
+  - only_raise
+  - only_fail
+  - semantic
+Style/SingleLineBlockParams:
+  Description: Enforces the names of some block params.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#reduce-blocks
+  Enabled: false
+  Methods:
+  - reduce:
+    - a
+    - e
+  - inject:
+    - a
+    - e
+Style/SingleLineMethods:
+  Description: Avoid single-line methods.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-single-line-methods
+  Enabled: false
+  AllowIfMethodIsEmpty: true
+Style/StringLiterals:
+  Description: Checks if uses of quotes match the configured preference.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#consistent-string-literals
+  Enabled: false
+  EnforcedStyle: double_quotes
+  SupportedStyles:
+  - single_quotes
+  - double_quotes
+Style/StringLiteralsInInterpolation:
+  Description: Checks if uses of quotes inside expressions in interpolated strings
+    match the configured preference.
+  Enabled: true
+  EnforcedStyle: single_quotes
+  SupportedStyles:
+  - single_quotes
+  - double_quotes
+Style/TrailingComma:
+  Description: Checks for trailing comma in parameter lists and literals.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-trailing-array-commas
+  Enabled: false
+  EnforcedStyleForMultiline: no_comma
+  SupportedStyles:
+  - comma
+  - no_comma
+Metrics/AbcSize:
+  Description: A calculated magnitude based on number of assignments, branches, and
+    conditions.
+  Enabled: false
+  Max: 15
+Metrics/ClassLength:
+  Description: Avoid classes longer than 100 lines of code.
+  Enabled: false
+  CountComments: false
+  Max: 100
+Metrics/LineLength:
+  Max: 130
+Metrics/ModuleLength:
+  CountComments: false
+  Max: 100
+  Description: Avoid modules longer than 100 lines of code.
+  Enabled: false
+Metrics/CyclomaticComplexity:
+  Description: A complexity metric that is strongly correlated to the number of test
+    cases needed to validate a method.
+  Enabled: false
+  Max: 6
+Metrics/MethodLength:
+  Description: Avoid methods longer than 10 lines of code.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#short-methods
+  Enabled: false
+  CountComments: false
+  Max: 10
+Metrics/ParameterLists:
+  Description: Avoid parameter lists longer than three or four parameters.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#too-many-params
+  Enabled: false
+  Max: 5
+  CountKeywordArgs: true
+Metrics/PerceivedComplexity:
+  Description: A complexity metric geared towards measuring complexity for a human
+    reader.
+  Enabled: false
+  Max: 7
+Lint/AssignmentInCondition:
+  Description: Don't use assignment in conditions.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#safe-assignment-in-condition
+  Enabled: false
+  AllowSafeAssignment: true
+Style/InlineComment:
+  Description: Avoid inline comments.
+  Enabled: false
+Style/AccessorMethodName:
+  Description: Check the naming of accessor methods for get_/set_.
+  Enabled: false
+Style/Alias:
+  Description: Use alias_method instead of alias.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#alias-method
+  Enabled: false
+Style/Documentation:
+  Description: Document classes and non-namespace modules.
+  Enabled: false
+Style/ClassVars:
+  Enabled: false
+Style/DoubleNegation:
+  Description: Checks for uses of double negation (!!).
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-bang-bang
+  Enabled: false
+Style/EachWithObject:
+  Description: Prefer `each_with_object` over `inject` or `reduce`.
+  Enabled: false
+Style/EmptyLiteral:
+  Description: Prefer literals to Array.new/Hash.new/String.new.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#literal-array-hash
+  Enabled: false
+Style/ModuleFunction:
+  Description: Checks for usage of `extend self` in modules.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#module-function
+  Enabled: false
+Style/OneLineConditional:
+  Description: Favor the ternary operator(?:) over if/then/else/end constructs.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#ternary-operator
+  Enabled: false
+Style/PerlBackrefs:
+  Description: Avoid Perl-style regex back references.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-perl-regexp-last-matchers
+  Enabled: false
+Style/Send:
+  Description: Prefer `Object#__send__` or `Object#public_send` to `send`, as `send`
+    may overlap with existing methods.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#prefer-public-send
+  Enabled: false
+Style/GlobalVars:
+  Enabled: false
+Style/SpecialGlobalVars:
+  Description: Avoid Perl-style global variables.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-cryptic-perlisms
+  Enabled: false
+Style/VariableInterpolation:
+  Description: Don't interpolate global, instance and class variables directly in
+    strings.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#curlies-interpolate
+  Enabled: false
+Style/WhenThen:
+  Description: Use when x then ... for one-line cases.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#one-line-cases
+  Enabled: false
+Lint/EachWithObjectArgument:
+  Description: Check for immutable argument given to each_with_object.
+  Enabled: true
+Lint/HandleExceptions:
+  Description: Don't suppress exception.
+  StyleGuide: https://github.com/bbatsov/ruby-style-guide#dont-hide-exceptions
+  Enabled: false
+Lint/LiteralInCondition:
+  Description: Checks of literals used in conditions.
+  Enabled: false
+Lint/LiteralInInterpolation:
+  Description: Checks for literals used in interpolation.
+  Enabled: false

data/.travis.yml

@@ -0,0 +1,5 @@
+sudo: false
+script: 'bundle exec rspec'
+language: ruby
+rvm:
+  - 2.2

data/Gemfile

@@ -2,8 +2,9 @@ source 'https://rubygems.org'
 
 gem 'thin', '~> 1.6'
 
-gem 'pry-byebug', '~> 3.2.0', {}.merge(ENV['RM_INFO'] ? {require: false} : {})
+gem 'pry-byebug', '~> 3.3.0', {}.merge(ENV['RM_INFO'] ? { require: false } : {})
 gem 'rspec', '~> 3.1'
 gem 'rspec-its', '~> 1.1'
+gem 'rubocop', '~> 0.35.1'
 
 gemspec

data/README.md

@@ -12,8 +12,8 @@ An HTTP framework for micro-services based environment, build on top of [typhoeu
 
 * Clean restful api supporting http verbs (GET/PUT/POST/DELETE)
 * Manage Failures -  set stubs for case of errors and SERVICE_DOWN event from [Jynx](https://github.com/AvnerCohen/service-jynx)
-* Strcutured and configurable YAML for multiple service end points
-* Build using Typheous, a fast and robuts http client, built on top of libcurl
+* Structured and configurable YAML for multiple service end points
+* Build using Typheous, a fast and robust http client, built on top of libcurl
 * Configurable timeouts for http request
 
 ## Configuration
@@ -38,14 +38,14 @@ production: &production
 
 </pre>
 
-### Possible flags
+### Configuration Flags
 
-* use_jynx - Remove the integrated jynx-service protection (default: false)
-* report_method - proc to be executed in the case of error
-* env_name - environment name (production|staging|development etc..)
-* config_folder - path to the configuration folder of the restful_services.yml file.
-* user_agent - user agent... duh! (users_service|mobile_service|etc..)
-* legacy_postfix - Legacy version accessed the restful_services.yml with an additional postfix in the yaml.
+* :use_jynx - Remove the integrated jynx-service protection (default: false)
+* :report_method - proc to be executed in the case of error
+* :env_name - environment name (production|staging|development etc..)
+* :config_folder - path to the configuration folder of the restful_services.yml file.
+* :user_agent - HTTP User-Agent agent, to be added to identify caller (users|mobile_service|anyname etc..)
+* :legacy_postfix - Legacy version accessed the restful_services.yml with an additional postfix in the yaml.
 
 ## Usage
 
@@ -123,7 +123,7 @@ Given:
 ````
 <pre>
 
-  RestfulClient.srv_url('posts') # ==> http://1.2.3.4:8383/api/v0/
+  RestfulClient.srv_url('users') # ==> http://1.2.3.4:8383/api/v0/
 </pre>
 
 ## Contributing

data/lib/restful_client.rb

@@ -11,11 +11,15 @@ module RestfulClient
 
   class RestError < StandardError; end
 
-  @@configuration  = nil
+  class << self
+    attr_writer :configuration, :logger, :timeout_occured_count
+  end
+  @@configuration = nil
   @@logger = nil
   @@timeout_occured_count = 0
 
   SERVER_SIDE_ERRORS_RANGE = 500
+  CLIENT_SIDE_ERRORS_RANGE = 400
 
   def self.configure
     @@configuration ||= RestfulClientConfiguration.new
@@ -33,52 +37,54 @@ module RestfulClient
   end
 
   def srv_url(caller)
-    callerr_config(caller)["url"]
+    callerr_config(caller)['url']
   end
 
-  def get(caller, path, params = {}, extra_options = {}, &on_error_block)
-    url = RestfulClientUri.uri_join(callerr_config(caller)["url"], path)
-    headers = { "Accept" => "text/json" }
-    headers.merge!(extra_options.fetch("headers", {}))
-    request = Typhoeus::Request.new(url, headers: headers, method: 'GET', timeout: timeout, params: params)
+  def get(caller, path, params = {}, extra = {}, &on_error_block)
+    url = RestfulClientUri.uri_join(callerr_config(caller)['url'], path)
+    headers = { 'Accept' => 'application/json' }
+    headers.merge!(extra.fetch('headers', {}))
+    request_args = { headers: headers, method: 'GET', timeout: timeout, params: params }.merge(extra.fetch('args', {}))
+    request = Typhoeus::Request.new(url, request_args.merge(extra.fetch('args', {})))
     run_safe_request(caller, request, true, &on_error_block)
   end
 
-  def post(caller, path, payload, extra_options = {}, &on_error_block)
-    url = RestfulClientUri.uri_join(callerr_config(caller)["url"], path)
-    headers, payload_as_str = prepare_payload_with_headers(payload, extra_options.fetch("headers", {}))
-    request = Typhoeus::Request.new(url, headers: headers, method: 'POST', body: payload_as_str, timeout: timeout)
+  def post(caller, path, payload, extra = {}, &on_error_block)
+    url = RestfulClientUri.uri_join(callerr_config(caller)['url'], path)
+    headers, payload_as_str = prepare_payload_with_headers(payload, extra.fetch('headers', {}))
+    request_args = { headers: headers, method: 'POST', body: payload_as_str, timeout: timeout }
+    request = Typhoeus::Request.new(url, request_args.merge(extra.fetch('args', {})))
     run_safe_request(caller, request, false, &on_error_block)
   end
 
   def post_raw(caller, path, payload, custom_timeout = timeout, &on_error_block)
-    url = RestfulClientUri.uri_join(callerr_config(caller)["url"], path)
+    url = RestfulClientUri.uri_join(callerr_config(caller)['url'], path)
     request = Typhoeus::Request.new(url, method: 'POST', body: payload, timeout: custom_timeout)
     run_safe_request(caller, request, false, &on_error_block)
   end
 
-  def delete(caller, path, payload = {}, extra_options = {}, &on_error_block)
-    url = RestfulClientUri.uri_join(callerr_config(caller)["url"], path)
-    headers, payload_as_str = prepare_payload_with_headers(payload, extra_options.fetch("headers", {}))
-    request = Typhoeus::Request.new(url, headers: headers, method: 'DELETE', body: payload_as_str, timeout: timeout)
+  def delete(caller, path, payload = {}, extra = {}, &on_error_block)
+    url = RestfulClientUri.uri_join(callerr_config(caller)['url'], path)
+    headers, payload_as_str = prepare_payload_with_headers(payload, extra.fetch('headers', {}))
+    request_args = { headers: headers, method: 'DELETE', body: payload_as_str, timeout: timeout }
+    request = Typhoeus::Request.new(url, request_args.merge(extra.fetch('args', {})))
     run_safe_request(caller, request, true, &on_error_block)
   end
 
-  def put(caller, path, payload, extra_options = {}, &on_error_block)
-    url = RestfulClientUri.uri_join(callerr_config(caller)["url"], path)
-    headers, payload_as_str = prepare_payload_with_headers(payload, extra_options.fetch("headers", {}))
+  def put(caller, path, payload, extra = {}, &on_error_block)
+    url = RestfulClientUri.uri_join(callerr_config(caller)['url'], path)
+    headers, payload_as_str = prepare_payload_with_headers(payload, extra.fetch('headers', {}))
     request = Typhoeus::Request.new(url, headers: headers, method: 'PUT', body: payload_as_str, timeout: timeout)
     run_safe_request(caller, request, false, &on_error_block)
   end
 
   def callerr_config(caller)
     caller_setup = configuration.data["#{caller}#{legacy_postfix}"]
-    raise "Couldn't find ['#{caller}#{legacy_postfix}'] in the configuration YAML !!" unless caller_setup
+    fail "Couldn't find ['#{caller}#{legacy_postfix}'] in the configuration YAML !!" unless caller_setup
     caller_setup
   end
 
   def run_safe_request(caller, request, retry_if_needed, &on_error_block)
-
     @@timeout_occured_count = 0
     if !use_jynx?
       response = run_request(request.dup, __method__, false)
@@ -94,39 +100,43 @@ module RestfulClient
     response
   rescue => e
     res = ServiceJynx.failure!(caller) if use_jynx?
-    report_method.call("ServiceJynx", "Service #{caller} was taken down as a result of exception", e) if res == :WENT_DOWN
+
+    if res == :WENT_DOWN
+      report_method.call('ServiceJynx', "Service #{caller} was taken down as a result of exception", e)
+    end
+
     on_error_block.call("Exception in #{caller} execution - #{e.message}") if on_error_block
   end
 
   def run_request(request, method, retry_if_needed)
     logger.debug { "#{__method__} :: Request :: #{request.inspect}" }
-    request.options[:headers].merge!({'X-Forwarded-For' => $client_ip}) if $client_ip
-    request.options[:headers].merge!({'User-Agent' => user_agent})
+    request.options[:headers].merge!('X-Forwarded-For' => $client_ip) if $client_ip
+    request.options[:headers].merge!('User-Agent' => user_agent)
     request.on_complete do |response|
-      #200, OK
+      # 200, OK
       if response.success?
         logger.debug { "Success in #{method} :: Code: #{response.response_code}, #{response.body}" }
-        return "" if response.body.empty?
+        return '' if response.body.empty?
         begin
           return JSON.parse(response.body)
         rescue => e
-          logger.error { "Response from #{response.effective_url} is not a valid json  - [#{response.body}]"}
+          logger.error { "Response from #{response.effective_url} is not a valid json  - [#{response.body}]" }
           raise e
         end
-        #Timeout occured
+        # Timeout occured
       elsif response.timed_out?
-        @@timeout_occured_count = @@timeout_occured_count + 1
+        @@timeout_occured_count += 1
         skip_raise = (retry_if_needed && @@timeout_occured_count <= retries)
 
-        error_type = "TimeoutOccured"
+        error_type = 'TimeoutOccured'
         error_description = prettify_logger(error_type, request, response)
         logger.error { "Time out in #{method} for: #{error_description}" }
 
         exception = RuntimeError.new(error_description)
         exception.set_backtrace(caller)
-        report_method.call("RestError", error_description, exception)
+        report_method.call('RestError', error_description, exception)
 
-        raise RestError.new(response.return_code.to_sym) unless skip_raise
+        fail RestError.new(response.return_code.to_sym) unless skip_raise
         # Could not get an http response, something's wrong.
       elsif response.code == 0
 
@@ -136,8 +146,8 @@ module RestfulClient
 
         exception = RuntimeError.new(error_description)
         exception.set_backtrace(caller)
-        report_method.call("RestError", error_description, exception)
-        raise RestError.new(error_type)
+        report_method.call('RestError', error_description, exception)
+        fail RestError.new(error_type)
         # Received a non-successful http response.
       elsif response.code >= SERVER_SIDE_ERRORS_RANGE
 
@@ -145,16 +155,17 @@ module RestfulClient
         error_description = prettify_logger(error_type, request, response)
         logger.error { "#{error_type} #{response.code}/#{response.return_code} for: #{error_description}" }
 
-        report_method.call("RestError", error_description, exception)
         exception = RuntimeError.new(error_description)
-
         exception.set_backtrace(caller)
+        report_method.call('RestError', error_description, exception)
 
-        raise RestError.new(error_type)
+        fail RestError.new(error_type)
+      elsif response.code.between?(CLIENT_SIDE_ERRORS_RANGE, (SERVER_SIDE_ERRORS_RANGE - 1))
+        logger.error { "#{error_type} #{response.code}/#{response.return_code} for: #{error_description}" }
+        return ''
       else
 
-        raise RestError.new(:BadReturnCode)
-
+        fail RestError.new(:BadReturnCode)
       end
     end
     request.run
@@ -162,9 +173,9 @@ module RestfulClient
 
   def prepare_payload_with_headers(payload, custom_headers)
     headers = {}
-    if payload.is_a?(Hash)
+    if payload.is_a?(Hash) && payload.any?
       payload_as_str = payload.to_json(root: false)
-      headers.merge!({ "Content-Type" => "application/json" })
+      headers.merge!('Content-Type' => 'application/json')
     else
       payload_as_str = payload
     end
@@ -174,9 +185,9 @@ module RestfulClient
     [headers, payload_as_str]
   end
 
-  def fake(caller, path, options = {}, &block)
-    url = RestfulClientUri.uri_join(callerr_config(caller)["url"], path)
-    Typhoeus.stub(url, options = {}, &block)
+  def fake(caller, path, _options = {}, &block)
+    url = RestfulClientUri.uri_join(callerr_config(caller)['url'], path)
+    Typhoeus.stub(url, {}, &block)
   end
 
   def timeout
@@ -205,7 +216,7 @@ module RestfulClient
 
   def prettify_logger(type, request, response)
     return "#{type} with no request or response." unless request || response
-    "#{type} #{response.code}/#{response.return_code} for: #{request.options.fetch(:method)} #{request.base_url}, Total time: #{response.total_time} seconds"
+    "#{type} #{response.code}/#{response.return_code} for: #{request.options.fetch(:method)}, "\
+    "#{request.base_url}, Total time: #{response.total_time} seconds"
   end
-
 end

data/lib/restful_client_configuration.rb

@@ -7,31 +7,30 @@ class RestfulClientConfiguration
   DEFAULT_USER_AGENT = 'RestfulClient - https://github.com/AvnerCohen/restful-client'
 
   def run!
-    raise "Configuration directory name must be provided" unless config_folder.class.to_s == "String"
-    file_name = ["restful_services.yml", "rest_api.yml"].each do |name|
+    fail 'Configuration directory name must be provided' unless config_folder.class.to_s == 'String'
+    file_name = ['restful_services.yml', 'rest_api.yml'].each do |name|
       locale_name = File.join(config_folder, name)
       break locale_name if File.file?(locale_name)
     end
 
     ## Set Default Values
-    @report_method  ||=     proc {|*args| nil }
-    @timeout        ||=     DEFAULT_TIMEOUT
-    @user_agent     ||=     DEFAULT_USER_AGENT
-    @retries        ||=     DEFAULT_RETRIES
-    @legacy_postfix ||=     ""
-    @use_jynx         =     true if @use_jynx.nil?
+    @report_method ||= proc { |*_args| nil }
+    @timeout ||= DEFAULT_TIMEOUT
+    @user_agent ||= DEFAULT_USER_AGENT
+    @retries ||= DEFAULT_RETRIES
+    @legacy_postfix ||= ''
+    @use_jynx         = true if @use_jynx.nil?
 
     @data = YAML.load(ERB.new(File.read(file_name)).result)[env].each do |name, entry|
-      next unless entry.has_key?("url")
+      next unless entry.key?('url')
       opts = {
         time_window_in_seconds: entry.fetch(:time_window_in_seconds, 20),
         max_errors: entry.fetch(:max_errors, 10),
         grace_period: entry.fetch(:grace_period, 120)
       }
 
-      ServiceJynx.register!(name.gsub(@legacy_postfix, ""), opts) if @use_jynx
+      ServiceJynx.register!(name.gsub(@legacy_postfix, ''), opts) if @use_jynx
     end
-
   end
 
   def reset
@@ -45,11 +44,10 @@ class RestfulClientConfiguration
 
   ## Dummy method to test reporting phase
   def report_on
-    @report_method.call("RestfulClientConfiguration", "Initialized at: #{Time.now}.")
+    @report_method.call('RestfulClientConfiguration', "Initialized at: #{Time.now.utc}.")
   end
 
   def env
-    @env_name || "default"
+    @env_name || 'default'
   end
-
 end

data/lib/restful_client_logger.rb

@@ -7,17 +7,18 @@ module RestfulClientLogger
 
   def rails_logger
     (defined?(Rails) && Rails.respond_to?(:logger) && Rails.logger) ||
-    (defined?(RAILS_DEFAULT_LOGGER) && RAILS_DEFAULT_LOGGER.respond_to?(:debug) && RAILS_DEFAULT_LOGGER)
+      (defined?(RAILS_DEFAULT_LOGGER) && RAILS_DEFAULT_LOGGER.respond_to?(:debug) && RAILS_DEFAULT_LOGGER)
   end
 
   def default_logger
     require 'logger'
-    l = Logger.new(STDOUT)
-    l.level = Logger::INFO
-    l
+    alogger = Logger.new(STDOUT)
+    alogger.level = Logger::INFO
+    alogger.datetime_format = '%c'
+    alogger
   end
 
   def logger=(logger)
     @logger = logger
   end
-end
+end

data/lib/restful_client_uri.rb

@@ -7,5 +7,4 @@ module RestfulClientUri
   def uri_join(url, path)
     File.join(url, path).to_s
   end
-
 end

data/restful_client.gemspec

@@ -1,26 +1,23 @@
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'restful_client/version'
 
 Gem::Specification.new do |spec|
   spec.name          = 'restful_client'
-  spec.version       = RestfulClient::VERSION
+  spec.version       = '0.3.0'
   spec.authors       = ['Avner Cohen']
   spec.email         = ['israbirding@gmail.com']
-  spec.description   = %q{An HTTP framework for micro-services based environment, build on top of Typheous and Service Jynx}
-  spec.summary       = %q{An HTTP framework for micro-services based environment}
+  spec.description   = 'An HTTP framework for micro-services based environment, build on top of Typheous and Service Jynx'
+  spec.summary       = 'An HTTP framework for micro-services based environment'
   spec.homepage      = 'https://github.com/AvnerCohen/restful_client'
   spec.license       = 'MIT'
 
-  spec.files         = `git ls-files`.split($/)
+  spec.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
 
   spec.add_development_dependency 'bundler'
-  spec.add_development_dependency 'rake'
 
   spec.add_runtime_dependency 'service_jynx'
   spec.add_runtime_dependency 'typhoeus'
 end
-