restforce 5.0.0 → 5.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c668433781a24af5211bf9c102e5601ef69919a856928fb4a876de43bb96fa14
-  data.tar.gz: 5d5ee573dc491e1eb38703028d2c107d28a9fa2b37616f08e3004cc20c653868
+  metadata.gz: 38acae68870155f93e38df159915fc242a663d02a4dbb252bb294c51763842e5
+  data.tar.gz: eeae1f3c32d469a435121baa0c9857b222cffea7055b4b3b50c84854191a5950
 SHA512:
-  metadata.gz: f938c2e517cb05c33c4526c04c0384edaa70f39bed1a391a58032fb52574fd50c20fab21f859439957070506d4c03d84447134885e14d5ad59f3bff02f689545
-  data.tar.gz: f2c466b8d4ae41bc6519dfaa27dbdbae2e302ad99c1ca52456f94bc391f243f99037bad48fc58533b83bb9cb146a30580e0cbe79a91cd9872e70fd0c9775865d
+  metadata.gz: e75731e44bfb826364edd12410a159d59a20c16865c4e6134736ec0ca83b06266cf8f5455772c92628fd092be94e4efb042951bbd6456865fc24d8cd2f7e3b80
+  data.tar.gz: af8a20544ea4f628a162d8038b8515ca2bd0333bd92f3796cbd19fcd713abfa46043395ee56a858ab5f2568b85e1961097269ac56fc29417633ead0dcbcd46f8

data/CHANGELOG.md

@@ -1,3 +1,34 @@
+## 5.0.5 (Feb 17, 2021)
+
+* Handle the `CANNOT_EXECUTE_FLOW_TRIGGER` error returned by Salesforce (@almusavi, @timrogers)
+
+## 5.0.4 (Jan 18, 2021)
+
+* Handle the `INVALID_QUERY_LOCATOR` error returned by Salesforce
+* Handle the `INVALID_OPERATION_WITH_EXPIRED_PASSWORD` error returned by Salesforce
+* Handle the `FIELD_INTEGRITY_EXCEPTION` error returned by Salesforce
+* Handle the `FORBIDDEN` error returned by Salesforce
+* Handle the `ILLEGAL_QUERY_PARAMETER_VALUE` error returned by Salesforce
+* Handle the `JSON_PARSER_ERROR` error returned by Salesforce
+
+## 5.0.3 (Sep 8, 2020)
+
+* Handle the undocumented `EXCEEDED_MAX_SEMIJOIN_SUBSELECTS` error returned by Salesforce (@embertel, @timrogers)
+
+## 5.0.2 (Sep 6, 2020)
+
+* Handle the undocumented `REQUEST_LIMIT_EXCEEDED` error returned by Salesforce (@wkirkby, @timrogers)
+* Handle the undocumented `SERVER_UNAVAILABLE` error returned by Salesforce (@wkirkby, @timrogers)
+* Refactor the library to be compatible with Rubocop 0.90's cops (this shouldn't introduce any noticeable changes see #569 for detailed changes) (@timrogers)
+
+## 5.0.1 (Aug 13, 2020)
+
+* Handle the undocumented `API_CURRENTLY_DISABLED` error returned by Salesforce (@ruipserra, @timrogers)
+* Handle the undocumented `MALFORMED_QUERY` error returned by Salesforce (@scottserok, @timrogers)
+* Handle the undocumented `INVALID_QUERY_FILTER_OPERATOR` error returned by Salesforce (@Dantemss, @timrogers)
+* Add documentation and scripts for running the
+library's tests using Docker (@ryansch)
+
 ## 5.0.0 (Jul 10, 2020)
 
 For instructions on upgrading from Restforce 4.x to 5.x, see our ["Upgrading from Restforce 4.x to 5.x"](https://github.com/restforce/restforce/blob/master/UPGRADING.md) guide.

data/CONTRIBUTING.md

@@ -35,3 +35,23 @@ Some things that will increase the chance that your pull request is accepted:
 * Write a [good commit message](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html).
 
 *Adapted from [factory_bot_rails's CONTRIBUTING.md](https://github.com/thoughtbot/factory_bot_rails/blob/master/CONTRIBUTING.md).*
+
+## Docker
+
+If you'd rather use a docker container to run the tests, you can use the following instructions.
+
+To set up the container image:
+
+`docker-compose build --pull`
+
+To run specs:
+
+`docker-compose run --rm restforce rspec`
+
+To run rubocop:
+
+`docker-compose run --rm restforce rubocop`
+
+To reset the bundler cache:
+
+`docker-compose down -v`

data/Dockerfile

@@ -0,0 +1,31 @@
+FROM ruby:2.6.5-alpine
+
+RUN apk add --no-cache \
+  ca-certificates \
+  wget \
+  openssl \ 
+  bash \
+  build-base \
+  git \
+  sqlite-dev \
+  tzdata \
+  tini
+
+ENV LANG en_US.UTF-8
+ENV LANGUAGE en_US:en
+ENV LC_ALL en_US.UTF-8
+
+ENV BUNDLER_VERSION 2.1.4
+RUN gem install bundler -v ${BUNDLER_VERSION} -i /usr/local/lib/ruby/gems/$(ls /usr/local/lib/ruby/gems) --force
+
+WORKDIR /srv
+
+COPY Gemfile restforce.gemspec /srv/
+COPY lib/restforce/version.rb /srv/lib/restforce/version.rb
+
+RUN bundle install
+
+COPY . /srv/
+
+ENTRYPOINT ["/sbin/tini", "-g", "--", "bundle", "exec"]
+CMD ["rspec"]

data/README.md

@@ -25,7 +25,7 @@ Features include:
 
 Add this line to your application's Gemfile:
 
-    gem 'restforce', '~> 5.0.0'
+    gem 'restforce', '~> 5.0.5'
 
 And then execute:
 
@@ -37,7 +37,7 @@ Or install it yourself as:
 
 __As of version 5.0.0, this gem is only compatible with Ruby 2.5.0 and later.__ If you're using an earlier Ruby version:
 
-* for Ruby 2.4, use version 4.2.2 or earlier
+* for Ruby 2.4, use version 4.3.0 or earlier
 * for Ruby 2.3, use version 3.2.0 or earlier
 * for Ruby versions 2.2, 2.1 and 2.0, use version 2.5.3 or earlier
 * for Ruby 1.9.3, use version 2.4.2
@@ -333,8 +333,11 @@ client.update('Account', Id: '0016000000MRatd', Name: 'Whizbang Corp')
 ```ruby
 # Update the record with external `External__c` external ID set to '12'
 client.upsert('Account', 'External__c', External__c: 12, Name: 'Foobar')
+# => true or "RecordId"
 ```
 
+The upsert method will return the record Id if included in the response body from the Salesforce API; otherwise, it returns true. Currently the Salesforce API only returns the Id for newly created records.
+
 ### destroy
 
 ```ruby

data/docker-compose.yml

@@ -0,0 +1,7 @@
+version: "3.6"
+services:
+  restforce:
+    build: .
+    image: restforce:dev
+    volumes:
+      - .:/srv

data/lib/restforce/collection.rb

@@ -12,12 +12,12 @@ module Restforce
     end
 
     # Yield each value on each page.
-    def each
+    def each(&block)
       @raw_page['records'].each { |record| yield Restforce::Mash.build(record, @client) }
 
       np = next_page
       while np
-        np.current_page.each { |record| yield record }
+        np.current_page.each(&block)
         np = np.next_page
       end
     end

data/lib/restforce/concerns/picklists.rb

@@ -35,7 +35,7 @@ module Restforce
           @valid_for = options.delete(:valid_for)
           raise "#{field} is not a dependent picklist" if @valid_for && !dependent?
 
-          replace(picklist_values)
+          super(picklist_values)
         end
 
         private

data/lib/restforce/concerns/streaming.rb

@@ -95,9 +95,7 @@ module Restforce
 
         def replay_id(channel)
           handler = @replay_handlers[channel]
-          if handler.is_a?(Integer)
-            handler # treat it as a scalar
-          elsif handler.respond_to?(:[])
+          if handler.respond_to?(:[]) && !handler.is_a?(Integer)
             # Ask for the latest replayId for this channel
             handler[channel]
           else

data/lib/restforce/config.rb

@@ -151,7 +151,7 @@ module Restforce
     option :request_headers
 
     # Set a logger for when Restforce.log is set to true, defaulting to STDOUT
-    option :logger, default: ::Logger.new(STDOUT)
+    option :logger, default: ::Logger.new($stdout)
 
     # Set a log level for logging when Restforce.log is set to true, defaulting to :debug
     option :log_level, default: :debug

data/lib/restforce/error_code.rb

@@ -14,180 +14,381 @@ module Restforce
     # It is possible that we will be missing some errors, so we will handle this in
     # at least a semi-graceful manner.
     class AllOrNoneOperationRolledBack < ResponseError; end
+
     class AlreadyInProcess < ResponseError; end
+
+    class ApiCurrentlyDisabled < ResponseError; end
+
     class AssigneeTypeRequired < ResponseError; end
+
     class BadCustomEntityParentDomain < ResponseError; end
+
     class BccNotAllowedIfBccComplianceEnabled < ResponseError; end
+
     class BccSelfNotAllowedIfBccComplianceEnabled < ResponseError; end
+
     class CannotCascadeProductActive < ResponseError; end
+
     class CannotChangeFieldTypeOfApexReferencedField < ResponseError; end
+
     class CannotCreateAnotherManagedPackage < ResponseError; end
+
     class CannotDeactivateDivision < ResponseError; end
+
     class CannotDeleteLastDatedConversionRate < ResponseError; end
+
     class CannotDeleteManagedObject < ResponseError; end
+
     class CannotDisableLastAdmin < ResponseError; end
+
     class CannotEnableIpRestrictRequests < ResponseError; end
+
+    class CannotExecuteFlowTrigger < ResponseError; end
+
     class CannotInsertUpdateActivateEntity < ResponseError; end
+
     class CannotModifyManagedObject < ResponseError; end
+
     class CannotRenameApexReferencedField < ResponseError; end
+
     class CannotRenameApexReferencedObject < ResponseError; end
+
     class CannotReparentRecord < ResponseError; end
+
     class CannotResolveName < ResponseError; end
+
     class CannotUpdateConvertedLead < ResponseError; end
+
     class CantDisableCorpCurrency < ResponseError; end
+
     class CantUnsetCorpCurrency < ResponseError; end
+
     class ChildShareFailsParent < ResponseError; end
+
     class CircularDependency < ResponseError; end
+
     class CommunityNotAccessible < ResponseError; end
+
     class CustomClobFieldLimitExceeded < ResponseError; end
+
     class CustomEntityOrFieldLimit < ResponseError; end
+
     class CustomFieldIndexLimitExceeded < ResponseError; end
+
     class CustomIndexExists < ResponseError; end
+
     class CustomLinkLimitExceeded < ResponseError; end
+
     class CustomMetadataLimitExceeded < ResponseError; end
+
     class CustomSettingsLimitExceeded < ResponseError; end
+
     class CustomTabLimitExceeded < ResponseError; end
+
     class DeleteFailed < ResponseError; end
+
     class DependencyExists < ResponseError; end
+
     class DuplicateCaseSolution < ResponseError; end
+
     class DuplicateCustomEntityDefinition < ResponseError; end
+
     class DuplicateCustomTabMotif < ResponseError; end
+
     class DuplicateDeveloperName < ResponseError; end
+
     class DuplicatesDetected < ResponseError; end
+
     class DuplicateExternalId < ResponseError; end
+
     class DuplicateMasterLabel < ResponseError; end
+
     class DuplicateSenderDisplayName < ResponseError; end
+
     class DuplicateUsername < ResponseError; end
+
     class DuplicateValue < ResponseError; end
+
     class EmailAddressBounced < ResponseError; end
+
     class EmailNotProcessedDueToPriorError < ResponseError; end
+
     class EmailOptedOut < ResponseError; end
+
     class EmailTemplateFormulaError < ResponseError; end
+
     class EmailTemplateMergefieldAccessError < ResponseError; end
+
     class EmailTemplateMergefieldError < ResponseError; end
+
     class EmailTemplateMergefieldValueError < ResponseError; end
+
     class EmailTemplateProcessingError < ResponseError; end
+
     class EmptyScontrolFileName < ResponseError; end
+
     class EntityFailedIflastmodifiedOnUpdate < ResponseError; end
+
     class EntityIsArchived < ResponseError; end
+
     class EntityIsDeleted < ResponseError; end
+
     class EntityIsLocked < ResponseError; end
+
     class EnvironmentHubMembershipConflict < ResponseError; end
+
     class ErrorInMailer < ResponseError; end
+
+    class ExceededMaxSemijoinSubselects < ResponseError; end
+
     class FailedActivation < ResponseError; end
+
     class FieldCustomValidationException < ResponseError; end
+
     class FieldFilterValidationException < ResponseError; end
+
+    class FieldIntegrityException < ResponseError; end
+
     class FilteredLookupLimitExceeded < ResponseError; end
+
+    class Forbidden < ResponseError; end
+
     class HtmlFileUploadNotAllowed < ResponseError; end
+
+    class IllegalQueryParameterValue < ResponseError; end
+
     class ImageTooLarge < ResponseError; end
+
     class InactiveOwnerOrUser < ResponseError; end
+
     class InsertUpdateDeleteNotAllowedDuringMaintenance < ResponseError; end
+
     class InsufficientAccessOnCrossReferenceEntity < ResponseError; end
+
     class InsufficientAccessOrReadonly < ResponseError; end
+
     class InvalidAccessLevel < ResponseError; end
+
     class InvalidArgumentType < ResponseError; end
+
     class InvalidAssigneeType < ResponseError; end
+
     class InvalidAssignmentRule < ResponseError; end
+
     class InvalidBatchOperation < ResponseError; end
+
     class InvalidContentType < ResponseError; end
+
     class InvalidCreditCardInfo < ResponseError; end
+
     class InvalidCrossReferenceKey < ResponseError; end
+
     class InvalidCrossReferenceTypeForField < ResponseError; end
+
     class InvalidCurrencyConvRate < ResponseError; end
+
     class InvalidCurrencyCorpRate < ResponseError; end
+
     class InvalidCurrencyIso < ResponseError; end
+
     class InvalidEmailAddress < ResponseError; end
+
     class InvalidEmptyKeyOwner < ResponseError; end
+
     class InvalidEventSubscription < ResponseError; end
+
     class InvalidField < ResponseError; end
+
     class InvalidFieldForInsertUpdate < ResponseError; end
+
     class InvalidFieldWhenUsingTemplate < ResponseError; end
+
     class InvalidFilterAction < ResponseError; end
+
     class InvalidIdField < ResponseError; end
+
     class InvalidInetAddress < ResponseError; end
+
     class InvalidLineitemCloneState < ResponseError; end
+
     class InvalidMasterOrTranslatedSolution < ResponseError; end
+
     class InvalidMessageIdReference < ResponseError; end
+
     class InvalidOperation < ResponseError; end
+
+    class InvalidOperationWithExpiredPassword < ResponseError; end
+
     class InvalidOperator < ResponseError; end
+
     class InvalidOrNullForRestrictedPicklist < ResponseError; end
+
+    class InvalidQueryFilterOperator < ResponseError; end
+
+    class InvalidQueryLocator < ResponseError; end
+
     class InvalidPartnerNetworkStatus < ResponseError; end
+
     class InvalidPersonAccountOperation < ResponseError; end
+
     class InvalidReadOnlyUserDml < ResponseError; end
+
     class InvalidSaveAsActivityFlag < ResponseError; end
+
     class InvalidSessionId < ResponseError; end
+
     class InvalidStatus < ResponseError; end
+
     class InvalidType < ResponseError; end
+
     class InvalidTypeForOperation < ResponseError; end
+
     class InvalidTypeOnFieldInRecord < ResponseError; end
+
     class IpRangeLimitExceeded < ResponseError; end
+
     class JigsawImportLimitExceeded < ResponseError; end
+
+    class JsonParserError < ResponseError; end
+
     class LicenseLimitExceeded < ResponseError; end
+
     class LightPortalUserException < ResponseError; end
+
     class LimitExceeded < ResponseError; end
+
     class LoginChallengeIssued < ResponseError; end
+
     class LoginChallengePending < ResponseError; end
+
     class LoginMustUseSecurityToken < ResponseError; end
+
     class MalformedId < ResponseError; end
+
+    class MalformedQuery < ResponseError; end
+
     class ManagerNotDefined < ResponseError; end
+
     class MassmailRetryLimitExceeded < ResponseError; end
+
     class MassMailLimitExceeded < ResponseError; end
+
     class MaximumCcemailsExceeded < ResponseError; end
+
     class MaximumDashboardComponentsExceeded < ResponseError; end
+
     class MaximumHierarchyLevelsReached < ResponseError; end
+
     class MaximumSizeOfAttachment < ResponseError; end
+
     class MaximumSizeOfDocument < ResponseError; end
+
     class MaxActionsPerRuleExceeded < ResponseError; end
+
     class MaxActiveRulesExceeded < ResponseError; end
+
     class MaxApprovalStepsExceeded < ResponseError; end
+
     class MaxFormulasPerRuleExceeded < ResponseError; end
+
     class MaxRulesExceeded < ResponseError; end
+
     class MaxRuleEntriesExceeded < ResponseError; end
+
     class MaxTaskDescriptionExceeded < ResponseError; end
+
     class MaxTmRulesExceeded < ResponseError; end
+
     class MaxTmRuleItemsExceeded < ResponseError; end
+
     class MergeFailed < ResponseError; end
+
     class MissingArgument < ResponseError; end
+
     class NonuniqueShippingAddress < ResponseError; end
+
     class NoApplicableProcess < ResponseError; end
+
     class NoAttachmentPermission < ResponseError; end
+
     class NoInactiveDivisionMembers < ResponseError; end
+
     class NoMassMailPermission < ResponseError; end
+
     class NumberOutsideValidRange < ResponseError; end
+
     class NumHistoryFieldsBySobjectExceeded < ResponseError; end
+
     class OpWithInvalidUserTypeException < ResponseError; end
+
     class OptedOutOfMassMail < ResponseError; end
+
     class PackageLicenseRequired < ResponseError; end
+
     class PlatformEventEncryptionError < ResponseError; end
+
     class PlatformEventPublishingUnavailable < ResponseError; end
+
     class PlatformEventPublishFailed < ResponseError; end
+
     class PortalUserAlreadyExistsForContact < ResponseError; end
+
     class PrivateContactOnAsset < ResponseError; end
+
     class RecordInUseByWorkflow < ResponseError; end
+
+    class RequestLimitExceeded < ResponseError; end
+
     class RequestRunningTooLong < ResponseError; end
+
     class RequiredFieldMissing < ResponseError; end
+
     class SelfReferenceFromTrigger < ResponseError; end
+
+    class ServerUnavailable < ResponseError; end
+
     class ShareNeededForChildOwner < ResponseError; end
+
     class SingleEmailLimitExceeded < ResponseError; end
+
     class StandardPriceNotDefined < ResponseError; end
+
     class StorageLimitExceeded < ResponseError; end
+
     class StringTooLong < ResponseError; end
+
     class TabsetLimitExceeded < ResponseError; end
+
     class TemplateNotActive < ResponseError; end
+
     class TerritoryRealignInProgress < ResponseError; end
+
     class TextDataOutsideSupportedCharset < ResponseError; end
+
     class TooManyApexRequests < ResponseError; end
+
     class TooManyEnumValue < ResponseError; end
+
     class TransferRequiresRead < ResponseError; end
+
     class UnableToLockRow < ResponseError; end
+
     class UnavailableRecordtypeException < ResponseError; end
+
     class UndeleteFailed < ResponseError; end
+
     class UnknownException < ResponseError; end
+
     class UnspecifiedEmailAddress < ResponseError; end
+
     class UnsupportedApexTriggerOperation < ResponseError; end
+
     class UnverifiedSenderAddress < ResponseError; end
+
     class WeblinkSizeLimitExceeded < ResponseError; end
+
     class WeblinkUrlInvalid < ResponseError; end
+
     class WrongControllerType < ResponseError; end
 
     # Maps `errorCode`s returned from Salesforce to the exception class
@@ -195,6 +396,7 @@ module Restforce
     ERROR_EXCEPTION_CLASSES = {
       "ALL_OR_NONE_OPERATION_ROLLED_BACK" => AllOrNoneOperationRolledBack,
       "ALREADY_IN_PROCESS" => AlreadyInProcess,
+      "API_CURRENTLY_DISABLED" => ApiCurrentlyDisabled,
       "ASSIGNEE_TYPE_REQUIRED" => AssigneeTypeRequired,
       "BAD_CUSTOM_ENTITY_PARENT_DOMAIN" => BadCustomEntityParentDomain,
       "BCC_NOT_ALLOWED_IF_BCC_COMPLIANCE_ENABLED" =>
@@ -211,6 +413,7 @@ module Restforce
       "CANNOT_DELETE_MANAGED_OBJECT" => CannotDeleteManagedObject,
       "CANNOT_DISABLE_LAST_ADMIN" => CannotDisableLastAdmin,
       "CANNOT_ENABLE_IP_RESTRICT_REQUESTS" => CannotEnableIpRestrictRequests,
+      "CANNOT_EXECUTE_FLOW_TRIGGER" => CannotExecuteFlowTrigger,
       "CANNOT_INSERT_UPDATE_ACTIVATE_ENTITY" => CannotInsertUpdateActivateEntity,
       "CANNOT_MODIFY_MANAGED_OBJECT" => CannotModifyManagedObject,
       "CANNOT_RENAME_APEX_REFERENCED_FIELD" => CannotRenameApexReferencedField,
@@ -260,11 +463,15 @@ module Restforce
       "ENTITY_IS_LOCKED" => EntityIsLocked,
       "ENVIRONMENT_HUB_MEMBERSHIP_CONFLICT" => EnvironmentHubMembershipConflict,
       "ERROR_IN_MAILER" => ErrorInMailer,
+      "EXCEEDED_MAX_SEMIJOIN_SUBSELECTS" => ExceededMaxSemijoinSubselects,
       "FAILED_ACTIVATION" => FailedActivation,
       "FIELD_CUSTOM_VALIDATION_EXCEPTION" => FieldCustomValidationException,
       "FIELD_FILTER_VALIDATION_EXCEPTION" => FieldFilterValidationException,
+      "FIELD_INTEGRITY_EXCEPTION" => FieldIntegrityException,
       "FILTERED_LOOKUP_LIMIT_EXCEEDED" => FilteredLookupLimitExceeded,
+      "FORBIDDEN" => Forbidden,
       "HTML_FILE_UPLOAD_NOT_ALLOWED" => HtmlFileUploadNotAllowed,
+      "ILLEGAL_QUERY_PARAMETER_VALUE" => IllegalQueryParameterValue,
       "IMAGE_TOO_LARGE" => ImageTooLarge,
       "INACTIVE_OWNER_OR_USER" => InactiveOwnerOrUser,
       "INSERT_UPDATE_DELETE_NOT_ALLOWED_DURING_MAINTENANCE" =>
@@ -297,9 +504,12 @@ module Restforce
       "INVALID_MASTER_OR_TRANSLATED_SOLUTION" => InvalidMasterOrTranslatedSolution,
       "INVALID_MESSAGE_ID_REFERENCE" => InvalidMessageIdReference,
       "INVALID_OPERATION" => InvalidOperation,
+      "INVALID_OPERATION_WITH_EXPIRED_PASSWORD" => InvalidOperationWithExpiredPassword,
       "INVALID_OPERATOR" => InvalidOperator,
       "INVALID_OR_NULL_FOR_RESTRICTED_PICKLIST" =>
    InvalidOrNullForRestrictedPicklist,
+      "INVALID_QUERY_FILTER_OPERATOR" => InvalidQueryFilterOperator,
+      "INVALID_QUERY_LOCATOR" => InvalidQueryLocator,
       "INVALID_PARTNER_NETWORK_STATUS" => InvalidPartnerNetworkStatus,
       "INVALID_PERSON_ACCOUNT_OPERATION" => InvalidPersonAccountOperation,
       "INVALID_READ_ONLY_USER_DML" => InvalidReadOnlyUserDml,
@@ -311,6 +521,7 @@ module Restforce
       "INVALID_TYPE_ON_FIELD_IN_RECORD" => InvalidTypeOnFieldInRecord,
       "IP_RANGE_LIMIT_EXCEEDED" => IpRangeLimitExceeded,
       "JIGSAW_IMPORT_LIMIT_EXCEEDED" => JigsawImportLimitExceeded,
+      "JSON_PARSER_ERROR" => JsonParserError,
       "LICENSE_LIMIT_EXCEEDED" => LicenseLimitExceeded,
       "LIGHT_PORTAL_USER_EXCEPTION" => LightPortalUserException,
       "LIMIT_EXCEEDED" => LimitExceeded,
@@ -318,6 +529,7 @@ module Restforce
       "LOGIN_CHALLENGE_PENDING" => LoginChallengePending,
       "LOGIN_MUST_USE_SECURITY_TOKEN" => LoginMustUseSecurityToken,
       "MALFORMED_ID" => MalformedId,
+      "MALFORMED_QUERY" => MalformedQuery,
       "MANAGER_NOT_DEFINED" => ManagerNotDefined,
       "MASSMAIL_RETRY_LIMIT_EXCEEDED" => MassmailRetryLimitExceeded,
       "MASS_MAIL_LIMIT_EXCEEDED" => MassMailLimitExceeded,
@@ -353,9 +565,11 @@ module Restforce
       "PORTAL_USER_ALREADY_EXISTS_FOR_CONTACT" => PortalUserAlreadyExistsForContact,
       "PRIVATE_CONTACT_ON_ASSET" => PrivateContactOnAsset,
       "RECORD_IN_USE_BY_WORKFLOW" => RecordInUseByWorkflow,
+      "REQUEST_LIMIT_EXCEEDED" => RequestLimitExceeded,
       "REQUEST_RUNNING_TOO_LONG" => RequestRunningTooLong,
       "REQUIRED_FIELD_MISSING" => RequiredFieldMissing,
       "SELF_REFERENCE_FROM_TRIGGER" => SelfReferenceFromTrigger,
+      "SERVER_UNAVAILABLE" => ServerUnavailable,
       "SHARE_NEEDED_FOR_CHILD_OWNER" => ShareNeededForChildOwner,
       "SINGLE_EMAIL_LIMIT_EXCEEDED" => SingleEmailLimitExceeded,
       "STANDARD_PRICE_NOT_DEFINED" => StandardPriceNotDefined,

data/lib/restforce/mash.rb

@@ -11,9 +11,10 @@ module Restforce
       # appropriate Restforce::Collection, Restforce::SObject and
       # Restforce::Mash objects.
       def build(val, client)
-        if val.is_a?(Array)
+        case val
+        when Array
           val.collect { |a_val| self.build(a_val, client) }
-        elsif val.is_a?(Hash)
+        when Hash
           self.klass(val).new(val, client)
         else
           val
@@ -55,6 +56,9 @@ module Restforce
       self.class.new(self, @client, self.default)
     end
 
+    # The #convert_value method and its signature are part of Hashie::Mash's API, so we
+    # can't unilaterally decide to change `duping` to be a keyword argument
+    # rubocop:disable Style/OptionalBooleanParameter
     def convert_value(val, duping = false)
       case val
       when self.class
@@ -68,5 +72,6 @@ module Restforce
         val
       end
     end
+    # rubocop:enable Style/OptionalBooleanParameter
   end
 end

data/lib/restforce/middleware.rb

@@ -16,6 +16,8 @@ module Restforce
     autoload :CustomHeaders,  'restforce/middleware/custom_headers'
 
     def initialize(app, client, options)
+      super(app)
+
       @app = app
       @client = client
       @options = options

data/lib/restforce/middleware/logger.rb

@@ -11,7 +11,7 @@ module Restforce
       @options = options
       @logger = logger || begin
         require 'logger'
-        ::Logger.new(STDOUT)
+        ::Logger.new($stdout)
       end
     end
 
@@ -36,7 +36,8 @@ module Restforce
     end
 
     def dump(hash)
-      "\n" + hash.map { |k, v| "  #{k}: #{v.inspect}" }.join("\n")
+      dumped_pairs = hash.map { |k, v| "  #{k}: #{v.inspect}" }.join("\n")
+      "\n#{dumped_pairs}"
     end
   end
 end

data/lib/restforce/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Restforce
-  VERSION = '5.0.0'
+  VERSION = '5.0.5'
 end

data/restforce.gemspec

@@ -34,7 +34,8 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency 'faye' unless RUBY_PLATFORM == 'java'
   gem.add_development_dependency 'rspec', '~> 2.14.0'
   gem.add_development_dependency 'rspec_junit_formatter', '~> 0.4.1'
-  gem.add_development_dependency 'rubocop', '~> 0.87.1'
-  gem.add_development_dependency 'simplecov', '~> 0.18.2'
-  gem.add_development_dependency 'webmock', '~> 3.8.3'
+
+  gem.add_development_dependency 'rubocop', '~> 1.9.1'
+  gem.add_development_dependency 'simplecov', '~> 0.21.2'
+  gem.add_development_dependency 'webmock', '~> 3.11.1'
 end

data/spec/unit/middleware/authentication_spec.rb

@@ -8,7 +8,9 @@ describe Restforce::Middleware::Authentication do
       proxy_uri: 'https://not-a-real-site.com',
       authentication_retries: retries,
       adapter: :net_http,
+      # rubocop:disable Naming/VariableNumber
       ssl: { version: :TLSv1_2 } }
+    # rubocop:enable Naming/VariableNumber
   end
 
   describe '.authenticate!' do
@@ -88,7 +90,9 @@ describe Restforce::Middleware::Authentication do
     end
 
     it "should have SSL config set" do
+      # rubocop:disable Naming/VariableNumber
       connection.ssl[:version].should eq(:TLSv1_2)
+      # rubocop:enable Naming/VariableNumber
     end
   end
 

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: restforce
 version: !ruby/object:Gem::Version
-  version: 5.0.0
+  version: 5.0.5
 platform: ruby
 authors:
 - Tim Rogers
 - Eric J. Holmes
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-07-10 00:00:00.000000000 Z
+date: 2021-02-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -133,42 +133,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.87.1
+        version: 1.9.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.87.1
+        version: 1.9.1
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.18.2
+        version: 0.21.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.18.2
+        version: 0.21.2
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.8.3
+        version: 3.11.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.8.3
+        version: 3.11.1
 description: A lightweight Ruby client for the Salesforce REST API
 email:
 - me@timrogers.co.uk
@@ -185,12 +185,14 @@ files:
 - CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - CONTRIBUTING.md
+- Dockerfile
 - Gemfile
 - Guardfile
 - LICENSE
 - README.md
 - Rakefile
 - UPGRADING.md
+- docker-compose.yml
 - lib/restforce.rb
 - lib/restforce/abstract_client.rb
 - lib/restforce/attachment.rb
@@ -317,7 +319,7 @@ licenses:
 metadata:
   source_code_uri: https://github.com/restforce/restforce
   changelog_uri: https://github.com/restforce/restforce/blob/master/CHANGELOG.md
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -332,8 +334,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
-signing_key: 
+rubygems_version: 3.2.5
+signing_key:
 specification_version: 4
 summary: A lightweight Ruby client for the Salesforce REST API
 test_files: