restforce 1.5.3 → 2.0.0

data/spec/unit/middleware/instance_url_spec.rb

@@ -6,7 +6,7 @@ describe Restforce::Middleware::InstanceURL do
 
     context 'when the instance url is not set' do
       before do
-        client.stub_chain :connection, :url_prefix => URI.parse('http:/')
+        client.stub_chain :connection, url_prefix: URI.parse('http:/')
       end
 
       it { should raise_error Restforce::UnauthorizedError }
@@ -14,7 +14,7 @@ describe Restforce::Middleware::InstanceURL do
 
     context 'when the instance url is set' do
       before do
-        client.stub_chain :connection, :url_prefix => URI.parse('http://foobar.com/')
+        client.stub_chain :connection, url_prefix: URI.parse('http://foobar.com/')
         app.should_receive(:call).once
       end
 

data/spec/unit/middleware/mashify_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 describe Restforce::Middleware::Mashify do
-  let(:env) { { :body => JSON.parse(fixture('sobject/query_success_response')) } }
+  let(:env) { { body: JSON.parse(fixture('sobject/query_success_response')) } }
   subject(:middleware) {
     described_class.new(lambda {|env|
       Faraday::Response.new(env)
@@ -10,7 +10,7 @@ describe Restforce::Middleware::Mashify do
 
   describe '.call' do
     it "should change the body to a Restforce::Collection" do
-      expect( middleware.call(env).body ).to be_kind_of(Restforce::Collection)
+      expect(middleware.call(env).body).to be_kind_of(Restforce::Collection)
     end
   end
 end

data/spec/unit/middleware/raise_error_spec.rb

@@ -2,31 +2,47 @@ require 'spec_helper'
 
 describe Restforce::Middleware::RaiseError do
   let(:body)       { fixture('sobject/query_error_response') }
-  let(:env)        { { :status => status, :body => body } }
+  let(:env)        { { status: status, body: body } }
   let(:middleware) { described_class.new app }
 
   describe '.on_complete' do
-    subject { lambda { middleware.on_complete(env) } }
+    subject(:on_complete) { middleware.on_complete(env) }
 
     context 'when the status code is 404' do
       let(:status) { 404 }
-      it { should raise_error Faraday::Error::ResourceNotFound, 'INVALID_FIELD: error_message' }
+
+      it "raises an error" do
+        expect { on_complete }.to raise_error Faraday::Error::ResourceNotFound,
+                                              'INVALID_FIELD: error_message'
+      end
     end
 
     context 'when the status code is 400' do
       let(:status) { 400 }
-      it { should raise_error Faraday::Error::ClientError, 'INVALID_FIELD: error_message' }
+
+      it "raises an error" do
+        expect { on_complete }.to raise_error Faraday::Error::ClientError,
+                                              'INVALID_FIELD: error_message'
+      end
     end
 
     context 'when the status code is 401' do
       let(:status) { 401 }
-      it { should raise_error Restforce::UnauthorizedError, 'INVALID_FIELD: error_message' }
+
+      it "raises an error" do
+        expect { on_complete }.to raise_error Restforce::UnauthorizedError,
+                                              'INVALID_FIELD: error_message'
+      end
     end
 
     context 'when the status code is 413' do
       let(:status) { 413 }
-      let(:body) { '' } #Zero length response
-      it { should raise_error Faraday::Error::ClientError, 'HTTP 413 - Request Entity Too Large' }
+      let(:body) { '' } # Zero length response
+
+      it "raises an error" do
+        expect { on_complete }.to raise_error Faraday::Error::ClientError,
+                                              'HTTP 413 - Request Entity Too Large'
+      end
     end
   end
 end

data/spec/unit/sobject_spec.rb

@@ -1,8 +1,12 @@
 require 'spec_helper'
 
 describe Restforce::SObject do
-  let(:client)      { double('Client') }
-  let(:hash)        { JSON.parse(fixture('sobject/query_success_response'))['records'].first }
+  let(:client) { double('Client') }
+
+  let(:hash) do
+    JSON.parse(fixture('sobject/query_success_response'))['records'].first
+  end
+
   subject(:sobject) { described_class.new(hash, client) }
 
   describe '#new' do
@@ -34,20 +38,23 @@ describe Restforce::SObject do
     end
   end
 
-  { :save     => :update,
-    :save!    => :update!,
-    :destroy  => :destroy,
-    :destroy! => :destroy! }.each do |method, receiver|
+  { save: :update,
+    save!: :update!,
+    destroy: :destroy,
+    destroy!: :destroy! }.each do |method, receiver|
     describe ".#{method}" do
-      subject { lambda { sobject.send(method) } }
+      subject(:send_method) { sobject.send(method) }
 
       context 'when an Id was not queried' do
-        it { should raise_error ArgumentError, 'You need to query the Id for the record first.' }
+        it "raises an error" do
+          expect { send_method }.to raise_error ArgumentError,
+                                                /need to query the Id for the record/
+        end
       end
 
       context 'when an Id is present' do
         before do
-          hash.merge!(:Id => '001D000000INjVe')
+          hash.merge!(Id: '001D000000INjVe')
           client.should_receive(receiver)
         end
 

data/spec/unit/tooling/client_spec.rb

@@ -4,4 +4,4 @@ describe Restforce::Tooling::Client do
   subject { described_class }
 
   it { should < Restforce::AbstractClient }
-end
+end

metadata

@@ -1,14 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: restforce
 version: !ruby/object:Gem::Version
-  version: 1.5.3
+  version: 2.0.0
 platform: ruby
 authors:
 - Eric J. Holmes
+- Tim Rogers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-26 00:00:00.000000000 Z
+date: 2015-06-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -120,6 +121,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.7.1
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.31.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.31.0
 - !ruby/object:Gem::Dependency
   name: faye
   requirement: !ruby/object:Gem::Requirement
@@ -134,14 +149,17 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: A lightweight ruby client for the Salesforce REST api.
+description: A lightweight ruby client for the Salesforce REST API.
 email:
 - eric@ejholmes.net
+- tim@gocardless.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rubocop.yml"
+- ".rubocop_todo.yml"
 - ".travis.yml"
 - CHANGELOG.md
 - Gemfile
@@ -264,7 +282,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.9.3
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -275,7 +293,7 @@ rubyforge_project:
 rubygems_version: 2.4.7
 signing_key: 
 specification_version: 4
-summary: A lightweight ruby client for the Salesforce REST api.
+summary: A lightweight ruby client for the Salesforce REST API.
 test_files:
 - spec/fixtures/auth_error_response.json
 - spec/fixtures/auth_success_response.json