rest-more 0.7.0

data/test/client/facebook/test_cache.rb

@@ -0,0 +1,58 @@
+
+require 'rest-core/test'
+
+describe RestCore::Facebook do
+  after do
+    WebMock.reset!
+    RR.verify
+  end
+
+  describe 'cache' do
+    before do
+      @url, @body = "https://graph.facebook.com/cache", '{"message":"ok"}'
+      @cache_key  = Digest::MD5.hexdigest(@url)
+      @cache = {}
+      @rg = RestCore::Facebook.new(:cache => @cache, :json_decode => false)
+      stub_request(:get, @url).to_return(:body => @body).times(1)
+    end
+
+    should 'enable cache if passing cache' do
+      3.times{ @rg.get('cache').should.eq @body }
+      @cache.should.eq({@cache_key => @body})
+    end
+
+    should 'respect expires_in' do
+      mock(@cache).method(:store){ mock!.arity{ -3 } }
+      mock(@cache).store(@cache_key, @body, :expires_in => 3)
+      @rg.get('cache', {}, :expires_in => 3).should.eq @body
+    end
+
+    should 'update cache if there is cache option set to false' do
+      @rg.get('cache')                     .should.eq @body
+      stub_request(:get, @url).to_return(:body => @body.reverse).times(2)
+      @rg.get('cache')                     .should.eq @body
+      @rg.get('cache', {}, :cache => false).should.eq @body.reverse
+      @rg.get('cache')                     .should.eq @body.reverse
+      @rg.cache = nil
+      @rg.get('cache', {}, :cache => false).should.eq @body.reverse
+    end
+  end
+
+  should 'not cache post/put/delete' do
+    [:put, :post, :delete].each{ |meth|
+      url, body = "https://graph.facebook.com/cache", '{"message":"ok"}'
+      stub_request(meth, url).to_return(:body => body).times(3)
+
+      cache = {}
+      rg = RestCore::Facebook.new(:cache => cache)
+      3.times{
+        if meth == :delete
+          rg.send(meth, 'cache').should.eq({'message' => 'ok'})
+        else
+          rg.send(meth, 'cache', 'payload').should.eq({'message' => 'ok'})
+        end
+      }
+      cache.should.eq({})
+    }
+  end
+end

data/test/client/facebook/test_default.rb

@@ -0,0 +1,23 @@
+
+require 'rest-core/test'
+
+describe RestCore::Facebook do
+  should 'honor default attributes' do
+    RestCore::Facebook.members.reject{ |name|
+      name.to_s =~ /method$|handler$|detector$/ }.each{ |name|
+        RestCore::Facebook.new.send(name).should ==
+        RestCore::Facebook.new.send("default_#{name}")
+    }
+  end
+
+  should 'use module to override default attributes' do
+    klass = RestCore::Facebook.dup
+    klass.send(:include, Module.new do
+      def default_app_id
+        '1829'
+      end
+    end)
+
+    klass.new.app_id.should.eq('1829')
+  end
+end

data/test/client/facebook/test_error.rb

@@ -0,0 +1,65 @@
+
+require 'rest-core/test'
+
+describe RestCore::Facebook::Error do
+  after do
+    WebMock.reset!
+    RR.verify
+  end
+
+  should 'have the right ancestors' do
+    RestCore::Facebook::Error::AccessToken.should.lt RestCore::Facebook::Error
+
+    RestCore::Facebook::Error::InvalidAccessToken.should.lt \
+      RestCore::Facebook::Error::AccessToken
+
+    RestCore::Facebook::Error::MissingAccessToken.should.lt \
+      RestCore::Facebook::Error::AccessToken
+  end
+
+  def error2env hash
+    {RestCore::RESPONSE_BODY => hash,
+     RestCore::REQUEST_PATH  => '/' ,
+     RestCore::REQUEST_QUERY => {}}
+  end
+
+  should 'parse right' do
+    %w[OAuthInvalidTokenException OAuthException].each{ |type|
+      RestCore::Facebook::Error.call(error2env('error' => {'type' => type})).
+        should.kind_of?(RestCore::Facebook::Error::InvalidAccessToken)
+    }
+
+    RestCore::Facebook::Error.call(
+      error2env('error'=>{'type'   =>'QueryParseException',
+                          'message'=>'An active access token..'})).
+      should.kind_of?(RestCore::Facebook::Error::MissingAccessToken)
+
+    RestCore::Facebook::Error.call(
+      error2env('error'=>{'type'   =>'QueryParseException',
+                          'message'=>'Oh active access token..'})).
+      should.not.kind_of?(RestCore::Facebook::Error::MissingAccessToken)
+
+    RestCore::Facebook::Error.call(error2env('error_code' => 190)).
+      should.kind_of?(RestCore::Facebook::Error::InvalidAccessToken)
+
+    RestCore::Facebook::Error.call(error2env('error_code' => 104)).
+      should.kind_of?(RestCore::Facebook::Error::MissingAccessToken)
+
+    RestCore::Facebook::Error.call(error2env('error_code' => 999)).
+      should.not.kind_of?(RestCore::Facebook::Error::AccessToken)
+
+    error = RestCore::Facebook::Error.call(error2env(['not a hash']))
+    error.should.not.kind_of?(RestCore::Facebook::Error::AccessToken)
+    error.should    .kind_of?(RestCore::Facebook::Error)
+  end
+
+  should 'nuke cache upon errors' do
+    stub_request(:get, 'https://graph.facebook.com/me').
+      to_return(:body => '{"error":"wrong"}').times(2)
+
+    rg = RestCore::Facebook.new(:cache         => {},
+                                :error_handler => lambda{|env|env})
+    rg.get('me'); rg.get('me')
+    rg.cache.values.should.eq []
+  end
+end

data/test/client/facebook/test_handler.rb

@@ -0,0 +1,84 @@
+
+require 'rest-core/test'
+
+describe RestCore::Facebook do
+  after do
+    WebMock.reset!
+    RR.verify
+  end
+
+  describe 'log method' do
+    should 'log whenever doing network request' do
+      stub_request(:get, 'https://graph.facebook.com/me').
+        to_return(:body => '{}')
+
+      logger = []
+      rg = RestCore::Facebook.new(:log_method => lambda{ |s| logger << [s] })
+      rg.get('me')
+
+      logger.size.should.eq 1
+    end
+  end
+
+  describe 'with Graph API' do
+    before do
+      @id    = lambda{ |env| env }
+      @error = '{"error":{"type":"Exception","message":"(#2500)"}}'
+      @error_hash = RestCore::JsonDecode.json_decode(@error)
+
+      stub_request(:get, 'https://graph.facebook.com/me').
+        to_return(:body => @error)
+    end
+
+    should 'call error_handler if error occurred' do
+      RestCore::Facebook.new(:error_handler => @id).get('me').
+        should.eq @error_hash
+    end
+
+    should 'raise ::RestCore::Facebook::Error in default error_handler' do
+      begin
+        RestCore::Facebook.new.get('me')
+      rescue ::RestCore::Facebook::Error => e
+        e.error  .should.eq @error_hash
+        e.message.should.eq \
+          "#{@error_hash.inspect} from https://graph.facebook.com/me"
+      end
+    end
+  end
+
+  describe 'with FQL API' do
+    # Example of an actual response (without newline)
+    # {"error_code":603,"error_msg":"Unknown table: bad_table",
+    #  "request_args":[{"key":"method","value":"fql.query"},
+    #                  {"key":"format","value":"json"},
+    #                  {"key":"query","value":
+    #                     "SELECT name FROM bad_table WHERE uid=12345"}]}
+    before do
+      @id             = lambda{ |env| env }
+      @fql_error      = '{"error_code":603,"error_msg":"Unknown table: bad"}'
+      @fql_error_hash = RestCore::JsonDecode.json_decode(@fql_error)
+
+      @bad_fql_query  = 'SELECT name FROM bad_table WHERE uid="12345"'
+      bad_fql_request = "https://api.facebook.com/method/fql.query?" \
+                        "format=json&query=#{CGI.escape(@bad_fql_query)}"
+
+      stub_request(:get, bad_fql_request).to_return(:body => @fql_error)
+    end
+
+    should 'call error_handler if error occurred' do
+      RestCore::Facebook.new(:error_handler => @id).fql(@bad_fql_query).
+        should.eq @fql_error_hash
+    end
+
+    should 'raise ::RestCore::Facebook::Error in default error_handler' do
+      begin
+        RestCore::Facebook.new.fql(@bad_fql_query)
+      rescue ::RestCore::Facebook::Error => e
+        e.error  .should.eq @fql_error_hash
+        e.message.should.start_with?(
+          "#{@fql_error_hash.inspect} from "          \
+          "https://api.facebook.com/method/fql.query?")
+      end
+    end
+  end
+end

data/test/client/facebook/test_load_config.rb

@@ -0,0 +1,39 @@
+
+require 'rest-core/test'
+
+require 'rest-core/util/config'
+
+describe RestCore::Config do
+
+  before do
+    @klass = RestCore::Facebook.dup
+  end
+
+  after do
+    RR.verify
+  end
+
+  def check
+    @klass.default_app_id     .should.eq 41829
+    @klass.default_secret     .should.eq 'r41829'.reverse
+    @klass.default_json_decode.should.eq false
+    @klass.default_lang       .should.eq 'zh-tw'
+  end
+
+  should 'honor rails config' do
+    app = Object.new
+    mock(app).env { 'test' }
+    mock(app).root{ File.dirname(__FILE__) }
+    RestCore::Config.load_for_rails(@klass, 'facebook', app)
+    check
+  end
+
+  should 'honor config' do
+    RestCore::Config.load(
+      @klass,
+      "#{File.dirname(__FILE__)}/config/rest-core.yaml",
+      'test',
+      'facebook')
+    check
+  end
+end

data/test/client/facebook/test_misc.rb

@@ -0,0 +1,72 @@
+
+require 'rest-core/test'
+
+describe RestCore::Facebook do
+  after do
+    WebMock.reset!
+    RR.verify
+  end
+
+  should 'return true in authorized? if there is an access_token' do
+    RestCore::Facebook.new(:access_token => '1').authorized?.should.eq true
+    RestCore::Facebook.new(:access_token => nil).authorized?.should.eq false
+  end
+
+  should 'treat oauth_token as access_token as well' do
+    rg = RestCore::Facebook.new
+    hate_facebook = 'why the hell two different name?'
+    rg.data['oauth_token'] = hate_facebook
+    rg.authorized?.should.eq true
+    rg.access_token.should.eq hate_facebook
+  end
+
+  should 'build correct headers' do
+    rg = RestCore::Facebook.new(:accept => 'text/html',
+                                :lang   => 'zh-tw')
+
+    headers = rg.dry.call(rg.send(:build_env))[RestCore::REQUEST_HEADERS]
+    headers['Accept'         ].should.eq 'text/html'
+    headers['Accept-Language'].should.eq 'zh-tw'
+  end
+
+  should 'build empty query string' do
+    rg = RestCore::Facebook.new
+    (rg.dry.call(rg.send(:build_env))[RestCore::REQUEST_QUERY] || {}).
+      should.eq({})
+  end
+
+  should 'create access_token in query string' do
+    rg = RestCore::Facebook.new(:access_token => 'token')
+    (rg.dry.call(rg.send(:build_env))[RestCore::REQUEST_QUERY] || {}).
+      should.eq({'access_token' => 'token'})
+  end
+
+  should 'build correct query string' do
+    rg = RestCore::Facebook.new(:access_token => 'token')
+    TestHelper.normalize_url(rg.url('', :message => 'hi!!')).
+      should.eq "#{rg.site}?access_token=token&message=hi%21%21"
+
+    rg.access_token = nil
+    TestHelper.normalize_url(rg.url('', :message => 'hi!!',
+                                        :subject => '(&oh&)')).
+      should.eq "#{rg.site}?message=hi%21%21&subject=%28%26oh%26%29"
+  end
+
+  should 'auto decode json' do
+    rg = RestCore::Facebook.new(:json_decode => true)
+    stub_request(:get, rg.site).to_return(:body => '[]')
+    rg.get('').should.eq []
+  end
+
+  should 'not auto decode json' do
+    rg = RestCore::Facebook.new(:json_decode => false)
+    stub_request(:get, rg.site).to_return(:body => '[]')
+    rg.get('').should.eq '[]'
+  end
+
+  should 'give attributes' do
+    RestCore::Facebook.new(:json_decode => false).attributes.
+      keys.map(&:to_s).sort.should.eq \
+      RestCore::Facebook.members.map(&:to_s).sort
+  end
+end

data/test/client/facebook/test_oauth.rb

@@ -0,0 +1,38 @@
+
+require 'rest-core/test'
+
+describe RestCore::Facebook do
+  before do
+    @rg  = RestCore::Facebook.new(:app_id => '29', :secret => '18')
+    @uri = 'http://zzz.tw'
+  end
+
+  after do
+    WebMock.reset!
+  end
+
+  should 'return correct oauth url' do
+    TestHelper.normalize_url(@rg.authorize_url(:redirect_uri => @uri)).
+    should.eq 'https://graph.facebook.com/oauth/authorize?' \
+              'client_id=29&redirect_uri=http%3A%2F%2Fzzz.tw'
+  end
+
+  should 'do authorizing and parse result and save it in data' do
+    stub_request(:get, 'https://graph.facebook.com/oauth/access_token?' \
+                       'client_id=29&client_secret=18&code=zzz&'        \
+                       'redirect_uri=http%3A%2F%2Fzzz.tw').
+      to_return(:body => 'access_token=baken&expires=2918')
+
+    result = {'access_token' => 'baken', 'expires' => '2918'}
+
+    @rg.authorize!(:redirect_uri => @uri, :code => 'zzz').
+             should.eq result
+    @rg.data.should.eq result
+  end
+
+  should 'not append access_token in authorize_url even presented' do
+    RestCore::Facebook.new(:access_token => 'do not use me').authorize_url.
+      should.eq 'https://graph.facebook.com/oauth/authorize'
+  end
+
+end

data/test/client/facebook/test_old.rb

@@ -0,0 +1,114 @@
+
+require 'rest-core/test'
+
+describe RestCore::Facebook do
+  after do
+    WebMock.reset!
+    RR.verify
+  end
+
+  should 'do fql query with/without access_token' do
+    fql = 'SELECT name FROM likes where id="123"'
+    query = "format=json&query=#{CGI.escape(fql)}"
+    stub_request(:get, "https://api.facebook.com/method/fql.query?#{query}").
+      to_return(:body => '[]')
+
+    RestCore::Facebook.new.fql(fql).should.eq []
+
+    token = 'token'.reverse
+    stub_request(:get, "https://api.facebook.com/method/fql.query?#{query}" \
+      "&access_token=#{token}").
+      to_return(:body => '[]')
+
+    RestCore::Facebook.new(:access_token => token).fql(fql).should.eq []
+  end
+
+  should 'do fql.mutilquery correctly' do
+    f0 = 'SELECT display_name FROM application WHERE app_id="233082465238"'
+    f1 = 'SELECT display_name FROM application WHERE app_id="110225210740"'
+    f0q, f1q = "\"#{f0.gsub('"', '\\"')}\"", "\"#{f1.gsub('"', '\\"')}\""
+    q = "format=json&queries=#{CGI.escape("{\"f0\":#{f0q},\"f1\":#{f1q}}")}"
+    p = "format=json&queries=#{CGI.escape("{\"f1\":#{f1q},\"f0\":#{f0q}}")}"
+
+    stub_multi = lambda{
+      stub_request(:get,
+        "https://api.facebook.com/method/fql.multiquery?#{q}").
+        to_return(:body => '[]')
+
+      stub_request(:get,
+        "https://api.facebook.com/method/fql.multiquery?#{p}").
+        to_return(:body => '[]')
+    }
+
+    stub_multi.call
+    RestCore::Facebook.new.fql_multi(:f0 => f0, :f1 => f1).should.eq []
+  end
+
+  should 'cache fake post in fql' do
+    query = 'select name from user where uid = 4'
+    body  = '[{"name":"Mark Zuckerberg"}]'
+    stub_request(:post,
+      'https://api.facebook.com/method/fql.query?format=json').
+      with(:body => {:query => query}).
+      to_return(:body => body)
+
+    RestCore::Facebook.new(:cache => (cache = {})).
+      fql(query, {}, :post => true).
+      first['name']   .should.eq 'Mark Zuckerberg'
+    cache.size        .should.eq 1
+    cache.values.first.should.eq body
+
+    WebMock.reset! # should hit the cache
+
+    RestCore::Facebook.new(:cache => cache).fql(query, {}, :post => true).
+      first['name']   .should.eq 'Mark Zuckerberg'
+    cache.size        .should.eq 1
+    cache.values.first.should.eq body
+
+    # query changed
+    should.raise(WebMock::NetConnectNotAllowedError) do
+      RestCore::Facebook.new(:cache => cache).
+        fql(query.upcase, {}, :post => true)
+    end
+
+    # cache should work for normal get
+    RestCore::Facebook.new(:cache => cache).fql(query).
+      first['name']   .should.eq 'Mark Zuckerberg'
+    cache.size        .should.eq 1
+    cache.values.first.should.eq body
+  end
+
+  should 'do facebook old rest api' do
+    body = 'hate facebook inconsistent'
+    stub_request(:get,
+      'https://api.facebook.com/method/notes.create?format=json').
+      to_return(:body => body)
+
+    RestCore::Facebook.new.
+      old_rest('notes.create', {}, :json_decode => false).should.eq body
+  end
+
+  should 'exchange sessions for access token' do
+    stub_request(:post,
+      'https://graph.facebook.com/oauth/exchange_sessions?'     \
+              'type=client_cred&client_id=id&client_secret=di&' \
+              'sessions=bad%20bed').
+      to_return(:body => '[{"access_token":"bogus"}]')
+
+    RestCore::Facebook.new(:app_id => 'id',
+                           :secret => 'di').
+      exchange_sessions(:sessions => 'bad bed').
+      first['access_token'].should.eq 'bogus'
+  end
+
+  should 'use an secret access_token' do
+    stub_request(:get,
+      'https://api.facebook.com/method/admin.getAppProperties?' \
+      'access_token=123%7Cs&format=json&properties=app_id'
+    ).to_return(:body => '{"app_id":"123"}')
+
+    RestCore::Facebook.new(:app_id => '123', :secret => 's').
+      secret_old_rest('admin.getAppProperties', :properties => 'app_id').
+      should.eq({'app_id' => '123'})
+  end
+end