rest-in-peace 3.0.0 → 4.0.0

data/VERSION

@@ -1 +1 @@
-3.0.0
+4.0.0

data/lib/rest_in_peace/definition_proxy/resource_method_definitions.rb

@@ -8,7 +8,7 @@ module RESTinPeace
       def get(method_name, url_template, default_params = {})
         @target.rip_registry[:resource] << { method: :get, name: method_name, url: url_template }
         @target.send(:define_method, method_name) do
-          call = RESTinPeace::ApiCall.new(api, url_template, self, hash_for_updates)
+          call = RESTinPeace::ApiCall.new(api, url_template, self, payload)
           call.get
         end
       end
@@ -16,7 +16,7 @@ module RESTinPeace
       def patch(method_name, url_template)
         @target.rip_registry[:resource] << { method: :patch, name: method_name, url: url_template }
         @target.send(:define_method, method_name) do
-          call = RESTinPeace::ApiCall.new(api, url_template, self, hash_for_updates)
+          call = RESTinPeace::ApiCall.new(api, url_template, self, payload)
           call.patch
         end
       end
@@ -24,7 +24,7 @@ module RESTinPeace
       def post(method_name, url_template)
         @target.rip_registry[:resource] << { method: :post, name: method_name, url: url_template }
         @target.send(:define_method, method_name) do
-          call = RESTinPeace::ApiCall.new(api, url_template, self, hash_for_updates)
+          call = RESTinPeace::ApiCall.new(api, url_template, self, payload)
           call.post
         end
       end
@@ -32,7 +32,7 @@ module RESTinPeace
       def put(method_name, url_template)
         @target.rip_registry[:resource] << { method: :put, name: method_name, url: url_template }
         @target.send(:define_method, method_name) do
-          call = RESTinPeace::ApiCall.new(api, url_template, self, hash_for_updates)
+          call = RESTinPeace::ApiCall.new(api, url_template, self, payload)
           call.put
         end
       end

data/lib/rest_in_peace.rb

@@ -14,10 +14,10 @@ module RESTinPeace
   end
 
   def initialize(attributes = {})
-    force_attributes_from_hash(attributes)
+    set_attributes attributes
   end
 
-  def hash_for_updates
+  def payload
     hash_representation = { id: id }
     changed.each do |key|
       value = send(key)
@@ -57,7 +57,7 @@ module RESTinPeace
     hash_representation
   end
 
-  def force_attributes_from_hash(attributes)
+  def set_attributes(attributes)
     attributes.each do |key, value|
       next unless respond_to?(key)
       if respond_to?("#{key}=")
@@ -66,11 +66,15 @@ module RESTinPeace
         instance_variable_set("@#{key}", value)
       end
     end
+  end
+
+  def force_attributes_from_hash(attributes)
+    set_attributes attributes
     clear_changes
   end
 
   def hash_representation_of_object(object)
-    return object.hash_for_updates if object.respond_to?(:hash_for_updates)
+    return object.payload if object.respond_to?(:payload)
     return object.map { |element| hash_representation_of_object(element) } if object.is_a?(Array)
     object
   end

data/spec/rest_in_peace/definition_proxy/resource_method_definitions_spec.rb

@@ -41,7 +41,7 @@ describe RESTinPeace::DefinitionProxy::ResourceMethodDefinitions do
     describe 'parameter and arguments handling' do
       it 'uses the attributes of the class' do
         expect(RESTinPeace::ApiCall).to receive(:new).
-          with(target.api, url_template, instance, instance.hash_for_updates).
+          with(target.api, url_template, instance, instance.payload).
           and_return(api_call_double)
 
         subject.send(http_verb, method_name, url_template)

data/spec/rest_in_peace/response_converter_spec.rb

@@ -26,12 +26,14 @@ describe RESTinPeace::ResponseConverter do
       specify { expect(subject).to be_instance_of(Array) }
       specify { expect(subject.first).to be_instance_of(extended_class) }
       specify { expect(subject.map(&:name)).to eq(%w(test1 test2)) }
+      specify { expect(subject.first).to_not be_changed }
     end
 
     shared_examples_for 'a hash input' do
       let(:response_body) { element1 }
       specify { expect(subject).to be_instance_of(extended_class) }
       specify { expect(subject.name).to eq('test1') }
+      it { is_expected.to_not be_changed }
     end
 
     shared_examples_for 'a string input' do

data/spec/rest_in_peace_spec.rb

@@ -102,25 +102,25 @@ describe RESTinPeace do
     specify { expect(subject).to eq(attributes.merge(overridden_attribute: 'something else')) }
   end
 
-  describe '#hash_for_updates' do
+  describe '#payload' do
     subject { instance }
-    specify { expect(subject).to respond_to(:hash_for_updates).with(0).arguments }
+    specify { expect(subject).to respond_to(:payload).with(0).arguments }
 
     context 'without a namspace defined' do
       it 'adds id by default' do
-        expect(subject.hash_for_updates).to include(id: 1)
+        expect(subject.payload).to include(id: 1)
       end
 
       context 'overridden getter' do
         before do
           subject.overridden_attribute = 'new value'
         end
-        specify { expect(subject.hash_for_updates).to include(overridden_attribute: 'something else') }
+        specify { expect(subject.payload).to include(overridden_attribute: 'something else') }
       end
 
       context 'self defined methods' do
         specify { expect(subject).to respond_to(:self_defined_method) }
-        specify { expect(subject.hash_for_updates).to_not include(:self_defined_method) }
+        specify { expect(subject.payload).to_not include(:self_defined_method) }
       end
 
       context 'hash' do
@@ -128,7 +128,7 @@ describe RESTinPeace do
           subject.my_hash = { element1: 'swag' }
         end
 
-        specify { expect(subject.hash_for_updates[:my_hash]).to eq(element1: 'swag') }
+        specify { expect(subject.payload[:my_hash]).to eq(element1: 'swag') }
       end
 
       context 'with objects assigned' do
@@ -138,14 +138,14 @@ describe RESTinPeace do
           subject.my_hash = new_hash
         end
 
-        it 'deeply calls hash_for_updates' do
-          expect(new_hash).to receive(:hash_for_updates).and_return({})
-          subject.hash_for_updates
+        it 'deeply calls payload' do
+          expect(new_hash).to receive(:payload).and_return({})
+          subject.payload
         end
       end
     end
 
-    context 'with a namspace defined' do
+    context 'with a namespace defined' do
       let(:extended_class) do
         Class.new do
           include RESTinPeace
@@ -165,7 +165,7 @@ describe RESTinPeace do
         subject.name = 'new value'
       end
 
-      specify { expect(subject.hash_for_updates).to eq(id: 1, blubb: { id: 1, name: 'new value' }) }
+      specify { expect(subject.payload).to eq(id: 1, blubb: { id: 1, name: 'new value', description: 'old description' }) }
     end
   end
 
@@ -227,7 +227,7 @@ describe RESTinPeace do
     subject { instance }
 
     context 'a new instance' do
-      it { is_expected.to_not be_changed }
+      it { is_expected.to be_changed }
     end
 
     context 'a modified instance' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rest-in-peace
 version: !ruby/object:Gem::Version
-  version: 3.0.0
+  version: 4.0.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-05 00:00:00.000000000 Z
+date: 2015-02-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel