rest-graph 1.5.0 → 1.6.0

data/test/common.rb

@@ -1,6 +1,6 @@
 
-require 'rubygems' if RUBY_VERSION < '1.9.0'
-require 'rack'     if RUBY_VERSION < '1.9.0' # autoload broken in 1.8?
+require 'rubygems' if RUBY_VERSION < '1.9.2'
+require 'rack'     if RUBY_VERSION < '1.9.2' # autoload broken in 1.8?
 require 'rest-graph'
 
 require 'rr'
@@ -11,7 +11,7 @@ require 'bacon'
 require 'yaml'
 
 include RR::Adapters::RRMethods
-include WebMock
+include WebMock::API
 WebMock.disable_net_connect!
 Bacon.summary_on_exit
 

data/test/test_api.rb

@@ -7,23 +7,23 @@ end
 
 describe RestGraph do
   after do
-    reset_webmock
+    WebMock.reset_webmock
     RR.verify
   end
 
-  it 'would generate correct url' do
+  should 'generate correct url' do
     TestHelper.normalize_url(
     RestGraph.new(:access_token => 'awesome').url('path', :query => 'str')).
       should ==
         'https://graph.facebook.com/path?access_token=awesome&query=str'
   end
 
-  it 'would request to correct server' do
+  should 'request to correct server' do
     stub_request(:get, 'http://nothing.godfat.org/me').with(
       :headers => {'Accept'          => 'text/plain',
                    'Accept-Language' => 'zh-tw',
                    'Accept-Encoding' => 'gzip, deflate', # this is by ruby
-                  }.merge(RUBY_VERSION <= '1.9.0' ?
+                  }.merge(RUBY_VERSION < '1.9.2' ?
                   {} :
                   {'User-Agent'      => 'Ruby'})).       # this is by ruby
       to_return(:body => '{"data": []}')
@@ -33,7 +33,7 @@ describe RestGraph do
                   :accept => 'text/plain').get('me').should == {'data' => []}
   end
 
-  it 'would post right' do
+  should 'post right' do
     stub_request(:post, 'https://graph.facebook.com/feed/me').
       with(:body => 'message=hi%20there').to_return(:body => 'ok')
 
@@ -41,7 +41,7 @@ describe RestGraph do
       post('feed/me', :message => 'hi there').should == 'ok'
   end
 
-  it 'could suppress auto-decode in an api call' do
+  should 'suppress auto-decode in an api call' do
     stub_request(:get, 'https://graph.facebook.com/woot').
       to_return(:body => 'bad json')
 
@@ -50,16 +50,17 @@ describe RestGraph do
     rg.auto_decode.should == true
   end
 
-  it 'would call post_request after request' do
-    stub_request(:put, 'https://graph.facebook.com/feed/me').
+  should 'call post_request after request' do
+    url = 'https://graph.facebook.com/feed/me'
+    stub_request(:put, url).
       with(:body => 'message=hi%20there').to_return(:body => '[]')
 
-    mock.proxy(rg = RestGraph.new).post_request('[]', {})
+    mock.proxy(rg = RestGraph.new).post_request('[]', url, {})
     rg.put('feed/me', :message => 'hi there').
       should == []
   end
 
-  it 'would not raise exception when encountering error' do
+  should 'not raise exception when encountering error' do
     [500, 401, 402, 403].each{ |status|
       stub_request(:delete, 'https://graph.facebook.com/123').to_return(
         :body => '[]', :status => status)
@@ -68,7 +69,7 @@ describe RestGraph do
     }
   end
 
-  it 'would convert query to string' do
+  should 'convert query to string' do
     mock(o = Object.new).to_s{ 'i am mock' }
     stub_request(:get, "https://graph.facebook.com/search?q=i%20am%20mock").
       to_return(:body => 'ok')

data/test/test_cache.rb

@@ -7,11 +7,11 @@ end
 
 describe RestGraph do
   after do
-    reset_webmock
+    WebMock.reset_webmock
     RR.verify
   end
 
-  it 'would enable cache if passing cache' do
+  should 'enable cache if passing cache' do
     url, body = "https://graph.facebook.com/cache", '{"message":"ok"}'
     stub_request(:get, url).to_return(:body => body).times(1)
 
@@ -21,7 +21,7 @@ describe RestGraph do
     cache.should == {rg.send(:cache_key, url) => body}
   end
 
-  it 'would not cache post/put/delete' do
+  should 'not cache post/put/delete' do
     [:put, :post, :delete].each{ |meth|
       url, body = "https://graph.facebook.com/cache", '{"message":"ok"}'
       stub_request(meth, url).to_return(:body => body).times(3)

data/test/test_default.rb

@@ -6,7 +6,7 @@ else
 end
 
 describe RestGraph do
-  it 'would honor default attributes' do
+  should 'honor default attributes' do
     TestHelper.attrs_no_callback.each{ |name|
       RestGraph.new.send(name).should ==
         RestGraph.send("default_#{name}")
@@ -16,7 +16,7 @@ describe RestGraph do
     }
   end
 
-  it 'could use module to override default attributes' do
+  should 'use module to override default attributes' do
     module BlahAttributes
       def default_app_id
         '1829'

data/test/test_error.rb

@@ -7,11 +7,11 @@ end
 
 describe RestGraph::Error do
   after do
-    reset_webmock
+    WebMock.reset_webmock
     RR.verify
   end
 
-  it 'has the right ancestors' do
+  should 'have the right ancestors' do
     RestGraph::Error::AccessToken       .should < RestGraph::Error
 
     RestGraph::Error::InvalidAccessToken.should <
@@ -21,7 +21,7 @@ describe RestGraph::Error do
       RestGraph::Error::AccessToken
   end
 
-  it 'would parse right' do
+  should 'parse right' do
     %w[OAuthInvalidTokenException OAuthException].each{ |type|
       RestGraph::Error.parse('error' => {'type' => type}).
         should.kind_of?(RestGraph::Error::InvalidAccessToken)

data/test/test_handler.rb

@@ -7,12 +7,12 @@ end
 
 describe RestGraph do
   after do
-    reset_webmock
+    WebMock.reset_webmock
     RR.verify
   end
 
   describe 'log handler' do
-    it 'would log whenever doing network request' do
+    should 'log whenever doing network request' do
       stub_request(:get, 'https://graph.facebook.com/me').
         to_return(:body => '{}')
 
@@ -30,7 +30,7 @@ describe RestGraph do
 
   describe 'with Graph API' do
     before do
-      @id    = lambda{ |obj| obj }
+      @id    = lambda{ |obj, url| obj }
       @error = '{"error":{"type":"Exception","message":"(#2500)"}}'
       @error_hash = RestGraph.json_decode(@error)
 
@@ -38,16 +38,17 @@ describe RestGraph do
         to_return(:body => @error)
     end
 
-    it 'would call error_handler if error occurred' do
+    should 'call error_handler if error occurred' do
       RestGraph.new(:error_handler => @id).get('me').should == @error_hash
     end
 
-    it 'would raise ::RestGraph::Error in default error_handler' do
+    should 'raise ::RestGraph::Error in default error_handler' do
       begin
         RestGraph.new.get('me')
       rescue ::RestGraph::Error => e
         e.error  .should == @error_hash
-        e.message.should == @error_hash.inspect
+        e.message.should ==
+          "#{@error_hash.inspect} from https://graph.facebook.com/me"
       end
     end
   end
@@ -60,7 +61,7 @@ describe RestGraph do
     #                  {"key":"query","value":
     #                     "SELECT name FROM bad_table WHERE uid=12345"}]}
     before do
-      @id             = lambda{ |obj| obj }
+      @id             = lambda{ |obj, url| obj }
       @fql_error      = '{"error_code":603,"error_msg":"Unknown table: bad"}'
       @fql_error_hash = RestGraph.json_decode(@fql_error)
 
@@ -71,17 +72,19 @@ describe RestGraph do
       stub_request(:get, bad_fql_request).to_return(:body => @fql_error)
     end
 
-    it 'would call error_handler if error occurred' do
+    should 'call error_handler if error occurred' do
       RestGraph.new(:error_handler => @id).fql(@bad_fql_query).
         should == @fql_error_hash
     end
 
-    it 'would raise ::RestGraph::Error in default error_handler' do
+    should 'raise ::RestGraph::Error in default error_handler' do
       begin
         RestGraph.new.fql(@bad_fql_query)
       rescue ::RestGraph::Error => e
         e.error  .should == @fql_error_hash
-        e.message.should == @fql_error_hash.inspect
+        e.message.should.start_with?(
+          "#{@fql_error_hash.inspect} from "          \
+          "https://api.facebook.com/method/fql.query?")
       end
     end
   end

data/test/test_load_config.rb

@@ -13,7 +13,7 @@ describe RestGraph::LoadConfig do
     RR.verify
   end
 
-  it 'would honor rails config' do
+  should 'honor rails config' do
     ::Rails = Object.new
     mock(Rails).env { 'test' }
     mock(Rails).root{ File.dirname(__FILE__) }

data/test/test_misc.rb

@@ -7,16 +7,16 @@ end
 
 describe RestGraph do
   after do
-    reset_webmock
+    WebMock.reset_webmock
     RR.verify
   end
 
-  it 'would return true in authorized? if there is an access_token' do
+  should 'return true in authorized? if there is an access_token' do
     RestGraph.new(:access_token => '1').authorized?.should == true
     RestGraph.new(:access_token => nil).authorized?.should == false
   end
 
-  it 'would treat oauth_token as access_token as well' do
+  should 'treat oauth_token as access_token as well' do
     rg = RestGraph.new
     hate_facebook = 'why the hell two different name?'
     rg.data['oauth_token'] = hate_facebook
@@ -24,23 +24,23 @@ describe RestGraph do
     rg.access_token       == hate_facebook
   end
 
-  it 'would build correct headers' do
+  should 'build correct headers' do
     rg = RestGraph.new(:accept => 'text/html',
                        :lang   => 'zh-tw')
     rg.send(:build_headers).should == {'Accept'          => 'text/html',
                                        'Accept-Language' => 'zh-tw'}
   end
 
-  it 'would build empty query string' do
+  should 'build empty query string' do
     RestGraph.new.send(:build_query_string).should == ''
   end
 
-  it 'would create access_token in query string' do
+  should 'create access_token in query string' do
     RestGraph.new(:access_token => 'token').send(:build_query_string).
       should == '?access_token=token'
   end
 
-  it 'would build correct query string' do
+  should 'build correct query string' do
     TestHelper.normalize_query(
     RestGraph.new(:access_token => 'token').send(:build_query_string,
                                                  :message => 'hi!!')).
@@ -52,20 +52,21 @@ describe RestGraph do
       should == '?message=hi%21%21&subject=%28%26oh%26%29'
   end
 
-  it 'would auto decode json' do
+  should 'auto decode json' do
     RestGraph.new(:auto_decode => true).send(:post_request, '[]').
       should == []
   end
 
-  it 'would not auto decode json' do
+  should 'not auto decode json' do
     RestGraph.new(:auto_decode => false).send(:post_request, '[]').
       should == '[]'
   end
 
-  it 'would give better inspect string' do
+  should 'give better inspect string' do
     RestGraph.new(:auto_decode => false).inspect.should =~ Regexp.new(
     '#<struct RestGraph auto_decode=false,'                          \
                       ' strict=false,'                               \
+                      ' timeout=10,'                                 \
                       ' graph_server="https://graph.facebook.com/",' \
                       ' old_server="https://api.facebook.com/",'     \
                       ' accept="text/javascript",'                   \
@@ -74,7 +75,8 @@ describe RestGraph do
                       ' secret=nil,'                                 \
                       ' data=\{\},'                                  \
                       ' cache=nil,'                                  \
-                      ' error_handler=#<Proc:.+>,'                   \
-                      ' log_handler=nil>')
+                      ' log_method=nil,'                             \
+                      ' log_handler=nil,'                            \
+                      ' error_handler=#<Proc:.+>>')
   end
 end

data/test/test_multi.rb

@@ -0,0 +1,126 @@
+
+if respond_to?(:require_relative, true)
+  require_relative 'common'
+else
+  require File.dirname(__FILE__) + '/common'
+end
+
+require 'em-http-request'
+load 'webmock/http_lib_adapters/em_http_request.rb'
+
+describe 'RestGraph#multi' do
+  after do
+    WebMock.reset_webmock
+    RR.verify
+  end
+
+  should 'do multi query with em-http-request' do
+    url = 'https://graph.facebook.com/me'
+    stub_request(:get, url).to_return(:body => '{"data":"get"}')
+    stub_request(:put, url).to_return(:body => '{"data":"put"}')
+    rg = RestGraph.new
+    mock.proxy(rg).request_em(anything, anything)
+    EM.run{
+      rg.multi([[:get, 'me'], [:put, 'me']]){ |results|
+        results.should == [{'data' => 'get'}, {'data' => 'put'}]
+        EM.stop
+      }
+    }
+  end
+
+  should 'call aget, aput family with multi' do
+    url = 'https://graph.facebook.com/me'
+    %w[aget adelete apost aput].each{ |meth|
+      stub_request("#{meth[1..-1]}".to_sym, url).
+        to_return(:body => "{\"data\":\"#{meth}\"}")
+      rg = RestGraph.new
+      mock.proxy(rg).request_em(anything, anything)
+      EM.run{
+        rg.send(meth, 'me', {}){ |result|
+          result.should == {'data' => meth.to_s}
+          EM.stop
+        }
+      }
+    }
+  end
+
+  should 'for_pages' do
+    rg = RestGraph.new
+
+    args = [is_a(Hash), is_a(Array)]
+    mock.proxy(rg).request_em(*args) # at least one time
+    stub.proxy(rg).request_em(*args)
+
+    %w[next previous].each{ |type|
+      kind = "#{type}_page"
+      data = {'paging' => {type => 'http://z'}, 'data' => ['z']}
+
+      # invalid pages or just the page itself
+      # not really need network
+      nils = 0
+      ranges = -1..1
+      ranges.each{ |page|
+        rg.for_pages(data, page, {:async => true}, kind){ |r|
+          if r
+            r.should == data
+          else
+            nils += 1
+          end
+        }.should == data
+      }
+      nils.should == ranges.to_a.size
+
+      (2..4).each{ |pages|
+        # merge data
+        stub_request(:get, 'z').to_return(:body => '{"data":["y"]}')
+        expects = [{'data' => %w[y]}, nil]
+
+        EM.run{
+          rg.for_pages(data, pages, {:async => true}, kind){ |r|
+            r.should == expects.shift
+            EM.stop if expects.empty?
+          }
+        }
+
+        # this data cannot be merged
+        stub_request(:get, 'z').to_return(:body => '{"data":"y"}')
+        expects = [{'data' => 'y'}, nil]
+
+        EM.run{
+          rg.for_pages(data, pages, {:async => true}, kind){ |r|
+            r.should == expects.shift
+            EM.stop if expects.empty?
+          }
+        }
+      }
+
+      stub_request(:get, 'z').to_return(:body =>
+        '{"paging":{"'+type+'":"http://yyy"},"data":["y"]}')
+      stub_request(:get, 'yyy').to_return(:body => '{"data":["x"]}')
+      expects = [{'data' => %w[y]}, {'data' => %w[x]}, nil]
+
+      EM.run{
+        rg.for_pages(data, 3, {:async => true}, kind){ |rr|
+          rr.frozen?.should == true unless rr.nil? && RUBY_VERSION < '1.9.2'
+          if rr
+            r = rr.dup
+            r.delete('paging')
+          else
+            r = rr
+          end
+          r.should == expects.shift
+          EM.stop if expects.empty?
+        }
+      }
+    }
+  end
+
+  # should 'cache in multi' do
+  # end
+  #
+  # should 'logging' do
+  # end
+  #
+  # should 'error handler?' do
+  # end
+end