rest-core 2.1.1 → 2.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5cc0c6118d2d5169988871b31d9b5544e2f28f60
-  data.tar.gz: c73e366ba7c4cdbdec4a5a76528ed5d8df21aed4
+  metadata.gz: 71b8ab944328b862d8a3524a01da91432fe7fcb4
+  data.tar.gz: 204f46ff9a25281ffdbbe814df50831519a98c88
 SHA512:
-  metadata.gz: c175b2f84c14257fe189ae82bee8f1d3a2bd205ac4da36ab8b0b596ccfdf47253d05b8cb4940c4ebe47e770385ed282b6dfadf53db04a1fba67adc4975ae177e
-  data.tar.gz: 53cd1bed753213a3a27637ceb85acf9577504aaa48cf0b760c48c20a6cd35c87f96f8b8c2dc438b568adc8404d1b4c19066dbb5efc6c40871d5ea91e78cd43e5
+  metadata.gz: 67d6c4ee4116a562fa5a16a41b6c94b5b4f0c768abc077e78d1b0a416d28146784a9a358208175de212c9ccac3fe3956a00bda5eabfa81ba714beec2aeeaec7e
+  data.tar.gz: 7f723ab6d7e7b295d24b664aa9ef1ce38d56c39e2c2ef75d34aaded046a8aa97d9fb1b16ecf5a3d1867fba596afb46f4203f250b9f729ccad998dfbf887cb72f

data/CHANGES.md

@@ -1,5 +1,15 @@
 # CHANGES
 
+## rest-core 2.1.2 -- 2013-05-31
+
+### Incompatible changes
+
+* Remove support for Ruby < 1.9.2
+
+### Bugs fixes
+
+* [`Client`] Fixed a bug where if we're using duplicated attributes.
+
 ## rest-core 2.1.1 -- 2013-05-21
 
 ### Bugs fixes

data/README.md

@@ -295,7 +295,7 @@ installed before trying this.
 [rib]: https://github.com/godfat/rib
 [rest-more]: https://github.com/cardinalblue/rest-more
 
-## List of built-in Middlewares:
+## List of built-in Middleware:
 
 * `RC::AuthBasic`
 * `RC::Bypass`
@@ -317,9 +317,87 @@ installed before trying this.
 * `RC::Oauth2Query`
 * `RC::Timeout`
 
-## Build Your Own Middlewares:
+## Build Your Own Middleware:
 
-To be added.
+### How We Pick the Default Value:
+
+There are a number of ways to specify a default value, each with different
+priorities. Suppose we have a middleware which remembers an integer:
+
+``` ruby
+class HP
+  def self.members; [:hp]; end
+  include RC::Middleware
+  def call env, &k
+    puts "HP: #{hp(env)}"
+    app.call(env, &k)
+  end
+end
+Mage = RC::Builder.client do
+  use HP, 5 # the very last default
+end
+mage = Mage.new
+```
+
+1. The one passed to the request directly gets the first priority, e.g.
+
+``` ruby
+mage.get('http://example.com/', {}, :hp => 1) # prints HP: 1
+```
+
+2. The one saved as an instance variable in the client gets the 2nd place.
+
+``` ruby
+mage.hp = 2
+mage.get('http://example.com/')               # prints HP: 2
+mage.get('http://example.com/', {}, :hp => 1) # prints HP: 1
+mage.hp         # still 2
+mage.hp = false # disable hp
+mage.hp = nil   # reset to default
+```
+
+3. The method defined in the client instance named `default_hp` gets the 3rd.
+
+``` ruby
+class Mage
+  def default_hp
+    3
+  end
+end
+mage.get('http://example.com/')               # prints HP: 3
+mage.hp       # 3
+mage.hp = nil # reset default
+Mage.send(:remove_method, :default_hp)
+```
+
+4. The method defined in the client class named `default_hp` gets the 4rd.
+   P.S. In [rest-more][], with `RestCore::Config` it would generate a
+   `DefaultAttributes` module which defines this kind of default method and
+   then is extended into the client class. You could still define this method
+   to override the default though.
+
+``` ruby
+class Mage
+  def self.default_hp
+    4
+  end
+end
+mage.get('http://example.com/')               # prints HP: 4
+mage.hp       # 4
+mage.hp = nil # reset to default
+Mage.singleton_class.send(:remove_method, :default_hp)
+```
+
+5. The one defined in the middleware gets the last place.
+
+``` ruby
+mage.get('http://example.com/')               # prints HP: 5
+mage.hp       # 5
+mage.hp = nil # reset to default
+```
+
+You can find all the details in client.rb and middleware.rb. See the
+included method hooks.
 
 ## Advanced Concurrent HTTP Requests -- Embrace the Future
 

data/lib/rest-core/builder.rb

@@ -19,7 +19,7 @@ class RestCore::Builder
     struct = if fields.empty?
                Struct.new(nil)
              else
-               Struct.new(*fields)
+               Struct.new(*fields.uniq)
              end
     client = Class.new(struct)
     client.const_set('Struct', struct)

data/lib/rest-core/client.rb

@@ -37,13 +37,6 @@ module RestCore::Client
         private :default_#{name}
       RUBY
     }
-    # if RUBY_VERSION < '1.9.2'
-    src << <<-RUBY if mod.members.first.kind_of?(String)
-      def members
-        super.map(&:to_sym)
-      end
-    RUBY
-    # end
     accessor = Module.new
     accessor.module_eval(src.join("\n"), __FILE__, __LINE__)
     mod.const_set('Accessor', accessor)

data/lib/rest-core/version.rb

@@ -1,4 +1,4 @@
 
 module RestCore
-  VERSION = '2.1.1'
+  VERSION = '2.1.2'
 end

data/rest-core.gemspec

@@ -2,13 +2,13 @@
 
 Gem::Specification.new do |s|
   s.name = "rest-core"
-  s.version = "2.1.1"
+  s.version = "2.1.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = [
   "Cardinal Blue",
   "Lin Jen-Shin (godfat)"]
-  s.date = "2013-05-21"
+  s.date = "2013-05-31"
   s.description = "Modular Ruby clients interface for REST APIs.\n\nThere has been an explosion in the number of REST APIs available today.\nTo address the need for a way to access these APIs easily and elegantly,\nwe have developed rest-core, which consists of composable middleware\nthat allows you to build a REST client for any REST API. Or in the case of\ncommon APIs such as Facebook, Github, and Twitter, you can simply use the\ndedicated clients provided by [rest-more][].\n\n[rest-more]: https://github.com/cardinalblue/rest-more"
   s.email = ["dev (XD) cardinalblue.com"]
   s.files = [

data/test/test_builder.rb

@@ -11,4 +11,14 @@ describe RC::Builder do
     builder.default_engine = RC::Dry
     builder.client.new.app.class.should.eq RC::Dry
   end
+
+  should 'not have duplicated fields' do
+    middleware = Class.new do
+      def self.members; [:value]; end
+      include RC::Middleware
+    end
+    client = RC::Builder.client(:value){ use middleware }.new
+    client.value = 10
+    client.value.should.eq 10
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rest-core
 version: !ruby/object:Gem::Version
-  version: 2.1.1
+  version: 2.1.2
 platform: ruby
 authors:
 - Cardinal Blue
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-21 00:00:00.000000000 Z
+date: 2013-05-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client