rest-core 2.0.1 → 2.0.2

data/CHANGES.md

@@ -1,5 +1,12 @@
 # CHANGES
 
+## rest-core 2.0.2 -- 2013-02-07
+
+### Bugs fixes
+
+* [`Cache`] Fix cache with multiline response body. This might invalidate
+  your existing cache.
+
 ## rest-core 2.0.1 -- 2013-01-08
 
 ### Bugs fixes

data/lib/rest-core/middleware/cache.rb

@@ -92,14 +92,16 @@ class RestCore::Cache
 
   def data_construct res
     "#{ res[RESPONSE_STATUS]}\n" \
-    "#{(res[RESPONSE_HEADERS]||{}).map{|k,v|"#{k}: #{v}"}.join("\n")}\n\n" \
+    "#{(res[RESPONSE_HEADERS]||{}).map{|k,v|"#{k}: #{v}\n"}.join}\n\n" \
     "#{ res[RESPONSE_BODY]}"
   end
 
   def data_extract data
-    _, status, headers, body = data.match(/\A(\d+)\n(.*)\n\n(.*)\Z/m).to_a
+    _, status, headers, body =
+      data.match(/\A(\d+)\n([^\n]+\n)*\n\n(.*)\Z/m).to_a
+
     {RESPONSE_BODY    => body,
-     RESPONSE_HEADERS => Hash[(headers||'').scan(/([^:]+): ([^\n]+)\n?/)],
+     RESPONSE_HEADERS => Hash[(headers||'').scan(/([^:]+): ([^\n]+)\n/)],
      RESPONSE_STATUS  => status.to_i}
   end
 

data/lib/rest-core/version.rb

@@ -1,4 +1,4 @@
 
 module RestCore
-  VERSION = '2.0.1'
+  VERSION = '2.0.2'
 end

data/rest-core.gemspec

@@ -2,13 +2,13 @@
 
 Gem::Specification.new do |s|
   s.name = "rest-core"
-  s.version = "2.0.1"
+  s.version = "2.0.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = [
   "Cardinal Blue",
   "Lin Jen-Shin (godfat)"]
-  s.date = "2013-01-08"
+  s.date = "2013-02-07"
   s.description = "Modular Ruby clients interface for REST APIs\n\nThere has been an explosion in the number of REST APIs available today.\nTo address the need for a way to access these APIs easily and elegantly,\nwe have developed rest-core, which consists of composable middleware\nthat allows you to build a REST client for any REST API. Or in the case of\ncommon APIs such as Facebook, Github, and Twitter, you can simply use the\ndedicated clients provided by [rest-more][].\n\n[rest-more]: https://github.com/cardinalblue/rest-more"
   s.email = ["dev (XD) cardinalblue.com"]
   s.files = [

data/test/test_cache.rb

@@ -25,7 +25,7 @@ describe RC::Cache do
     end.new
     c.get('/')
     key = Digest::MD5.hexdigest('get:/:')
-    c.cache.should.eq("rest-core:cache:#{key}" => "200\nA: B\n\nresponse")
+    c.cache.should.eq("rest-core:cache:#{key}" => "200\nA: B\n\n\nresponse")
     c.app.app.tick.should.eq 1
     c.get('/')
     c.app.app.tick.should.eq 1
@@ -107,6 +107,16 @@ describe RC::Cache do
     c.cache.values.first.should.eq "200\n\n\n#{body}"
   end
 
+  should 'multiline response' do
+    c = RC::Builder.client do
+      use RC::Cache, {}, 3600
+    end.new
+    stub_request(:get, 'html').to_return(:body => body = "a\n\nb")
+    c.get('html').should.eq body
+    c.cache.values.first.should.eq "200\n\n\n#{body}"
+    c.get('html')       .should.eq body
+  end
+
   should "follow redirect with cache.update correctly" do
     c = RC::Builder.client do
       use RC::FollowRedirect, 10

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rest-core
 version: !ruby/object:Gem::Version
-  version: 2.0.1
+  version: 2.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-01-08 00:00:00.000000000 Z
+date: 2013-02-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client