rest-core 0.2.3 → 0.3.0.pre.0

data/test/{test_api.rb → client/facebook/test_api.rb}

@@ -1,11 +1,7 @@
 
-if respond_to?(:require_relative, true)
-  require_relative 'common'
-else
-  require File.dirname(__FILE__) + '/common'
-end
+require 'rest-core/test'
 
-describe RestGraph do
+describe RestCore::Facebook do
   after do
     WebMock.reset!
     RR.verify
@@ -13,9 +9,9 @@ describe RestGraph do
 
   should 'generate correct url' do
     TestHelper.normalize_url(
-    RestGraph.new(:access_token => 'awesome').url('path', :query => 'str')).
-      should ==
-        'https://graph.facebook.com/path?access_token=awesome&query=str'
+    RestCore::Facebook.new(:access_token => 'awesome').
+      url('path', :query => 'str')).should.eq \
+      'https://graph.facebook.com/path?access_token=awesome&query=str'
   end
 
   should 'request to correct server' do
@@ -28,9 +24,10 @@ describe RestGraph do
                   {'User-Agent'      => 'Ruby'})).       # this is by ruby
       to_return(:body => '{"data": []}')
 
-    RestGraph.new(:site   => 'http://nothing.godfat.org/',
-                  :lang   => 'zh-tw',
-                  :accept => 'text/plain').get('me').should == {'data' => []}
+    RestCore::Facebook.new(:site   => 'http://nothing.godfat.org/',
+                           :lang   => 'zh-tw',
+                           :accept => 'text/plain').
+                           get('me').should.eq({'data' => []})
   end
 
   should 'pass custom headers' do
@@ -44,16 +41,16 @@ describe RestGraph do
                   {'User-Agent'      => 'Ruby'})).       # this is by ruby
       to_return(:body => '{"data": []}')
 
-    RestGraph.new.request({:headers => {'X-Forwarded-For' => '127.0.0.1'}},
-                          [:get, 'http://example.com']).
-      should == {'data' => []}
+    RestCore::Facebook.new.request(
+      {:headers => {'X-Forwarded-For' => '127.0.0.1'}},
+      [:get, 'http://example.com']).should.eq({'data' => []})
   end
 
   should 'post right' do
     stub_request(:post, 'https://graph.facebook.com/feed/me').
       with(:body => 'message=hi%20there').to_return(:body => 'ok')
 
-    RestGraph.new(:auto_decode => false).
+    RestCore::Facebook.new(:json_decode => false).
       post('feed/me', :message => 'hi there').should == 'ok'
   end
 
@@ -62,8 +59,9 @@ describe RestGraph do
       'https://graph.facebook.com/me?access_token=1|2').
       to_return(:body => 'ok')
 
-    rg = RestGraph.new(:auto_decode => false, :access_token => 'wrong',
-                       :app_id => '1', :secret => '2')
+    rg = RestCore::Facebook.new(
+      :json_decode => false, :access_token => 'wrong',
+      :app_id => '1', :secret => '2')
     rg.get('me', {}, :secret => true).should == 'ok'
     rg.url('me', {}, :secret => true).should ==
       'https://graph.facebook.com/me?access_token=1%7C2'
@@ -75,9 +73,9 @@ describe RestGraph do
     stub_request(:get, 'https://graph.facebook.com/woot').
       to_return(:body => 'bad json')
 
-    rg = RestGraph.new(:auto_decode => true)
-    rg.get('woot', {}, :auto_decode => false).should == 'bad json'
-    rg.auto_decode.should == true
+    rg = RestCore::Facebook.new(:json_decode => true)
+    rg.get('woot', {}, :json_decode => false).should == 'bad json'
+    rg.json_decode.should == true
   end
 
   should 'not raise exception when encountering error' do
@@ -85,7 +83,7 @@ describe RestGraph do
       stub_request(:delete, 'https://graph.facebook.com/123').to_return(
         :body => '[]', :status => status)
 
-      RestGraph.new.delete('123').should == []
+      RestCore::Facebook.new.delete('123').should == []
     }
   end
 
@@ -93,6 +91,7 @@ describe RestGraph do
     stub(o = Object.new).to_s{ 'i am mock' }
     stub_request(:get, "https://graph.facebook.com/search?q=i%20am%20mock").
       to_return(:body => 'ok')
-    RestGraph.new(:auto_decode => false).get('search', :q => o).should == 'ok'
+    RestCore::Facebook.new(:json_decode => false).
+      get('search', :q => o).should.eq 'ok'
   end
 end

data/test/{test_cache.rb → client/facebook/test_cache.rb}

@@ -1,11 +1,7 @@
 
-if respond_to?(:require_relative, true)
-  require_relative 'common'
-else
-  require File.dirname(__FILE__) + '/common'
-end
+require 'rest-core/test'
 
-describe RestGraph do
+describe RestCore::Facebook do
   after do
     WebMock.reset!
     RR.verify
@@ -16,7 +12,7 @@ describe RestGraph do
       @url, @body = "https://graph.facebook.com/cache", '{"message":"ok"}'
       @cache_key  = Digest::MD5.hexdigest(@url)
       @cache = {}
-      @rg = RestGraph.new(:cache => @cache, :auto_decode => false)
+      @rg = RestCore::Facebook.new(:cache => @cache, :json_decode => false)
       stub_request(:get, @url).to_return(:body => @body).times(1)
     end
 
@@ -48,7 +44,7 @@ describe RestGraph do
       stub_request(meth, url).to_return(:body => body).times(3)
 
       cache = {}
-      rg = RestGraph.new(:cache => cache)
+      rg = RestCore::Facebook.new(:cache => cache)
       3.times{
         if meth == :delete
           rg.send(meth, 'cache').should == {'message' => 'ok'}

data/test/{test_default.rb → client/facebook/test_default.rb}

@@ -1,21 +1,17 @@
 
-if respond_to?(:require_relative, true)
-  require_relative 'common'
-else
-  require File.dirname(__FILE__) + '/common'
-end
+require 'rest-core/test'
 
-describe RestGraph do
+describe RestCore::Facebook do
   should 'honor default attributes' do
-    RestGraph.members.reject{ |name|
+    RestCore::Facebook.members.reject{ |name|
       name.to_s =~ /method$|handler$|detector$/ }.each{ |name|
-        RestGraph.new.send(name).should ==
-        RestGraph.new.send("default_#{name}")
+        RestCore::Facebook.new.send(name).should ==
+        RestCore::Facebook.new.send("default_#{name}")
     }
   end
 
   should 'use module to override default attributes' do
-    klass = RestGraph.dup
+    klass = RestCore::Facebook.dup
     klass.send(:include, Module.new do
       def default_app_id
         '1829'

data/test/client/facebook/test_error.rb

@@ -0,0 +1,65 @@
+
+require 'rest-core/test'
+
+describe RestCore::Facebook::Error do
+  after do
+    WebMock.reset!
+    RR.verify
+  end
+
+  should 'have the right ancestors' do
+    RestCore::Facebook::Error::AccessToken.should < RestCore::Facebook::Error
+
+    RestCore::Facebook::Error::InvalidAccessToken.should <
+      RestCore::Facebook::Error::AccessToken
+
+    RestCore::Facebook::Error::MissingAccessToken.should <
+      RestCore::Facebook::Error::AccessToken
+  end
+
+  def error2env hash
+    {RestCore::RESPONSE_BODY => hash,
+     RestCore::REQUEST_PATH  => '/' ,
+     RestCore::REQUEST_QUERY => {}}
+  end
+
+  should 'parse right' do
+    %w[OAuthInvalidTokenException OAuthException].each{ |type|
+      RestCore::Facebook::Error.call(error2env('error' => {'type' => type})).
+        should.kind_of?(RestCore::Facebook::Error::InvalidAccessToken)
+    }
+
+    RestCore::Facebook::Error.call(
+      error2env('error'=>{'type'   =>'QueryParseException',
+                          'message'=>'An active access token..'})).
+      should.kind_of?(RestCore::Facebook::Error::MissingAccessToken)
+
+    RestCore::Facebook::Error.call(
+      error2env('error'=>{'type'   =>'QueryParseException',
+                          'message'=>'Oh active access token..'})).
+      should.not.kind_of?(RestCore::Facebook::Error::MissingAccessToken)
+
+    RestCore::Facebook::Error.call(error2env('error_code' => 190)).
+      should.kind_of?(RestCore::Facebook::Error::InvalidAccessToken)
+
+    RestCore::Facebook::Error.call(error2env('error_code' => 104)).
+      should.kind_of?(RestCore::Facebook::Error::MissingAccessToken)
+
+    RestCore::Facebook::Error.call(error2env('error_code' => 999)).
+      should.not.kind_of?(RestCore::Facebook::Error::AccessToken)
+
+    error = RestCore::Facebook::Error.call(error2env(['not a hash']))
+    error.should.not.kind_of?(RestCore::Facebook::Error::AccessToken)
+    error.should    .kind_of?(RestCore::Facebook::Error)
+  end
+
+  should 'nuke cache upon errors' do
+    stub_request(:get, 'https://graph.facebook.com/me').
+      to_return(:body => '{"error":"wrong"}').times(2)
+
+    rg = RestCore::Facebook.new(:cache         => {},
+                                :error_handler => lambda{|env|env})
+    rg.get('me'); rg.get('me')
+    rg.cache.values.should == []
+  end
+end

data/test/{test_handler.rb → client/facebook/test_handler.rb}

@@ -1,11 +1,7 @@
 
-if respond_to?(:require_relative, true)
-  require_relative 'common'
-else
-  require File.dirname(__FILE__) + '/common'
-end
+require 'rest-core/test'
 
-describe RestGraph do
+describe RestCore::Facebook do
   after do
     WebMock.reset!
     RR.verify
@@ -17,7 +13,7 @@ describe RestGraph do
         to_return(:body => '{}')
 
       logger = []
-      rg = RestGraph.new(:log_method => lambda{ |s| logger << [s] })
+      rg = RestCore::Facebook.new(:log_method => lambda{ |s| logger << [s] })
       rg.get('me')
 
       logger.size.should == 1
@@ -35,13 +31,14 @@ describe RestGraph do
     end
 
     should 'call error_handler if error occurred' do
-      RestGraph.new(:error_handler => @id).get('me').should == @error_hash
+      RestCore::Facebook.new(:error_handler => @id).get('me').
+        should.eq @error_hash
     end
 
-    should 'raise ::RestGraph::Error in default error_handler' do
+    should 'raise ::RestCore::Facebook::Error in default error_handler' do
       begin
-        RestGraph.new.get('me')
-      rescue ::RestGraph::Error => e
+        RestCore::Facebook.new.get('me')
+      rescue ::RestCore::Facebook::Error => e
         e.error  .should == @error_hash
         e.message.should ==
           "#{@error_hash.inspect} from https://graph.facebook.com/me"
@@ -69,14 +66,14 @@ describe RestGraph do
     end
 
     should 'call error_handler if error occurred' do
-      RestGraph.new(:error_handler => @id).fql(@bad_fql_query).
+      RestCore::Facebook.new(:error_handler => @id).fql(@bad_fql_query).
         should == @fql_error_hash
     end
 
-    should 'raise ::RestGraph::Error in default error_handler' do
+    should 'raise ::RestCore::Facebook::Error in default error_handler' do
       begin
-        RestGraph.new.fql(@bad_fql_query)
-      rescue ::RestGraph::Error => e
+        RestCore::Facebook.new.fql(@bad_fql_query)
+      rescue ::RestCore::Facebook::Error => e
         e.error  .should == @fql_error_hash
         e.message.should.start_with?(
           "#{@fql_error_hash.inspect} from "          \

data/test/{test_load_config.rb → client/facebook/test_load_config.rb}

@@ -1,9 +1,5 @@
 
-if respond_to?(:require_relative, true)
-  require_relative 'common'
-else
-  require File.dirname(__FILE__) + '/common'
-end
+require 'rest-core/test'
 
 require 'rest-core/util/config'
 ::Rails = Object.new
@@ -11,7 +7,7 @@ require 'rest-core/util/config'
 describe RestCore::Config do
 
   before do
-    @klass = RestGraph.dup
+    @klass = RestCore::Facebook.dup
   end
 
   after do
@@ -21,14 +17,14 @@ describe RestCore::Config do
   def check
     @klass.default_app_id     .should == 41829
     @klass.default_secret     .should == 'r41829'.reverse
-    @klass.default_auto_decode.should == false
+    @klass.default_json_decode.should == false
     @klass.default_lang       .should == 'zh-tw'
   end
 
   should 'honor rails config' do
     mock(Rails).env { 'test' }
     mock(Rails).root{ File.dirname(__FILE__) }
-    RestCore::Config.load_for_rails(@klass)
+    RestCore::Config.load_for_rails(@klass, 'facebook')
     check
   end
 
@@ -36,7 +32,8 @@ describe RestCore::Config do
     RestCore::Config.load(
       @klass,
       "#{File.dirname(__FILE__)}/config/rest-core.yaml",
-      'test')
+      'test',
+      'facebook')
     check
   end
 end

data/test/{test_misc.rb → client/facebook/test_misc.rb}

@@ -1,23 +1,19 @@
 
-if respond_to?(:require_relative, true)
-  require_relative 'common'
-else
-  require File.dirname(__FILE__) + '/common'
-end
+require 'rest-core/test'
 
-describe RestGraph do
+describe RestCore::Facebook do
   after do
     WebMock.reset!
     RR.verify
   end
 
   should 'return true in authorized? if there is an access_token' do
-    RestGraph.new(:access_token => '1').authorized?.should == true
-    RestGraph.new(:access_token => nil).authorized?.should == false
+    RestCore::Facebook.new(:access_token => '1').authorized?.should == true
+    RestCore::Facebook.new(:access_token => nil).authorized?.should == false
   end
 
   should 'treat oauth_token as access_token as well' do
-    rg = RestGraph.new
+    rg = RestCore::Facebook.new
     hate_facebook = 'why the hell two different name?'
     rg.data['oauth_token'] = hate_facebook
     rg.authorized?.should == true
@@ -25,8 +21,8 @@ describe RestGraph do
   end
 
   should 'build correct headers' do
-    rg = RestGraph.new(:accept => 'text/html',
-                       :lang   => 'zh-tw')
+    rg = RestCore::Facebook.new(:accept => 'text/html',
+                                :lang   => 'zh-tw')
 
     headers = rg.ask.call(rg.send(:build_env))[RestCore::REQUEST_HEADERS]
     headers['Accept'         ].should == 'text/html'
@@ -34,19 +30,19 @@ describe RestGraph do
   end
 
   should 'build empty query string' do
-    rg = RestGraph.new
+    rg = RestCore::Facebook.new
     (rg.ask.call(rg.send(:build_env))[RestCore::REQUEST_QUERY] || {}).
       should == {}
   end
 
   should 'create access_token in query string' do
-    rg = RestGraph.new(:access_token => 'token')
+    rg = RestCore::Facebook.new(:access_token => 'token')
     (rg.ask.call(rg.send(:build_env))[RestCore::REQUEST_QUERY] || {}).
       should == {'access_token' => 'token'}
   end
 
   should 'build correct query string' do
-    rg = RestGraph.new(:access_token => 'token')
+    rg = RestCore::Facebook.new(:access_token => 'token')
     TestHelper.normalize_url(rg.url('', :message => 'hi!!')).
       should == "#{rg.site}?access_token=token&message=hi%21%21"
 
@@ -57,19 +53,20 @@ describe RestGraph do
   end
 
   should 'auto decode json' do
-    rg = RestGraph.new(:auto_decode => true)
+    rg = RestCore::Facebook.new(:json_decode => true)
     stub_request(:get, rg.site).to_return(:body => '[]')
     rg.get('').should ==  []
   end
 
   should 'not auto decode json' do
-    rg = RestGraph.new(:auto_decode => false)
+    rg = RestCore::Facebook.new(:json_decode => false)
     stub_request(:get, rg.site).to_return(:body => '[]')
     rg.get('').should == '[]'
   end
 
   should 'give attributes' do
-    RestGraph.new(:auto_decode => false).attributes.keys.map(&:to_s).sort.
-      should == RestGraph.members.map(&:to_s).sort
+    RestCore::Facebook.new(:json_decode => false).attributes.
+      keys.map(&:to_s).sort.should.eq \
+      RestCore::Facebook.members.map(&:to_s).sort
   end
 end

data/test/{test_oauth.rb → client/facebook/test_oauth.rb}

@@ -1,13 +1,9 @@
 
-if respond_to?(:require_relative, true)
-  require_relative 'common'
-else
-  require File.dirname(__FILE__) + '/common'
-end
+require 'rest-core/test'
 
-describe RestGraph do
+describe RestCore::Facebook do
   before do
-    @rg  = RestGraph.new(:app_id => '29', :secret => '18')
+    @rg  = RestCore::Facebook.new(:app_id => '29', :secret => '18')
     @uri = 'http://zzz.tw'
   end
 
@@ -35,7 +31,7 @@ describe RestGraph do
   end
 
   should 'not append access_token in authorize_url even presented' do
-    RestGraph.new(:access_token => 'do not use me').authorize_url.
+    RestCore::Facebook.new(:access_token => 'do not use me').authorize_url.
       should == 'https://graph.facebook.com/oauth/authorize'
   end
 

data/test/{test_old.rb → client/facebook/test_old.rb}

@@ -1,11 +1,7 @@
 
-if respond_to?(:require_relative, true)
-  require_relative 'common'
-else
-  require File.dirname(__FILE__) + '/common'
-end
+require 'rest-core/test'
 
-describe RestGraph do
+describe RestCore::Facebook do
   after do
     WebMock.reset!
     RR.verify
@@ -17,14 +13,14 @@ describe RestGraph do
     stub_request(:get, "https://api.facebook.com/method/fql.query?#{query}").
       to_return(:body => '[]')
 
-    RestGraph.new.fql(fql).should == []
+    RestCore::Facebook.new.fql(fql).should == []
 
     token = 'token'.reverse
     stub_request(:get, "https://api.facebook.com/method/fql.query?#{query}" \
       "&access_token=#{token}").
       to_return(:body => '[]')
 
-    RestGraph.new(:access_token => token).fql(fql).should == []
+    RestCore::Facebook.new(:access_token => token).fql(fql).should == []
   end
 
   should 'do fql.mutilquery correctly' do
@@ -45,7 +41,7 @@ describe RestGraph do
     }
 
     stub_multi.call
-    RestGraph.new.fql_multi(:f0 => f0, :f1 => f1).should == []
+    RestCore::Facebook.new.fql_multi(:f0 => f0, :f1 => f1).should == []
   end
 
   should 'cache fake post in fql' do
@@ -56,25 +52,27 @@ describe RestGraph do
       with(:body => {:query => query}).
       to_return(:body => body)
 
-    RestGraph.new(:cache => (cache = {})).fql(query, {}, :post => true).
+    RestCore::Facebook.new(:cache => (cache = {})).
+      fql(query, {}, :post => true).
       first['name']   .should == 'Mark Zuckerberg'
     cache.size        .should == 1
     cache.values.first.should == body
 
     WebMock.reset! # should hit the cache
 
-    RestGraph.new(:cache => cache).fql(query, {}, :post => true).
+    RestCore::Facebook.new(:cache => cache).fql(query, {}, :post => true).
       first['name']   .should == 'Mark Zuckerberg'
     cache.size        .should == 1
     cache.values.first.should == body
 
     # query changed
     should.raise(WebMock::NetConnectNotAllowedError) do
-      RestGraph.new(:cache => cache).fql(query.upcase, {}, :post => true)
+      RestCore::Facebook.new(:cache => cache).
+        fql(query.upcase, {}, :post => true)
     end
 
     # cache should work for normal get
-    RestGraph.new(:cache => cache).fql(query).
+    RestCore::Facebook.new(:cache => cache).fql(query).
       first['name']   .should == 'Mark Zuckerberg'
     cache.size        .should == 1
     cache.values.first.should == body
@@ -86,8 +84,8 @@ describe RestGraph do
       'https://api.facebook.com/method/notes.create?format=json').
       to_return(:body => body)
 
-    RestGraph.new.old_rest('notes.create', {}, :auto_decode => false).
-      should == body
+    RestCore::Facebook.new.
+      old_rest('notes.create', {}, :json_decode => false).should.eq body
   end
 
   should 'exchange sessions for access token' do
@@ -97,8 +95,8 @@ describe RestGraph do
               'sessions=bad%20bed').
       to_return(:body => '[{"access_token":"bogus"}]')
 
-    RestGraph.new(:app_id => 'id',
-                  :secret => 'di').
+    RestCore::Facebook.new(:app_id => 'id',
+                           :secret => 'di').
       exchange_sessions(:sessions => 'bad bed').
       first['access_token'].should == 'bogus'
   end
@@ -109,7 +107,7 @@ describe RestGraph do
       'access_token=123%7Cs&format=json&properties=app_id'
     ).to_return(:body => '{"app_id":"123"}')
 
-    RestGraph.new(:app_id => '123', :secret => 's').
+    RestCore::Facebook.new(:app_id => '123', :secret => 's').
       secret_old_rest('admin.getAppProperties', :properties => 'app_id').
       should == {'app_id' => '123'}
   end

data/test/{test_page.rb → client/facebook/test_page.rb}

@@ -1,18 +1,14 @@
 
-if respond_to?(:require_relative, true)
-  require_relative 'common'
-else
-  require File.dirname(__FILE__) + '/common'
-end
+require 'rest-core/test'
 
-describe RestGraph do
+describe RestCore::Facebook do
   after do
     WebMock.reset!
     RR.verify
   end
 
   should 'get the next/prev page' do
-    rg = RestGraph.new(:site => '', :cache => false)
+    rg = RestCore::Facebook.new(:site => '', :cache => false)
     %w[next previous].each{ |type|
       kind = "#{type}_page"
       rg.send(kind, {})              .should == nil
@@ -25,7 +21,7 @@ describe RestGraph do
   end
 
   should 'merge all pages into one' do
-    rg = RestGraph.new(:site => '', :cache => false)
+    rg = RestCore::Facebook.new(:site => '', :cache => false)
     %w[next previous].each{ |type|
       kind = "#{type}_page"
       data = {'paging' => {type => 'zzz'}, 'data' => ['z']}
@@ -54,7 +50,7 @@ describe RestGraph do
   end
 
   should 'for_pages with callback' do
-    rg = RestGraph.new(:site => '', :cache => false)
+    rg = RestCore::Facebook.new(:site => '', :cache => false)
     %w[next previous].each{ |type|
       kind = "#{type}_page"
       data = {'paging' => {type => 'zzz'}, 'data' => ['z']}