rest-client 2.0.2 → 2.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 10312217af6f5a0312bdce748c8fd82f428fce64
-  data.tar.gz: 67846732a7926b335a7082eb1fba0b7178f0c5c4
+SHA256:
+  metadata.gz: e61fb064d966989b00da05fc3e16e3c389cebb68de302d1436e9e2be10dbef8c
+  data.tar.gz: fa5deab3c8c4a44e2d5478e212dd24221d37812f818d4e8cb63e65ebafd8e85c
 SHA512:
-  metadata.gz: 56d9d3140ee5418e9b4e877e9756bbb1a1858314c4487b5d7e41ca5fc72f70532f764dcf480c8c3098f4297025fa66c7d8db0bd890e9ae46459e7478a34a685a
-  data.tar.gz: 812f11c8a6c2c4ac5ec68852e75f64ae2d7416ae4683f5ff6525055dbf8e472baed3cc01a85eb76e5da2cb39233ff2dc2129cbdab7165dec89637987b346359b
+  metadata.gz: ca5026c1f26f1c465c0e2ed869c1a6f6f0dc3b229843d972f9c0267d2f25e98565a672a91b899796d5494391bac73b35d3f36782f0b4afdade1b4d525e09307a
+  data.tar.gz: 8ce3970ab67e95e68cfce154ed6865285f04f0e493c694a7014dee54901a9d64759299bf43c542ce23baf05e15676c9daebd5fa4c53703891cdf179a6a0cf769

data/.gitignore

@@ -6,3 +6,4 @@
 /pkg
 /rdoc
 /.yardoc
+/tmp

data/.mailmap

@@ -0,0 +1,10 @@
+Blake Mizerany <blake.mizerany@gmail.com>
+Lawrence Leonard Gilbert <larry@l2g.to>
+<larry@l2g.to> <larry@L2G.to>
+Marc-André Cournoyer <macournoyer@gmail.com>
+Matthew Manning <matt.manning@gmail.com>
+Nicholas Wieland <nicholas.wieland@gmail.com>
+Rafael Ssouza <rafael.ssouza@gmail.com>
+Richard Schneeman <richard.schneeman@gmail.com>
+Rick Olson <technoweenie@gmail.com>
+T. Watanabe <wtnabe@wt-srv.watanabe>

data/.rubocop

@@ -0,0 +1,2 @@
+--display-cop-names
+--fail-level=W

data/.rubocop-disables.yml

@@ -17,7 +17,7 @@ Lint/StringConversionInInterpolation:
 Lint/UnusedBlockArgument:
   Enabled: false
 
-Lint/Eval:
+Security/Eval:
   Exclude:
   - rest-client.windows.gemspec
 
@@ -53,8 +53,9 @@ Style/BracesAroundHashParameters:
   Enabled: false
 
 # Offense count: 1
-Style/ClassAndModuleCamelCase:
-  Enabled: false
+Naming/ClassAndModuleCamelCase:
+  Exclude:
+    - lib/restclient/windows/root_certs.rb
 
 # Offense count: 2
 # Configuration parameters: EnforcedStyle, SupportedStyles.
@@ -102,7 +103,7 @@ Style/ConditionalAssignment:
   EnforcedStyle: assign_inside_condition
 
 # Offense count: 2
-Style/ConstantName:
+Naming/ConstantName:
   Enabled: false
 
 # TODO: eh?
@@ -110,10 +111,8 @@ Style/ConstantName:
 Metrics/CyclomaticComplexity:
   Max: 22
 
-# Offense count: 1
-# Cop supports --auto-correct.
-Style/DeprecatedHashMethods:
-  Enabled: false
+Style/PreferredHashMethods:
+  EnforcedStyle: verbose
 
 # TODO: docs
 # Offense count: 17
@@ -122,7 +121,7 @@ Style/Documentation:
 
 # Offense count: 9
 # Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/DotPosition:
+Layout/DotPosition:
   Enabled: false
 
 # Offense count: 1
@@ -136,24 +135,27 @@ Style/EachWithObject:
 
 # Offense count: 5
 # Cop supports --auto-correct.
-Style/EmptyLines:
+Layout/EmptyLines:
   Enabled: false
 
 # Offense count: 11
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/EmptyLinesAroundClassBody:
+Layout/EmptyLinesAroundClassBody:
   Enabled: false
 
 # Offense count: 1
 # Cop supports --auto-correct.
-Style/EmptyLinesAroundMethodBody:
+Layout/EmptyLinesAroundMethodBody:
   Enabled: false
 
 # Offense count: 9
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/EmptyLinesAroundModuleBody:
+Layout/EmptyLinesAroundModuleBody:
+  Enabled: false
+
+Layout/EmptyLinesAroundExceptionHandlingKeywords:
   Enabled: false
 
 # Offense count: 31
@@ -161,11 +163,9 @@ Style/EmptyLinesAroundModuleBody:
 Style/Encoding:
   Enabled: false
 
-# TODO: exclude
-# Offense count: 1
-# Configuration parameters: Exclude.
-Style/FileName:
-  Enabled: false
+Naming/FileName:
+  Exclude:
+    - lib/rest-client.rb
 
 # Offense count: 3
 # Configuration parameters: EnforcedStyle, SupportedStyles.
@@ -184,12 +184,9 @@ Style/HashSyntax:
 Style/IfUnlessModifier:
   Enabled: false
 
-# TODO: configure
-# Offense count: 6
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/IndentHash:
-  Enabled: false
+Layout/IndentFirstHashElement:
+  Exclude:
+    - 'spec/**/*.rb'
 
 # NOTABUG
 # Offense count: 19
@@ -199,14 +196,13 @@ Style/Lambda:
 # TODO
 # Offense count: 14
 # Cop supports --auto-correct.
-Style/LeadingCommentSpace:
+Layout/LeadingCommentSpace:
   Enabled: false
 
-# TODO
-# Offense count: 218
-# Configuration parameters: AllowURI.
 Metrics/LineLength:
-  Max: 340
+  Exclude:
+    - 'spec/**/*.rb'
+    - 'Rakefile'
 
 # TODO
 # Offense count: 28
@@ -262,7 +258,7 @@ Style/PercentLiteralDelimiters:
 
 # Offense count: 3
 # Configuration parameters: NamePrefixBlacklist.
-Style/PredicateName:
+Naming/PredicateName:
   Enabled: false
 
 # TODO: configure
@@ -298,47 +294,45 @@ Style/SignalException:
 # TODO
 # Offense count: 2
 # Cop supports --auto-correct.
-Style/SpaceAfterNot:
+Layout/SpaceAfterNot:
   Enabled: false
 
 # Offense count: 19
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/SpaceAroundEqualsInParameterDefault:
+Layout/SpaceAroundEqualsInParameterDefault:
   Enabled: false
 
 # Offense count: 20
 # Cop supports --auto-correct.
-Style/SpaceAroundOperators:
+Layout/SpaceAroundOperators:
   Enabled: false
 
 # Offense count: 9
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/SpaceBeforeBlockBraces:
+Layout/SpaceBeforeBlockBraces:
   Enabled: false
 
-# Offense count: 37
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
-Style/SpaceInsideBlockBraces:
+Layout/EmptyLinesAroundBlockBody:
   Enabled: false
 
-# Offense count: 6
+# Offense count: 37
 # Cop supports --auto-correct.
-Style/SpaceInsideBrackets:
+# Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
+Layout/SpaceInsideBlockBraces:
   Enabled: false
 
 # Offense count: 181
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SupportedStyles.
-Style/SpaceInsideHashLiteralBraces:
+Layout/SpaceInsideHashLiteralBraces:
   Enabled: false
 
 # TODO
 # Offense count: 9
 # Cop supports --auto-correct.
-Style/SpaceInsideParens:
+Layout/SpaceInsideParens:
   Enabled: false
 
 # Offense count: 414
@@ -347,8 +341,10 @@ Style/SpaceInsideParens:
 Style/StringLiterals:
   Enabled: false
 
-Style/TrailingCommaInLiteral:
-  EnforcedStyleForMultiline: comma
+Style/TrailingCommaInArrayLiteral:
+  EnforcedStyleForMultiline: consistent_comma
+Style/TrailingCommaInHashLiteral:
+  EnforcedStyleForMultiline: consistent_comma
 Style/TrailingCommaInArguments:
   Enabled: false
 
@@ -382,3 +378,9 @@ Style/WordArray:
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 Style/BarePercentLiterals:
   Enabled: false
+
+
+Style/RescueStandardError:
+  Exclude:
+    - 'bin/restclient'
+    - 'lib/restclient/windows/root_certs.rb'

data/.rubocop.yml

@@ -1,3 +1,8 @@
 ---
 inherit_from:
 - .rubocop-disables.yml
+
+AllCops:
+  Exclude:
+    - 'tmp/*.rb'
+    - 'vendor/**/*'

data/.travis.yml

@@ -1,48 +1,62 @@
 # Available ruby versions: http://rubies.travis-ci.org/
 
 language: ruby
+sudo: false
 
 os:
   - linux
-  - osx
+#  - osx
 
 rvm:
-  - "2.0.0"
   - "2.1" # latest 2.1.x
-  - "2.2.5"
-  - "2.3.3"
-  - "2.4.0"
+  - "2.2.10"
+  - "2.3.8"
+  - "2.4.6"
+  - "2.5.5"
+  - "2.6.3"
   - "ruby-head"
-  - "jruby-9.0.5.0"
-  - "jruby-9.1.5.0"
+  - "jruby-9.1.9.0"
   - "jruby-head"
 
 cache: bundler
 
 script:
-  bundle exec rake test
+  - bundle exec rake test
+  - bundle exec rake rubocop
 
 branches:
   except:
     - "readme-edits"
 
 before_install:
-  - gem update --system
+  # Install rubygems < 3.0 so that we can support ruby < 2.3
+  # https://github.com/rubygems/rubygems/issues/2534
+  - gem install rubygems-update -v '<3' && update_rubygems
   # bundler installation needed for jruby-head
   # https://github.com/travis-ci/travis-ci/issues/5861
-  - gem install bundler
-
-# Travis OS X support is pretty janky. These are some hacks to include tests
-# only on versions that actually work.
-# (last tested: 2016-11)
+  # stick to bundler 1.x in order to support ruby < 2.3
+  - gem install bundler -v '~> 1.17'
+
+# Travis macOS support is pretty janky. These are some hacks to include tests
+# only on versions that actually work. We test on macOS because Apple monkey
+# patches OpenSSL to have different behavior, and we want to ensure that SSL
+# verification at least is broken in the expected ways on macOS.
+# (last tested: 2019-08)
 matrix:
   # exclude: {}
-  # include: {}
+  include:
+    # test only a few versions on mac
+    - os: osx
+      rvm: 2.6.3
+    - os: osx
+      rvm: ruby-head
+    - os: osx
+      rvm: jruby-9.1.9.0
+    - os: osx
+      rvm: jruby-head
 
   allow_failures:
     - rvm: 'ruby-head'
 
   # return results as soon as mandatory versions are done
   fast_finish: true
-
-sudo: false

data/AUTHORS

@@ -7,6 +7,7 @@ Adrian Rangel
 Alex Tomlins
 Aman Gupta
 Andy Brody
+Avi Deitcher
 Blake Mizerany
 Brad Ediger
 Braintree
@@ -38,10 +39,12 @@ Harm Aarts
 Hiro Asari
 Hugh McGowan
 Ian Warshak
+Igor Zubkov
 Ivan Makfinsky
 JH. Chabran
 James Edward Gray II
 Jari Bakken
+Jeff Pereira
 Jeff Remer
 Jeffrey Hardy
 Jeremy Kemper
@@ -59,12 +62,14 @@ Keith Rarick
 Kenichi Kamiya
 Kevin Read
 Kosuke Asami
+Kyle Meyer
 Kyle VanderBeek
 Lars Gierth
 Lawrence Leonard Gilbert
 Lee Jarvis
 Lennon Day-Reynolds
 Lin Jen-Shin
+Magne Matre Gåsland
 Marc-André Cournoyer
 Marius Butuc
 Matthew Manning
@@ -77,6 +82,7 @@ Nicholas Wieland
 Nick Hammond
 Nick Plante
 Niko Dittmann
+Nikolay Shebanov
 Oscar Del Ben
 Pablo Astigarraga
 Paul Dlug
@@ -85,9 +91,11 @@ Pedro Chambino
 Philip Corliss
 Pierre-Louis Gottfrois
 Rafael Ssouza
+Richard Schneeman
 Rick Olson
 Robert Eanes
 Rodrigo Panachi
+Sam Norbury
 Samuel Cochran
 Syl Turner
 T. Watanabe

data/README.md

@@ -39,6 +39,7 @@ The rest-client gem depends on these other gems for usage at runtime:
 
 * [mime-types](http://rubygems.org/gems/mime-types)
 * [netrc](http://rubygems.org/gems/netrc)
+* [http-accept](https://rubygems.org/gems/http-accept)
 * [http-cookie](https://rubygems.org/gems/http-cookie)
 
 There are also several development dependencies. It's recommended to use
@@ -359,7 +360,7 @@ RestClient.get('http://example.com/resource') { |response, request, result, &blo
   when 423
     raise SomeCustomExceptionIfYouWant
   else
-    response.return!(request, result, &block)
+    response.return!(&block)
   end
 }
 ```
@@ -446,6 +447,106 @@ You can:
 
 See `RestClient::Request`'s documentation for more information.
 
+### Streaming request payload
+
+RestClient will try to stream any file-like payload rather than reading it into
+memory. This happens through `RestClient::Payload::Streamed`, which is
+automatically called internally by `RestClient::Payload.generate` on anything
+with a `read` method.
+
+```ruby
+>> r = RestClient.put('http://httpbin.org/put', File.open('/tmp/foo.txt', 'r'),
+                      content_type: 'text/plain')
+=> <RestClient::Response 200 "{\n  \"args\":...">
+```
+
+In Multipart requests, RestClient will also stream file handles passed as Hash
+(or __new in 2.1__ ParamsArray).
+
+```ruby
+>> r = RestClient.put('http://httpbin.org/put',
+                      {file_a: File.open('a.txt', 'r'),
+                       file_b: File.open('b.txt', 'r')})
+=> <RestClient::Response 200 "{\n  \"args\":...">
+
+# received by server as two file uploads with multipart/form-data
+>> JSON.parse(r)['files'].keys
+=> ['file_a', 'file_b']
+```
+
+### Streaming responses
+
+Normally, when you use `RestClient.get` or the lower level
+`RestClient::Request.execute method: :get` to retrieve data, the entire
+response is buffered in memory and returned as the response to the call.
+
+However, if you are retrieving a large amount of data, for example a Docker
+image, an iso, or any other large file, you may want to stream the response
+directly to disk rather than loading it in memory. If you have a very large
+file, it may become *impossible* to load it into memory.
+
+There are two main ways to do this:
+
+#### `raw_response`, saves into Tempfile
+
+If you pass `raw_response: true` to `RestClient::Request.execute`, it will save
+the response body to a temporary file (using `Tempfile`) and return a
+`RestClient::RawResponse` object rather than a `RestClient::Response`.
+
+Note that the tempfile created by `Tempfile.new` will be in `Dir.tmpdir`
+(usually `/tmp/`), which you can override to store temporary files in a
+different location. This file will be unlinked when it is dereferenced.
+
+If logging is enabled, this will also print download progress.
+__New in 2.1:__ Customize the interval with `:stream_log_percent` (defaults to
+10 for printing a message every 10% complete).
+
+For example:
+
+```ruby
+>> raw = RestClient::Request.execute(
+           method: :get,
+           url: 'http://releases.ubuntu.com/16.04.2/ubuntu-16.04.2-desktop-amd64.iso',
+           raw_response: true)
+=> <RestClient::RawResponse @code=200, @file=#<Tempfile:/tmp/rest-client.20170522-5346-1pptjm1>, @request=<RestClient::Request @method="get", @url="http://releases.ubuntu.com/16.04.2/ubuntu-16.04.2-desktop-amd64.iso">>
+>> raw.file.size
+=> 1554186240
+>> raw.file.path
+=> "/tmp/rest-client.20170522-5346-1pptjm1"
+raw.file.path
+=> "/tmp/rest-client.20170522-5346-1pptjm1"
+
+>> require 'digest/sha1'
+>> Digest::SHA1.file(raw.file.path).hexdigest
+=> "4375b73e3a1aa305a36320ffd7484682922262b3"
+```
+
+#### `block_response`, receives raw Net::HTTPResponse
+
+If you want to stream the data from the response to a file as it comes, rather
+than entirely in memory, you can also pass `RestClient::Request.execute` a
+parameter `:block_response` to which you pass a block/proc. This block receives
+the raw unmodified Net::HTTPResponse object from Net::HTTP, which you can use
+to stream directly to a file as each chunk is received.
+
+Note that this bypasses all the usual HTTP status code handling, so you will
+want to do you own checking for HTTP 20x response codes, redirects, etc.
+
+The following is an example:
+
+````ruby
+File.open('/some/output/file', 'w') {|f|
+  block = proc { |response|
+    response.read_body do |chunk|
+      f.write chunk
+    end
+  }
+  RestClient::Request.execute(method: :get,
+                              url: 'http://example.com/some/really/big/file.img',
+                              block_response: block)
+}
+````
+
 ## Shell
 
 The restclient shell command gives an IRB session with RestClient already loaded:
@@ -498,15 +599,32 @@ $ restclient put http://example.com/resource < input_body
 
 ## Logging
 
-To enable logging you can:
+To enable logging globally you can:
 
-- set RestClient.log with a Ruby Logger, or
-- set an environment variable to avoid modifying the code (in this case you can use a file name, "stdout" or "stderr"):
+- set RestClient.log with a Ruby Logger
+
+```ruby
+RestClient.log = STDOUT
+```
+
+- or set an environment variable to avoid modifying the code (in this case you can use a file name, "stdout" or "stderr"):
 
 ```ruby
 $ RESTCLIENT_LOG=stdout path/to/my/program
 ```
-Either produces logs like this:
+
+You can also set individual loggers when instantiating a Resource or making an
+individual request:
+
+```ruby
+resource = RestClient::Resource.new 'http://example.com/resource', log: Logger.new(STDOUT)
+```
+
+```ruby
+RestClient::Request.execute(method: :get, url: 'http://example.com/foo', log: Logger.new(STDERR))
+```
+
+All options produce logs like this:
 
 ```ruby
 RestClient.get "http://some/resource"
@@ -774,11 +892,10 @@ See AUTHORS for the full list.
 
 ## Legal
 
-Released under the MIT License: http://www.opensource.org/licenses/mit-license.php
+Released under the MIT License: https://opensource.org/licenses/MIT
 
-"Master Shake" photo (http://www.flickr.com/photos/solgrundy/924205581/) by
-"SolGrundy"; used under terms of the Creative Commons Attribution-ShareAlike 2.0
-Generic license (http://creativecommons.org/licenses/by-sa/2.0/)
+Photo of the International Space Station was produced by NASA and is in the
+public domain.
 
 Code for reading Windows root certificate store derived from work by Puppet;
 used under terms of the Apache License, Version 2.0.