resque_extensions 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 80002f51b0e8d0497984bd9868fcd9e3b52d3f1e
-  data.tar.gz: 9bcb0d60827406630a66d18436d91c3852c65ac4
+  metadata.gz: 452eed9b7cf302095dda7f7c8fb1fc4d9056d486
+  data.tar.gz: f23c5754c966622f5055a5ce703d8bb9ff8fdc87
 SHA512:
-  metadata.gz: 630b27e23f2be9306aac3d7e020c2559ec6e14204852b4da90dc2d33fedffc4f24e7117acc0990835d44a9f8d3914b8b01832b48002a45d1831b0bef3a3b0ef3
-  data.tar.gz: 7268b939b048db1df7cabe598f9f5dae3030c05001c7e785ddcd9d69d306ec280498f3ed52bae73f8a9dce35ee6ce5080c146b735cb15603f04b2b05517c396f
+  metadata.gz: ce440e2e0fca8e28ed7f3d7c699f0902d853b85b20a4b97c1330ca6a1657438608100ec6b67d832cdae68a287fcd33abe67cfcefb3ad6bb4f4410fd4c951fe28
+  data.tar.gz: 44395467176955c6b894566d2c9a40fa306a48e2956ef229f9465f15935504e8a8ee496c715c5f57116408c9ff285280320954ddea2ab22c41e1b8c7acddcc50

data/lib/resque_extensions/async_method.rb

@@ -73,10 +73,10 @@ module ResqueExtensions
         data = data.split("::")
         id = data.pop
         class_name = data[1..-1].join("::")
-        data = Resque::Job.const_get(class_name).find(id)
+        data = self.constantize(class_name).find(id)
       # classes become strings prefixed by _Class
       elsif data.to_s =~ /^#{CLASS_PREFIX}/
-        data = Resque::Job.const_get(data.gsub(/^#{CLASS_PREFIX}/,''))
+        data = self.constantize(data.gsub(/^#{CLASS_PREFIX}/, ''))
       end
       # return data
       data
@@ -124,5 +124,17 @@ module ResqueExtensions
       # if we have overlaps, we've been passed options
       return (keys & OPTIONAL_SETTINGS).length > 0
     end
+
+    def self.constantize(namespaced_class)
+      names = namespaced_class.split('::')
+      names.shift if names.empty? || names.first.empty?
+
+      constant = Object
+      names.each do |name|
+        constant = constant.const_defined?(name) ? constant.const_get(name) : constant.const_missing(name)
+      end
+
+      constant
+    end
   end
 end

data/lib/resque_extensions/version.rb

@@ -1,3 +1,3 @@
 module ResqueExtensions
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

data/spec/lib/resque_extensions/async_method_spec.rb

@@ -15,7 +15,6 @@ module ResqueExtensions
 
         job = Resque.reserve("default")
         job.perform
-
       end
 
       it "deserializes and calls a method on an ActiveRecord" do
@@ -33,6 +32,18 @@ module ResqueExtensions
 
       end
 
+      it 'properly looks up class names that are namespaced' do
+
+        async_method = AsyncMethod.new(RootModule::InnerClass, :my_class_method, 'a')
+        async_method.enqueue!
+
+        RootModule::InnerClass.expects(:send).with('my_class_method', 'a')
+        InnerClass.expects(:send).never
+
+        job = Resque.reserve('default')
+        job.perform
+      end
+
     end
 
 
@@ -81,9 +92,9 @@ module ResqueExtensions
         async_method.enqueue!
 
         job = Resque.reserve("default")
-        
+
         job.payload.should eql({
-          "class" => "ResqueExtensions::AsyncMethod", 
+          "class" => "ResqueExtensions::AsyncMethod",
           "args" => ["_Class::MyClass", "my_class_method"]
         })
 
@@ -97,11 +108,11 @@ module ResqueExtensions
         async_method.enqueue!
 
         job = Resque.reserve("default")
-        
+
         job.payload.should eql({
-          "class" => "ResqueExtensions::AsyncMethod", 
+          "class" => "ResqueExtensions::AsyncMethod",
           "args" => [
-            "_ActiveRecord::MyClass::#{my_instance.id}", 
+            "_ActiveRecord::MyClass::#{my_instance.id}",
             "my_instance_method"
           ]
         })
@@ -113,10 +124,10 @@ module ResqueExtensions
         my_instance = MyClass.create(:name => "Dan")
 
         async_method = AsyncMethod.new(
-          MyClass, 
-          :my_class_method, 
-          [my_instance], 
-          my_instance, 
+          MyClass,
+          :my_class_method,
+          [my_instance],
+          my_instance,
           {:a => my_instance}
         )
         async_method.enqueue!
@@ -127,9 +138,9 @@ module ResqueExtensions
         job = Resque.reserve("default")
 
         job.payload.should eql({
-          "class" => "ResqueExtensions::AsyncMethod", 
+          "class" => "ResqueExtensions::AsyncMethod",
           "args" => [
-            "_Class::MyClass", 
+            "_Class::MyClass",
             "my_class_method",
             [instance_string],
             instance_string,

data/spec/spec_helper.rb

@@ -51,6 +51,18 @@ RSpec.configure do |config|
 
     end
 
+    module RootModule
+      class InnerClass
+        def self.my_class_method(arg)
+        end
+      end
+    end
+
+    module InnerClass
+      def self.my_class_method(arg)
+      end
+    end
+
   end
 
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: resque_extensions
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Dan Langevin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-25 00:00:00.000000000 Z
+date: 2013-10-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: resque