resque-multi-step 1.1.1 → 1.1.2

data/History.txt

@@ -0,0 +1,9 @@
+Version 1.1.2
+=====
+
+Fixed race condition around task finalization which caused some jobs to fail FinalizationAlreadyBegun errors.  This did not negatively impact task completion but it did clutter the failed job queue.
+
+Version 1.0.0 
+=======
+
+Initial port of internal code to support multi step tasks.

data/VERSION

@@ -1 +1 @@
-1.1.1
+1.1.2

data/lib/resque/plugins/multi_step_task.rb

@@ -17,6 +17,11 @@ module Resque
       class NoSuchMultiStepTask < StandardError; end
       class NotReadyForFinalization < StandardError; end
       class FinalizationAlreadyBegun < StandardError; end
+      class StdOutLogger
+        def warn(*args); puts args; end
+        def info(*args); puts args; end
+        def debug(*args); puts args; end
+      end
 
       class << self
         include Constantization
@@ -285,6 +290,10 @@ module Resque
       def maybe_finalize
         return unless ready_for_finalization? && !incomplete_because_of_errors?
         finalize!
+      rescue FinalizationAlreadyBegun
+        # Just eat it the exception.  Sometimes multiple normal jobs
+        # will try to finalize a task simultaneously.  This is
+        # expected behavior because normal jobs run in parallel.
       end
 
       # Is this task at the point where finalization can occur.

data/resque-multi-step.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{resque-multi-step}
-  s.version = "1.1.1"
+  s.version = "1.1.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Peter Williams", "Morgan Whitney"]
-  s.date = %q{2011-02-28}
+  s.date = %q{2011-03-14}
   s.description = %q{Provides multi-step tasks with finalization and progress tracking}
   s.email = %q{pezra@barelyenough.org}
   s.extra_rdoc_files = [
@@ -18,6 +18,7 @@ Gem::Specification.new do |s|
   ]
   s.files = [
     ".document",
+    "History.txt",
     "LICENSE",
     "README.md",
     "Rakefile",

data/spec/resque/plugins/multi_step_task_spec.rb

@@ -124,7 +124,7 @@ module  Resque::Plugins
       task.add_job(TestJob, "my", "args") rescue nil
       task.finalizable!
 
-      task.should be_incomplete_because_of_error
+      task.should be_incomplete_because_of_errors
     end
 
     it "knows it has failed if a finalized job raises an exception" do

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 1
   - 1
-  - 1
-  version: 1.1.1
+  - 2
+  version: 1.1.2
 platform: ruby
 authors: 
 - Peter Williams
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-02-28 00:00:00 -07:00
+date: 2011-03-14 00:00:00 -06:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -107,6 +107,7 @@ extra_rdoc_files:
 - README.md
 files: 
 - .document
+- History.txt
 - LICENSE
 - README.md
 - Rakefile