resque-kubernetes 1.3.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c90637618ea819269c20b91f9cc752e28b435da0
-  data.tar.gz: 94391752da8c4a799442d22e31f5cfdf3ac8cc21
+  metadata.gz: 5b5eb837eae7cac78d84a9cdc246888a76b72757
+  data.tar.gz: fa20e71d90dd54d75f46ede6395426b8fdc5adac
 SHA512:
-  metadata.gz: 9c3dcccddc78c704a909c2abba2b0acd7236ba8df30026dbaf4a0ce11958e4823064c25dfb8bdfaf3b923510fe3468088ad70d26ec799c6ca0fe037711db2f89
-  data.tar.gz: f9257d78372f47e6a94be98d022095d05d3af32f960b402c126a760cf247060e28fd7dca34c402898e8db6d591fb79e63f6162042da130b77f4767da3c16ca02
+  metadata.gz: b7a5c03e3368267b04f3cf0027fb0e72a882cf36133b4ed2da7ca63a0528781baecfbfa4670113d196b4baaf3794b2711fa0dd30fc7e9d68ce48a8c803c1dc16
+  data.tar.gz: 1aec966a307c5619a07c56fd93549b18764b6fa239138af439e718a45c89b823550e68bf9f7d36e56ed2e9df77c658f2ad7b2de8484d759f0a1cc67bc438114d

data/CHANGELOG.md

@@ -1,3 +1,34 @@
+# V2.0.0
+**Breaking Change:**
+- The `environments` configuration as been replaced by a more flexible `enabled` property.
+
+  Here's how to migrate from the `environments` property to the `enabled` property:
+
+  Before:
+  ```ruby
+  # config/initializers/resque-kubernetes.rb
+
+  Resque::Kubernetes.configuration do |config|
+   config.environments << "staging"
+   config.max_workers = 10
+  end
+  ```
+
+  After:
+  ```ruby
+  # config/initializers/resque-kubernetes.rb
+
+  Resque::Kubernetes.configuration do |config|
+   config.enabled     = Rails.env.production? || Rails.env.staging?
+   config.max_workers = 10
+  end
+  ```
+    
+  ⚠️ By default, this gem is not enabled.
+
+**Changes:**
+- Allow resque 2.0 but retain support for 1.26 or later.
+
 # v1.3.0
 - Retry when a timeout occurs connecting to the Kubernetes API server
 

data/README.md

@@ -152,19 +152,16 @@ your project:
 # config/initializers/resque-kubernetes.rb
 
 Resque::Kubernetes.configuration do |config|
- config.environments << "staging"
+ config.enabled     = Rails.env.production? || Rails.env.staging?
  config.max_workers = 10
 end
 ```
 
-### `environments`
+### `enabled`
 
-> This only works under Rails, when `Rails.env` is set.
+⚠️ By default, the `enabled` property is set to `false` which means that, by default, this plugin will not be launched.
 
-By default `Resque::Kubernetes` will only manage Kubernetes Jobs in
-`:production`. If you want to add other environments you can update this list
-(`config.environments << "staging"`) or replace it (`config.environments =
-["production", "development"]`).
+You should not enable this Resque plugin in environments that are not run inside a Kubernetes cluster (for example, your CI env).
 
 ### `max_workers`
 

data/lib/resque/kubernetes.rb

@@ -19,8 +19,8 @@ module Resque
   module Kubernetes
     extend Configurable
 
-    # By default only manage kubernetes jobs in :production
-    define_setting :environments, ["production"]
+    # By default, this plugin is not active.
+    define_setting :enabled, false
 
     # Limit the number of workers that should be spun up, default 10
     define_setting :max_workers, 10

data/lib/resque/kubernetes/context_factory.rb

@@ -10,7 +10,6 @@ module Resque
 
       class << self
         def context
-          # TODO: Add ability to load this from config
           [
               Resque::Kubernetes::Context::WellKnown,
               Resque::Kubernetes::Context::Kubectl
@@ -18,6 +17,8 @@ module Resque
             context = context_type.new
             return context.context if context.applicable?
           end
+
+          nil
         end
       end
     end

data/lib/resque/kubernetes/job.rb

@@ -83,9 +83,7 @@ module Resque
 
       # A before_enqueue hook that adds worker jobs to the cluster.
       def before_enqueue_kubernetes_job(*_args)
-        if defined? Rails
-          return unless Resque::Kubernetes.environments.include?(Rails.env)
-        end
+        return unless Resque::Kubernetes.enabled
 
         manager = JobsManager.new(self)
         manager.reap_finished_jobs

data/lib/resque/kubernetes/version.rb

@@ -2,6 +2,6 @@
 
 module Resque
   module Kubernetes
-    VERSION = "1.3.0"
+    VERSION = "2.0.0"
   end
 end

data/resque-kubernetes.gemspec

@@ -33,6 +33,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rubocop", "~> 0.52", ">= 0.52.1", "< 0.56.0"
 
   spec.add_dependency "kubeclient", ">= 3.1.2", "< 5.0"
-  spec.add_dependency "resque", "~> 1.26"
+  spec.add_dependency "resque", ">= 1.26"
   spec.add_dependency "retriable", "~> 3.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: resque-kubernetes
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 2.0.0
 platform: ruby
 authors:
 - Jeremy Wadsack
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-12-11 00:00:00.000000000 Z
+date: 2019-02-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: appraisal
@@ -144,14 +144,14 @@ dependencies:
   name: resque
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.26'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.26'
 - !ruby/object:Gem::Dependency