resque-job-stats 0.1.3 → 0.2.0

data/README.rdoc

@@ -30,7 +30,8 @@ Simply extend your class
 
   class MyJob
     extend Resque::Plugins::JobStats
-    
+
+    @queue = :my_job
     def self.perform(*payload)
       # ..
     end
@@ -45,20 +46,40 @@ Alternatively you can include just the metric you wish to record.
     extend Resque::Plugins::JobStats::Failed
     extend Resque::Plugins::JobStats::Duration
 
+    @queue = :my_job
     def self.perform(*payload)
       # ...
     end
   end
 
-Duration module also extends the class with two singleton methods, MyJob.job_rolling_avg and MyJob.longest_job.
+=== Duration module
+
+The duration module provides two metrics, the longest job and the job rolling avg.
+
+These are accessible via two singleton methods, MyJob.job_rolling_avg and MyJob.longest_job.
+
+By default the last 100 jobs durations are stored and used to provide the above metrics.
+
+You may set the number of jobs to include by setting the @durations_recorded variable.
+
+
+  class MyJob
+    extend Resque::Plugins::JobStats::Duration
+
+    @queue = :my_job
+    @durations_recorded = 1000
+
+    def self.perform(*payload)
+      # ...
+    end
+  end
 
 == TODO
 
-* Allow classes to define how many job's duration to measure
 * Add ui for stats in resque-web
 
 == Contributing to resque-job-stats
- 
+
 * Check out the latest master to make sure the feature hasn't been implemented or the bug hasn't been fixed yet
 * Check out the issue tracker to make sure someone already hasn't requested it and/or contributed it
 * Fork the project

data/VERSION

@@ -1 +1 @@
-0.1.3
+0.2.0

data/lib/resque/plugins/job_stats/duration.rb

@@ -10,7 +10,7 @@ module Resque
 
         # Returns the number of jobs failed
         def job_durations
-          Resque.redis.lrange(jobs_duration_key,0,job_durations_to_track).map(&:to_f)
+          Resque.redis.lrange(jobs_duration_key,0,durations_recorded - 1).map(&:to_f)
         end
 
         # Returns the key used for tracking job durations
@@ -25,11 +25,11 @@ module Resque
           duration = Time.now - start
 
           Resque.redis.lpush(jobs_duration_key, duration)
-          Resque.redis.ltrim(jobs_duration_key, 0, job_durations_to_track)
+          Resque.redis.ltrim(jobs_duration_key, 0, durations_recorded)
         end
 
-        def job_durations_to_track
-          100
+        def durations_recorded
+          @durations_recorded || 100
         end
 
         def job_rolling_avg

data/resque-job-stats.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{resque-job-stats}
-  s.version = "0.1.3"
+  s.version = "0.2.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["alanpeabody"]
-  s.date = %q{2011-07-17}
+  s.date = %q{2011-09-24}
   s.description = %q{Tracks jobs performed, failed, and the duration of the last 100 jobs for each job type.}
   s.email = %q{gapeabody@gmail.com}
   s.extra_rdoc_files = [

data/test/test_job_stats.rb

@@ -22,6 +22,12 @@ class FailJob < BaseJob
   end
 end
 
+class CustomDurJob < BaseJob
+  extend Resque::Plugins::JobStats::Duration
+  @queue = :test
+  @durations_recorded = 5
+end
+
 class TestResqueJobStats < MiniTest::Unit::TestCase
 
   def setup
@@ -60,11 +66,13 @@ class TestResqueJobStats < MiniTest::Unit::TestCase
     SimpleJob.reset_job_durations
     assert_equal 0.0, SimpleJob.job_rolling_avg
     assert_equal 0.0, SimpleJob.longest_job
+
     3.times do |i|
       d = (i + 1)/10.0
       Resque.enqueue(SimpleJob,d)
       @worker.work(0)
     end
+
     assert_in_delta 0.3, SimpleJob.job_durations[0], 0.01
     assert_in_delta 0.2, SimpleJob.job_durations[1], 0.01
     assert_in_delta 0.1, SimpleJob.job_durations[2], 0.01
@@ -72,4 +80,21 @@ class TestResqueJobStats < MiniTest::Unit::TestCase
     assert_in_delta 0.2, SimpleJob.job_rolling_avg, 0.01
   end
 
+  def test_custom_duration
+    CustomDurJob.reset_job_durations
+
+    2.times do
+      Resque.enqueue(CustomDurJob,1.0)
+      @worker.work(0)
+    end
+
+    5.times do
+      Resque.enqueue(CustomDurJob,0.1)
+      @worker.work(0)
+    end
+
+    assert_in_delta 0.1, CustomDurJob.longest_job, 0.01
+    assert_in_delta 0.1, CustomDurJob.job_rolling_avg, 0.01
+  end
+
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: resque-job-stats
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.2.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,12 +9,12 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-07-17 00:00:00.000000000 -04:00
+date: 2011-09-24 00:00:00.000000000 -04:00
 default_executable: 
 dependencies:
 - !ruby/object:Gem::Dependency
   name: resque
-  requirement: &8140020 !ruby/object:Gem::Requirement
+  requirement: &13078080 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -22,10 +22,10 @@ dependencies:
         version: 1.17.0
   type: :runtime
   prerelease: false
-  version_requirements: *8140020
+  version_requirements: *13078080
 - !ruby/object:Gem::Dependency
   name: minitest
-  requirement: &8114360 !ruby/object:Gem::Requirement
+  requirement: &13076680 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -33,10 +33,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *8114360
+  version_requirements: *13076680
 - !ruby/object:Gem::Dependency
   name: bundler
-  requirement: &8112800 !ruby/object:Gem::Requirement
+  requirement: &13075340 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -44,10 +44,10 @@ dependencies:
         version: 1.0.0
   type: :development
   prerelease: false
-  version_requirements: *8112800
+  version_requirements: *13075340
 - !ruby/object:Gem::Dependency
   name: jeweler
-  requirement: &8111340 !ruby/object:Gem::Requirement
+  requirement: &13073780 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -55,10 +55,10 @@ dependencies:
         version: 1.6.4
   type: :development
   prerelease: false
-  version_requirements: *8111340
+  version_requirements: *13073780
 - !ruby/object:Gem::Dependency
   name: rcov
-  requirement: &8110040 !ruby/object:Gem::Requirement
+  requirement: &13048440 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -66,10 +66,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *8110040
+  version_requirements: *13048440
 - !ruby/object:Gem::Dependency
   name: mynyml-redgreen
-  requirement: &8108480 !ruby/object:Gem::Requirement
+  requirement: &13046280 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -77,7 +77,7 @@ dependencies:
         version: 0.7.1
   type: :development
   prerelease: false
-  version_requirements: *8108480
+  version_requirements: *13046280
 description: Tracks jobs performed, failed, and the duration of the last 100 jobs
   for each job type.
 email: gapeabody@gmail.com
@@ -119,7 +119,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -2575674717997746686
+      hash: -2425324419253773281
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements: