resque-integration 3.4.1

data/spec/resque/integration/configuration_spec.rb

@@ -0,0 +1,147 @@
+# coding: utf-8
+
+require 'spec_helper'
+
+describe Resque::Integration::Configuration do
+  let(:config) do
+    File.stub(:exists? => true)
+    File.stub(:read)
+    ERB.stub_chain(:new, :result)
+    YAML.stub(:load => config_yaml)
+    described_class.new('path/to/config.yml')
+  end
+
+  let(:config_yaml) { {} }
+
+  describe '#schedule_file' do
+    let(:config_yaml) { {'resque' => {'schedule_file' => 'schedule.yml'}} }
+
+    it { expect(config.schedule_file).to eq 'schedule.yml' }
+  end
+
+  describe '#log_level' do
+    context 'when default' do
+      it { expect(config.log_level).to eq 1 }
+    end
+
+    context 'when defined' do
+      let(:config_yaml) { {'resque' => {'log_level' => 2}} }
+
+      it { expect(config.log_level).to eq 2 }
+    end
+  end
+
+  describe '#resque_scheduler?' do
+    context 'when default' do
+      it { expect(config.resque_scheduler?).to be_truthy }
+    end
+
+    context 'when defined' do
+      let(:config_yaml) { {'resque' => {'scheduler' => 'no'}} }
+
+      it { expect(config.resque_scheduler?).to be_falsey }
+    end
+  end
+
+  describe '#run_at_exit_hooks?' do
+    context 'when default' do
+      it { expect(config.resque_scheduler?).to be_truthy }
+    end
+
+    context 'when defined' do
+      let(:config_yaml) { {'resque' => {'run_at_exit_hooks' => 'no'}} }
+
+      it { expect(config.run_at_exit_hooks?).to be_falsey }
+    end
+  end
+end
+
+describe Resque::Integration::Configuration::Notifier do
+  context 'when NilClass given as config' do
+    subject(:config) { described_class::new(nil) }
+
+    it { should_not be_enabled }
+    its(:include_payload?) { should be_truthy }
+    its(:to) { should be_empty }
+    its(:from) { should eq 'no_reply@gmail.com' }
+    its(:mail) { should eq :alert }
+    its(:mailer) { should eq 'ResqueFailedJobMailer::Mailer' }
+  end
+
+  context 'when Hash given as config' do
+    let :configuration do
+      {to: ['to1@mail', 'to2@mail'],
+       from: 'from@mail',
+       enabled: false,
+       include_payload: false,
+       mail: 'notify',
+       mailer: 'MyMailer'}
+    end
+
+    subject(:config) { described_class::new(configuration) }
+
+    it { should_not be_enabled }
+    its(:include_payload?) { should be_falsey }
+    its(:to) { should include 'to1@mail' }
+    its(:to) { should include 'to2@mail' }
+    its(:from) { should eq 'from@mail' }
+    its(:mail) { should eq :notify }
+    its(:mailer) { should eq 'MyMailer' }
+  end
+end
+
+describe Resque::Integration::Configuration::Worker do
+  describe '.new' do
+    context 'when Integer given as config' do
+      subject(:config) { described_class::new(:default, 2) }
+
+      its(:queue) { should eq :default }
+      its(:count) { should eq 2 }
+    end
+
+    context 'when Hash given as config' do
+      subject(:config) { described_class::new(:default, :count => 2) }
+
+      its(:queue) { should eq :default }
+      its(:count) { should eq 2 }
+    end
+  end
+
+  describe '#count' do
+    context 'when initialized without count paramter' do
+      subject { described_class::new(:default, {}) }
+
+      its(:count) { should eq 1 }
+    end
+
+    context 'when initialized with count <= 0' do
+      subject { described_class::new(:default, :count => 0) }
+
+      its(:count) { should eq 1 }
+    end
+  end
+
+  describe '#env' do
+    let :config do
+      described_class.new(:default,
+                           :count => 2,
+                           :jobs_per_fork => 10,
+                           :minutes_per_fork => 5,
+                           :shuffle => true,
+                           :env => {:VAR => 2})
+    end
+
+    subject { config.env }
+
+    its([:QUEUE]) { should eq 'default' }
+    its([:JOBS_PER_FORK]) { should eq '10' }
+    its([:MINUTES_PER_FORK]) { should eq '5' }
+    its([:SHUFFLE]) { should eq '1' }
+    its([:VAR]) { should eq '2' }
+
+    context "when shuffle is disabled" do
+      let(:config) { described_class.new(:default, shuffle: false) }
+      its([:SHUFFLE]) { should be_nil }
+    end
+  end
+end

data/spec/resque/integration/continuous_spec.rb

@@ -0,0 +1,122 @@
+# coding: utf-8
+
+require 'spec_helper'
+
+describe Resque::Integration::Continuous do
+  context 'when applied to non-unique job' do
+    class ContinuousJobTest
+      include Resque::Integration
+
+      queue :continuous_test
+      continuous
+
+      def self.perform(id)
+        continue(id + 1)
+      end
+    end
+
+    it 'should re-enqueue the job' do
+      Resque.enqueue(ContinuousJobTest, 1)
+
+      job = Resque.reserve(ContinuousJobTest.queue)
+      job.should be_a(Resque::Job)
+      job.payload['args'].should eq [1]
+      job.perform
+
+      job2 = Resque.reserve(ContinuousJobTest.queue)
+      job2.should be_a(Resque::Job)
+      job2.payload['args'].should eq [2]
+    end
+  end
+
+  context 'when applied to unique job' do
+    class ContinuousUniqueJobTest
+      include Resque::Integration
+
+      queue :unique_continuous_test
+      continuous
+      unique { |x, y| x }
+
+      def self.execute(x, y)
+        continue(x, y + 1)
+      end
+    end
+
+    it 'should re-enqueue the job regardless of any locks' do
+      ContinuousUniqueJobTest.enqueue(1, 1)
+
+      job = Resque.reserve(ContinuousUniqueJobTest.queue)
+      job.should be_a(Resque::Job)
+
+      # meta prepend meta_id arg, so we just ignore it here
+      job.payload['args'][1..-1].should eq [1, 1]
+      job.perform
+
+      ContinuousUniqueJobTest.should be_locked(1, 2)
+      ContinuousUniqueJobTest.should be_enqueued(1, 2)
+
+      job2 = Resque.reserve(ContinuousUniqueJobTest.queue)
+      job2.should be_a(Resque::Job)
+      job2.payload['args'][1..-1].should eq [1, 2]
+
+      # clean the queue
+      ContinuousUniqueJobTest.dequeue(1)
+    end
+
+    it 'should not finish meta' do
+      meta = ContinuousUniqueJobTest.enqueue(2, 1)
+
+      job = Resque.reserve(ContinuousUniqueJobTest.queue)
+      job.perform
+      meta.reload!
+
+      meta2 = ContinuousUniqueJobTest.enqueued?(2, 2)
+
+      meta2.started_at.should eq meta.started_at
+      meta2.enqueued_at.should eq meta.enqueued_at
+      meta2.data.should eq meta.data
+      meta2.should be_working
+
+      # clean the queue
+      ContinuousUniqueJobTest.dequeue(2)
+    end
+
+    it 'should enqueue job with the same meta_id' do
+      ContinuousUniqueJobTest.enqueue(3, 1)
+
+      job1 = Resque.reserve(ContinuousUniqueJobTest.queue)
+      meta1 = job1.payload['args'].first
+
+      job1.perform
+
+      job2 = Resque.reserve(ContinuousUniqueJobTest.queue)
+      meta2 = job2.payload['args'].first
+
+      meta1.should eq meta2
+    end
+  end
+
+  context 'when called without arguments' do
+    class ContinuousWithoutArgsJobTest
+      include Resque::Integration
+
+      queue :continuous_without_args_test
+      continuous
+      unique
+
+      def self.execute(x)
+        continue
+      end
+    end
+
+    it 'should re-enqueue job with same arguments' do
+      ContinuousWithoutArgsJobTest.enqueue(1)
+
+      job = Resque.reserve(ContinuousWithoutArgsJobTest.queue)
+      job.should be_a(Resque::Job)
+      job.perform
+
+      ContinuousWithoutArgsJobTest.should be_enqueued(1)
+    end
+  end
+end

data/spec/resque/integration/failure_backends/queues_totals_spec.rb

@@ -0,0 +1,105 @@
+require 'spec_helper'
+
+describe Resque::Integration::FailureBackends::QueuesTotals do
+  let(:failure) { double('UnbelievableError') }
+  let(:worker) { double('Worker') }
+  let(:payload) { double('Payload') }
+
+  describe '#save' do
+    let(:queue) { 'images' }
+    let(:backend) { described_class.new(failure, worker, queue, payload) }
+
+    before { stub_const('Resque::Integration::FailureBackends::QueuesTotals::MAX_COUNTER_VALUE', 3) }
+
+    it 'increments failures count for specified queue' do
+      expect do
+        2.times { backend.save }
+      end.to change { described_class.count(queue) }.from(0).to(2)
+    end
+
+    context 'when counter overflows' do
+      it 'resets failures count for specified queue to 1' do
+        expect do
+          3.times { backend.save }
+        end.to change { described_class.count(queue) }.from(0).to(1)
+      end
+    end
+  end
+
+  describe '.count' do
+    let(:images_queue) { 'images' }
+    let(:products_queue) { 'products' }
+    let(:images_failure_backend) { described_class.new(failure, worker, images_queue, payload) }
+    let(:products_failure_backend) { described_class.new(failure, worker, products_queue, payload) }
+
+    before do
+      2.times { images_failure_backend.save }
+      3.times { products_failure_backend.save }
+    end
+
+    context 'with specified queue' do
+      it 'returns failures count for specified queue' do
+        expect(described_class.count(images_queue)).to eq(2)
+        expect(described_class.count(products_queue)).to eq(3)
+      end
+    end
+
+    context 'with queue which has no failures' do
+      it 'returns 0' do
+        expect(described_class.count('not_failed')).to eq(0)
+      end
+    end
+
+    context 'without specified queue' do
+      it 'returns aggregated failures count from all queues' do
+        expect(described_class.count).to eq(5)
+      end
+    end
+  end
+
+  describe '.queues' do
+    context 'when has failures data' do
+      let(:images_queue) { 'images' }
+      let(:products_queue) { 'products' }
+
+      before do
+        described_class.new(failure, worker, images_queue, payload).save
+        described_class.new(failure, worker, products_queue, payload).save
+      end
+
+      it 'returns names of failed queues' do
+        expect(described_class.queues).to match_array([images_queue, products_queue])
+      end
+    end
+
+    context 'when does not have failures data' do
+      it { expect(described_class.queues).to be_empty }
+    end
+  end
+
+  describe '.clear' do
+    let(:images_queue) { 'images' }
+    let(:products_queue) { 'products' }
+
+    before do
+      described_class.new(failure, worker, images_queue, payload).save
+      described_class.new(failure, worker, products_queue, payload).save
+    end
+
+    context 'with specified queue' do
+      it 'deletes counter data for specified queue' do
+        expect { described_class.clear(products_queue) }.to change { described_class.count }.from(2).to(1)
+        expect(described_class.count(images_queue)).to eq(1)
+        expect(described_class.count(products_queue)).to eq(0)
+      end
+    end
+
+    context 'without specified queue' do
+      it 'deletes counter data for all queues' do
+        expect { described_class.clear }.to change { described_class.count }.from(2).to(0)
+        expect(described_class.count(images_queue)).to eq(0)
+        expect(described_class.count(products_queue)).to eq(0)
+      end
+    end
+  end
+end

data/spec/resque/integration/ordered_spec.rb

@@ -0,0 +1,87 @@
+require "spec_helper"
+
+describe Resque::Integration::Ordered do
+  class TestJob
+    include Resque::Integration
+
+    unique { |company_id, param1| [company_id] }
+    ordered max_iterations: 2
+  end
+
+  class UniqueTestJob
+    include Resque::Integration
+
+    unique { |company_id, param1| [company_id] }
+    ordered max_iterations: 2, unique: ->(_company_id, param1) { [param1] }
+  end
+
+  it "push args to separate queue" do
+    ordered_meta1 = TestJob.enqueue(1, 10)
+    ordered_meta2 = TestJob.enqueue(1, 20)
+
+    meta_id = TestJob.meta_id(1, 10)
+    args_key = TestJob.ordered_queue_key(meta_id)
+
+    expect(TestJob).to be_enqueued(1)
+    expect(TestJob.ordered_queue_size(meta_id)).to eq 2
+
+    job_args = Resque.decode(Resque.redis.lpop(args_key))
+    expect(job_args[0]).to eq ordered_meta1.meta_id
+
+    job_args = Resque.decode(Resque.redis.lpop(args_key))
+    expect(job_args[0]).to eq ordered_meta2.meta_id
+  end
+
+  it "execute jobs by each args" do
+    TestJob.enqueue(1, 10)
+    TestJob.enqueue(1, 20)
+
+    expect(TestJob).to receive(:execute).with(kind_of(Resque::Plugins::Meta::Metadata), 1, 10).ordered
+    expect(TestJob).to receive(:execute).with(kind_of(Resque::Plugins::Meta::Metadata), 1, 20).ordered
+    expect(TestJob).to_not receive(:continue)
+
+    meta_id = TestJob.meta_id(1, 10)
+    TestJob.perform(meta_id)
+    expect(TestJob.ordered_queue_size(meta_id)).to eq 0
+  end
+
+  it "reenqueue job after max iterations reached" do
+    TestJob.enqueue(1, 10)
+    TestJob.enqueue(1, 20)
+    TestJob.enqueue(1, 30)
+    TestJob.enqueue(1, 40)
+
+    expect(TestJob).to receive(:execute).with(kind_of(Resque::Plugins::Meta::Metadata), 1, 10).ordered
+    expect(TestJob).to receive(:execute).with(kind_of(Resque::Plugins::Meta::Metadata), 1, 20).ordered
+    expect(TestJob).to_not receive(:execute).with(kind_of(Resque::Plugins::Meta::Metadata), 1, 30).ordered
+    expect(TestJob).to_not receive(:execute).with(kind_of(Resque::Plugins::Meta::Metadata), 1, 40).ordered
+    expect(TestJob).to receive(:continue)
+
+    meta_id = TestJob.meta_id(1, 10)
+    TestJob.perform(meta_id)
+    expect(TestJob.ordered_queue_size(meta_id)).to eq 2
+  end
+
+  context 'uniqueness' do
+    it 'perform with unique args only once' do
+      UniqueTestJob.enqueue(1, 10)
+      UniqueTestJob.enqueue(1, 20)
+      UniqueTestJob.enqueue(1, 10)
+
+      expect(UniqueTestJob).to receive(:execute).once.with(kind_of(Resque::Plugins::Meta::Metadata), 1, 10).ordered
+      expect(UniqueTestJob).to receive(:execute).once.with(kind_of(Resque::Plugins::Meta::Metadata), 1, 20).ordered
+      expect(UniqueTestJob).to_not receive(:continue)
+
+      meta_id = UniqueTestJob.meta_id(1, 10)
+      UniqueTestJob.perform(meta_id)
+      expect(UniqueTestJob.ordered_queue_size(meta_id)).to eq 0
+      expect(UniqueTestJob.uniqueness.size(meta_id)).to eq 0
+    end
+
+    it 'enqueue unique jobs with equal meta' do
+      meta = UniqueTestJob.enqueue(1, 10)
+      expect(meta.meta_id).to eq UniqueTestJob.enqueue(1, 10).meta_id
+      expect(meta.meta_id).to_not eq UniqueTestJob.enqueue(1, 20).meta_id
+    end
+  end
+end

data/spec/resque/integration/priority_spec.rb

@@ -0,0 +1,94 @@
+require 'spec_helper'
+
+RSpec.describe Resque::Integration::Priority do
+  class JobWithPriority
+    include Resque::Integration
+
+    queue :foo
+    prioritized
+
+    def self.perform(id, params)
+    end
+  end
+
+  class UniqueJobWithPriority
+    include Resque::Integration
+
+    queue :foo
+    unique do |id, params|
+      [id, params["param"]]
+    end
+    prioritized
+
+    def self.execute(id, params)
+    end
+  end
+
+  describe '#enqueue' do
+    it 'enqueue to priority queue' do
+      JobWithPriority.enqueue_with_priority(:high, 1, param: 'one')
+
+      expect(Resque.size(:foo)).to eq(0)
+      expect(Resque.size(:foo_low)).to eq(0)
+      expect(Resque.size(:foo_high)).to eq(1)
+    end
+
+    it 'enqueue to default queue' do
+      JobWithPriority.enqueue(1, param: 'one')
+
+      expect(Resque.size(:foo)).to eq(1)
+      expect(Resque.size(:foo_low)).to eq(0)
+      expect(Resque.size(:foo_high)).to eq(0)
+    end
+
+    it 'enqueue only one job' do
+      meta1 = UniqueJobWithPriority.enqueue_with_priority(:high, 1, param: 'one')
+      meta2 = UniqueJobWithPriority.enqueue_with_priority(:high, 1, param: 'one')
+
+      expect(meta1.meta_id).to eq(meta2.meta_id)
+
+      expect(Resque.size(:foo)).to eq(0)
+      expect(Resque.size(:foo_low)).to eq(0)
+      expect(Resque.size(:foo_high)).to eq(1)
+    end
+  end
+
+  describe '#dequeue' do
+    it 'dequeue simple job with high priority' do
+      JobWithPriority.enqueue_with_priority(:high, 1, param: 'one')
+      JobWithPriority.enqueue_with_priority(:high, 2, param: 'two')
+      expect(Resque.size(:foo_high)).to eq(2)
+
+      JobWithPriority.dequeue(:high, 1, param: 'one')
+      expect(Resque.size(:foo_high)).to eq(1)
+    end
+
+    it 'dequeue unique job with high priority' do
+      UniqueJobWithPriority.enqueue_with_priority(:high, 1, param: 'one')
+      UniqueJobWithPriority.enqueue_with_priority(:high, 2, param: 'two')
+      expect(Resque.size(:foo_high)).to eq(2)
+
+      UniqueJobWithPriority.dequeue(:high, 1, param: 'one')
+      expect(Resque.size(:foo_high)).to eq(1)
+    end
+  end
+
+  describe '#perform' do
+    include_context 'resque inline'
+
+    it 'executes job' do
+      expect(JobWithPriority).to receive(:perform).with(1, 'param' => 'one')
+      expect(JobWithPriority).to receive(:perform).with(2, 'param' => 'two')
+
+      JobWithPriority.enqueue_with_priority(:high, 1, param: 'one')
+      JobWithPriority.enqueue_with_priority(:high, 2, param: 'two')
+    end
+
+    it 'executes job' do
+      expect(UniqueJobWithPriority).to receive(:execute).twice.and_call_original
+
+      UniqueJobWithPriority.enqueue_with_priority(:high, 1, param: 'one')
+      UniqueJobWithPriority.enqueue_with_priority(:high, 1, param: 'one')
+    end
+  end
+end