resque-heroku-signals 2.5.0 → 2.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3fd0d2ff7c73bef401f2abd72465d542e9c8d3ec19dbde5f6f2aeede596f5c8e
-  data.tar.gz: 0e3332150e08504abab3b7604fad850caf7bdbedf95ed93808e9c0efa8e95e40
+  metadata.gz: '084c40afbbe574362fe885154b1445197c593d7fada8332a1d5b544c57ec0350'
+  data.tar.gz: 39cb127ffa94809de2abb47cad2c1ea836f0d524dc3b3f9a7b1a7aafb8631add
 SHA512:
-  metadata.gz: 1251aa0f48ab31cee2741c5b5eafeae7789b52a261bbc4469c51295f92d01e1128bd2f7a6eeb3d2cb3c309213bd2fd4c5a1deab84a0aeb062b66fe57e5f69dde
-  data.tar.gz: 80319b8d09d046e50b56c59ae904c1e0835f9e87a50bad3fb1aece55382b87775a1b64c2c5c54b2a0ce257fcda8069a2c6e53bb10c07eb414098e3c32360bb4f
+  metadata.gz: 9c11a2d70a3c2f6cef8f0f593ffbf63e2cb683f49ada10c521c86a1dcde80956c7a3037ba401ce984d7d9b8b41e2b2d6e2348a56619d10af7a400b7ad61cb3d8
+  data.tar.gz: fe6f9b45760f34aeecd7f424d3a3b45d3150398781e552b34b3a576fe9c2b4ff1eba2bc7accc34963b801e2bb3e7cb40fdafb1985864109609f2e38132d5213f

data/.github/workflows/ci.yml

@@ -10,7 +10,7 @@ jobs:
           - 6379:6379
     strategy:
       matrix:
-        ruby-version: ['3.0', '2.7']
+        ruby-version: ['3.2', '3.1', '3.0', '2.7']
 
     steps:
       - uses: actions/checkout@v3

data/lib/resque-heroku-signals.rb

@@ -12,24 +12,43 @@ end
 #   https://github.com/resque/resque/blame/v2.0.0/lib/resque/worker.rb#L406
 # https://github.com/resque/resque/issues/1559#issuecomment-310908574
 Resque::Worker.class_eval do
-  def unregister_signal_handlers
-    trap('TERM') do
-      $HEROKU_WILL_TERMINATE_RESQUE = true
+  # In this patched implementation, the only change is that the worker sends
+  # SIGINT to the child, the rest is copied verbatim.
+  def new_kill_child
+    if @child
+      unless child_already_exited?
+        if pre_shutdown_timeout && pre_shutdown_timeout > 0.0
+          log_with_severity :debug, "Waiting #{pre_shutdown_timeout.to_f}s for child process to exit"
+          return if wait_for_child_exit(pre_shutdown_timeout)
+        end
 
-      trap('TERM') do
-        log_with_severity :info, "[resque-heroku] received second term signal, throwing term exception"
+        log_with_severity :debug, "Sending INT signal to child #{@child}"
+        Process.kill("INT", @child)
 
-        trap('TERM') do
-          log_with_severity :info, "[resque-heroku] third or more time receiving TERM, ignoring"
+        if wait_for_child_exit(term_timeout)
+          return
+        else
+          log_with_severity :debug, "Sending KILL signal to child #{@child}"
+          Process.kill("KILL", @child)
         end
-
-        raise Resque::TermException.new("SIGTERM")
+      else
+        log_with_severity :debug, "Child #{@child} already quit."
       end
+    end
+  rescue SystemCallError
+    log_with_severity :error, "Child #{@child} already quit and reaped."
+  end
 
-      log_with_severity :info, "[resque-heroku] received first term signal from heroku, ignoring"
+  def unregister_signal_handlers
+    trap("TERM") do
+      log_with_severity :debug, "Got TERM signal from Heroku."
+      $HEROKU_WILL_TERMINATE_RESQUE = true
     end
 
-    trap('INT', 'DEFAULT')
+    trap("INT") do
+      log_with_severity :debug, "Got INT signal from the worker."
+      raise Resque::TermException.new("SIGINT")
+    end
 
     begin
       trap('QUIT', 'DEFAULT')

data/resque-heroku-signals.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = "resque-heroku-signals"
-  spec.version       = '2.5.0'
+  spec.version       = '2.6.0'
   spec.authors       = ["Michael Bianco"]
   spec.email         = ["mike@mikebian.co"]
 
@@ -22,7 +22,7 @@ Gem::Specification.new do |spec|
   spec.metadata['rubygems_mfa_required'] = 'true'
 
   # strict resque dependency is intentional
-  spec.add_dependency "resque", "2.5.0"
+  spec.add_dependency "resque", "2.6.0"
 
   spec.add_development_dependency "bundler", "~> 2.2"
   spec.add_development_dependency "rake", "~> 13.0"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: resque-heroku-signals
 version: !ruby/object:Gem::Version
-  version: 2.5.0
+  version: 2.6.0
 platform: ruby
 authors:
 - Michael Bianco
-autorequire:
+autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-03-01 00:00:00.000000000 Z
+date: 2023-08-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: resque
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.5.0
+        version: 2.6.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.5.0
+        version: 2.6.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -66,7 +66,7 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.10'
-description:
+description: 
 email:
 - mike@mikebian.co
 executables: []
@@ -92,7 +92,7 @@ licenses:
 - MIT
 metadata:
   rubygems_mfa_required: 'true'
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -107,8 +107,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.1
-signing_key:
+rubygems_version: 3.4.10
+signing_key: 
 specification_version: 4
 summary: Patch resque to be compatible with Heroku
 test_files: []