resque-heroku-signals 2.4.0 → 2.5.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bd617d3ef284ea60150b8b8be9afd02c1940c874e1ed1d50c7eea8df8e5acb08
-  data.tar.gz: 92ddf20276dfd1cc6494cea3cf6b5bc203d3b078f2768b66005308db94c0b679
+  metadata.gz: 62ff5405f78d9e6ad1be2a2807541180adb14ead8924102cc54cefe3d6a0a898
+  data.tar.gz: defed1cc3cd6016402502aab6c53f8e4a610bfc9e6f8c6e17ce3241f57fe7330
 SHA512:
-  metadata.gz: e5830ae5b15b878641d2c5c61ac5625c85cc715f7f7e8d39eca270113f8114871ec9ad3a5ec1a7be7137381d0e300c0927df2a07be79a69a664dc7c01100afa5
-  data.tar.gz: 61751f5cd0ebf894d4fc7804093ffba5bd6b69a337f01120cac996c11f5c6f79a335d99a126b36bbb5be5bf6cb56c612298bea6e60073622d8a07914370b0cb4
+  metadata.gz: 703923f42deee729bd04abdb26bbde32a55a6f098007be6b2959c624eb47f9d172d48a3bb9101590df0203c6849fe4a844a5ff274b6594f63cffaaf0fba1f90f
+  data.tar.gz: e3bb87939927ebdb2511f7b44e32f6669d2abe5d39ae9c660e8991fd88e0a4549d87f156e0bed4453f64e93ddace4dd01491609393f49f78dada7224640ce9bc

data/.github/workflows/ci.yml

@@ -10,7 +10,7 @@ jobs:
           - 6379:6379
     strategy:
       matrix:
-        ruby-version: ['3.0', '2.7']
+        ruby-version: ['3.2', '3.1', '3.0', '2.7']
 
     steps:
       - uses: actions/checkout@v3

data/lib/resque-heroku-signals.rb

@@ -12,24 +12,43 @@ end
 #   https://github.com/resque/resque/blame/v2.0.0/lib/resque/worker.rb#L406
 # https://github.com/resque/resque/issues/1559#issuecomment-310908574
 Resque::Worker.class_eval do
-  def unregister_signal_handlers
-    trap('TERM') do
-      $HEROKU_WILL_TERMINATE_RESQUE = true
+  # In this patched implementation, the only change is that the worker sends
+  # SIGINT to the child, the rest is copied verbatim.
+  def new_kill_child
+    if @child
+      unless child_already_exited?
+        if pre_shutdown_timeout && pre_shutdown_timeout > 0.0
+          log_with_severity :debug, "Waiting #{pre_shutdown_timeout.to_f}s for child process to exit"
+          return if wait_for_child_exit(pre_shutdown_timeout)
+        end
 
-      trap('TERM') do
-        log_with_severity :info, "[resque-heroku] received second term signal, throwing term exception"
+        log_with_severity :debug, "Sending INT signal to child #{@child}"
+        Process.kill("INT", @child)
 
-        trap('TERM') do
-          log_with_severity :info, "[resque-heroku] third or more time receiving TERM, ignoring"
+        if wait_for_child_exit(term_timeout)
+          return
+        else
+          log_with_severity :debug, "Sending KILL signal to child #{@child}"
+          Process.kill("KILL", @child)
         end
-
-        raise Resque::TermException.new("SIGTERM")
+      else
+        log_with_severity :debug, "Child #{@child} already quit."
       end
+    end
+  rescue SystemCallError
+    log_with_severity :error, "Child #{@child} already quit and reaped."
+  end
 
-      log_with_severity :info, "[resque-heroku] received first term signal from heroku, ignoring"
+  def unregister_signal_handlers
+    trap("TERM") do
+      log_with_severity :debug, "Got TERM signal from Heroku."
+      $HEROKU_WILL_TERMINATE_RESQUE = true
     end
 
-    trap('INT', 'DEFAULT')
+    trap("INT") do
+      log_with_severity :debug, "Got INT signal from the worker."
+      raise Resque::TermException.new("SIGINT")
+    end
 
     begin
       trap('QUIT', 'DEFAULT')

data/resque-heroku-signals.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = "resque-heroku-signals"
-  spec.version       = '2.4.0'
+  spec.version       = '2.5.0.1'
   spec.authors       = ["Michael Bianco"]
   spec.email         = ["mike@mikebian.co"]
 
@@ -22,7 +22,7 @@ Gem::Specification.new do |spec|
   spec.metadata['rubygems_mfa_required'] = 'true'
 
   # strict resque dependency is intentional
-  spec.add_dependency "resque", "2.4.0"
+  spec.add_dependency "resque", "2.5.0"
 
   spec.add_development_dependency "bundler", "~> 2.2"
   spec.add_development_dependency "rake", "~> 13.0"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: resque-heroku-signals
 version: !ruby/object:Gem::Version
-  version: 2.4.0
+  version: 2.5.0.1
 platform: ruby
 authors:
 - Michael Bianco
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-09-06 00:00:00.000000000 Z
+date: 2023-05-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: resque
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.4.0
+        version: 2.5.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.4.0
+        version: 2.5.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -66,7 +66,7 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.10'
-description: 
+description:
 email:
 - mike@mikebian.co
 executables: []
@@ -92,7 +92,7 @@ licenses:
 - MIT
 metadata:
   rubygems_mfa_required: 'true'
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -107,8 +107,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.5
-signing_key: 
+rubygems_version: 3.4.1
+signing_key:
 specification_version: 4
 summary: Patch resque to be compatible with Heroku
 test_files: []